geventhttpclient 2.2.0__tar.gz → 2.2.1__tar.gz

geventhttpclient-2.2.1/LICENSE-MIT

@@ -0,0 +1,22 @@
+This software is licensed under the MIT License.
+
+Copyright Antonin Amand <antonin.amand@gmail.com>, 2018.
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to permit
+persons to whom the Software is furnished to do so, subject to the
+following conditions:
+
+The above copyright notice and this permission notice shall be included
+in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+USE OR OTHER DEALINGS IN THE SOFTWARE.

{geventhttpclient-2.2.0/src/geventhttpclient.egg-info → geventhttpclient-2.2.1}/PKG-INFO

@@ -1,35 +1,30 @@
 Metadata-Version: 2.1
 Name: geventhttpclient
-Version: 2.2.0
+Version: 2.2.1
 Summary: HTTP client library for gevent
 Author-email: Antonin Amand <antonin.amand@gmail.com>
-License: Based on llhttp, copyright Fedor Indutny, 2018.
+License: This software is licensed under the MIT License.
         
-        Python extension is copyright Antonin Amand <antonin.amand@gmail.com>,
-        licensed under the same terms.
+        Copyright Antonin Amand <antonin.amand@gmail.com>, 2018.
         
-        Permission is hereby granted, free of charge, to any person obtaining a copy
-        of this software and associated documentation files (the "Software"), to
-        deal in the Software without restriction, including without limitation the
-        rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
-        sell copies of the Software, and to permit persons to whom the Software is
-        furnished to do so, subject to the following conditions:
+        Permission is hereby granted, free of charge, to any person obtaining a
+        copy of this software and associated documentation files (the
+        "Software"), to deal in the Software without restriction, including
+        without limitation the rights to use, copy, modify, merge, publish,
+        distribute, sublicense, and/or sell copies of the Software, and to permit
+        persons to whom the Software is furnished to do so, subject to the
+        following conditions:
         
-        The above copyright notice and this permission notice shall be included in
-        all copies or substantial portions of the Software.
+        The above copyright notice and this permission notice shall be included
+        in all copies or substantial portions of the Software.
         
-        THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-        IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-        FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-        AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-        LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-        FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
-        IN THE SOFTWARE.
-        
-        Note: Previous versions of gevenhttpclient used http_parser.c, which in turn 
-        was based on src/http/ngx_http_parse.c from NGINX, copyright Igor Sysoev, 
-        Joyent, Inc. and other Node contributors. See http://github.com/joyent/http-parser 
-        for more information
+        THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+        OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+        MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+        NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+        DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+        OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+        USE OR OTHER DEALINGS IN THE SOFTWARE.
         
 Project-URL: homepage, http://github.com/geventhttpclient/geventhttpclient
 Project-URL: issues, http://github.com/geventhttpclient/geventhttpclient/issues
@@ -38,6 +33,7 @@ Keywords: http,gevent,client
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Intended Audience :: Developers
 Classifier: Intended Audience :: Information Technology
+Classifier: License :: OSI Approved :: MIT License
 Classifier: Operating System :: OS Independent
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.9
@@ -48,7 +44,7 @@ Classifier: Programming Language :: Python :: 3 :: Only
 Classifier: Topic :: Software Development :: Libraries
 Requires-Python: >=3.9
 Description-Content-Type: text/markdown
-License-File: LICENSE.txt
+License-File: LICENSE-MIT
 Requires-Dist: gevent
 Requires-Dist: certifi
 Requires-Dist: brotli
@@ -241,3 +237,11 @@ for mor details. Also note, HTTPX is better be used with asyncio, not gevent.
 | Httpx              | 770.3  |
 
 *Linux(x86_64), Python 3.11.6 @ Intel i7-7560U*
+
+## License
+
+This package is distributed under the [MIT license](https://github.com/geventhttpclient/geventhttpclient/blob/master/LICENSE-MIT). 
+Previous versions of geventhttpclient used http_parser.c, which in turn 
+was based on `src/http/ngx_http_parse.c` from NGINX, copyright Igor Sysoev, 
+Joyent, Inc., and other Node contributors. For more information, see 
+http://github.com/joyent/http-parser 

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/README.md

@@ -174,3 +174,11 @@ for mor details. Also note, HTTPX is better be used with asyncio, not gevent.
 | Httpx              | 770.3  |
 
 *Linux(x86_64), Python 3.11.6 @ Intel i7-7560U*
+
+## License
+
+This package is distributed under the [MIT license](https://github.com/geventhttpclient/geventhttpclient/blob/master/LICENSE-MIT). 
+Previous versions of geventhttpclient used http_parser.c, which in turn 
+was based on `src/http/ngx_http_parse.c` from NGINX, copyright Igor Sysoev, 
+Joyent, Inc., and other Node contributors. For more information, see 
+http://github.com/joyent/http-parser 

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/pyproject.toml

@@ -5,17 +5,18 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "geventhttpclient"
-version = "2.2.0" # dont forget to update version __init__.py as well
+version = "2.2.1" # dont forget to update version __init__.py as well
 description = "HTTP client library for gevent"
 readme = "README.md"
 requires-python = ">=3.9"
-license = {file = "LICENSE.txt"}
+license = {file = "LICENSE-MIT"}
 keywords = ["http", "gevent", "client"]
 authors = [{name = "Antonin Amand", email = "antonin.amand@gmail.com"}]
 classifiers = [
     "Development Status :: 5 - Production/Stable",
     "Intended Audience :: Developers",
     "Intended Audience :: Information Technology",
+    "License :: OSI Approved :: MIT License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
     "Programming Language :: Python :: 3.9",

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/__init__.py

@@ -1,6 +1,6 @@
 # package
 
-__version__ = "2.2.0"  # dont forget to update version in pyproject.toml as well
+__version__ = "2.2.1"  # dont forget to update version in pyproject.toml as well
 
 from geventhttpclient.client import HTTPClient
 from geventhttpclient.url import URL

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/client.py

@@ -146,14 +146,10 @@ class HTTPClient:
         self.default_headers.update(self.DEFAULT_HEADERS)
         self.default_headers.update(headers)
         self.block_size = block_size
-        self._base_url_string = str(self.get_base_url())
-
-    def get_base_url(self):
-        url = URL()
-        url.host = self.host
-        url.port = self.port
-        url.scheme = self.ssl and PROTO_HTTPS or PROTO_HTTP
-        return url
+
+        scheme = PROTO_HTTPS if self.ssl else PROTO_HTTP
+        port_str = f":{port}" if port else ""
+        self._base_url_string = f"{scheme}://{self.host}{port_str}/"
 
     def close(self):
         self._connection_pool.close()

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/connectionpool.py

@@ -1,5 +1,4 @@
 import os
-from contextlib import contextmanager
 
 import gevent.queue
 import gevent.socket
@@ -198,12 +197,15 @@ def init_ssl_context(ssl_context_factory, ca_certs, check_hostname=True):
 
 
 try:
+    from ssl import PROTOCOL_TLS_CLIENT
+
     import gevent.ssl
 
     try:
         from gevent.ssl import create_default_context
     except ImportError:
         create_default_context = None
+
 except ImportError:
     pass
 else:
@@ -222,6 +224,7 @@ else:
             "ciphers": _DEFAULT_CIPHERS,
             "ca_certs": _CA_CERTS,
             "cert_reqs": gevent.ssl.CERT_REQUIRED,
+            "ssl_version": PROTOCOL_TLS_CLIENT,
         }
 
         def __init__(
@@ -260,30 +263,3 @@ else:
             else:
                 server_hostname = self.ssl_options.get("server_hostname", self._request_host)
                 return self.ssl_context.wrap_socket(sock, server_hostname=server_hostname)
-
-
-class ClientPool:
-    """
-    Pool implementation for HTTP clients, that weren't designed with concurrency in mind.
-    Usage example:
-
-    pool = ClientPool(MyHttpClient)
-    with pool.get() as client:
-        response = client.request("127.0.0.1")
-    """
-
-    def __init__(self, factory, concurrency=5):
-        self.factory = factory
-        self.queue = gevent.queue.Queue(concurrency)
-        for i in range(concurrency):
-            self.queue.put(factory())
-
-    @contextmanager
-    def get(self):
-        client = self.queue.get()
-        yield client
-        self.queue.put(client)
-
-    def close(self):
-        for client in self.queue:
-            client.close()

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/httplib.py

@@ -3,14 +3,15 @@ Provide HTTPConnection, HTTPSConnection and HTTPResponse implementations ready
 to use as drop-in replacements for their counterparts in http.client.
 """
 
-import http.client as httplib
+import http.client
+from contextlib import contextmanager
 
 import gevent.socket
 import gevent.ssl
 
 from geventhttpclient import connectionpool, header, response
 
-_UNKNOWN = getattr(httplib, "_UNKNOWN", "UNKNOWN")
+_UNKNOWN = getattr(http.client, "_UNKNOWN", "UNKNOWN")
 
 
 class HTTPLibHeaders(header.Headers):
@@ -120,10 +121,7 @@ class HTTPResponse(response.HTTPSocketResponse):
         return self.status_code
 
 
-HTTPLibConnection = httplib.HTTPConnection
-
-
-class HTTPConnection(httplib.HTTPConnection):
+class HTTPConnection(http.client.HTTPConnection):
     response_class = HTTPResponse
     source_address = None
     _hidden_socket = None
@@ -220,9 +218,35 @@ else:
 
 
 def patch():
-    httplib.HTTPConnection = HTTPConnection
-    httplib.HTTPResponse = HTTPResponse
+    http.client.HTTPConnection = HTTPConnection
+    http.client.HTTPResponse = HTTPResponse
+    try:
+        http.client.HTTPSConnection = HTTPSConnection
+    except NameError:
+        pass
+
+
+@contextmanager
+def patched():
+    """Temporarily patch http.client."""
+    http_client_HTTPConnection = http.client.HTTPConnection
+    http_client_HTTPResponse = http.client.HTTPResponse
     try:
-        httplib.HTTPSConnection = HTTPSConnection
+        http_client_HTTPSConnection = http.client.HTTPSConnection
     except NameError:
         pass
+    try:
+        http.client.HTTPConnection = HTTPConnection
+        http.client.HTTPResponse = HTTPResponse
+        try:
+            http.client.HTTPSConnection = HTTPSConnection
+        except NameError:
+            pass
+        yield
+    finally:
+        http.client.HTTPConnection = http_client_HTTPConnection
+        http.client.HTTPResponse = http_client_HTTPResponse
+        try:
+            http.client.HTTPSConnection = http_client_HTTPSConnection
+        except NameError:
+            pass

geventhttpclient-2.2.1/src/geventhttpclient/httplib2.py

@@ -0,0 +1,69 @@
+"""
+Drop-in replacement for httplib2. Make sure to monkey patch everything first!
+
+import gevent.monkey
+gevent.monkey.patch_all()
+
+from geventhttpclient import httplib
+httplib.patch()
+
+from geventhttpclient import httplib2
+
+http = httplib2.Http(concurrency=5)
+"""
+
+from contextlib import contextmanager
+
+import gevent.queue
+
+import geventhttpclient.httplib
+
+
+class ClientPool:
+    """
+    Pool implementation for HTTP clients, that weren't designed with concurrency in mind.
+    Usage example:
+
+    pool = ClientPool(MyHttpClient)
+    with pool.get() as client:
+        response = client.request("127.0.0.1")
+    """
+
+    def __init__(self, factory, concurrency=5):
+        self.factory = factory
+        self.queue = gevent.queue.Queue(concurrency)
+        for i in range(concurrency):
+            self.queue.put(factory())
+
+    @contextmanager
+    def get(self):
+        client = self.queue.get()
+        yield client
+        self.queue.put(client)
+
+    def close(self):
+        for client in self.queue:
+            client.close()
+
+
+with geventhttpclient.httplib.patched():
+    import httplib2
+
+    class Http:
+        """Imitate a httplib2.Http client. Except that it is now run concurrently."""
+
+        def __init__(self, *args, **kw):
+            self.concurrency = max(kw.pop("concurrency", 0), 2)  # never smaller than 2
+            self.args = args
+            self.kw = kw
+            self.pool = ClientPool(self._http_factory, concurrency=self.concurrency)
+
+        def _http_factory(self):
+            return httplib2.Http(*self.args, **self.kw)
+
+        def request(self, *args, **kw):
+            with self.pool.get() as client:
+                return client.request(*args, **kw)
+
+        def close(self):
+            self.pool.close()

geventhttpclient-2.2.1/src/geventhttpclient/tests/conftest.py

@@ -0,0 +1,57 @@
+import gevent.monkey
+
+gevent.monkey.patch_all()  # make sure all tests run monkey patched
+
+from contextlib import contextmanager
+
+import gevent.pywsgi
+import gevent.queue
+import gevent.server
+
+TEST_HOST = "127.0.0.1"
+TEST_PORT = 54323
+LISTENER = TEST_HOST, TEST_PORT
+LISTENER_URL = f"http://{TEST_HOST}:{TEST_PORT}/"
+HTTPBIN_HOST = "httpbingo.org"  # this might be exchanged with a self-hosted version
+
+
+@contextmanager
+def server(handler):
+    exception_queue = gevent.queue.Queue()
+
+    def wrapped_handler(env, start_response):
+        try:
+            return handler(env, start_response)
+        except Exception as e:
+            exception_queue.put(e)
+            raise
+
+    server = gevent.server.StreamServer(LISTENER, handle=wrapped_handler)
+    server.start()
+    try:
+        yield
+        if not exception_queue.empty():
+            raise exception_queue.get()
+    finally:
+        server.stop()
+
+
+@contextmanager
+def wsgiserver(handler):
+    exception_queue = gevent.queue.Queue()
+
+    def wrapped_handler(env, start_response):
+        try:
+            return handler(env, start_response)
+        except Exception as e:
+            exception_queue.put(e)
+            raise
+
+    server = gevent.pywsgi.WSGIServer(LISTENER, wrapped_handler)
+    server.start()
+    try:
+        yield
+        if not exception_queue.empty():
+            raise exception_queue.get()
+    finally:
+        server.stop()

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/tests/test_client.py

@@ -1,37 +1,13 @@
 import json
-import os
-from contextlib import contextmanager
 
 import gevent.pool
-import gevent.pywsgi
+import gevent.queue
 import gevent.server
 import pytest
-from gevent.ssl import SSLError
 
-from geventhttpclient import HTTPClient, __version__
-
-LISTENER = "127.0.0.1", 54323
-HTTPBIN_HOST = "httpbingo.org"  # this might be exchanged with a self-hosted version
-
-
-@contextmanager
-def server(handler):
-    server = gevent.server.StreamServer(LISTENER, handle=handler)
-    server.start()
-    try:
-        yield
-    finally:
-        server.stop()
-
-
-@contextmanager
-def wsgiserver(handler):
-    server = gevent.pywsgi.WSGIServer(LISTENER, handler)
-    server.start()
-    try:
-        yield
-    finally:
-        server.stop()
+from geventhttpclient import __version__
+from geventhttpclient.client import METHOD_GET, HTTPClient
+from geventhttpclient.tests.conftest import HTTPBIN_HOST, LISTENER, server, wsgiserver
 
 
 def httpbin_client(
@@ -80,12 +56,22 @@ def httpbin():
 @pytest.mark.parametrize("request_uri", ["/tp/", "tp/", f"http://{HTTPBIN_HOST}/tp/"])
 def test_build_request(httpbin, request_uri):
     request_ref = f"GET /tp/ HTTP/1.1\r\nUser-Agent: python/gevent-http-client-{__version__}\r\nHost: {HTTPBIN_HOST}\r\n\r\n"
-    assert httpbin._build_request("GET", request_uri) == request_ref
+    assert httpbin._build_request(METHOD_GET, request_uri) == request_ref
 
 
 def test_build_request_invalid_host(httpbin):
     with pytest.raises(ValueError):
-        httpbin._build_request("GET", "http://someunrelatedhost.com/")
+        httpbin._build_request(METHOD_GET, "http://someunrelatedhost.com/")
+
+
+@pytest.mark.parametrize("port", [None, 1234])
+@pytest.mark.parametrize("host", ["localhost", "127.0.0.1", "::1", "[::1]"])
+def test_build_request_host(host, port):
+    client = HTTPClient(host, port)
+    host_ref = (
+        f"host: {f'[{host}]' if host.startswith(':') else host}{f':{port}' if port else ''}\r\n"
+    )
+    assert host_ref in client._build_request(METHOD_GET, "").lower()
 
 
 test_url_client_args = [
@@ -255,7 +241,7 @@ def test_bytes_post():
 
 
 def test_string_post():
-    with wsgiserver(check_upload("12345", 5)):
+    with wsgiserver(check_upload(b"12345", 5)):
         client = HTTPClient(*LISTENER)
         client.post("/", "12345")
 
@@ -334,26 +320,6 @@ def test_response_context_manager(httpbin):
     assert r._sock is None  # released
 
 
-@pytest.mark.network
-def test_client_ssl():
-    client = HTTPClient("github.com", ssl=True)
-    assert client.port == 443
-    response = client.get("/")
-    assert response.status_code == 200
-    body = response.read()
-    assert len(body)
-
-
-@pytest.mark.network
-def test_ssl_fail_invalid_certificate():
-    certs = os.path.join(os.path.dirname(os.path.abspath(__file__)), "oncert.pem")
-    client = HTTPClient("github.com", ssl_options={"ca_certs": certs})
-    assert client.port == 443
-    with pytest.raises(SSLError) as e_info:
-        client.get("/")
-    assert e_info.value.reason == "CERTIFICATE_VERIFY_FAILED"
-
-
 @pytest.mark.network
 def test_multi_queries_greenlet_safe():
     httpbin = httpbin_client(concurrency=3)

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/tests/test_httplib.py

@@ -1,23 +1,10 @@
+import http.client
 import urllib.request
-from contextlib import contextmanager
-from http.client import HTTPException
 
-import gevent.server
 import pytest
 
-from geventhttpclient.httplib import HTTPConnection
-
-LISTENER = "127.0.0.1", 54323
-
-
-@contextmanager
-def server(handler):
-    server = gevent.server.StreamServer(LISTENER, handle=handler)
-    server.start()
-    try:
-        yield
-    finally:
-        server.stop()
+from geventhttpclient.httplib import HTTPConnection, patched
+from geventhttpclient.tests.conftest import HTTPBIN_HOST, LISTENER, server
 
 
 def wrong_response_status_line(sock, addr):
@@ -29,7 +16,7 @@ def test_httplib_exception():
     with server(wrong_response_status_line):
         connection = HTTPConnection(*LISTENER)
         connection.request("GET", "/")
-        with pytest.raises(HTTPException):
+        with pytest.raises(http.client.HTTPException):
             connection.getresponse()
 
 
@@ -67,9 +54,20 @@ def test_msg():
         assert response.msg["Content-Type"] == "text/plain"
 
 
+def test_patched():
+    assert http.client.HTTPResponse.__module__ == "http.client"
+    assert http.client.HTTPConnection.__module__ == "http.client"
+    with patched():
+        assert http.client.HTTPResponse.__module__ == "geventhttpclient.httplib"
+        assert http.client.HTTPConnection.__module__ == "geventhttpclient.httplib"
+    assert http.client.HTTPResponse.__module__ == "http.client"
+    assert http.client.HTTPConnection.__module__ == "http.client"
+
+
 @pytest.mark.network
-@pytest.mark.parametrize("url", ["http://httpbingo.org", "https://github.com"])
+@pytest.mark.parametrize("url", [f"http://{HTTPBIN_HOST}", "https://github.com"])
 def test_urllib_request(url):
-    content = urllib.request.urlopen(url).read()
-    assert content
-    assert b"body" in content
+    with patched():
+        content = urllib.request.urlopen(url).read()
+        assert content
+        assert b"body" in content

geventhttpclient-2.2.1/src/geventhttpclient/tests/test_httplib2.py

@@ -0,0 +1,31 @@
+import gevent.pool
+import pytest
+
+import geventhttpclient.httplib
+
+httplib2 = pytest.importorskip("geventhttpclient.httplib2")
+
+
+def job(client, url):
+    response, content = client.request(url)
+    assert content
+    assert b"body" in content
+
+
+@pytest.mark.network
+def test_request_parallel():
+    with geventhttpclient.httplib.patched():
+        errors = []
+
+        client = httplib2.Http(concurrency=5)
+        group = gevent.pool.Pool(size=5)
+
+        urls = ["https://google.com", "http://gevent.org", "https://github.com"]
+        for url in urls:
+            g = group.spawn(job, client, url)
+            g.link_exception(lambda g: errors.append(g.exception))
+        group.join()
+        if errors:
+            for e in errors:
+                print(e)
+            raise errors[0]

{geventhttpclient-2.2.0 → geventhttpclient-2.2.1}/src/geventhttpclient/tests/test_network_failures.py

@@ -1,24 +1,11 @@
-from contextlib import contextmanager
 from http.client import HTTPException
 
 import gevent.server
 import gevent.socket
 import pytest
 
-from geventhttpclient import HTTPClient
-
-CRLF = "\r\n"
-LISTENER = "127.0.0.1", 54323
-
-
-@contextmanager
-def server(handler):
-    server = gevent.server.StreamServer(LISTENER, handle=handler)
-    server.start()
-    try:
-        yield
-    finally:
-        server.stop()
+from geventhttpclient.client import CRLF, HTTPClient
+from geventhttpclient.tests.conftest import LISTENER, server
 
 
 def wrong_response_status_line(sock, addr):