gemcode 0.4.23__tar.gz → 0.4.25__tar.gz

{gemcode-0.4.23/src/gemcode.egg-info → gemcode-0.4.25}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gemcode
-Version: 0.4.23
+Version: 0.4.25
 Summary: Local-first coding agent on Google Gemini + ADK
 Author: GemCode Contributors
 License:                                  Apache License

{gemcode-0.4.23 → gemcode-0.4.25}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "gemcode"
-version = "0.4.23"
+version = "0.4.25"
 description = "Local-first coding agent on Google Gemini + ADK"
 readme = "README.md"
 requires-python = ">=3.11"

gemcode-0.4.25/src/gemcode/web/preview_api.py

@@ -0,0 +1,213 @@
+"""Detect local (or tenant-pod) dev servers and reverse-proxy them for the web UI."""
+
+from __future__ import annotations
+
+import socket
+from http.client import HTTPConnection
+from typing import Any
+from urllib.error import URLError
+from urllib.parse import unquote
+from urllib.request import Request, urlopen
+
+# Common dev-server ports (GemCode web UI uses 3002; API 3001)
+COMMON_DEV_PORTS = (
+  3000,
+  3003,
+  3004,
+  5173,
+  5174,
+  8080,
+  8000,
+  4200,
+  5000,
+  4321,
+  8888,
+)
+
+_STRIP_RESPONSE_HEADERS = frozenset(
+  {
+    "transfer-encoding",
+    "connection",
+    "content-length",
+    "content-encoding",
+    "x-frame-options",
+    "content-security-policy",
+    "content-security-policy-report-only",
+  }
+)
+
+
+def _port_open(host: str, port: int, *, timeout: float = 0.2) -> bool:
+  try:
+    with socket.create_connection((host, port), timeout=timeout):
+      return True
+  except OSError:
+    return False
+
+
+def _probe_http(url: str, *, timeout: float = 1.5) -> dict[str, Any] | None:
+  try:
+    req = Request(url, headers={"User-Agent": "GemCode-Web-Preview/1.0"})
+    with urlopen(req, timeout=timeout) as resp:
+      ctype = (resp.headers.get("Content-Type") or "").lower()
+      return {
+        "ok": True,
+        "status": resp.status,
+        "content_type": ctype,
+      }
+  except (URLError, OSError, TimeoutError, ValueError):
+    return None
+
+
+def scan_local_preview_ports(
+  *,
+  host: str = "127.0.0.1",
+  extra_ports: list[int] | None = None,
+) -> list[dict[str, Any]]:
+  """Return listening HTTP-ish ports on localhost (tenant pod when hosted)."""
+  ports: list[int] = list(COMMON_DEV_PORTS)
+  if extra_ports:
+    for p in extra_ports:
+      if isinstance(p, int) and 1 < p < 65536 and p not in ports:
+        ports.append(p)
+
+  found: list[dict[str, Any]] = []
+  for port in ports:
+    if not _port_open(host, port):
+      continue
+    url = f"http://{host}:{port}"
+    probe = _probe_http(url)
+    found.append(
+      {
+        "port": port,
+        "url": url,
+        "reachable": probe is not None,
+        "content_type": (probe or {}).get("content_type"),
+      }
+    )
+  return found
+
+
+def handle_preview_get(kind: str) -> tuple[int, dict[str, Any]]:
+  k = (kind or "ports").strip().lower()
+  if k == "ports":
+    ports = scan_local_preview_ports()
+    return 200, {"ok": True, "ports": ports, "host": "127.0.0.1"}
+  return 400, {"ok": False, "error": f"Unknown preview kind: {kind}"}
+
+
+def _inject_base_href(html: str, base_path: str) -> str:
+  base_tag = f'<base href="{base_path}">'
+  if "<base " in html.lower():
+    return html
+  lower = html.lower()
+  idx = lower.find("<head")
+  if idx >= 0:
+    gt = html.find(">", idx)
+    if gt >= 0:
+      return html[: gt + 1] + base_tag + html[gt + 1 :]
+  return base_tag + html
+
+
+def handle_preview_proxy(
+  port: int,
+  sub_path: str = "/",
+  *,
+  query: str = "",
+) -> tuple[int, bytes, dict[str, str]]:
+  """
+  Reverse-proxy HTTP from 127.0.0.1:{port} (on this process / tenant pod).
+
+  Returns (status, body, response_headers).
+  """
+  if not isinstance(port, int) or port < 1 or port > 65535:
+    return 400, b'{"error":"Invalid port"}', {"Content-Type": "application/json; charset=utf-8"}
+
+  # Block GemCode's own API/UI ports from being framed as "app preview"
+  if port in (3001, 3002):
+    return (
+      400,
+      b'{"error":"Port reserved for GemCode API/UI"}',
+      {"Content-Type": "application/json; charset=utf-8"},
+    )
+
+  raw = sub_path or "/"
+  if not raw.startswith("/"):
+    raw = "/" + raw
+  # Collapse .. segments
+  parts: list[str] = []
+  for seg in raw.split("/"):
+    if seg in ("", "."):
+      continue
+    if seg == "..":
+      if parts:
+        parts.pop()
+      continue
+    parts.append(seg)
+  path = "/" + "/".join(parts)
+  if raw.endswith("/") and path != "/":
+    path += "/"
+
+  qs = (query or "").lstrip("?")
+  request_path = path if not qs else f"{path}?{qs}"
+
+  try:
+    conn = HTTPConnection("127.0.0.1", port, timeout=20.0)
+    conn.request(
+      "GET",
+      request_path,
+      headers={"User-Agent": "GemCode-Web-Preview/1.0", "Accept": "*/*"},
+    )
+    resp = conn.getresponse()
+    body = resp.read()
+    ctype = (resp.getheader("Content-Type") or "").lower()
+    headers: dict[str, str] = {}
+    for key, value in resp.getheaders():
+      if key.lower() in _STRIP_RESPONSE_HEADERS:
+        continue
+      headers[key] = value
+    status = int(resp.status)
+    conn.close()
+  except OSError as exc:
+    msg = f'{{"error":"Preview upstream unreachable: {type(exc).__name__}: {exc}"}}'
+    return 502, msg.encode(), {"Content-Type": "application/json; charset=utf-8"}
+
+  proxy_base = f"/api/preview/proxy/{port}/"
+  if "text/html" in ctype:
+    try:
+      text = body.decode("utf-8", errors="replace")
+      text = _inject_base_href(text, proxy_base)
+      body = text.encode("utf-8")
+      headers["Content-Type"] = "text/html; charset=utf-8"
+    except Exception:
+      pass
+
+  headers["Cache-Control"] = "no-store"
+  headers["X-Frame-Options"] = "SAMEORIGIN"
+  headers["Content-Security-Policy"] = (
+    "default-src * 'unsafe-inline' 'unsafe-eval' data: blob:; "
+    "script-src * 'unsafe-inline' 'unsafe-eval'; style-src * 'unsafe-inline'; "
+    "frame-ancestors 'self';"
+  )
+  return status, body, headers
+
+
+def parse_preview_proxy_path(raw_path: str) -> tuple[int, str] | None:
+  """Parse `/api/preview/proxy/{port}` or `/api/preview/proxy/{port}/...` → (port, sub_path)."""
+  prefix = "/api/preview/proxy/"
+  if not raw_path.startswith(prefix):
+    return None
+  rest = raw_path[len(prefix) :]
+  if not rest:
+    return None
+  parts = rest.split("/", 1)
+  try:
+    port = int(parts[0])
+  except ValueError:
+    return None
+  sub = "/"
+  if len(parts) > 1 and parts[1]:
+    sub = "/" + unquote(parts[1])
+  elif rest.endswith("/") or raw_path.endswith("/"):
+    sub = "/"
+  return port, sub

{gemcode-0.4.23 → gemcode-0.4.25}/src/gemcode/web/server.py

@@ -304,6 +304,35 @@ def _build_handler(project_root: str) -> type[BaseHTTPRequestHandler]:
         self.wfile.write(body)
         return
 
+      if parsed.path.startswith("/api/preview/proxy/"):
+        try:
+          from gemcode.web.preview_api import handle_preview_proxy, parse_preview_proxy_path
+
+          parsed_proxy = parse_preview_proxy_path(parsed.path)
+          if not parsed_proxy:
+            status, body, hdrs = (
+              400,
+              b'{"error":"Invalid preview proxy path"}',
+              {"Content-Type": "application/json; charset=utf-8"},
+            )
+          else:
+            port, sub_path = parsed_proxy
+            status, body, hdrs = handle_preview_proxy(
+              port, sub_path, query=parsed.query or ""
+            )
+        except Exception as exc:
+          status = 500
+          body = json.dumps({"error": f"{type(exc).__name__}: {exc}"}).encode()
+          hdrs = {"Content-Type": "application/json; charset=utf-8"}
+        self.send_response(status)
+        for hk, hv in hdrs.items():
+          self.send_header(hk, hv)
+        self.send_header("Content-Length", str(len(body)))
+        self._cors()
+        self.end_headers()
+        self.wfile.write(body)
+        return
+
       fleet_get = {
         "/api/org": "org",
         "/api/habits": "habits",

{gemcode-0.4.23 → gemcode-0.4.25}/src/gemcode/web/sse_adapter.py

@@ -489,15 +489,33 @@ def _inject_web_code_context(cfg: GemCodeConfig, prompt: str, req: dict[str, Any
         "or type @path — unless they mean the whole project (see below)."
       )
 
-  lines.extend(
-    [
-      'When the user says "this file", "the current one", or similar, use the active / @-referenced file above.',
-      'When they ask to analyze the whole codebase, project, repo, or "all files", start with `repo_map` and '
-      '`list_directory` on `.` — do not ask which file first.',
-      "**Web UI permissions** — shell and mutating tools show an **Approve / Deny** dialog in the browser. "
-      "Never tell the user to approve in a terminal; wait for the in-app prompt and continue after approval.",
-    ]
+  # Permission mode for THIS turn (must match actual HITL / auto-approve behavior).
+  lines.append(
+    'When the user says "this file", "the current one", or similar, use the active / @-referenced file above.'
   )
+  lines.append(
+    'When they ask to analyze the whole codebase, project, repo, or "all files", start with `repo_map` and '
+    '`list_directory` on `.` — do not ask which file first.'
+  )
+  auto_on = bool(
+    getattr(cfg, "yes_to_all", False)
+    or getattr(cfg, "super_mode", False)
+    or not getattr(cfg, "_web_interactive_hitl", True)
+  )
+  if auto_on:
+    lines.append(
+      "**Web UI permissions — AUTO-APPROVE is ON for this turn.** "
+      "Shell and mutating tools run immediately with **no** Yes/No card. "
+      "Never mention Approve, Deny, approval prompts, dialogs, or waiting for the user — "
+      "just run tools and report what you did."
+    )
+  else:
+    lines.append(
+      "**Web UI permissions — interactive.** Shell and mutating tools pause for an "
+      "**inline Yes/No card in the chat** (also pinned above the composer). "
+      "Do **not** invent Approve/Deny dialog text or tell the user to open a popup — "
+      "wait silently; after they tap Yes or No the turn continues."
+    )
 
   if mode == "agents":
     lines.extend(
@@ -920,6 +938,7 @@ def _apply_web_permissions(cfg: GemCodeConfig, req: dict[str, Any]) -> None:
   }
   object.__setattr__(cfg, "_web_auto_approve", normalized)
 
+  # UI is source of truth for web chat — do not leave env GEMCODE_SUPER_MODE stuck on.
   super_mode = bool(perms.get("super_mode"))
   if super_mode:
     cfg.super_mode = True
@@ -929,6 +948,7 @@ def _apply_web_permissions(cfg: GemCodeConfig, req: dict[str, Any]) -> None:
     object.__setattr__(cfg, "_web_interactive_hitl", False)
     return
 
+  cfg.super_mode = False
   if all(normalized.values()):
     cfg.yes_to_all = True
     cfg.interactive_permission_ask = False
@@ -946,13 +966,33 @@ def _apply_web_permissions(cfg: GemCodeConfig, req: dict[str, Any]) -> None:
 
 
 def _configure_web_permissions(cfg: GemCodeConfig, req: dict[str, Any]) -> None:
-  """Web chat defaults to interactive Approve/Deny unless everything is auto-approved."""
+  """Web chat HITL follows the UI request, not process-level GEMCODE_SUPER_MODE.
+
+  Hosted tenant images historically set ``GEMCODE_SUPER_MODE=1`` so mesh/jobs are
+  unattended. That must not silently skip Yes/No cards when the user has
+  Auto-approve off in the web UI. Mesh workers still use
+  ``GEMCODE_MESH_WORKER_UNATTENDED`` independently.
+  """
   object.__setattr__(cfg, "_gemcode_web_sse", True)
-  _apply_web_permissions(cfg, req)
-  if not isinstance(req.get("permissions"), dict):
+
+  perms = req.get("permissions")
+  has_perms = isinstance(perms, dict)
+
+  # Clear env-applied super mode before applying the UI payload.
+  if not (has_perms and bool(perms.get("super_mode"))):
+    cfg.super_mode = False
     cfg.yes_to_all = False
     cfg.interactive_permission_ask = True
     object.__setattr__(cfg, "_web_interactive_hitl", True)
+
+  if has_perms:
+    _apply_web_permissions(cfg, req)
+  else:
+    cfg.super_mode = False
+    cfg.yes_to_all = False
+    cfg.interactive_permission_ask = True
+    object.__setattr__(cfg, "_web_interactive_hitl", True)
+
   _ensure_web_hitl(cfg)
   if os.environ.get("GEMCODE_WEB_YES_TO_ALL", "").lower() in ("1", "true", "yes", "on"):
     cfg.yes_to_all = True
@@ -961,8 +1001,9 @@ def _configure_web_permissions(cfg: GemCodeConfig, req: dict[str, Any]) -> None:
 
 
 def _ensure_web_hitl(cfg: GemCodeConfig) -> None:
-  """Web chat always uses the UI approval bridge when tools are not fully auto-approved."""
+  """Web chat uses the UI approval bridge when tools are not fully auto-approved."""
   if getattr(cfg, "yes_to_all", False) or getattr(cfg, "super_mode", False):
+    object.__setattr__(cfg, "_web_interactive_hitl", False)
     return
   cfg.interactive_permission_ask = True
   object.__setattr__(cfg, "_web_interactive_hitl", True)
@@ -1246,6 +1287,10 @@ async def run_adapter(req: dict[str, Any]) -> None:
           "model": model,
           "project_root": str(cfg.project_root),
           "workspace_mode": workspace_mode,
+          "hitl_interactive": bool(getattr(cfg, "_web_interactive_hitl", False)),
+          "auto_approve": bool(
+            getattr(cfg, "yes_to_all", False) or getattr(cfg, "super_mode", False)
+          ),
           **({"skill": resolved.skill_name} if resolved.skill_name else {}),
         }
       )

{gemcode-0.4.23 → gemcode-0.4.25/src/gemcode.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gemcode
-Version: 0.4.23
+Version: 0.4.25
 Summary: Local-first coding agent on Google Gemini + ADK
 Author: GemCode Contributors
 License:                                  Apache License

{gemcode-0.4.23 → gemcode-0.4.25}/src/gemcode.egg-info/SOURCES.txt

@@ -187,6 +187,7 @@ tests/test_multimodal_input.py
 tests/test_output_styles_and_rules.py
 tests/test_paths.py
 tests/test_permissions.py
+tests/test_preview_proxy.py
 tests/test_prompt_suggestions.py
 tests/test_repl_commands.py
 tests/test_repl_slash.py
@@ -200,6 +201,7 @@ tests/test_token_budget.py
 tests/test_tool_context_circulation.py
 tests/test_tools.py
 tests/test_tools_inspector.py
+tests/test_web_permissions_hitl.py
 tests/test_web_server.py
 tests/test_web_sse_adapter.py
 tests/test_workspace_hints.py

gemcode-0.4.25/tests/test_preview_proxy.py

@@ -0,0 +1,21 @@
+"""Tests for preview proxy path parsing."""
+
+from gemcode.web.preview_api import parse_preview_proxy_path
+
+
+def test_parse_preview_proxy_root() -> None:
+  assert parse_preview_proxy_path("/api/preview/proxy/8000") == (8000, "/")
+  assert parse_preview_proxy_path("/api/preview/proxy/8000/") == (8000, "/")
+
+
+def test_parse_preview_proxy_subpath() -> None:
+  assert parse_preview_proxy_path("/api/preview/proxy/5173/assets/app.js") == (
+    5173,
+    "/assets/app.js",
+  )
+
+
+def test_parse_preview_proxy_invalid() -> None:
+  assert parse_preview_proxy_path("/api/preview") is None
+  assert parse_preview_proxy_path("/api/preview/proxy/") is None
+  assert parse_preview_proxy_path("/api/preview/proxy/abc") is None

gemcode-0.4.25/tests/test_web_permissions_hitl.py

@@ -0,0 +1,71 @@
+"""Web UI permissions must override process-level GEMCODE_SUPER_MODE."""
+
+from __future__ import annotations
+
+from pathlib import Path
+
+from gemcode.config import GemCodeConfig, apply_super_mode
+from gemcode.web import sse_adapter
+
+
+def test_web_permissions_clear_env_super_mode(tmp_path: Path, monkeypatch) -> None:
+  monkeypatch.setenv("GEMCODE_SUPER_MODE", "1")
+  cfg = GemCodeConfig(project_root=tmp_path)
+  assert cfg.super_mode is True
+  apply_super_mode(cfg)
+  assert cfg.yes_to_all is True
+
+  sse_adapter._configure_web_permissions(
+    cfg,
+    {
+      "permissions": {
+        "super_mode": False,
+        "auto_approve": {
+          "bash": False,
+          "file_read": False,
+          "file_write": False,
+          "web_search": False,
+        },
+      }
+    },
+  )
+  assert cfg.super_mode is False
+  assert cfg.yes_to_all is False
+  assert getattr(cfg, "_web_interactive_hitl") is True
+
+
+def test_web_permissions_ui_super_mode_on(tmp_path: Path, monkeypatch) -> None:
+  monkeypatch.delenv("GEMCODE_SUPER_MODE", raising=False)
+  cfg = GemCodeConfig(project_root=tmp_path)
+  cfg.super_mode = False
+  cfg.yes_to_all = False
+
+  sse_adapter._configure_web_permissions(
+    cfg,
+    {"permissions": {"super_mode": True, "auto_approve": {}}},
+  )
+  assert cfg.super_mode is True
+  assert cfg.yes_to_all is True
+  assert getattr(cfg, "_web_interactive_hitl") is False
+
+
+def test_inject_web_context_auto_approve_copy(tmp_path: Path) -> None:
+  cfg = GemCodeConfig(project_root=tmp_path)
+  cfg.yes_to_all = True
+  object.__setattr__(cfg, "_web_workspace_mode", "code")
+  object.__setattr__(cfg, "_web_interactive_hitl", False)
+  out = sse_adapter._inject_web_code_context(cfg, "hello", {})
+  assert "AUTO-APPROVE is ON" in out
+  assert "Never mention Approve" in out
+  assert "inline Yes/No card" not in out
+
+
+def test_inject_web_context_interactive_copy(tmp_path: Path) -> None:
+  cfg = GemCodeConfig(project_root=tmp_path)
+  cfg.super_mode = False
+  cfg.yes_to_all = False
+  object.__setattr__(cfg, "_web_workspace_mode", "code")
+  object.__setattr__(cfg, "_web_interactive_hitl", True)
+  out = sse_adapter._inject_web_code_context(cfg, "hello", {})
+  assert "inline Yes/No card" in out
+  assert "AUTO-APPROVE is ON" not in out

gemcode-0.4.23/src/gemcode/web/preview_api.py

@@ -1,82 +0,0 @@
-"""Detect local dev servers for in-UI localhost preview."""
-
-from __future__ import annotations
-
-import socket
-from typing import Any
-from urllib.error import URLError
-from urllib.request import Request, urlopen
-
-# Common dev-server ports (GemCode web UI uses 3002; API 3001)
-COMMON_DEV_PORTS = (
-  3000,
-  3003,
-  3004,
-  5173,
-  5174,
-  8080,
-  8000,
-  4200,
-  5000,
-  4321,
-  8888,
-)
-
-
-def _port_open(host: str, port: int, *, timeout: float = 0.2) -> bool:
-  try:
-    with socket.create_connection((host, port), timeout=timeout):
-      return True
-  except OSError:
-    return False
-
-
-def _probe_http(url: str, *, timeout: float = 1.5) -> dict[str, Any] | None:
-  try:
-    req = Request(url, headers={"User-Agent": "GemCode-Web-Preview/1.0"})
-    with urlopen(req, timeout=timeout) as resp:
-      ctype = (resp.headers.get("Content-Type") or "").lower()
-      return {
-        "ok": True,
-        "status": resp.status,
-        "content_type": ctype,
-      }
-  except (URLError, OSError, TimeoutError, ValueError):
-    return None
-
-
-def scan_local_preview_ports(
-  *,
-  host: str = "127.0.0.1",
-  extra_ports: list[int] | None = None,
-) -> list[dict[str, Any]]:
-  """Return listening HTTP-ish ports on localhost."""
-  ports: list[int] = list(COMMON_DEV_PORTS)
-  if extra_ports:
-    for p in extra_ports:
-      if isinstance(p, int) and 1 < p < 65536 and p not in ports:
-        ports.append(p)
-
-  found: list[dict[str, Any]] = []
-  for port in ports:
-    if not _port_open(host, port):
-      continue
-    url = f"http://{host}:{port}"
-    probe = _probe_http(url)
-    found.append(
-      {
-        "port": port,
-        "url": url,
-        "reachable": probe is not None,
-        "content_type": (probe or {}).get("content_type"),
-      }
-    )
-  return found
-
-
-def handle_preview_get(kind: str) -> tuple[int, dict[str, Any]]:
-  k = (kind or "ports").strip().lower()
-  if k == "ports":
-    ports = scan_local_preview_ports()
-    return 200, {"ok": True, "ports": ports, "host": "127.0.0.1"}
-  return 400, {"ok": False, "error": f"Unknown preview kind: {kind}"}