gamdl 3.0__tar.gz → 3.2__tar.gz

{gamdl-3.0 → gamdl-3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gamdl
-Version: 3.0
+Version: 3.2
 Summary: A command-line app for downloading Apple Music songs, music videos and post videos.
 License-Expression: MIT
 Project-URL: Repository, https://github.com/glomatico/gamdl
@@ -166,6 +166,7 @@ The file is created automatically on first run. Command-line arguments override
 | `--cover-format`                | Cover format                                                      | `jpg`                                          |
 | `--cover-size`                  | Cover size in pixels                                              | `1200`                                         |
 | `--wvd-path`                    | .wvd file path                                                    | -                                              |
+| `--wrapper-m3u8-ip`             | Wrapper m3u8 IP address and port                                  | -                                              |
 | **Song Options**                |                                                                   |                                                |
 | `--synced-lyrics-format`        | Synced lyrics format                                              | `lrc`                                          |
 | `--song-codec-priority`         | Comma-separated codec priority                                    | `aac-legacy`                                   |

{gamdl-3.0 → gamdl-3.2}/README.md

@@ -142,6 +142,7 @@ The file is created automatically on first run. Command-line arguments override
 | `--cover-format`                | Cover format                                                      | `jpg`                                          |
 | `--cover-size`                  | Cover size in pixels                                              | `1200`                                         |
 | `--wvd-path`                    | .wvd file path                                                    | -                                              |
+| `--wrapper-m3u8-ip`             | Wrapper m3u8 IP address and port                                  | -                                              |
 | **Song Options**                |                                                                   |                                                |
 | `--synced-lyrics-format`        | Synced lyrics format                                              | `lrc`                                          |
 | `--song-codec-priority`         | Comma-separated codec priority                                    | `aac-legacy`                                   |

gamdl-3.2/gamdl/__init__.py

@@ -0,0 +1 @@
+__version__ = "3.2"

{gamdl-3.0 → gamdl-3.2}/gamdl/api/apple_music.py

@@ -70,6 +70,7 @@ class AppleMusicApi:
     async def get_token() -> str:
         log = logger.bind(action="get_token")
 
+        response = None
         async with httpx.AsyncClient() as client:
             try:
                 response = await client.get(
@@ -81,7 +82,7 @@ class AppleMusicApi:
             except httpx.HTTPError:
                 raise GamdlApiResponseError(
                     "Error fetching Apple Music homepage",
-                    status_code=response.status_code,
+                    status_code=response.status_code if response is not None else None,
                 )
 
         index_js_uri_match = re.search(
@@ -94,6 +95,7 @@ class AppleMusicApi:
             )
         index_js_uri = index_js_uri_match.group(1)
 
+        response = None
         async with httpx.AsyncClient(follow_redirects=True) as client:
             try:
                 response = await client.get(
@@ -104,7 +106,7 @@ class AppleMusicApi:
             except httpx.HTTPError:
                 raise GamdlApiResponseError(
                     "Error fetching index.js page",
-                    status_code=response.status_code,
+                    status_code=response.status_code if response is not None else None,
                 )
 
         token_match = re.search('(?=eyJh)(.*?)(?=")', index_js_page)
@@ -124,6 +126,7 @@ class AppleMusicApi:
     ) -> dict:
         log = logger.bind(action="get_account_info", meta=meta)
 
+        response = None
         async with httpx.AsyncClient() as client:
             try:
                 response = await client.get(
@@ -142,7 +145,7 @@ class AppleMusicApi:
             except httpx.HTTPError:
                 raise GamdlApiResponseError(
                     "Error fetching account info",
-                    status_code=response.status_code,
+                    status_code=response.status_code if response is not None else None,
                 )
 
         log.debug("success", account_info=account_info)
@@ -243,6 +246,7 @@ class AppleMusicApi:
         *args,
         **kwargs,
     ) -> "AppleMusicApi":
+        response = None
         async with httpx.AsyncClient() as client:
             try:
                 response = await client.get(wrapper_account_url)
@@ -251,7 +255,7 @@ class AppleMusicApi:
             except httpx.HTTPError:
                 raise GamdlApiResponseError(
                     "Error fetching wrapper account info",
-                    status_code=response.status_code,
+                    status_code=response.status_code if response is not None else None,
                 )
 
         return await cls.create(
@@ -266,6 +270,7 @@ class AppleMusicApi:
         uri: str,
         params: dict | None = None,
     ) -> dict:
+        response = None
         try:
             response = await self.client.get(
                 APPLE_MUSIC_AMP_API_URL + uri,
@@ -276,8 +281,8 @@ class AppleMusicApi:
         except httpx.HTTPError:
             raise GamdlApiResponseError(
                 "Error fetching from AMP API",
-                content=response.text,
-                status_code=response.status_code,
+                content=response.text if response is not None else None,
+                status_code=response.status_code if response is not None else None,
             )
 
         if "errors" in response_json:
@@ -533,6 +538,7 @@ class AppleMusicApi:
     ) -> dict:
         log = logger.bind(action="get_webplayback", track_id=track_id)
 
+        response = None
         try:
             response = await self.client.post(
                 APPLE_MUSIC_WEBPLAYBACK_API_URL,
@@ -546,8 +552,8 @@ class AppleMusicApi:
         except httpx.HTTPError:
             raise GamdlApiResponseError(
                 "Error fetching webplayback data",
-                content=response.text,
-                status_code=response.status_code,
+                content=response.text if response is not None else None,
+                status_code=response.status_code if response is not None else None,
             )
 
         if "dialog" in webplayback:
@@ -570,6 +576,7 @@ class AppleMusicApi:
     ) -> dict:
         log = logger.bind(action="get_license_exchange", track_id=track_id)
 
+        response = None
         try:
             response = await self.client.post(
                 APPLE_MUSIC_LICENSE_API_URL,
@@ -587,8 +594,8 @@ class AppleMusicApi:
         except httpx.HTTPError:
             raise GamdlApiResponseError(
                 "Error fetching license exchange data",
-                content=response.text,
-                status_code=response.status_code,
+                content=response.text if response is not None else None,
+                status_code=response.status_code if response is not None else None,
             )
 
         if license_exchange.get("status") != 0:

{gamdl-3.0 → gamdl-3.2}/gamdl/api/exceptions.py

@@ -9,7 +9,7 @@ class GamdlApiResponseError(GamdlApiError):
     def __init__(
         self,
         message: str,
-        content: str,
+        content: str | None = None,
         status_code: int | None = None,
     ):
         self.message = message

{gamdl-3.0 → gamdl-3.2}/gamdl/api/itunes.py

@@ -30,6 +30,7 @@ class ItunesApi:
     async def get_storefront_id(storefront: str) -> int:
         log = logger.bind(action="get_storefront_id", storefront=storefront)
 
+        response = None
         async with httpx.AsyncClient() as client:
             try:
                 response = await client.get(APPLE_MUSIC_MUSIC_KIT_URL)
@@ -38,7 +39,7 @@ class ItunesApi:
             except httpx.HTTPError:
                 raise GamdlApiResponseError(
                     "Error fetching MusicKit content",
-                    status_code=response.status_code,
+                    status_code=response.status_code if response is not None else None,
                 )
 
         normalized_storefront = storefront.upper()
@@ -92,6 +93,7 @@ class ItunesApi:
     ) -> dict:
         log = logger.bind(action="get_lookup_result", media_id=media_id, entity=entity)
 
+        response = None
         try:
             response = await self.client.get(
                 ITUNES_LOOKUP_API_URL,
@@ -107,8 +109,8 @@ class ItunesApi:
         except httpx.HTTPError:
             raise GamdlApiResponseError(
                 "Error fetching iTunes lookup result",
-                content=response.text,
-                status_code=response.status_code,
+                content=response.text if response is not None else None,
+                status_code=response.status_code if response is not None else None,
             )
 
         log.debug("success", lookup_result=lookup_result)
@@ -126,6 +128,7 @@ class ItunesApi:
             media_id=media_id,
         )
 
+        response = None
         try:
             response = await self.client.get(
                 ITUNES_PAGE_API_URL.format(media_type=media_type, media_id=media_id),
@@ -138,8 +141,8 @@ class ItunesApi:
         except httpx.HTTPError:
             raise GamdlApiResponseError(
                 "Error fetching iTunes page",
-                content=response.text,
-                status_code=response.status_code,
+                content=response.text if response is not None else None,
+                status_code=response.status_code if response is not None else None,
             )
 
         log.debug("success", itunes_page=itunes_page)

{gamdl-3.0 → gamdl-3.2}/gamdl/cli/cli.py

@@ -1,6 +1,5 @@
 import asyncio
 import logging
-import traceback
 from functools import wraps
 from pathlib import Path
 
@@ -18,9 +17,7 @@ from ..downloader import (
     AppleMusicMusicVideoDownloader,
     AppleMusicSongDownloader,
     AppleMusicUploadedVideoDownloader,
-    DownloadItem,
     GamdlDownloaderDependencyNotFoundError,
-    GamdlDownloaderFlatFilterExcludedError,
     GamdlDownloaderMediaFileExistsError,
     GamdlDownloaderSyncedLyricsOnlyError,
 )
@@ -32,6 +29,7 @@ from ..interface import (
     AppleMusicUploadedVideoInterface,
     GamdlInterfaceArtistMediaTypeError,
     GamdlInterfaceDecryptionNotAvailableError,
+    GamdlInterfaceFlatFilterExcludedError,
     GamdlInterfaceFormatNotAvailableError,
     GamdlInterfaceMediaNotStreamableError,
     GamdlInterfaceUrlParseError,
@@ -78,6 +76,7 @@ async def main(config: CliConfig):
     structlog.configure(
         processors=[
             structlog.processors.add_log_level,
+            structlog.processors.ExceptionPrettyPrinter(),
             custom_structlog_formatter,
         ],
         logger_factory=structlog.stdlib.LoggerFactory(),
@@ -142,6 +141,8 @@ async def main(config: CliConfig):
         apple_music_api=apple_music_api,
         cover_format=config.cover_format,
         cover_size=config.cover_size,
+        use_wrapper=config.use_wrapper,
+        wrapper_m3u8_ip=config.wrapper_m3u8_ip,
         wvd_path=config.wvd_path,
     )
 
@@ -150,7 +151,6 @@ async def main(config: CliConfig):
         synced_lyrics_format=config.synced_lyrics_format,
         codec_priority=config.song_codec_piority,
         use_album_date=config.use_album_date,
-        skip_decryption_key_non_legacy=config.use_wrapper,
         skip_stream_info=config.synced_lyrics_only,
         ask_codec_function=interactive_prompts.ask_song_codec,
     )
@@ -184,7 +184,6 @@ async def main(config: CliConfig):
         mp4decrypt_path=config.mp4decrypt_path,
         ffmpeg_path=config.ffmpeg_path,
         mp4box_path=config.mp4box_path,
-        use_wrapper=config.use_wrapper,
         wrapper_decrypt_ip=config.wrapper_decrypt_ip,
         download_mode=config.download_mode,
         album_folder_template=config.album_folder_template,
@@ -245,64 +244,71 @@ async def main(config: CliConfig):
         url_log.info(f'Processing "{url}"')
 
         try:
-            download_queue: list[DownloadItem] = []
-            async for media in downloader.get_download_item_from_url(url):
-                download_queue.append(media)
+            async for download_item in downloader.get_download_item_from_url(url):
+                media_index = download_item.media.index + 1
+                media_total = download_item.media.total or "-"
+
+                track_log = logger.bind(
+                    action=f"Track {media_index:>3}/{media_total:<3}"
+                )
+
+                media_title = (
+                    download_item.media.media_metadata["attributes"]["name"]
+                    if download_item.media.media_metadata
+                    and download_item.media.media_metadata.get("attributes", {}).get(
+                        "name"
+                    )
+                    else "Unknown Title"
+                )
+                media_type = (
+                    download_item.media.media_metadata["type"]
+                    if download_item.media.media_metadata
+                    else None
+                )
+
+                if download_item.media.partial and media_type in {
+                    None,
+                    "songs",
+                    "library-songs",
+                    "music-videos",
+                    "library-music-videos",
+                    "uploaded-videos",
+                }:
+                    track_log.info(f'Downloading "{media_title}"')
+
+                try:
+                    await downloader.download(download_item)
+                except (
+                    GamdlInterfaceMediaNotStreamableError,
+                    GamdlInterfaceFormatNotAvailableError,
+                    GamdlInterfaceDecryptionNotAvailableError,
+                    GamdlInterfaceArtistMediaTypeError,
+                    GamdlDownloaderSyncedLyricsOnlyError,
+                    GamdlDownloaderMediaFileExistsError,
+                    GamdlDownloaderDependencyNotFoundError,
+                    GamdlInterfaceFlatFilterExcludedError,
+                ) as e:
+                    track_log.warning(f'Skipping "{media_title}": {e}')
+                    continue
+                except Exception as e:
+                    error_count += 1
+                    track_log.exception(f'Error downloading "{media_title}"')
+
+                if (
+                    database
+                    and download_item.media.media_metadata
+                    and download_item.final_path
+                ):
+                    database.add(
+                        download_item.media.media_metadata["id"],
+                        download_item.final_path,
+                    )
         except GamdlInterfaceUrlParseError as e:
-            url_log.warning(f"{e}")
+            url_log.error(f"{e}")
             continue
         except Exception as e:
-            url_log.error(f'Error processing "{url}": {e}')
+            url_log.exception(f'Error processing "{url}": {e}')
             error_count += 1
-            if not config.no_exceptions:
-                traceback.print_exc()
             continue
 
-        for download_index, download_item in enumerate(
-            download_queue,
-            1,
-        ):
-            track_log = logger.bind(
-                action=f"Track {download_index:>3}/{len(download_queue):<3}"
-            )
-
-            media_title = (
-                download_item.media.media_metadata["attributes"]["name"]
-                if download_item.media.media_metadata
-                and download_item.media.media_metadata.get("attributes", {}).get("name")
-                else "Unknown Title"
-            )
-
-            track_log.info(f'Downloading "{media_title}"')
-
-            try:
-                await downloader.download(download_item)
-            except (
-                GamdlInterfaceMediaNotStreamableError,
-                GamdlInterfaceFormatNotAvailableError,
-                GamdlInterfaceDecryptionNotAvailableError,
-                GamdlInterfaceArtistMediaTypeError,
-                GamdlDownloaderSyncedLyricsOnlyError,
-                GamdlDownloaderMediaFileExistsError,
-                GamdlDownloaderDependencyNotFoundError,
-                GamdlDownloaderFlatFilterExcludedError,
-            ) as e:
-                track_log.warning(f'Skipping "{media_title}": {e}')
-                continue
-            except Exception as e:
-                error_count += 1
-                track_log.error(f'Error downloading "{media_title}"')
-                if not config.no_exceptions:
-                    traceback.print_exc()
-
-            if (
-                database
-                and download_item.media.media_metadata
-                and download_item.final_path
-            ):
-                database.add(
-                    download_item.media.media_metadata["id"],
-                    download_item.final_path,
-                )
-
     logger.info(f"Finished with {error_count} error(s)")

{gamdl-3.0 → gamdl-3.2}/gamdl/cli/cli_config.py

@@ -210,6 +210,22 @@ class CliConfig:
             ),
         ),
     ]
+    use_wrapper: Annotated[
+        bool,
+        option(
+            "--use-wrapper",
+            help="Use wrapper for decrypting songs",
+            is_flag=True,
+        ),
+    ]
+    wrapper_m3u8_ip: Annotated[
+        str,
+        option(
+            "--wrapper-m3u8-ip",
+            help="Wrapper m3u8 IP address and port",
+            default=base_interface_create_sig.parameters["wrapper_m3u8_ip"].default,
+        ),
+    ]
     # Song Interface Options
     synced_lyrics_format: Annotated[
         SyncedLyricsFormat,
@@ -328,14 +344,6 @@ class CliConfig:
             default=base_downloader_sig.parameters["mp4box_path"].default,
         ),
     ]
-    use_wrapper: Annotated[
-        bool,
-        option(
-            "--use-wrapper",
-            help="Use wrapper for decrypting songs",
-            is_flag=True,
-        ),
-    ]
     wrapper_decrypt_ip: Annotated[
         str,
         option(

{gamdl-3.0 → gamdl-3.2}/gamdl/downloader/base.py

@@ -27,7 +27,6 @@ class AppleMusicBaseDownloader:
         mp4decrypt_path: str = "mp4decrypt",
         ffmpeg_path: str = "ffmpeg",
         mp4box_path: str = "MP4Box",
-        use_wrapper: bool = False,
         wrapper_decrypt_ip: str = "127.0.0.1:10020",
         download_mode: DownloadMode = DownloadMode.YTDLP,
         album_folder_template: str = "{album_artist}/{album}",
@@ -50,7 +49,6 @@ class AppleMusicBaseDownloader:
         self.mp4decrypt_path = mp4decrypt_path
         self.ffmpeg_path = ffmpeg_path
         self.mp4box_path = mp4box_path
-        self.use_wrapper = use_wrapper
         self.wrapper_decrypt_ip = wrapper_decrypt_ip
         self.download_mode = download_mode
         self.album_folder_template = album_folder_template

{gamdl-3.0 → gamdl-3.2}/gamdl/downloader/downloader.py

@@ -5,12 +5,10 @@ from typing import AsyncGenerator
 import structlog
 
 from ..interface.types import AppleMusicMedia
-
 from .constants import TEMP_PATH_TEMPLATE
 from .enums import DownloadMode, RemuxMode
 from .exceptions import (
     GamdlDownloaderDependencyNotFoundError,
-    GamdlDownloaderFlatFilterExcludedError,
     GamdlDownloaderMediaFileExistsError,
     GamdlDownloaderSyncedLyricsOnlyError,
 )
@@ -60,7 +58,10 @@ class AppleMusicDownloader:
         self,
         media: AppleMusicMedia,
     ) -> DownloadItem:
-        if media.error or media.flat_filter_result:
+        if media.error:
+            return DownloadItem(media)
+
+        if media.partial:
             return DownloadItem(media)
 
         elif media.media_metadata["type"] in {"songs", "library-songs"}:
@@ -80,10 +81,8 @@ class AppleMusicDownloader:
             if item.media.error:
                 raise item.media.error
 
-            if item.media.flat_filter_result:
-                raise GamdlDownloaderFlatFilterExcludedError(
-                    item.media.media_metadata["id"]
-                )
+            if item.media.partial:
+                return
 
             await self._initial_processing(item)
             await self._download(item)

{gamdl-3.0 → gamdl-3.2}/gamdl/downloader/exceptions.py

@@ -18,8 +18,3 @@ class GamdlDownloaderMediaFileExistsError(GamdlDownloaderError):
 class GamdlDownloaderDependencyNotFoundError(GamdlDownloaderError):
     def __init__(self, dependency_name: str) -> None:
         super().__init__(f"Required dependency not found: {dependency_name}")
-
-
-class GamdlDownloaderFlatFilterExcludedError(GamdlDownloaderError):
-    def __init__(self, media_id: str) -> None:
-        super().__init__(f"Media is excluded by flat filter: {media_id}")

{gamdl-3.0 → gamdl-3.2}/gamdl/downloader/song.py

@@ -96,7 +96,7 @@ class AppleMusicSongDownloader:
             staged_path=staged_path,
         )
 
-        if self.base.use_wrapper and not legacy:
+        if self.base.interface.base.use_wrapper and not legacy:
             await self._decrypt_amdecrypt(
                 encrypted_path,
                 staged_path,

{gamdl-3.0 → gamdl-3.2}/gamdl/interface/base.py

@@ -29,12 +29,16 @@ class AppleMusicBaseInterface:
         itunes_api: ItunesApi,
         cover_format: CoverFormat,
         cover_size: int,
+        use_wrapper: bool,
+        wrapper_m3u8_ip: str,
         cdm: Cdm,
     ) -> None:
         self.apple_music_api = apple_music_api
         self.itunes_api = itunes_api
         self.cover_format = cover_format
         self.cover_size = cover_size
+        self.use_wrapper = use_wrapper
+        self.wrapper_m3u8_ip = wrapper_m3u8_ip
         self.cdm = cdm
 
     @staticmethod
@@ -103,14 +107,28 @@ class AppleMusicBaseInterface:
 
         return response
 
+    @staticmethod
+    def format_cover(
+        template_cover_url: str,
+        cover_size: int,
+        cover_format: CoverFormat,
+    ) -> str:
+        return re.sub(
+            r"/\{w\}x\{h\}([a-z]{2})\.jpg",
+            f"/{cover_size}x{cover_size}bb.{cover_format.value}",
+            template_cover_url,
+        )
+
     @classmethod
     async def create(
         cls,
         apple_music_api: AppleMusicApi,
         cover_format: CoverFormat = CoverFormat.JPG,
         cover_size: int = 1200,
-        itunes_api: ItunesApi | None = None,
+        use_wrapper: bool = False,
+        wrapper_m3u8_ip: str = "127.0.0.1:20020",
         wvd_path: str | None = None,
+        itunes_api: ItunesApi | None = None,
     ):
         itunes_api = itunes_api or await ItunesApi.create(
             storefront=apple_music_api.storefront,
@@ -123,6 +141,8 @@ class AppleMusicBaseInterface:
             itunes_api=itunes_api,
             cover_format=cover_format,
             cover_size=cover_size,
+            use_wrapper=use_wrapper,
+            wrapper_m3u8_ip=wrapper_m3u8_ip,
             cdm=cdm,
         )
         return base
@@ -246,10 +266,10 @@ class AppleMusicBaseInterface:
         if self.cover_format == CoverFormat.RAW:
             cover_url = template_url
         else:
-            cover_url = re.sub(
-                r"/\{w\}x\{h\}([a-z]{2})\.jpg",
-                f"/{self.cover_size}x{self.cover_size}bb.{self.cover_format.value}",
+            cover_url = self.format_cover(
                 template_url,
+                self.cover_size,
+                self.cover_format,
             )
 
         cover_file_extension = await self._get_cover_file_extension(cover_url)

{gamdl-3.0 → gamdl-3.2}/gamdl/interface/exceptions.py

@@ -38,5 +38,14 @@ class GamdlInterfaceUrlParseError(GamdlInterfaceError):
 
 
 class GamdlInterfaceArtistMediaTypeError(GamdlInterfaceError):
-    def __init__(self, media_type: str):
-        super().__init__(f"Artist has no media of type: {media_type}")
+    def __init__(self, media_id: str, media_type: str):
+        super().__init__(
+            f"Artist has no media of type (media ID: {media_id}): {media_type}"
+        )
+
+
+class GamdlInterfaceFlatFilterExcludedError(GamdlInterfaceError):
+    def __init__(self, media_id: str, result: Any):
+        super().__init__(f"Media excluded by flat filter: {media_id}")
+
+        self.result = result