gac 0.16.1__tar.gz → 0.16.3__tar.gz

{gac-0.16.1 → gac-0.16.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gac
-Version: 0.16.1
+Version: 0.16.3
 Summary: AI-powered Git commit message generator with multi-provider support
 Project-URL: Homepage, https://github.com/cellwebb/gac
 Project-URL: Documentation, https://github.com/cellwebb/gac#readme

{gac-0.16.1 → gac-0.16.3}/src/gac/__version__.py

@@ -1,3 +1,3 @@
 """Version information for gac package."""
 
-__version__ = "0.16.1"
+__version__ = "0.16.3"

{gac-0.16.1 → gac-0.16.3}/src/gac/constants.py

@@ -102,8 +102,8 @@ class FileTypeImportance:
         ".ini": 3.5,  # INI config
         ".env": 3.5,  # Environment variables
         # Documentation
-        ".md": 4.0,  # Markdown
-        ".rst": 3.8,  # reStructuredText
+        ".md": 2.5,  # Markdown (reduced to prioritize code changes)
+        ".rst": 2.5,  # reStructuredText (reduced to prioritize code changes)
         # Web
         ".html": 3.5,  # HTML
         ".css": 3.5,  # CSS

{gac-0.16.1 → gac-0.16.3}/src/gac/git.py

@@ -127,12 +127,25 @@ def run_pre_commit_hooks() -> bool:
 
         # Run pre-commit hooks on staged files
         logger.info("Running pre-commit hooks...")
-        try:
-            run_subprocess(["pre-commit", "run"], silent=False, raise_on_error=True)
-            # If we get here, all hooks passed
+        # Run pre-commit and capture both stdout and stderr
+        result = subprocess.run(["pre-commit", "run"], capture_output=True, text=True, check=False)
+
+        if result.returncode == 0:
+            # All hooks passed
             return True
-        except subprocess.CalledProcessError as e:
-            logger.error(f"Pre-commit hooks failed with exit code {e.returncode}")
+        else:
+            # Pre-commit hooks failed - show the output
+            output = result.stdout if result.stdout else ""
+            error = result.stderr if result.stderr else ""
+
+            # Combine outputs (pre-commit usually outputs to stdout)
+            full_output = output + ("\n" + error if error else "")
+
+            if full_output.strip():
+                # Show which hooks failed and why
+                logger.error(f"Pre-commit hooks failed:\n{full_output}")
+            else:
+                logger.error(f"Pre-commit hooks failed with exit code {result.returncode}")
             return False
     except Exception as e:
         logger.debug(f"Error running pre-commit: {e}")

{gac-0.16.1 → gac-0.16.3}/src/gac/prompt.py

@@ -15,6 +15,22 @@ DEFAULT_TEMPLATE = """<role>
 You are an expert git commit message generator. Your task is to analyze code changes and create a concise, meaningful git commit message. You will receive git status and diff information. Your entire response will be used directly as a git commit message.
 </role>
 
+<focus>
+Your commit message must reflect the core purpose and impact of these changes.
+Prioritize the primary intent over implementation details.
+Consider what future developers need to understand about this change.
+Identify if this introduces new capabilities, fixes problems, or improves existing code.
+</focus>
+
+<mixed_changes>
+When changes span multiple areas:
+- Choose the commit type based on the PRIMARY purpose, not the largest file count
+- Feature additions with supporting tests/docs should use 'feat'
+- Bug fixes with added tests should use 'fix'
+- Refactoring that improves multiple components should use 'refactor'
+- Documentation updates are 'docs' only when that's the sole purpose
+</mixed_changes>
+
 <format>
   <one_liner>
   Create a single-line commit message (50-72 characters if possible).
@@ -31,10 +47,17 @@ You are an expert git commit message generator. Your task is to analyze code cha
 </format>
 
 <conventions_no_scope>
-You MUST start your commit message with the most appropriate conventional commit prefix:
+You MUST start your commit message with the most appropriate conventional commit prefix.
+
+IMPORTANT: Check file types FIRST when determining the commit type:
+- If changes are ONLY to documentation files (*.md, *.rst, *.txt in docs/, README*, CHANGELOG*, etc.), ALWAYS use 'docs:'
+- Use 'docs:' ONLY when ALL changes are documentation files - INCLUDING README updates, regardless of how significant the changes are
+- If changes include both documentation and code, use the prefix for the code changes, unless it is a documentation-only change
+
+Commit type prefixes:
 - feat: A new feature or functionality addition
 - fix: A bug fix or error correction
-- docs: Documentation changes only
+- docs: Documentation changes only (INCLUDING README updates, regardless of how significant)
 - style: Changes to code style/formatting without logic changes
 - refactor: Code restructuring without behavior changes
 - perf: Performance improvements
@@ -55,10 +78,14 @@ You MUST write a conventional commit message with EXACTLY ONE type and the REQUI
 
 FORMAT: type({scope}): description
 
+IMPORTANT: Check file types FIRST when determining the commit type:
+- If changes are ONLY to documentation files (*.md, *.rst, *.txt in docs/, README*, CHANGELOG*, etc.), ALWAYS use 'docs'
+- If changes include both documentation and code, use the prefix for the code changes, unless it is a documentation-only change
+
 Select ONE type from this list that best matches the primary purpose of the changes:
 - feat: A new feature or functionality addition
 - fix: A bug fix or error correction
-- docs: Documentation changes only
+- docs: Documentation changes only (INCLUDING README and CHANGELOG updates, regardless of how significant)
 - style: Changes to code style/formatting without logic changes
 - refactor: Code restructuring without behavior changes
 - perf: Performance improvements
@@ -87,10 +114,14 @@ You MUST write a conventional commit message with EXACTLY ONE type and an inferr
 
 FORMAT: type(scope): description
 
+IMPORTANT: Check file types FIRST when determining the commit type:
+- If changes are ONLY to documentation files (*.md, *.rst, *.txt in docs/, README*, CHANGELOG*, etc.), ALWAYS use 'docs'
+- If changes include both documentation and code, use the prefix for the code changes, unless it is a documentation-only change
+
 Select ONE type from this list that best matches the primary purpose of the changes:
 - feat: A new feature or functionality addition
 - fix: A bug fix or error correction
-- docs: Documentation changes only
+- docs: Documentation changes only (INCLUDING README and CHANGELOG updates, regardless of how significant)
 - style: Changes to code style/formatting without logic changes
 - refactor: Code restructuring without behavior changes
 - perf: Performance improvements
@@ -100,6 +131,16 @@ Select ONE type from this list that best matches the primary purpose of the chan
 - chore: Miscellaneous changes not affecting src/test files
 
 You MUST infer an appropriate scope from the changes. A good scope is concise (usually one word) and indicates the component or area that was changed.
+
+<scope_rules>
+For scope inference, select the most specific component affected:
+- Use module/component names from the codebase (auth, api, cli, core)
+- Use functional areas for cross-cutting changes (config, build, test)
+- Keep scopes consistent with existing commit history when possible
+- Prefer established patterns over creating new scope names
+- Use singular form (auth, not auths; test, not tests)
+</scope_rules>
+
 Examples of good scopes: api, auth, ui, core, docs, build, prompt, config
 
 CORRECT EXAMPLES (these formats are correct):
@@ -133,6 +174,44 @@ Additional context provided by the user: <hint_text></hint_text>
 <diff></diff>
 </git_diff>
 
+
+
+<examples_no_scope>
+Good commit messages (no scope):
+[OK] feat: add OAuth2 integration with Google and GitHub
+[OK] fix: resolve race condition in user session management
+[OK] docs: add troubleshooting section for common installation issues
+[OK] refactor: extract validation logic into reusable utilities
+[OK] test: add comprehensive unit tests for token validation
+[OK] build: upgrade to latest security patches
+
+Bad commit messages:
+[ERROR] fix stuff
+[ERROR] update code
+[ERROR] feat(auth): add login (scope included when not requested)
+[ERROR] WIP: still working on this
+[ERROR] Fixed bug
+[ERROR] Changes
+</examples_no_scope>
+
+<examples_with_scope>
+Good commit messages (with scope):
+[OK] feat(auth): add OAuth2 integration with Google and GitHub
+[OK] fix(api): resolve race condition in user session management
+[OK] docs(readme): add troubleshooting section for common installation issues
+[OK] refactor(core): extract validation logic into reusable utilities
+[OK] test(auth): add comprehensive unit tests for token validation
+[OK] build(deps): upgrade to latest security patches
+
+Bad commit messages:
+[ERROR] fix stuff
+[ERROR] update code
+[ERROR] feat: fix(auth): add login (double prefix)
+[ERROR] WIP: still working on this
+[ERROR] Fixed bug
+[ERROR] Changes
+</examples_with_scope>
+
 <instructions>
 IMMEDIATELY AFTER ANALYZING THE CHANGES, RESPOND WITH ONLY THE COMMIT MESSAGE.
 DO NOT include any preamble, reasoning, explanations or anything other than the commit message itself.
@@ -237,6 +316,18 @@ def build_prompt(
     else:
         template = re.sub(r"<one_liner>.*?</one_liner>", "", template, flags=re.DOTALL)
 
+    # Clean up examples sections based on scope settings
+    if scope is None:
+        # No scope - keep no_scope examples, remove scope examples
+        template = re.sub(r"<examples_with_scope>.*?</examples_with_scope>\n?", "", template, flags=re.DOTALL)
+        template = template.replace("<examples_no_scope>", "<examples>")
+        template = template.replace("</examples_no_scope>", "</examples>")
+    else:
+        # With scope (either provided or inferred) - keep scope examples, remove no_scope examples
+        template = re.sub(r"<examples_no_scope>.*?</examples_no_scope>\n?", "", template, flags=re.DOTALL)
+        template = template.replace("<examples_with_scope>", "<examples>")
+        template = template.replace("</examples_with_scope>", "</examples>")
+
     # Clean up extra whitespace, collapsing blank lines that may contain spaces
     template = re.sub(r"\n(?:[ \t]*\n){2,}", "\n\n", template)
 

{gac-0.16.1 → gac-0.16.3}/src/gac/utils.py

@@ -102,12 +102,12 @@ def run_subprocess(
             timeout=timeout,
         )
 
-        if result.returncode != 0 and (check or raise_on_error):
+        should_raise = result.returncode != 0 and (check or raise_on_error)
+
+        if should_raise:
             if not silent:
                 logger.debug(f"Command stderr: {result.stderr}")
-
-            error = subprocess.CalledProcessError(result.returncode, command, result.stdout, result.stderr)
-            raise error
+            raise subprocess.CalledProcessError(result.returncode, command, result.stdout, result.stderr)
 
         output = result.stdout
         if strip_output:
@@ -119,7 +119,7 @@ def run_subprocess(
         raise GacError(f"Command timed out: {' '.join(command)}") from e
     except subprocess.CalledProcessError as e:
         if not silent:
-            logger.error(f"Command failed: {e.stderr.strip() if hasattr(e, 'stderr') else str(e)}")
+            logger.error(f"Command failed: {e.stderr.strip() if e.stderr else str(e)}")
         if raise_on_error:
             raise
         return ""
@@ -128,6 +128,5 @@ def run_subprocess(
             logger.debug(f"Command error: {e}")
         if raise_on_error:
             # Convert generic exceptions to CalledProcessError for consistency
-            error = subprocess.CalledProcessError(1, command, "", str(e))
-            raise error from e
+            raise subprocess.CalledProcessError(1, command, "", str(e)) from e
         return ""