fxsocket 0.3.0__tar.gz → 0.5.0__tar.gz

{fxsocket-0.3.0 → fxsocket-0.5.0}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.4
+Metadata-Version: 2.5
 Name: fxsocket
-Version: 0.3.0
+Version: 0.5.0
 Summary: Python SDK for the FxSocket API — MT4/MT5 account management, trading, and real-time streaming.
 Project-URL: Homepage, https://fxsocket.com
 Project-URL: Documentation, https://api.fxsocket.com/v1/docs
@@ -42,8 +42,9 @@ interfaces.
 - **Account management** — link, list, fetch, and disconnect MT4/MT5 accounts.
 - **Private servers** — list your dedicated hosting servers and manage the
   accounts on them.
-- **Trading** — market & pending orders, modify, close, plus margin/profit calculators.
-- **Market data** — quotes, symbol specifications, OHLC history, account state & info.
+- **Trading** — market & pending orders, modify, close, close-all, plus margin/profit calculators.
+- **Market data** — quotes, symbol specifications (incl. commission rules & trading
+  sessions), OHLC history, account state & info.
 - **Live streaming** — ticks, bars, account, positions, trades, and terminal status
   over WebSocket, with automatic reconnect + subscription replay.
 - **Sync *and* async** — `Client` / `AsyncClient`, method-for-method mirrors.
@@ -157,6 +158,21 @@ if res.is_effective:        # applied now, or already in effect
     ...
 ```
 
+There's also a panic button. `close_all()` closes every open position in one
+trade-EA pass — optionally filtered by `symbol` and/or `magic` (`magic=0`
+matches manually-opened orders), and `delete_pending=True` also deletes
+matching pending orders. It returns a `CloseAllSummary` with per-ticket
+results. On a 504 the pass *continues inside the terminal* — check
+`opened_orders()` before acting again rather than re-sending:
+
+```python
+summary = term.close_all(symbol="EURUSD", delete_pending=True)
+if summary.failed:
+    for r in summary.results:
+        if not r.success:
+            print(r.ticket, r.retcode, r.retcode_description)
+```
+
 Inputs are validated client-side before they're sent. One guard worth knowing:
 in `order_modify`, a literal `stop_loss=0.0` would *remove* your stop-loss, so
 it's rejected — pass `clear_stop_loss=True` to remove one deliberately, while
@@ -213,6 +229,35 @@ with Client(api_key="fxs_live_…") as fx:
                 print(event.data.bid, event.data.ask)
 ```
 
+### Trade events
+
+A `TradeUpdate` carries the full deal: `commission`, `swap`, `magic` and a
+real `comment` alongside `profit` (bridges MT5 0.12+ / MT4 0.11+; zero on
+older pods). Event-only P&L accounting is `data.net_profit`
+(`profit + commission + swap`).
+
+Correlate the `In` and `Out` events of one round-trip through
+`data.position` — on MT5, `Out` deals carry `magic=0` / `comment=""` unless
+the closing request set them (platform behavior, not a bridge gap), so
+position id is the reliable join key. On MT4, `deal` is always 0 and
+`position` equals the order ticket. The same id appears as `position` in
+`order_history()` rows (bridges MT5 0.14+ / MT4 0.13+) and as
+`position_id` in `position_history()`.
+
+If the bridge can't fully enrich an event in time it sets
+`data.degraded=True`: identifiers, `symbol`, `type`, `volume` and `price`
+are still trustworthy, but `entry` is `"Unknown"` and the cost fields are
+zeroed — reconcile that deal via `order_history()`.
+
+```python
+async for event in s:
+    match event:
+        case TradeUpdate() as t if t.data.degraded:
+            reconcile_later(t.data.position)     # costs/entry unreliable
+        case TradeUpdate() as t if t.data.entry == DealEntry.OUT:
+            print(t.data.position, "closed, net", t.data.net_profit)
+```
+
 ## Errors
 
 Every failure raises a subclass of `fxsocket.FxSocketError`:

{fxsocket-0.3.0 → fxsocket-0.5.0}/README.md

@@ -15,8 +15,9 @@ interfaces.
 - **Account management** — link, list, fetch, and disconnect MT4/MT5 accounts.
 - **Private servers** — list your dedicated hosting servers and manage the
   accounts on them.
-- **Trading** — market & pending orders, modify, close, plus margin/profit calculators.
-- **Market data** — quotes, symbol specifications, OHLC history, account state & info.
+- **Trading** — market & pending orders, modify, close, close-all, plus margin/profit calculators.
+- **Market data** — quotes, symbol specifications (incl. commission rules & trading
+  sessions), OHLC history, account state & info.
 - **Live streaming** — ticks, bars, account, positions, trades, and terminal status
   over WebSocket, with automatic reconnect + subscription replay.
 - **Sync *and* async** — `Client` / `AsyncClient`, method-for-method mirrors.
@@ -130,6 +131,21 @@ if res.is_effective:        # applied now, or already in effect
     ...
 ```
 
+There's also a panic button. `close_all()` closes every open position in one
+trade-EA pass — optionally filtered by `symbol` and/or `magic` (`magic=0`
+matches manually-opened orders), and `delete_pending=True` also deletes
+matching pending orders. It returns a `CloseAllSummary` with per-ticket
+results. On a 504 the pass *continues inside the terminal* — check
+`opened_orders()` before acting again rather than re-sending:
+
+```python
+summary = term.close_all(symbol="EURUSD", delete_pending=True)
+if summary.failed:
+    for r in summary.results:
+        if not r.success:
+            print(r.ticket, r.retcode, r.retcode_description)
+```
+
 Inputs are validated client-side before they're sent. One guard worth knowing:
 in `order_modify`, a literal `stop_loss=0.0` would *remove* your stop-loss, so
 it's rejected — pass `clear_stop_loss=True` to remove one deliberately, while
@@ -186,6 +202,35 @@ with Client(api_key="fxs_live_…") as fx:
                 print(event.data.bid, event.data.ask)
 ```
 
+### Trade events
+
+A `TradeUpdate` carries the full deal: `commission`, `swap`, `magic` and a
+real `comment` alongside `profit` (bridges MT5 0.12+ / MT4 0.11+; zero on
+older pods). Event-only P&L accounting is `data.net_profit`
+(`profit + commission + swap`).
+
+Correlate the `In` and `Out` events of one round-trip through
+`data.position` — on MT5, `Out` deals carry `magic=0` / `comment=""` unless
+the closing request set them (platform behavior, not a bridge gap), so
+position id is the reliable join key. On MT4, `deal` is always 0 and
+`position` equals the order ticket. The same id appears as `position` in
+`order_history()` rows (bridges MT5 0.14+ / MT4 0.13+) and as
+`position_id` in `position_history()`.
+
+If the bridge can't fully enrich an event in time it sets
+`data.degraded=True`: identifiers, `symbol`, `type`, `volume` and `price`
+are still trustworthy, but `entry` is `"Unknown"` and the cost fields are
+zeroed — reconcile that deal via `order_history()`.
+
+```python
+async for event in s:
+    match event:
+        case TradeUpdate() as t if t.data.degraded:
+            reconcile_later(t.data.position)     # costs/entry unreliable
+        case TradeUpdate() as t if t.data.entry == DealEntry.OUT:
+            print(t.data.position, "closed, net", t.data.net_profit)
+```
+
 ## Errors
 
 Every failure raises a subclass of `fxsocket.FxSocketError`:

{fxsocket-0.3.0 → fxsocket-0.5.0}/src/fxsocket/__init__.py

@@ -42,6 +42,10 @@ from .models import (
     AccountInfo,
     AccountSummary,
     Candle,
+    CloseAllResult,
+    CloseAllSummary,
+    CommissionRule,
+    CommissionTier,
     Health,
     HealthChecks,
     HistoryTrade,
@@ -57,6 +61,7 @@ from .models import (
     SymbolInfo,
     TerminalStatusData,
     TradeEventData,
+    TradingSession,
 )
 from .terminal import (
     AccountUpdate,
@@ -112,8 +117,13 @@ __all__ = [
     "ServerTimezone",
     "Quote",
     "SymbolInfo",
+    "CommissionRule",
+    "CommissionTier",
+    "TradingSession",
     "Candle",
     "OrderResult",
+    "CloseAllResult",
+    "CloseAllSummary",
     "MarginCalc",
     "ProfitCalc",
     "Health",

fxsocket-0.5.0/src/fxsocket/_version.py

@@ -0,0 +1 @@
+__version__ = "0.5.0"

{fxsocket-0.3.0 → fxsocket-0.5.0}/src/fxsocket/enums.py

@@ -103,11 +103,17 @@ class OrderKind(str, Enum):
 
 
 class DealEntry(str, Enum):
-    """Direction of a deal in trade history / the ``trades`` stream."""
+    """Direction of a deal in trade history / the ``trades`` stream.
+
+    ``UNKNOWN`` appears only on degraded ``trades``-stream frames, where the
+    bridge could not resolve the deal direction in time — see
+    ``TradeEventData.degraded``.
+    """
 
     IN = "In"
     OUT = "Out"
     IN_OUT = "InOut"
+    UNKNOWN = "Unknown"
 
 
 class HealthStatus(str, Enum):

{fxsocket-0.3.0 → fxsocket-0.5.0}/src/fxsocket/models.py

@@ -21,7 +21,7 @@ from __future__ import annotations
 
 from datetime import datetime
 
-from pydantic import BaseModel, ConfigDict
+from pydantic import BaseModel, ConfigDict, Field
 from pydantic.alias_generators import to_camel
 
 from .enums import OrderOutcome, Platform, TradingStatus
@@ -205,10 +205,20 @@ class HistoryTrade(_Camel):
 
     On MT4 this is one row per closed *order* (no per-deal granularity);
     ``order`` aliases the ticket and ``entry`` is constant.
+
+    ``position`` groups the rows of one round-trip: on MT5 it is the deal's
+    ``DEAL_POSITION_ID`` — the ``In`` and ``Out`` rows share it, and it
+    equals the ``trades``-stream events' ``position`` and
+    :attr:`PositionTrade.position_id` — so an exit row alone identifies the
+    position it closed even though MT5 exits usually carry ``magic=0`` /
+    ``comment=""``. On MT4 it equals the order ticket. 0 on pods older than
+    bridge MT5 0.14 / MT4 0.13. (Netting-account caveat: a reversal
+    ``InOut`` row reports the position it belongs to *after* processing.)
     """
 
     ticket: int
     order: int
+    position: int = 0
     symbol: str
     type: str
     entry: str
@@ -271,8 +281,65 @@ class Quote(_Camel):
     volume: int
 
 
+class CommissionTier(_Camel):
+    """One tier of a commission rule — a value and the volume/turnover range
+    it applies to.
+
+    Enum-like fields (``mode``, ``volume_type``) carry the raw MQL5 constant
+    names (e.g. ``SYMBOL_COMMISSION_MODE_MONEY``) so nothing is lost in
+    translation. ``range_to == 0`` means unbounded; ``min_value`` /
+    ``max_value`` cap the charged amount (0 = no cap).
+    """
+
+    mode: str
+    volume_type: str
+    value: float
+    min_value: float
+    max_value: float
+    range_from: float
+    range_to: float
+    currency: str
+
+
+class CommissionRule(_Camel):
+    """One broker commission rule for a symbol, as configured server-side
+    (MT5 ``SymbolInfoCommissions``).
+
+    A symbol can carry several rules; each has its own tiers. The mode fields
+    carry the MQL5 ``ENUM_SYMBOL_COMMISSION_*`` constant names verbatim.
+    """
+
+    currency: str
+    range_mode: str
+    charge_mode: str
+    entry_mode: str
+    direction_mode: str
+    profit_mode: str
+    tiers: list[CommissionTier] = []
+
+
+class TradingSession(_Camel):
+    """One trading-session window of a symbol, in *broker server time*.
+
+    ``day`` uses the MQL ``ENUM_DAY_OF_WEEK`` constant names (``SUNDAY`` …
+    ``SATURDAY``); times are ``HH:MM`` where ``24:00`` means end of day, so a
+    24-hour market shows ``00:00``–``24:00``.
+    """
+
+    day: str
+    from_: str = Field(alias="from")
+    to: str
+
+
 class SymbolInfo(_Camel):
-    """Contract specification for a symbol (``GET /SymbolInfo``)."""
+    """Contract specification for a symbol (``GET /SymbolInfo``).
+
+    ``commissions`` are the broker's commission rules straight from the
+    server's symbol specification; ``sessions`` are the per-weekday trading
+    windows in broker server time. Both default to empty on pods older than
+    bridge 0.10 (and ``commissions`` also when the broker publishes none or
+    the terminal predates the API — build 6060+).
+    """
 
     symbol: str
     description: str
@@ -295,6 +362,8 @@ class SymbolInfo(_Camel):
     currency_base: str
     currency_profit: str
     currency_margin: str
+    commissions: list[CommissionRule] = []
+    sessions: list[TradingSession] = []
 
 
 class Candle(_Camel):
@@ -360,6 +429,39 @@ class OrderResult(_Camel):
         return self.success or self.is_no_change
 
 
+class CloseAllResult(_Camel):
+    """One per-ticket outcome of a ``/CloseAll`` pass.
+
+    ``kind`` is ``"position"`` (closed) or ``"pending"`` (deleted).
+    """
+
+    ticket: int
+    kind: str
+    success: bool
+    retcode: int
+    retcode_description: str
+
+    @property
+    def is_pending(self) -> bool:
+        """True when this row is a deleted pending order (vs. a closed position)."""
+        return self.kind.lower() == "pending"
+
+
+class CloseAllSummary(_Camel):
+    """Reply of ``POST /CloseAll`` — every matched position (and pending
+    order, when ``delete_pending`` was set) with its close/delete outcome.
+
+    ``requested`` is how many orders the filters matched and were attempted;
+    ``closed`` how many attempts the broker accepted; ``failed`` how many it
+    rejected — inspect ``results`` for the per-ticket retcodes.
+    """
+
+    requested: int
+    closed: int
+    failed: int
+    results: list[CloseAllResult] = []
+
+
 class MarginCalc(_Camel):
     """Required margin for a hypothetical order (``GET /OrderCalcMargin``)."""
 
@@ -411,8 +513,17 @@ class AccountHealth(_Camel):
 
 
 class BridgeHealth(_Camel):
+    """Bridge section of ``/status``.
+
+    ``trade_ea_heartbeat_age_ms`` is how long ago the trade EA last made
+    dispatcher progress (``-1`` = never registered, or a pod older than
+    bridge 0.10). A large age while ``trade_ea_ready`` is still ``True``
+    means the EA is blocked in a long dealer call or dead — worth alerting on.
+    """
+
     version: str = ""
     trade_ea_ready: bool = False
+    trade_ea_heartbeat_age_ms: int = -1
     symbols_synced: bool = False
 
 
@@ -452,8 +563,29 @@ class HealthChecks(_Camel):
 class TradeEventData(_Camel):
     """A trade transaction pushed on the ``trades`` stream.
 
-    ``deal`` / ``position`` are 0 on MT4 (no per-deal model); ``entry`` is the
-    deal direction (compare against :class:`fxsocket.DealEntry`).
+    ``entry`` is the deal direction (compare against
+    :class:`fxsocket.DealEntry`; ``"Unknown"`` appears only on degraded
+    frames). ``commission`` / ``swap`` / ``magic`` (and a real ``comment`` on
+    MT5) arrive on bridges MT5 0.12+ / MT4 0.11+ and default to 0 before
+    that; a deal's net P&L is ``profit + commission + swap``
+    (:attr:`net_profit`).
+
+    Platform semantics:
+
+    * **MT5** — ``Out`` deals carry ``magic=0`` / ``comment=""`` unless the
+      closing request set them (a platform property, not a bridge gap).
+      Correlate ``In``/``Out`` through ``position``, which is present on
+      every event.
+    * **MT4** — orders keep their magic/comment for the whole lifecycle, so
+      both ``In`` and ``Out`` events carry them; ``deal`` is always 0 and
+      ``position`` equals the order ticket.
+
+    ``degraded=True`` (bridges MT5 0.13+ / MT4 0.12+; structurally always
+    ``False`` on MT4) means the bridge could not fully enrich the event in
+    time: the identifiers, ``symbol``, ``type``, ``volume`` and ``price`` are
+    trustworthy, but ``entry`` is ``"Unknown"`` and ``profit`` /
+    ``commission`` / ``swap`` / ``magic`` / ``comment`` are zeroed —
+    reconcile the deal via ``GET /OrderHistory``.
     """
 
     deal: int
@@ -465,8 +597,17 @@ class TradeEventData(_Camel):
     volume: float
     price: float
     profit: float
+    commission: float = 0.0
+    swap: float = 0.0
+    magic: int = 0
     comment: str
     time: str
+    degraded: bool = False
+
+    @property
+    def net_profit(self) -> float:
+        """Deal P&L including costs: ``profit + commission + swap``."""
+        return self.profit + self.commission + self.swap
 
 
 class TerminalStatusData(_Camel):

{fxsocket-0.3.0 → fxsocket-0.5.0}/src/fxsocket/terminal/client.py

@@ -46,6 +46,7 @@ from ..models import (
     AccountInfo,
     AccountSummary,
     Candle,
+    CloseAllSummary,
     Health,
     HealthChecks,
     HistoryTrade,
@@ -234,6 +235,20 @@ def _order_send_body(
     )
 
 
+def _close_all_body(
+    *, symbol: str | None, magic: int | None, delete_pending: bool
+) -> dict[str, Any]:
+    # magic=0 is a real filter (manually-opened orders) — only None is omitted.
+    # An empty dict is a valid body: it means "close everything".
+    return _clean(
+        {
+            "symbol": symbol,
+            "magic": magic,
+            "deletePending": True if delete_pending else None,
+        }
+    )
+
+
 def _order_modify_body(
     *,
     ticket: int,
@@ -481,6 +496,32 @@ class TerminalClient:
             self._http.request("POST", "/OrderClose", json=body)
         )
 
+    def close_all(
+        self,
+        *,
+        symbol: str | None = None,
+        magic: int | None = None,
+        delete_pending: bool = False,
+    ) -> CloseAllSummary:
+        """Close every open position in one trade-EA pass (``POST /CloseAll``).
+
+        Optionally filtered by ``symbol`` and/or ``magic`` (``magic=0``
+        matches manually-opened orders; ``None`` means no filter);
+        ``delete_pending=True`` also deletes matching pending orders. The
+        reply carries a per-ticket result for every attempted close/delete.
+
+        Positions opened while the pass is running are not covered, and on a
+        504 (:class:`~fxsocket.TerminalTimeoutError`) the pass *continues to
+        completion inside the terminal* — check :meth:`opened_orders` before
+        acting again rather than re-sending.
+        """
+        body = _close_all_body(
+            symbol=symbol, magic=magic, delete_pending=delete_pending
+        )
+        return CloseAllSummary.model_validate(
+            self._http.request("POST", "/CloseAll", json=body)
+        )
+
     # -- health ------------------------------------------------------------ #
 
     def status(self) -> Health:
@@ -732,6 +773,21 @@ class AsyncTerminalClient:
             await self._http.request("POST", "/OrderClose", json=body)
         )
 
+    async def close_all(
+        self,
+        *,
+        symbol: str | None = None,
+        magic: int | None = None,
+        delete_pending: bool = False,
+    ) -> CloseAllSummary:
+        """Async mirror of :meth:`TerminalClient.close_all`."""
+        body = _close_all_body(
+            symbol=symbol, magic=magic, delete_pending=delete_pending
+        )
+        return CloseAllSummary.model_validate(
+            await self._http.request("POST", "/CloseAll", json=body)
+        )
+
     async def status(self) -> Health:
         return Health.model_validate(await self._http.request("GET", "/status"))
 

{fxsocket-0.3.0 → fxsocket-0.5.0}/tests/test_private_servers.py

@@ -26,8 +26,8 @@ SERVER_ACCOUNT = {
     "server": "ICMarkets-Demo",
     "login": 7001,
     "status": "ready",
-    "rest_url": f"https://159.223.244.125/22222222-2222-2222-2222-222222222222",
-    "ws_url": f"wss://159.223.244.125/22222222-2222-2222-2222-222222222222/ws",
+    "rest_url": "https://159.223.244.125/22222222-2222-2222-2222-222222222222",
+    "ws_url": "wss://159.223.244.125/22222222-2222-2222-2222-222222222222/ws",
     "trade_ea_symbol": "",
     "created_at": "2026-07-16T08:00:00Z",
 }

{fxsocket-0.3.0 → fxsocket-0.5.0}/tests/test_stream.py

@@ -13,6 +13,7 @@ from fxsocket import (
     AccountUpdate,
     AsyncStream,
     Bar,
+    DealEntry,
     PositionsUpdate,
     Stream,
     StreamWarning,
@@ -157,12 +158,19 @@ def test_parse_event_all_types() -> None:
                 "volume": 0.1,
                 "price": 1.0,
                 "profit": 0.0,
-                "comment": "",
+                "commission": -0.04,
+                "swap": 0.0,
+                "magic": 1000999,
+                "comment": "CN_9999_8888",
                 "time": "t",
+                "degraded": False,
             },
         }
     )
     assert isinstance(trade, TradeUpdate) and trade.data.entry == "In"
+    assert trade.data.commission == -0.04 and trade.data.magic == 1000999
+    assert trade.data.degraded is False
+    assert trade.data.net_profit == pytest.approx(-0.04)
 
     term = parse_event(
         {
@@ -192,6 +200,61 @@ def test_parse_event_all_types() -> None:
     assert isinstance(parse_event({"type": "subscriptions", "data": []}), Subscriptions)
 
 
+def test_parse_trade_pre_012_bridge_defaults() -> None:
+    """Bridges older than MT5 0.12 / MT4 0.11 omit the enrichment fields."""
+    trade = parse_event(
+        {
+            "type": "trade",
+            "data": {
+                "deal": 9,
+                "order": 10,
+                "position": 10,
+                "symbol": "EURUSD",
+                "type": "Buy",
+                "entry": "In",
+                "volume": 0.1,
+                "price": 1.0,
+                "profit": 0.0,
+                "comment": "",
+                "time": "t",
+            },
+        }
+    )
+    assert isinstance(trade, TradeUpdate)
+    assert trade.data.commission == 0.0 and trade.data.swap == 0.0
+    assert trade.data.magic == 0 and trade.data.degraded is False
+
+
+def test_parse_trade_degraded_frame() -> None:
+    """A degraded frame: identifiers/direction real, costs zeroed, entry Unknown."""
+    trade = parse_event(
+        {
+            "type": "trade",
+            "data": {
+                "deal": 9,
+                "order": 10,
+                "position": 10,
+                "symbol": "EURUSD",
+                "type": "Buy",
+                "entry": "Unknown",
+                "volume": 0.1,
+                "price": 1.0,
+                "profit": 0.0,
+                "commission": 0.0,
+                "swap": 0.0,
+                "magic": 0,
+                "comment": "",
+                "time": "2026-08-19T18:53:41.000Z",
+                "degraded": True,
+            },
+        }
+    )
+    assert isinstance(trade, TradeUpdate)
+    assert trade.data.degraded is True
+    assert trade.data.entry == DealEntry.UNKNOWN
+    assert trade.data.symbol == "EURUSD" and trade.data.position == 10
+
+
 # --------------------------------------------------------------------------- #
 # Validation (no connection needed — raised before send)
 # --------------------------------------------------------------------------- #

{fxsocket-0.3.0 → fxsocket-0.5.0}/tests/test_terminal.py

@@ -212,6 +212,22 @@ def test_status_nested_health() -> None:
     assert h.terminal.ping_ms == 108
     assert h.account.logged_in is True
     assert h.bridge.trade_ea_ready is True
+    # Pre-0.10 bridges omit the heartbeat — defaults to -1 (never/unknown).
+    assert h.bridge.trade_ea_heartbeat_age_ms == -1
+
+
+def test_bridge_health_heartbeat_parses() -> None:
+    from fxsocket.models import BridgeHealth
+
+    b = BridgeHealth.model_validate(
+        {
+            "version": "0.10.0",
+            "tradeEaReady": True,
+            "tradeEaHeartbeatAgeMs": 8,
+            "symbolsSynced": True,
+        }
+    )
+    assert b.trade_ea_heartbeat_age_ms == 8
 
 
 # --------------------------------------------------------------------------- #
@@ -430,6 +446,76 @@ def test_order_modify_omits_unset_fields() -> None:
     }
 
 
+@respx.mock
+def test_close_all_sends_filters_and_parses() -> None:
+    route = respx.post(f"{TERM}/CloseAll").mock(
+        return_value=httpx.Response(
+            200,
+            json={
+                "requested": 2,
+                "closed": 1,
+                "failed": 1,
+                "results": [
+                    {
+                        "ticket": 100,
+                        "kind": "position",
+                        "success": True,
+                        "retcode": 10009,
+                        "retcodeDescription": "Done",
+                    },
+                    {
+                        "ticket": 101,
+                        "kind": "pending",
+                        "success": False,
+                        "retcode": 10006,
+                        "retcodeDescription": "Rejected",
+                    },
+                ],
+            },
+        )
+    )
+    with _term() as t:
+        summary = t.close_all(symbol="EURUSD", magic=0, delete_pending=True)
+    # magic=0 is a real filter (manual orders) and must be sent, not dropped.
+    assert json.loads(route.calls.last.request.content) == {
+        "symbol": "EURUSD",
+        "magic": 0,
+        "deletePending": True,
+    }
+    assert (summary.requested, summary.closed, summary.failed) == (2, 1, 1)
+    assert [r.is_pending for r in summary.results] == [False, True]
+    assert summary.results[1].retcode_description == "Rejected"
+
+
+@respx.mock
+def test_close_all_no_filters_sends_empty_json_body() -> None:
+    # /CloseAll requires a JSON body; with no filters it must be exactly {}.
+    route = respx.post(f"{TERM}/CloseAll").mock(
+        return_value=httpx.Response(
+            200, json={"requested": 0, "closed": 0, "failed": 0, "results": []}
+        )
+    )
+    with _term() as t:
+        summary = t.close_all()
+    req = route.calls.last.request
+    assert json.loads(req.content) == {}
+    assert req.headers["content-type"] == "application/json"
+    assert summary.requested == 0 and summary.results == []
+
+
+@respx.mock
+def test_close_all_504_maps_to_timeout() -> None:
+    # The pass continues inside the terminal after a 504 — the SDK must
+    # surface the timeout (never retry), so callers re-check /OpenedOrders.
+    respx.post(f"{TERM}/CloseAll").mock(
+        return_value=httpx.Response(
+            504, json={"error": "MRPC_TIMEOUT", "message": "timed out", "command_id": 3}
+        )
+    )
+    with _term() as t, pytest.raises(TerminalTimeoutError):
+        t.close_all()
+
+
 # --------------------------------------------------------------------------- #
 # Health probes — 503 carries a body, not an error
 # --------------------------------------------------------------------------- #
@@ -552,6 +638,46 @@ def test_symbol_info_parses_camelcase() -> None:
     assert si.tick_size == 0.00001
     assert si.volume_min == 0.01
     assert si.currency_base == "EUR"
+    # Pods older than bridge 0.10 omit commissions/sessions — default empty.
+    assert si.commissions == [] and si.sessions == []
+
+
+def test_symbol_info_commissions_and_sessions_parse() -> None:
+    from fxsocket import CommissionRule, TradingSession
+
+    rule = CommissionRule.model_validate(
+        {
+            "currency": "USD",
+            "rangeMode": "SYMBOL_COMMISSION_RANGE_VOLUME",
+            "chargeMode": "SYMBOL_COMMISSION_CHARGE_INSTANT",
+            "entryMode": "SYMBOL_COMMISSION_ENTRY_INOUT",
+            "directionMode": "SYMBOL_COMMISSION_DIRECTION_BOTH",
+            "profitMode": "SYMBOL_COMMISSION_PROFIT_ALL",
+            "tiers": [
+                {
+                    "mode": "SYMBOL_COMMISSION_MONEY_DEPOSIT",
+                    "volumeType": "SYMBOL_COMMISSION_VOLUME_TYPE_VOLUME",
+                    "value": 3.5,
+                    "minValue": 0.0,
+                    "maxValue": 0.0,
+                    "rangeFrom": 0.0,
+                    "rangeTo": 1000000.0,
+                    "currency": "USD",
+                }
+            ],
+        }
+    )
+    assert rule.range_mode == "SYMBOL_COMMISSION_RANGE_VOLUME"
+    assert rule.tiers[0].value == 3.5
+    assert rule.tiers[0].range_to == 1000000.0
+
+    # `from` is a Python keyword — the wire field maps to `from_`.
+    session = TradingSession.model_validate(
+        {"day": "FRIDAY", "from": "00:01", "to": "23:57"}
+    )
+    assert session.day == "FRIDAY"
+    assert session.from_ == "00:01"
+    assert session.to == "23:57"
 
 
 @respx.mock
@@ -567,6 +693,54 @@ def test_server_timezone_parses() -> None:
     assert isinstance(tz.server_time, str)
 
 
+@respx.mock
+def test_order_history_parses_position() -> None:
+    # Second row mimics a pod older than bridge MT5 0.14 / MT4 0.13 (no
+    # ``position`` yet) — must default to 0, not fail validation.
+    respx.get(f"{TERM}/OrderHistory").mock(
+        return_value=httpx.Response(
+            200,
+            json=[
+                {
+                    "ticket": 14541780,
+                    "order": 13173527,
+                    "position": 13173524,
+                    "symbol": "EURUSD",
+                    "type": "Sell",
+                    "entry": "Out",
+                    "volume": 0.01,
+                    "price": 1.16635,
+                    "profit": -0.02,
+                    "commission": -0.04,
+                    "swap": 0.0,
+                    "magic": 0,
+                    "comment": "",
+                    "time": "2026-08-19T18:53:47.000Z",
+                },
+                {
+                    "ticket": 14541777,
+                    "order": 13173524,
+                    "symbol": "EURUSD",
+                    "type": "Buy",
+                    "entry": "In",
+                    "volume": 0.01,
+                    "price": 1.16637,
+                    "profit": 0.0,
+                    "commission": -0.04,
+                    "swap": 0.0,
+                    "magic": 1000999,
+                    "comment": "CN_9999_8888",
+                    "time": "2026-08-19T18:53:41.000Z",
+                },
+            ],
+        )
+    )
+    with _term() as t:
+        rows = t.order_history()
+    assert rows[0].position == 13173524
+    assert rows[1].position == 0
+
+
 @respx.mock
 def test_position_history_sends_dates_and_parses() -> None:
     route = respx.get(f"{TERM}/PositionHistory").mock(
@@ -721,3 +895,31 @@ async def test_async_order_send_body_and_validation() -> None:
         "volume": 0.2,
         "expertId": 7,
     }
+
+
+@respx.mock
+async def test_async_close_all() -> None:
+    route = respx.post(f"{TERM}/CloseAll").mock(
+        return_value=httpx.Response(
+            200,
+            json={
+                "requested": 1,
+                "closed": 1,
+                "failed": 0,
+                "results": [
+                    {
+                        "ticket": 100,
+                        "kind": "position",
+                        "success": True,
+                        "retcode": 10009,
+                        "retcodeDescription": "Done",
+                    }
+                ],
+            },
+        )
+    )
+    async with AsyncClient(api_key="fxs_live_k") as fx:
+        term = fx.terminal(_account())
+        summary = await term.close_all(symbol="EURUSD")
+    assert json.loads(route.calls.last.request.content) == {"symbol": "EURUSD"}
+    assert summary.closed == 1 and summary.results[0].success

fxsocket-0.3.0/src/fxsocket/_version.py

@@ -1 +0,0 @@
-__version__ = "0.3.0"