fractal-server 2.19.0__tar.gz → 2.19.0a0__tar.gz

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fractal-server
-Version: 2.19.0
+Version: 2.19.0a0
 Summary: Backend component of the Fractal analytics platform
 Author: Tommaso Comparin, Marco Franzon, Yuri Chiucconi, Jacopo Nespolo
 Author-email: Tommaso Comparin <tommaso.comparin@exact-lab.it>, Marco Franzon <marco.franzon@exact-lab.it>, Yuri Chiucconi <yuri.chiucconi@exact-lab.it>, Jacopo Nespolo <jacopo.nespolo@exact-lab.it>
@@ -17,7 +17,7 @@ Requires-Dist: pydantic>=2.12.0,<2.13.0
 Requires-Dist: pydantic-settings==2.12.0
 Requires-Dist: packaging>=25.0.0,<26.0.0
 Requires-Dist: fabric>=3.2.2,<3.3.0
-Requires-Dist: gunicorn>=24.1,<25
+Requires-Dist: gunicorn>=23.0,<24.0
 Requires-Dist: psycopg[binary]>=3.1.0,<4.0.0
 Requires-Dist: tomli-w>=1.2.0,<1.3.0
 Requires-Python: >=3.12, <3.15

fractal_server-2.19.0a0/fractal_server/__init__.py

@@ -0,0 +1 @@
+__VERSION__ = "2.19.0a0"

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/dataset.py

@@ -27,6 +27,10 @@ class DatasetV2(SQLModel, table=True):
         sa_relationship_kwargs=dict(lazy="selectin"),
     )
 
+    history: list[dict[str, Any]] = Field(
+        sa_column=Column(JSONB, server_default="[]", nullable=False)
+    )
+
     timestamp_created: datetime = Field(
         default_factory=get_timestamp,
         sa_column=Column(DateTime(timezone=True), nullable=False),

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/job.py

@@ -5,7 +5,6 @@ from pydantic import ConfigDict
 from sqlalchemy import Column
 from sqlalchemy.dialects.postgresql import JSONB
 from sqlalchemy.types import DateTime
-from sqlalchemy.types import String
 from sqlmodel import Field
 from sqlmodel import Index
 from sqlmodel import SQLModel
@@ -45,9 +44,6 @@ class JobV2(SQLModel, table=True):
     project_dump: dict[str, Any] = Field(
         sa_column=Column(JSONB, nullable=False)
     )
-    fractal_server_version: str = Field(
-        sa_column=Column(String, server_default="pre-2.19.0", nullable=False)
-    )
 
     worker_init: str | None = None
     working_dir: str | None = None

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/task.py

@@ -14,6 +14,7 @@ class TaskV2(SQLModel, table=True):
     type: str
     command_non_parallel: str | None = None
     command_parallel: str | None = None
+    source: str | None = None
 
     meta_non_parallel: dict[str, Any] = Field(
         sa_column=Column(JSON, server_default="{}", default={}, nullable=False)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/task_group.py

@@ -4,7 +4,6 @@ from datetime import timezone
 from sqlalchemy import Column
 from sqlalchemy.dialects.postgresql import JSONB
 from sqlalchemy.types import DateTime
-from sqlalchemy.types import String
 from sqlmodel import Field
 from sqlmodel import Relationship
 from sqlmodel import SQLModel
@@ -152,6 +151,3 @@ class TaskGroupActivityV2(SQLModel, table=True):
         default=None,
         sa_column=Column(DateTime(timezone=True)),
     )
-    fractal_server_version: str = Field(
-        sa_column=Column(String, server_default="pre-2.19.0", nullable=False)
-    )

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/workflow.py

@@ -32,5 +32,3 @@ class WorkflowV2(SQLModel, table=True):
         default_factory=get_timestamp,
         sa_column=Column(DateTime(timezone=True), nullable=False),
     )
-
-    description: str | None = Field(default=None, nullable=True)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/models/v2/workflowtask.py

@@ -39,6 +39,3 @@ class WorkflowTaskV2(SQLModel, table=True):
     task_type: str
     task_id: int = Field(foreign_key="taskv2.id")
     task: TaskV2 = Relationship(sa_relationship_kwargs=dict(lazy="selectin"))
-
-    alias: str | None = Field(default=None, nullable=True)
-    description: str | None = Field(default=None, nullable=True)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/admin/v2/task.py

@@ -30,6 +30,7 @@ class TaskMinimal(BaseModel):
     taskgroupv2_id: int
     command_non_parallel: str | None = None
     command_parallel: str | None = None
+    source: str | None = None
     version: str | None = None
 
 
@@ -54,6 +55,7 @@ class TaskInfo(BaseModel):
 @router.get("/", response_model=PaginationResponse[TaskInfo])
 async def query_tasks(
     id: int | None = None,
+    source: str | None = None,
     version: str | None = None,
     name: str | None = None,
     task_type: TaskType | None = None,
@@ -79,6 +81,9 @@ async def query_tasks(
     if id is not None:
         stm = stm.where(TaskV2.id == id)
         stm_count = stm_count.where(TaskV2.id == id)
+    if source is not None:
+        stm = stm.where(TaskV2.source.icontains(source))
+        stm_count = stm_count.where(TaskV2.source.icontains(source))
     if version is not None:
         stm = stm.where(TaskV2.version == version)
         stm_count = stm_count.where(TaskV2.version == version)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/admin/v2/task_group_lifecycle.py

@@ -5,7 +5,6 @@ from fastapi import HTTPException
 from fastapi import Response
 from fastapi import status
 
-from fractal_server import __VERSION__
 from fractal_server.app.db import AsyncSession
 from fractal_server.app.db import get_async_db
 from fractal_server.app.models import UserOAuth
@@ -94,7 +93,6 @@ async def deactivate_task_group(
             ),
             timestamp_started=get_timestamp(),
             timestamp_ended=get_timestamp(),
-            fractal_server_version=__VERSION__,
         )
         db.add(task_group)
         db.add(task_group_activity)
@@ -110,7 +108,6 @@ async def deactivate_task_group(
         pkg_name=task_group.pkg_name,
         version=task_group.version,
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()
@@ -191,7 +188,6 @@ async def reactivate_task_group(
             ),
             timestamp_started=get_timestamp(),
             timestamp_ended=get_timestamp(),
-            fractal_server_version=__VERSION__,
         )
         db.add(task_group)
         db.add(task_group_activity)
@@ -215,7 +211,6 @@ async def reactivate_task_group(
         pkg_name=task_group.pkg_name,
         version=task_group.version,
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()
@@ -269,7 +264,6 @@ async def delete_task_group(
         pkg_name=task_group.pkg_name,
         version=(task_group.version or "N/A"),
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/__init__.py

@@ -14,6 +14,7 @@ from .job import router as job_router
 from .pre_submission_checks import router as pre_submission_checks_router
 from .project import router as project_router
 from .sharing import router as sharing_router
+from .status_legacy import router as status_legacy_router
 from .submit import router as submit_job_router
 from .task import router as task_router
 from .task_collection import router as task_collection_router
@@ -36,6 +37,7 @@ router_api.include_router(sharing_router, tags=["Project Sharing"])
 router_api.include_router(project_router, tags=["Project"])
 router_api.include_router(submit_job_router, tags=["Job"])
 router_api.include_router(history_router, tags=["History"])
+router_api.include_router(status_legacy_router, tags=["Status Legacy"])
 
 
 settings = Inject(get_settings)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/_aux_functions_task_lifecycle.py

@@ -2,6 +2,8 @@ from fastapi import HTTPException
 from fastapi import status
 from httpx import AsyncClient
 from httpx import TimeoutException
+from packaging.version import InvalidVersion
+from packaging.version import Version
 from sqlmodel import func
 from sqlmodel import select
 
@@ -12,7 +14,6 @@ from fractal_server.app.models.v2 import TaskGroupV2
 from fractal_server.app.models.v2 import TaskV2
 from fractal_server.app.models.v2 import WorkflowTaskV2
 from fractal_server.app.models.v2 import WorkflowV2
-from fractal_server.app.routes.aux._versions import _find_latest_version_or_422
 from fractal_server.app.schemas.v2 import JobStatusType
 from fractal_server.app.schemas.v2 import TaskGroupActivityStatus
 from fractal_server.logger import set_logger
@@ -25,6 +26,24 @@ PYPI_JSON_HEADERS = {"Accept": "application/vnd.pypi.simple.v1+json"}
 logger = set_logger(__name__)
 
 
+def _find_latest_version_or_422(versions: list[str]) -> str:
+    """
+    > For PEP 440 versions, this is easy enough for the client to do (using
+    > the `packaging` library [...]. For non-standard versions, there is no
+    > well-defined ordering, and clients will need to decide on what rule is
+    > appropriate for their needs.
+    (https://peps.python.org/pep-0700/#why-not-provide-a-latest-version-value)
+    """
+    try:
+        latest = max(versions, key=lambda v_str: Version(v_str))
+        return latest
+    except InvalidVersion as e:
+        raise HTTPException(
+            status_code=status.HTTP_422_UNPROCESSABLE_CONTENT,
+            detail=f"Cannot find latest version (original error: {str(e)}).",
+        )
+
+
 async def get_package_version_from_pypi(
     name: str,
     version: str | None = None,

fractal_server-2.19.0a0/fractal_server/app/routes/api/v2/status_legacy.py

@@ -0,0 +1,156 @@
+from fastapi import APIRouter
+from fastapi import Depends
+
+from fractal_server.app.db import AsyncSession
+from fractal_server.app.db import get_async_db
+from fractal_server.app.models import UserOAuth
+from fractal_server.app.models.v2 import JobV2
+from fractal_server.app.routes.auth import get_api_guest
+from fractal_server.app.schemas.v2.sharing import ProjectPermissions
+from fractal_server.app.schemas.v2.status_legacy import LegacyStatusRead
+from fractal_server.app.schemas.v2.status_legacy import WorkflowTaskStatusType
+from fractal_server.logger import set_logger
+
+from ._aux_functions import _get_dataset_check_access
+from ._aux_functions import _get_submitted_jobs_statement
+from ._aux_functions import _get_workflow_check_access
+
+router = APIRouter()
+
+logger = set_logger(__name__)
+
+
+@router.get(
+    "/project/{project_id}/status-legacy/",
+    response_model=LegacyStatusRead,
+)
+async def get_workflowtask_status(
+    project_id: int,
+    dataset_id: int,
+    workflow_id: int,
+    user: UserOAuth = Depends(get_api_guest),
+    db: AsyncSession = Depends(get_async_db),
+) -> LegacyStatusRead | None:
+    """
+    Extract the status of all `WorkflowTaskV2` of a given `WorkflowV2` that ran
+    on a given `DatasetV2`.
+
+    *NOTE*: the current endpoint is not guaranteed to provide consistent
+    results if the workflow task list is modified in a non-trivial way
+    (that is, by adding intermediate tasks, removing tasks, or changing their
+    order). See fractal-server GitHub issues: 793, 1083.
+    """
+    # Get the dataset DB entry
+    output = await _get_dataset_check_access(
+        project_id=project_id,
+        dataset_id=dataset_id,
+        user_id=user.id,
+        required_permissions=ProjectPermissions.READ,
+        db=db,
+    )
+    dataset = output["dataset"]
+
+    # Get the workflow DB entry
+    workflow = await _get_workflow_check_access(
+        project_id=project_id,
+        workflow_id=workflow_id,
+        user_id=user.id,
+        required_permissions=ProjectPermissions.READ,
+        db=db,
+    )
+
+    # Check whether there exists a submitted job associated to this
+    # workflow/dataset pair. If it does exist, it will be used later.
+    # If there are multiple jobs, raise an error.
+    res = await db.execute(
+        _get_submitted_jobs_statement()
+        .where(JobV2.dataset_id == dataset_id)
+        .where(JobV2.workflow_id == workflow_id)
+    )
+    running_job = res.scalars().one_or_none()
+
+    # Initialize empty dictionary for WorkflowTaskV2 status
+    workflow_tasks_status_dict: dict = {}
+
+    # Lowest priority: read status from DB, which corresponds to jobs that are
+    # not running
+    history = dataset.history
+    for history_item in history:
+        wftask_id = history_item["workflowtask"]["id"]
+        wftask_status = history_item["status"]
+        workflow_tasks_status_dict[wftask_id] = wftask_status
+
+    if running_job is None:
+        # If no job is running, the chronological-last history item is also the
+        # positional-last workflow task to be included in the response.
+        if len(history) > 0:
+            last_valid_wftask_id = history[-1]["workflowtask"]["id"]
+        else:
+            last_valid_wftask_id = None
+    else:
+        # If a job is running, then gather more up-to-date information
+
+        # Mid priority: Set all WorkflowTask's that are part of the running job
+        # as "submitted"
+        start = running_job.first_task_index
+        end = running_job.last_task_index + 1
+
+        running_job_wftasks = workflow.task_list[start:end]
+        running_job_statuses = [
+            workflow_tasks_status_dict.get(wft.id, None)
+            for wft in running_job_wftasks
+        ]
+        try:
+            first_submitted_index = running_job_statuses.index(
+                WorkflowTaskStatusType.SUBMITTED
+            )
+        except ValueError:
+            logger.warning(
+                f"Job {running_job.id} is submitted but its task list does not"
+                f" contain a {WorkflowTaskStatusType.SUBMITTED} task."
+            )
+            first_submitted_index = 0
+
+        for wftask in running_job_wftasks[first_submitted_index:]:
+            workflow_tasks_status_dict[wftask.id] = (
+                WorkflowTaskStatusType.SUBMITTED
+            )
+
+        # The last workflow task that is included in the submitted job is also
+        # the positional-last workflow task to be included in the response.
+        try:
+            last_valid_wftask_id = workflow.task_list[end - 1].id
+        except IndexError as e:
+            logger.warning(
+                f"Handled IndexError in `get_workflowtask_status` ({str(e)})."
+            )
+            logger.warning(
+                "Additional information: "
+                f"{running_job.first_task_index=}; "
+                f"{running_job.last_task_index=}; "
+                f"{len(workflow.task_list)=}; "
+                f"{dataset_id=}; "
+                f"{workflow_id=}."
+            )
+            last_valid_wftask_id = None
+            logger.warning(f"Now setting {last_valid_wftask_id=}.")
+
+    # Based on previously-gathered information, clean up the response body
+    clean_workflow_tasks_status_dict = {}
+    for wf_task in workflow.task_list:
+        wf_task_status = workflow_tasks_status_dict.get(wf_task.id)
+        if wf_task_status is None:
+            # If a wftask ID was not found, ignore it and continue
+            continue
+        clean_workflow_tasks_status_dict[str(wf_task.id)] = wf_task_status
+        if wf_task_status == WorkflowTaskStatusType.FAILED:
+            # Starting from the beginning of `workflow.task_list`, stop the
+            # first time that you hit a failed job
+            break
+        if wf_task.id == last_valid_wftask_id:
+            # Starting from the beginning of `workflow.task_list`, stop the
+            # first time that you hit `last_valid_wftask_id``
+            break
+
+    response_body = LegacyStatusRead(status=clean_workflow_tasks_status_dict)
+    return response_body

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/submit.py

@@ -11,7 +11,6 @@ from fastapi import status
 from sqlmodel import select
 from sqlmodel import update
 
-from fractal_server import __VERSION__
 from fractal_server.app.db import AsyncSession
 from fractal_server.app.db import get_async_db
 from fractal_server.app.models import Profile
@@ -217,12 +216,11 @@ async def submit_job(
             dataset.model_dump_json(exclude={"images", "history"})
         ),
         workflow_dump=json.loads(
-            workflow.model_dump_json(exclude={"task_list", "description"})
+            workflow.model_dump_json(exclude={"task_list"})
         ),
         project_dump=json.loads(
             project.model_dump_json(exclude={"resource_id"})
         ),
-        fractal_server_version=__VERSION__,
         **job_create.model_dump(),
     )
 

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/task_collection.py

@@ -14,7 +14,6 @@ from pydantic import BaseModel
 from pydantic import ValidationError
 from pydantic import model_validator
 
-from fractal_server import __VERSION__
 from fractal_server.app.db import AsyncSession
 from fractal_server.app.db import get_async_db
 from fractal_server.app.models import UserOAuth
@@ -333,7 +332,6 @@ async def collect_tasks_pip(
         action=TaskGroupActivityAction.COLLECT,
         pkg_name=task_group.pkg_name,
         version=task_group.version,
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/task_collection_pixi.py

@@ -10,7 +10,6 @@ from fastapi import Response
 from fastapi import UploadFile
 from fastapi import status
 
-from fractal_server import __VERSION__
 from fractal_server.app.db import AsyncSession
 from fractal_server.app.db import get_async_db
 from fractal_server.app.models import UserOAuth
@@ -183,7 +182,6 @@ async def collect_task_pixi(
         action=TaskGroupActivityAction.COLLECT,
         pkg_name=task_group.pkg_name,
         version=task_group.version,
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/task_group.py

@@ -4,6 +4,9 @@ from fastapi import APIRouter
 from fastapi import Depends
 from fastapi import HTTPException
 from fastapi import status
+from packaging.version import InvalidVersion
+from packaging.version import Version
+from packaging.version import parse
 from pydantic.types import AwareDatetime
 from sqlmodel import or_
 from sqlmodel import select
@@ -22,7 +25,6 @@ from fractal_server.app.routes.auth._aux_auth import (
 from fractal_server.app.routes.auth._aux_auth import (
     _verify_user_belongs_to_group,
 )
-from fractal_server.app.routes.aux._versions import _version_sort_key
 from fractal_server.app.schemas.v2 import TaskGroupActivityAction
 from fractal_server.app.schemas.v2 import TaskGroupActivityRead
 from fractal_server.app.schemas.v2 import TaskGroupActivityStatus
@@ -41,6 +43,26 @@ router = APIRouter()
 logger = set_logger(__name__)
 
 
+def _version_sort_key(
+    task_group: TaskGroupV2,
+) -> tuple[int, Version | str | None]:
+    """
+    Returns a tuple used as (reverse) ordering key for TaskGroups in
+    `get_task_group_list`.
+    The TaskGroups with a parsable versions are the first in order,
+    sorted according to the sorting rules of packaging.version.Version.
+    Next in order we have the TaskGroups with non-null non-parsable versions,
+    sorted alphabetically.
+    Last we have the TaskGroups with null version.
+    """
+    if task_group.version is None:
+        return (0, task_group.version)
+    try:
+        return (2, parse(task_group.version))
+    except InvalidVersion:
+        return (1, task_group.version)
+
+
 @router.get("/activity/", response_model=list[TaskGroupActivityRead])
 async def get_task_group_activity_list(
     task_group_activity_id: int | None = None,
@@ -154,7 +176,7 @@ async def get_task_group_list(
                 await remove_duplicate_task_groups(
                     task_groups=sorted(
                         list(groups),
-                        key=lambda group: _version_sort_key(group.version),
+                        key=_version_sort_key,
                         reverse=True,
                     ),
                     user_id=user.id,

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/task_group_lifecycle.py

@@ -5,7 +5,6 @@ from fastapi import HTTPException
 from fastapi import Response
 from fastapi import status
 
-from fractal_server import __VERSION__
 from fractal_server.app.db import AsyncSession
 from fractal_server.app.db import get_async_db
 from fractal_server.app.models import UserOAuth
@@ -100,7 +99,6 @@ async def deactivate_task_group(
             ),
             timestamp_started=get_timestamp(),
             timestamp_ended=get_timestamp(),
-            fractal_server_version=__VERSION__,
         )
         db.add(task_group)
         db.add(task_group_activity)
@@ -116,7 +114,6 @@ async def deactivate_task_group(
         pkg_name=task_group.pkg_name,
         version=task_group.version,
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     task_group.active = False
     db.add(task_group)
@@ -205,7 +202,6 @@ async def reactivate_task_group(
             ),
             timestamp_started=get_timestamp(),
             timestamp_ended=get_timestamp(),
-            fractal_server_version=__VERSION__,
         )
         db.add(task_group)
         db.add(task_group_activity)
@@ -229,7 +225,6 @@ async def reactivate_task_group(
         pkg_name=task_group.pkg_name,
         version=task_group.version,
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()
@@ -293,7 +288,6 @@ async def delete_task_group(
         pkg_name=task_group.pkg_name,
         version=(task_group.version or "N/A"),
         timestamp_started=get_timestamp(),
-        fractal_server_version=__VERSION__,
     )
     db.add(task_group_activity)
     await db.commit()

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/workflow.py

@@ -149,7 +149,7 @@ async def update_workflow(
         db=db,
     )
 
-    if patch.name and patch.name != workflow.name:
+    if patch.name:
         await _check_workflow_exists(
             name=patch.name, project_id=project_id, db=db
         )

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/workflow_import.py

@@ -19,8 +19,8 @@ from fractal_server.app.routes.auth import get_api_user
 from fractal_server.app.routes.auth._aux_auth import (
     _get_default_usergroup_id_or_none,
 )
-from fractal_server.app.routes.aux._versions import _version_sort_key
 from fractal_server.app.schemas.v2 import TaskImport
+from fractal_server.app.schemas.v2 import TaskImportLegacy
 from fractal_server.app.schemas.v2 import WorkflowImport
 from fractal_server.app.schemas.v2 import WorkflowReadWithWarnings
 from fractal_server.app.schemas.v2 import WorkflowTaskCreate
@@ -73,6 +73,32 @@ async def _get_user_accessible_taskgroups(
     return accessible_task_groups
 
 
+async def _get_task_by_source(
+    source: str,
+    task_groups_list: list[TaskGroupV2],
+) -> int | None:
+    """
+    Find task with a given source.
+
+    Args:
+        source: `source` of the task to be imported.
+        task_groups_list: Current list of valid task groups.
+
+    Return:
+        `id` of the matching task, or `None`.
+    """
+    task_id = next(
+        iter(
+            task.id
+            for task_group in task_groups_list
+            for task in task_group.task_list
+            if task.source == source
+        ),
+        None,
+    )
+    return task_id
+
+
 async def _get_task_by_taskimport(
     *,
     task_import: TaskImport,
@@ -115,15 +141,14 @@ async def _get_task_by_taskimport(
         return None
 
     # Determine target `version`
+    # Note that task_import.version cannot be "", due to a validator
     if task_import.version is None:
         logger.debug(
             "[_get_task_by_taskimport] "
             "No version requested, looking for latest."
         )
-        version = max(
-            [tg.version for tg in matching_task_groups],
-            key=_version_sort_key,
-        )
+        latest_task = max(matching_task_groups, key=lambda tg: tg.version or "")
+        version = latest_task.version
         logger.debug(
             f"[_get_task_by_taskimport] Latest version set to {version}."
         )
@@ -221,13 +246,19 @@ async def import_workflow(
     list_task_ids = []
     for wf_task in workflow_import.task_list:
         task_import = wf_task.task
-        task_id = await _get_task_by_taskimport(
-            task_import=task_import,
-            user_id=user.id,
-            default_group_id=default_group_id,
-            task_groups_list=task_group_list,
-            db=db,
-        )
+        if isinstance(task_import, TaskImportLegacy):
+            task_id = await _get_task_by_source(
+                source=task_import.source,
+                task_groups_list=task_group_list,
+            )
+        else:
+            task_id = await _get_task_by_taskimport(
+                task_import=task_import,
+                user_id=user.id,
+                default_group_id=default_group_id,
+                task_groups_list=task_group_list,
+                db=db,
+            )
         if task_id is None:
             raise HTTPException(
                 status_code=status.HTTP_422_UNPROCESSABLE_CONTENT,

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/api/v2/workflowtask.py

@@ -193,8 +193,13 @@ async def update_workflowtask(
             if not actual_args:
                 actual_args = None
             setattr(db_wf_task, key, actual_args)
-        else:
+        elif key in ["meta_parallel", "meta_non_parallel", "type_filters"]:
             setattr(db_wf_task, key, value)
+        else:
+            raise HTTPException(
+                status_code=status.HTTP_422_UNPROCESSABLE_CONTENT,
+                detail=f"patch_workflow_task endpoint cannot set {key=}",
+            )
 
     await db.commit()
     await db.refresh(db_wf_task)

{fractal_server-2.19.0 → fractal_server-2.19.0a0}/fractal_server/app/routes/auth/current_user.py

@@ -4,8 +4,6 @@ Definition of `/auth/current-user/` endpoints
 
 from fastapi import APIRouter
 from fastapi import Depends
-from fastapi import HTTPException
-from fastapi import status
 from sqlalchemy.ext.asyncio import AsyncSession
 from sqlmodel import select
 
@@ -54,12 +52,6 @@ async def patch_current_user(
     Note: a user cannot patch their own password (as enforced within the
     `UserUpdateStrict` schema).
     """
-    if current_user.is_guest:
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail="This feature is not available for guest users.",
-        )
-
     update = UserUpdate(**user_update.model_dump(exclude_unset=True))
 
     # NOTE: here it would be relevant to catch an `InvalidPasswordException`