foxmath 0.7.0__tar.gz → 0.7.1__tar.gz

{foxmath-0.7.0/src/foxmath.egg-info → foxmath-0.7.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: foxmath
-Version: 0.7.0
+Version: 0.7.1
 Summary: Minimalist CLI for math & cryptography exploration 🦊
 Author-email: Abhrankan Chakrabarti <abhrankan@gmail.com>
 License: MIT
@@ -61,7 +61,7 @@ Check which version you have installed:
 foxmath --version
 ```
 ```
-foxmath 0.7.0
+foxmath 0.7.1
 ```
 
 ## Usage Examples

{foxmath-0.7.0 → foxmath-0.7.1}/README.md

@@ -42,7 +42,7 @@ Check which version you have installed:
 foxmath --version
 ```
 ```
-foxmath 0.7.0
+foxmath 0.7.1
 ```
 
 ## Usage Examples

{foxmath-0.7.0 → foxmath-0.7.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "foxmath"
-version = "0.7.0"
+version = "0.7.1"
 description = "Minimalist CLI for math & cryptography exploration 🦊"
 readme = "README.md"
 license = {text = "MIT"}

{foxmath-0.7.0 → foxmath-0.7.1}/src/foxmath/foxmath.py

@@ -22,20 +22,66 @@ def _package_version() -> str:
 
 # ------------------- Math Functions -------------------
 
-def legendre_symbol(a: int, p: int) -> int:
-    """Compute Legendre symbol (a/p)"""
-    if p < 2 or p % 2 == 0:
+# First 13 primes. As Miller-Rabin bases they make the test *deterministic*
+# for every n below 3,317,044,064,679,887,385,961,981 (~3.3e24); 12 bases
+# would not be enough (399165290221 * 798330580441, ~3.2e23, fools them).
+_PRIME_TEST_BASES = (2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41)
+
+def _is_probable_prime(n: int) -> bool:
+    """Miller-Rabin primality test.
+
+    Exact for n < ~3.3e24. Above that it is a strong probable-prime test:
+    ordinary composites essentially never pass, but a composite built
+    specifically to fool these 13 bases could.
+    """
+    if n < 2:
+        return False
+    for sp in _PRIME_TEST_BASES:
+        if n == sp:
+            return True
+        if n % sp == 0:
+            return False
+    d, r = n - 1, 0
+    while d % 2 == 0:
+        d //= 2
+        r += 1
+    for a in _PRIME_TEST_BASES:
+        x = pow(a, d, n)
+        if x == 1 or x == n - 1:
+            continue
+        for _ in range(r - 1):
+            x = x * x % n
+            if x == n - 1:
+                break
+        else:
+            return False
+    return True
+
+def _require_odd_prime(p: int) -> None:
+    """Enforce the contract the Legendre symbol and Tonelli-Shanks rely on.
+
+    Euler's criterion is only meaningful for a prime modulus. On a composite
+    it returns garbage, and Tonelli-Shanks' search for a non-residue can loop
+    forever (mod 9 or mod 561, for example, there is none to find).
+    """
+    if p < 2 or p % 2 == 0 or not _is_probable_prime(p):
         raise ValueError("p must be an odd prime")
+
+def _legendre_unchecked(a: int, p: int) -> int:
     res = pow(a, (p - 1) // 2, p)
     return 1 if res == 1 else (-1 if res == p - 1 else 0)
 
+def legendre_symbol(a: int, p: int) -> int:
+    """Compute Legendre symbol (a/p). p must be an odd prime."""
+    _require_odd_prime(p)
+    return _legendre_unchecked(a, p)
+
 def sqrt_mod(a: int, p: int) -> tuple:
     """Return the square root(s) of a modulo an odd prime p."""
-    if p < 2 or p % 2 == 0:
-        raise ValueError("p must be an odd prime")
+    _require_odd_prime(p)
 
     a %= p
-    symbol = legendre_symbol(a, p)
+    symbol = _legendre_unchecked(a, p)
     if symbol == 0:
         return (0,)
     if symbol == -1:
@@ -52,7 +98,7 @@ def sqrt_mod(a: int, p: int) -> tuple:
             s += 1
 
         non_residue = 2
-        while legendre_symbol(non_residue, p) != -1:
+        while _legendre_unchecked(non_residue, p) != -1:
             non_residue += 1
 
         c = pow(non_residue, q, p)

{foxmath-0.7.0 → foxmath-0.7.1/src/foxmath.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: foxmath
-Version: 0.7.0
+Version: 0.7.1
 Summary: Minimalist CLI for math & cryptography exploration 🦊
 Author-email: Abhrankan Chakrabarti <abhrankan@gmail.com>
 License: MIT
@@ -61,7 +61,7 @@ Check which version you have installed:
 foxmath --version
 ```
 ```
-foxmath 0.7.0
+foxmath 0.7.1
 ```
 
 ## Usage Examples

{foxmath-0.7.0 → foxmath-0.7.1}/tests/test_cli.py

@@ -301,6 +301,16 @@ class TestNormalUsage(unittest.TestCase):
         self.assertEqual(code, 0)
         self.assertIn("sqrt(0) = 0 (mod 17)", out)
 
+    def test_legendre_composite_p_errors(self):
+        code, out, err = run("legendre", "2", "9")
+        self.assertEqual(code, 1)
+        self.assertIn("p must be an odd prime", err)
+
+    def test_sqrtmod_composite_p_errors(self):
+        code, out, err = run("sqrtmod", "2", "9")
+        self.assertEqual(code, 1)
+        self.assertIn("p must be an odd prime", err)
+
 
 if __name__ == "__main__":
     unittest.main()

{foxmath-0.7.0 → foxmath-0.7.1}/tests/test_foxmath.py

@@ -15,7 +15,7 @@ sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..",
 from foxmath.foxmath import (
     legendre_symbol, sqrt_mod, euler_hermann_pi_approx, ec_point_add, ec_mul, crt_solve,
     continued_fraction, cf_convergents, CURVES, is_on_curve,
-    generate_problem,
+    generate_problem, _is_probable_prime,
 )
 import random
 
@@ -51,6 +51,12 @@ class TestLegendreSymbol(unittest.TestCase):
         with self.assertRaises(ValueError):
             legendre_symbol(3, 1)
 
+    def test_rejects_composite_odd_p(self):
+        for comp in (9, 15, 21, 25, 27, 33, 35, 561):
+            with self.subTest(p=comp):
+                with self.assertRaises(ValueError):
+                    legendre_symbol(2, comp)
+
 
 class TestSqrtMod(unittest.TestCase):
     def test_tonelli_shanks_returns_both_roots(self):
@@ -93,6 +99,32 @@ class TestSqrtMod(unittest.TestCase):
         self.assertEqual(roots_97, (14, 83))
         self.assertTrue(all((r * r - 2) % 97 == 0 for r in roots_97))
 
+    def test_rejects_composite_odd_p(self):
+        for comp in (9, 15, 25, 561):
+            with self.subTest(p=comp):
+                with self.assertRaises(ValueError):
+                    sqrt_mod(4, comp)
+
+
+class TestPrimality(unittest.TestCase):
+    def test_small_primes(self):
+        for p in (2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 97, 193):
+            with self.subTest(p=p):
+                self.assertTrue(_is_probable_prime(p))
+
+    def test_small_composites(self):
+        for c in (0, 1, 4, 6, 8, 9, 10, 12, 14, 15, 16, 18, 20, 21, 25, 27):
+            with self.subTest(c=c):
+                self.assertFalse(_is_probable_prime(c))
+
+    def test_carmichael_numbers_rejected(self):
+        for cn in (561, 1105, 1729):
+            with self.subTest(cn=cn):
+                self.assertFalse(_is_probable_prime(cn))
+
+    def test_mersenne_prime(self):
+        self.assertTrue(_is_probable_prime(2147483647))
+
 
 class TestEulerHermannPiApprox(unittest.TestCase):
     def test_converges_to_pi(self):