forward-netbox 2.0.2__tar.gz → 2.0.4__tar.gz

{forward_netbox-2.0.2 → forward_netbox-2.0.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: forward-netbox
-Version: 2.0.2
+Version: 2.0.4
 Summary: NetBox plugin to sync Forward data into NetBox via built-in NQE queries
 License: MIT
 License-File: LICENSE
@@ -31,7 +31,9 @@ Forward 26.6 is the baseline for async NQE.
 
 | Plugin Release | NetBox Version | Status |
 | --- | --- | --- |
-| `v2.0.2` | `4.6.3` required; needs netbox-branching `1.1.0+` | Current release; Patch: apply_device_scope_tags now works with multiple include tags in `any` match mode — each device is tagged with exactly the include tag(s) it carries (resolved per-device at fetch time), instead of skipping. Also silences the spurious `Skipping untagged VLAN 1` warning (VID 1 is NetBox's implicit access default and is intentionally not imported). No engine/schema changes; drop-in from `2.0.1`, no org republish |
+| `v2.0.4` | `4.6.3` required; needs netbox-branching `1.1.0+` | Current release; Patch: collapse the module-sync readiness warning wall into ONE summary. When module sync is enabled before a device's module bays exist in NetBox, every module row is skipped; 2.0.3 capped the per-row lines at 3, this replaces them entirely with a single actionable line per sync (total skipped + a few examples + the `forward_module_readiness` remedy). Other skip reasons are unchanged. No engine/schema/org changes; drop-in from `2.0.3` |
+| `v2.0.3` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.4`; Patch: (1) module-sync readiness warnings no longer flood the log — the per-row `module bay does not exist; run forward_module_readiness` skip is capped to a few examples plus a suppressed-count summary (was up to 20 near-identical lines per sync); (2) fixes the release `CI` gate (`CHANGELOG matches README`) that had been red since v1.7.2 — the generator no longer depends on git tag-date timing; (3) removes dead executor code (`ForwardFastBootstrapExecutor.run`) and refreshes stale internal docs. No engine/schema changes; drop-in from `2.0.2` |
+| `v2.0.2` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.3`; Patch: apply_device_scope_tags now works with multiple include tags in `any` match mode — each device is tagged with exactly the include tag(s) it carries (resolved per-device at fetch time), instead of skipping. Also silences the spurious `Skipping untagged VLAN 1` warning (VID 1 is NetBox's implicit access default and is intentionally not imported). No engine/schema changes; drop-in from `2.0.1`, no org republish |
 | `v2.0.1` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.2`; Patch: fixes two 2.0.0 regressions an operator hits immediately — a false `netbox_branching is not installed; syncs will fail` startup warning (the dependency check used the wrong distribution name), and a 500 on the Sync list page (`KeyError: 'available'` from a removed execution-ledger summary). No engine or data changes; drop-in upgrade from `2.0.0` |
 | `v2.0.0` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.1`; Breaking 2.0 — single-branch is the only execution path. Removed the per-shard branching/fast-bootstrap/resumable executor, 10k-change budget sharding, and the execution-ledger run-history; dropped the backend/max-changes/scheduler-overlap selectors |
 | `v1.7.2` | `4.6.3` required (4.5.x dropped); needs netbox-branching `1.1.0+` | Superseded by `v2.0.0`; Collection-gap diagnostics: per-reason backfill breakdown + staleness, growth/trend escalation, per-device collection result, ACI delete safety valve, opt-in auto-tag |

{forward_netbox-2.0.2 → forward_netbox-2.0.4}/README.md

@@ -8,7 +8,9 @@ Forward 26.6 is the baseline for async NQE.
 
 | Plugin Release | NetBox Version | Status |
 | --- | --- | --- |
-| `v2.0.2` | `4.6.3` required; needs netbox-branching `1.1.0+` | Current release; Patch: apply_device_scope_tags now works with multiple include tags in `any` match mode — each device is tagged with exactly the include tag(s) it carries (resolved per-device at fetch time), instead of skipping. Also silences the spurious `Skipping untagged VLAN 1` warning (VID 1 is NetBox's implicit access default and is intentionally not imported). No engine/schema changes; drop-in from `2.0.1`, no org republish |
+| `v2.0.4` | `4.6.3` required; needs netbox-branching `1.1.0+` | Current release; Patch: collapse the module-sync readiness warning wall into ONE summary. When module sync is enabled before a device's module bays exist in NetBox, every module row is skipped; 2.0.3 capped the per-row lines at 3, this replaces them entirely with a single actionable line per sync (total skipped + a few examples + the `forward_module_readiness` remedy). Other skip reasons are unchanged. No engine/schema/org changes; drop-in from `2.0.3` |
+| `v2.0.3` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.4`; Patch: (1) module-sync readiness warnings no longer flood the log — the per-row `module bay does not exist; run forward_module_readiness` skip is capped to a few examples plus a suppressed-count summary (was up to 20 near-identical lines per sync); (2) fixes the release `CI` gate (`CHANGELOG matches README`) that had been red since v1.7.2 — the generator no longer depends on git tag-date timing; (3) removes dead executor code (`ForwardFastBootstrapExecutor.run`) and refreshes stale internal docs. No engine/schema changes; drop-in from `2.0.2` |
+| `v2.0.2` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.3`; Patch: apply_device_scope_tags now works with multiple include tags in `any` match mode — each device is tagged with exactly the include tag(s) it carries (resolved per-device at fetch time), instead of skipping. Also silences the spurious `Skipping untagged VLAN 1` warning (VID 1 is NetBox's implicit access default and is intentionally not imported). No engine/schema changes; drop-in from `2.0.1`, no org republish |
 | `v2.0.1` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.2`; Patch: fixes two 2.0.0 regressions an operator hits immediately — a false `netbox_branching is not installed; syncs will fail` startup warning (the dependency check used the wrong distribution name), and a 500 on the Sync list page (`KeyError: 'available'` from a removed execution-ledger summary). No engine or data changes; drop-in upgrade from `2.0.0` |
 | `v2.0.0` | `4.6.3` required; needs netbox-branching `1.1.0+` | Superseded by `v2.0.1`; Breaking 2.0 — single-branch is the only execution path. Removed the per-shard branching/fast-bootstrap/resumable executor, 10k-change budget sharding, and the execution-ledger run-history; dropped the backend/max-changes/scheduler-overlap selectors |
 | `v1.7.2` | `4.6.3` required (4.5.x dropped); needs netbox-branching `1.1.0+` | Superseded by `v2.0.0`; Collection-gap diagnostics: per-reason backfill breakdown + staleness, growth/trend escalation, per-device collection result, ACI delete safety valve, opt-in auto-tag |

{forward_netbox-2.0.2 → forward_netbox-2.0.4}/forward_netbox/__init__.py

@@ -8,7 +8,7 @@ class NetboxForwardConfig(PluginConfig):
     name = "forward_netbox"
     verbose_name = "NetBox Forward Plugin"
     description = "Sync Forward data into NetBox using built-in NQE queries."
-    version = "2.0.2"
+    version = "2.0.4"
     base_url = "forward"
     min_version = "4.6.3"
 

forward_netbox-2.0.4/forward_netbox/tests/test_module_readiness_rollup.py

@@ -0,0 +1,89 @@
+from unittest.mock import Mock
+
+from django.test import TestCase
+
+from forward_netbox.models import ForwardSource
+from forward_netbox.models import ForwardSync
+from forward_netbox.utilities.sync import ForwardSyncRunner
+
+
+class ModuleReadinessRollupTest(TestCase):
+    """A systemic module-readiness gap (module sync enabled before the device's
+    module bays exist) skips every module row. Those skips must collapse into ONE
+    actionable summary, not a per-row wall — while ordinary per-row skip reasons
+    keep their first-N-then-suppressed behavior."""
+
+    def _runner(self):
+        source = ForwardSource.objects.create(
+            name=f"mr-src-{ForwardSource.objects.count()}",
+            type="saas",
+            url="https://fwd.app",
+            status="ready",
+            parameters={
+                "username": "u",
+                "password": "p",
+                "verify": True,
+                "network_id": "n",
+            },
+        )
+        sync = ForwardSync.objects.create(
+            name=f"mr-sync-{source.pk}",
+            source=source,
+            parameters={"snapshot_id": "x"},
+        )
+        return ForwardSyncRunner(sync=sync, ingestion=None, client=None, logger_=Mock())
+
+    def _warnings(self, runner):
+        return [c.args[0] for c in runner.logger.log_warning.call_args_list if c.args]
+
+    def test_module_bay_skips_collapse_to_one_summary(self):
+        runner = self._runner()
+        for i in range(12):
+            runner._record_aggregated_skip_warning(
+                model_string="dcim.module",
+                reason="missing-module-bay",
+                warning_message="per-row text that must NOT be logged",
+                sample=f"dev{i}/module 0",
+            )
+        # Nothing logged per row during the model apply.
+        self.assertEqual(self._warnings(runner), [])
+
+        runner._emit_aggregated_skip_warning_summaries("dcim.module")
+        warns = self._warnings(runner)
+        self.assertEqual(len(warns), 1)
+        summary = warns[0]
+        self.assertIn("Skipped 12 dcim.module row(s)", summary)
+        self.assertIn("forward_module_readiness", summary)
+        self.assertIn("dev0/module 0", summary)  # an example is shown
+        self.assertIn("(+7 more)", summary)  # 12 total - 5 sampled = 7
+
+    def test_few_skips_show_all_examples_no_more_suffix(self):
+        runner = self._runner()
+        for name in ("a", "b", "c"):
+            runner._record_aggregated_skip_warning(
+                model_string="dcim.module",
+                reason="missing-module-bay",
+                warning_message="x",
+                sample=f"{name}/module 0",
+            )
+        runner._emit_aggregated_skip_warning_summaries("dcim.module")
+        summary = self._warnings(runner)[0]
+        self.assertIn("Skipped 3 dcim.module row(s)", summary)
+        self.assertNotIn("more)", summary)
+
+    def test_non_rollup_reason_keeps_per_row_then_suppressed(self):
+        # Regression guard: ordinary skip reasons are unchanged by the rollup.
+        runner = self._runner()
+        for i in range(22):
+            runner._record_aggregated_skip_warning(
+                model_string="dcim.macaddress",
+                reason="missing-interface",
+                warning_message=f"skip {i}",
+            )
+        # First CONFLICT_WARNING_DETAIL_LIMIT (20) logged per row.
+        self.assertEqual(len(self._warnings(runner)), 20)
+
+        runner._emit_aggregated_skip_warning_summaries("dcim.macaddress")
+        summary = self._warnings(runner)[-1]
+        self.assertIn("Suppressed 2 additional", summary)
+        self.assertIn("missing-interface", summary)