folio-migration-tools 1.9.1__tar.gz → 1.9.2__tar.gz

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: folio_migration_tools
-Version: 1.9.1
+Version: 1.9.2
 Summary: A tool allowing you to migrate data from legacy ILS:s (Library systems) into FOLIO LSP
 License: MIT
 Keywords: FOLIO,ILS,LSP,Library Systems,MARC21,Library data

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "folio_migration_tools"
-version = "1.9.1"
+version = "1.9.2"
 description =  "A tool allowing you to migrate data from legacy ILS:s (Library systems) into FOLIO LSP"
 authors = [
 	{name = "Theodor Tolstoy", email = "github.teddes@tolstoy.se"},

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/src/folio_migration_tools/mapping_file_transformation/holdings_mapper.py

@@ -1,10 +1,12 @@
 import ast
+import json
+import logging
 
 import i18n
 from folio_uuid.folio_uuid import FOLIONamespaces
 from folioclient import FolioClient
 
-from folio_migration_tools.custom_exceptions import TransformationRecordFailedError
+from folio_migration_tools.custom_exceptions import TransformationProcessError, TransformationRecordFailedError
 from folio_migration_tools.library_configuration import (
     FileDefinition,
     LibraryConfiguration,
@@ -59,6 +61,21 @@ class HoldingsMapper(MappingFileMapperBase):
                 "name",
                 "CallNumberTypeMapping",
             )
+        self.holdings_sources = self.get_holdings_sources()
+
+    def get_holdings_sources(self):
+        res = {}
+        holdings_sources = list(
+            self.folio_client.folio_get_all("/holdings-sources", "holdingsRecordsSources")
+        )
+        logging.info("Fetched %s holdingsRecordsSources from tenant", len(holdings_sources))
+        res = {n["name"].upper(): n["id"] for n in holdings_sources}
+        if "FOLIO" not in res:
+            raise TransformationProcessError("", "No holdings source with name FOLIO in tenant")
+        if "MARC" not in res:
+            raise TransformationProcessError("", "No holdings source with name MARC in tenant")
+        logging.info(json.dumps(res, indent=4))
+        return res
 
     def perform_additional_mappings(self, legacy_ids, folio_rec, file_def):
         self.handle_suppression(folio_rec, file_def)

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/src/folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

@@ -171,14 +171,15 @@ class MappingFileMapperBase(MapperBase):
         object_type: FOLIONamespaces,
         accept_duplicate_ids: bool = False,
     ):
+        folio_object = {}
         if self.ignore_legacy_identifier:
-            return (
+            folio_object.update(
                 {
                     "id": str(uuid.uuid4()),
                     "type": "object",
-                },
-                index_or_id,
+                }
             )
+            return folio_object, index_or_id
 
         if not (
             legacy_id := " ".join(
@@ -205,13 +206,21 @@ class MappingFileMapperBase(MapperBase):
             )
         else:
             self.unique_record_ids.add(generated_id)
-        return (
+        folio_object.update(
             {
                 "id": generated_id,
                 "type": "object",
-            },
-            legacy_id,
+            }
         )
+        if object_type == FOLIONamespaces.holdings and hasattr(self, "holdings_sources"):
+            folio_object['sourceId'] = self.holdings_sources.get("FOLIO")
+        elif object_type == FOLIONamespaces.holdings and not hasattr(self, "holdings_sources"):
+            raise TransformationProcessError(
+                index_or_id,
+                "Holdings source not set in the mapper",
+                None
+            )
+        return folio_object, legacy_id
 
     def get_statistical_code(self, legacy_item: dict, folio_prop_name: str, index_or_id):
         if self.statistical_codes_mapping:

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/src/folio_migration_tools/marc_rules_transformation/rules_mapper_base.py

@@ -559,6 +559,16 @@ class RulesMapperBase(MapperBase):
             if k == "authorityId" and (legacy_subfield_9 := marc_field.get("9")):
                 marc_field.add_subfield("0", legacy_subfield_9)
                 marc_field.delete_subfield("9")
+            if k == "authorityId" and (entity_subfields := entity_mapping.get("subfield", [])):
+                for subfield in entity_subfields:
+                    if subfield != "9":
+                        Helper.log_data_issue(
+                            index_or_legacy_id,
+                            f"authorityId mapping from ${subfield} is not supported. Data Import will fail. "
+                            "Use only $9 for authority id mapping in MARC-to-Instance mapping rules.",
+                            marc_field,
+                        )
+                        entity_mapping["subfield"] = ["9"]
             if my_values := [
                 v
                 for v in self.apply_rules(marc_field, entity_mapping, index_or_legacy_id)

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/src/folio_migration_tools/marc_rules_transformation/rules_mapper_bibs.py

@@ -165,7 +165,7 @@ class BibsRulesMapper(RulesMapperBase):
             Helper.log_data_issue(
                 legacy_ids,
                 "Multiple main entry fields in record. Record will fail Data Import. Creating Instance anyway.",
-                main_entry_fields
+                [str(field) for field in main_entry_fields]
             )
         if not main_entry_fields:
             main_entry_fields += marc_record.get_fields("700", "710", "711", "730")

{folio_migration_tools-1.9.1 → folio_migration_tools-1.9.2}/src/folio_migration_tools/migration_tasks/holdings_csv_transformer.py

@@ -209,7 +209,6 @@ class HoldingsCsvTransformer(MigrationTaskBase):
             self.holdings = {}
             self.total_records = 0
             self.holdings_id_map = self.load_id_map(self.folder_structure.holdings_id_map_path)
-            self.holdings_sources = self.get_holdings_sources()
             self.results_path = self.folder_structure.created_objects_path
             self.holdings_types = list(
                 self.folio_client.folio_get_all("/holdings-types", "holdingsTypes")
@@ -432,8 +431,6 @@ class HoldingsCsvTransformer(MigrationTaskBase):
         if not folio_rec.get("holdingsTypeId", ""):
             folio_rec["holdingsTypeId"] = self.fallback_holdings_type["id"]
 
-        folio_rec["sourceId"] = self.holdings_sources.get("FOLIO")
-
         holdings_from_row = []
         all_instance_ids = folio_rec.get("instanceId", [])
         if len(all_instance_ids) == 1:
@@ -521,20 +518,6 @@ class HoldingsCsvTransformer(MigrationTaskBase):
             self.holdings[holdings_key], new_holdings_record
         )
 
-    def get_holdings_sources(self):
-        res = {}
-        holdings_sources = list(
-            self.mapper.folio_client.folio_get_all("/holdings-sources", "holdingsRecordsSources")
-        )
-        logging.info("Fetched %s holdingsRecordsSources from tenant", len(holdings_sources))
-        res = {n["name"].upper(): n["id"] for n in holdings_sources}
-        if "FOLIO" not in res:
-            raise TransformationProcessError("", "No holdings source with name FOLIO in tenant")
-        if "MARC" not in res:
-            raise TransformationProcessError("", "No holdings source with name MARC in tenant")
-        logging.info(json.dumps(res, indent=4))
-        return res
-
 
 def explode_former_ids(folio_holding: dict):
     temp_ids = []