folio-migration-tools 1.9.0a4__tar.gz → 1.9.0a6__tar.gz

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/PKG-INFO

@@ -1,8 +1,7 @@
-Metadata-Version: 2.1
+Metadata-Version: 2.3
 Name: folio_migration_tools
-Version: 1.9.0a4
+Version: 1.9.0a6
 Summary: A tool allowing you to migrate data from legacy ILS:s (Library systems) into FOLIO LSP
-Home-page: https://github.com/FOLIO-FSE/folio_migration_tools
 License: MIT
 Keywords: FOLIO,ILS,LSP,Library Systems,MARC21,Library data
 Author: Theodor Tolstoy
@@ -27,6 +26,7 @@ Requires-Dist: pyhumps (>=3.7.3,<4.0.0)
 Requires-Dist: pymarc (>=5.2.3,<6.0.0)
 Requires-Dist: python-dateutil (>=2.8.2,<3.0.0)
 Requires-Dist: python-i18n (>=0.3.9,<0.4.0)
+Project-URL: Homepage, https://github.com/FOLIO-FSE/folio_migration_tools
 Project-URL: Repository, https://github.com/FOLIO-FSE/folio_migration_tools
 Description-Content-Type: text/markdown
 

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "folio_migration_tools"
-version = "1.9.0a4"
+version = "1.9.0a6"
 description =  "A tool allowing you to migrate data from legacy ILS:s (Library systems) into FOLIO LSP"
 authors = ["Theodor Tolstoy <github.teddes@tolstoy.se>", "Lisa Sjögren", "Brooks Travis", "Jeremy Nelson", "Clinton Bradford"]
 license = "MIT"

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/src/folio_migration_tools/mapper_base.py

@@ -24,6 +24,7 @@ from folio_migration_tools.mapping_file_transformation.ref_data_mapping import (
     RefDataMapping,
 )
 from folio_migration_tools.migration_report import MigrationReport
+from folio_migration_tools.task_configuration import AbstractTaskConfiguration
 
 
 class MapperBase:
@@ -42,7 +43,7 @@ class MapperBase:
         self.start_datetime = datetime.now(timezone.utc)
         self.folio_client: FolioClient = folio_client
         self.library_configuration: LibraryConfiguration = library_configuration
-
+        self.task_configuration: AbstractTaskConfiguration
         self.mapped_folio_fields: dict = {}
         self.migration_report: MigrationReport = MigrationReport()
         self.num_criticalerrors = 0
@@ -267,7 +268,13 @@ class MapperBase:
             sys.exit(1)
 
     def get_id_map_tuple(self, legacy_id: str, folio_record: dict, object_type: FOLIONamespaces):
-        if object_type == FOLIONamespaces.instances:
+        if all(
+            [
+                object_type == FOLIONamespaces.instances,
+                (not getattr(self.task_configuration, "data_import_marc", False)),
+                getattr(self.task_configuration, "create_source_records", True),
+            ]
+        ):
             return (legacy_id, folio_record["id"], folio_record["hrid"])
         return (legacy_id, folio_record["id"])
 

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/src/folio_migration_tools/marc_rules_transformation/hrid_handler.py

@@ -6,9 +6,7 @@ import httpx
 import i18n
 from folio_uuid import FOLIONamespaces
 from folioclient import FolioClient
-from pymarc import Field
-from pymarc import Record
-from pymarc import Subfield
+from pymarc import Field, Record, Subfield
 
 from folio_migration_tools.custom_exceptions import TransformationProcessError
 from folio_migration_tools.helper import Helper
@@ -220,7 +218,7 @@ class HRIDHandler:
                 ),
             )
             self.handle_035_generation(
-                marc_record, legacy_ids, self.migration_report, self.deactivate035_from001
+                marc_record, legacy_ids, self.migration_report, self.deactivate035_from001, False
             )
             Helper.log_data_issue(
                 legacy_ids,

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/src/folio_migration_tools/marc_rules_transformation/marc_file_processor.py

@@ -32,7 +32,7 @@ class MarcFileProcessor:
         self.created_objects_file = created_objects_file
         if mapper.task_configuration.create_source_records:
             self.srs_records_file = open(self.folder_structure.srs_records_path, "w+")
-        if mapper.task_configuration.data_import_marc:
+        if getattr(mapper.task_configuration, "data_import_marc", False):
             self.data_import_marc_file = open(self.folder_structure.data_import_marc_path, "wb+")
         self.unique_001s: set = set()
         self.failed_records_count: int = 0
@@ -87,7 +87,7 @@ class MarcFileProcessor:
                             legacy_ids,
                             self.object_type,
                         )
-                    if self.mapper.task_configuration.data_import_marc:
+                    if getattr(self.mapper.task_configuration, "data_import_marc", False):
                         self.save_marc_record(
                             marc_record,
                             folio_rec,
@@ -271,7 +271,7 @@ class MarcFileProcessor:
             if not self.srs_records_file.seek(0):
                 os.remove(self.srs_records_file.name)
             self.srs_records_file.close()
-        if self.mapper.task_configuration.data_import_marc:
+        if getattr(self.mapper.task_configuration, "data_import_marc", False):
             self.data_import_marc_file.seek(0)
             if not self.data_import_marc_file.read(1):
                 os.remove(self.data_import_marc_file.name)

{folio_migration_tools-1.9.0a4 → folio_migration_tools-1.9.0a6}/src/folio_migration_tools/marc_rules_transformation/rules_mapper_bibs.py

@@ -24,6 +24,7 @@ from folio_migration_tools.custom_exceptions import (
 from folio_migration_tools.helper import Helper
 from folio_migration_tools.library_configuration import (
     FileDefinition,
+    HridHandling,
     IlsFlavour,
     LibraryConfiguration,
 )
@@ -59,9 +60,11 @@ class BibsRulesMapper(RulesMapperBase):
         self.instance_relationship_types: dict = {}
         self.other_mode_of_issuance_id = get_unspecified_mode_of_issuance(self.folio_client)
         self.create_source_records = all(
-            [self.task_configuration.create_source_records, (not self.task_configuration.data_import_marc)]
+            [self.task_configuration.create_source_records, (not getattr(self.task_configuration, "data_import_marc", False))]
         )
         self.data_import_marc = self.task_configuration.data_import_marc
+        if self.data_import_marc:
+            self.hrid_handler.deactivate035_from001 = True
         self.start = time.time()
 
     def perform_initial_preparation(self, marc_record: pymarc.Record, legacy_ids):
@@ -73,7 +76,7 @@ class BibsRulesMapper(RulesMapperBase):
                 str(legacy_ids[-1]),
             )
         )
-        if self.create_source_records:
+        if self.create_source_records or self.hrid_handler.handling == HridHandling.preserve001:
             self.hrid_handler.handle_hrid(
                 FOLIONamespaces.instances,
                 folio_instance,
@@ -118,7 +121,7 @@ class BibsRulesMapper(RulesMapperBase):
         bad_tags = set(self.task_configuration.tags_to_delete)  # "907"
         folio_instance = self.perform_initial_preparation(marc_record, legacy_ids)
         if self.data_import_marc:
-            self.simple_bib_map(marc_record, folio_instance, ignored_subsequent_fields, legacy_ids)
+            self.simple_bib_map(folio_instance, marc_record, ignored_subsequent_fields, legacy_ids)
         else:
             for marc_field in marc_record:
                 self.report_marc_stats(marc_field, bad_tags, legacy_ids, ignored_subsequent_fields)
@@ -152,7 +155,13 @@ class BibsRulesMapper(RulesMapperBase):
             legacy_ids (List[str]): _description_
             file_def (FileDefinition): _description_
         """
-        self.process_marc_field(folio_instnace, marc_record['245'], ignored_subsequent_fields, legacy_ids)
+        try:
+            self.process_marc_field(folio_instnace, marc_record['245'], ignored_subsequent_fields, legacy_ids)
+        except KeyError:
+            raise TransformationRecordFailedError(
+                legacy_ids,
+                "No 245 field in MARC record"
+            )
 
     def perform_additional_parsing(
         self,