flwr-nightly 1.19.0.dev20250607__tar.gz → 1.19.0.dev20250610__tar.gz

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: flwr-nightly
-Version: 1.19.0.dev20250607
+Version: 1.19.0.dev20250610
 Summary: Flower: A Friendly Federated AI Framework
 License: Apache-2.0
 Keywords: Artificial Intelligence,Federated AI,Federated Analytics,Federated Evaluation,Federated Learning,Flower,Machine Learning

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/client/grpc_rere_client/connection.py

@@ -32,9 +32,11 @@ from flwr.common.grpc import create_channel, on_channel_state_change
 from flwr.common.heartbeat import HeartbeatSender
 from flwr.common.inflatable import get_all_nested_objects
 from flwr.common.inflatable_grpc_utils import (
-    inflate_object_from_contents,
     make_pull_object_fn_grpc,
     make_push_object_fn_grpc,
+)
+from flwr.common.inflatable_utils import (
+    inflate_object_from_contents,
     pull_objects,
     push_objects,
 )

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/common/inflatable.py

@@ -18,11 +18,9 @@
 from __future__ import annotations
 
 import hashlib
-from logging import ERROR
 from typing import TypeVar, cast
 
 from .constant import HEAD_BODY_DIVIDER, HEAD_VALUE_DIVIDER
-from .logger import log
 
 
 class UnexpectedObjectContentError(Exception):
@@ -175,16 +173,6 @@ def get_object_body_len_from_object_content(object_content: bytes) -> int:
     return get_object_head_values_from_object_content(object_content)[2]
 
 
-def check_body_len_consistency(object_content: bytes) -> bool:
-    """Check that the object body is of length as specified in the head."""
-    try:
-        body_len = get_object_body_len_from_object_content(object_content)
-        return body_len == len(_get_object_body(object_content))
-    except ValueError:
-        log(ERROR, "Object content does match the expected format.")
-        return False
-
-
 def get_object_head_values_from_object_content(
     object_content: bytes,
 ) -> tuple[str, list[str], int]:

flwr_nightly-1.19.0.dev20250610/py/flwr/common/inflatable_grpc_utils.py

@@ -0,0 +1,99 @@
+# Copyright 2025 Flower Labs GmbH. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ==============================================================================
+"""InflatableObject utils."""
+
+
+from typing import Callable
+
+from flwr.proto.message_pb2 import (  # pylint: disable=E0611
+    PullObjectRequest,
+    PullObjectResponse,
+    PushObjectRequest,
+    PushObjectResponse,
+)
+from flwr.proto.node_pb2 import Node  # pylint: disable=E0611
+
+from .inflatable_utils import ObjectIdNotPreregisteredError, ObjectUnavailableError
+
+
+def make_pull_object_fn_grpc(
+    pull_object_grpc: Callable[[PullObjectRequest], PullObjectResponse],
+    node: Node,
+    run_id: int,
+) -> Callable[[str], bytes]:
+    """Create a pull object function that uses gRPC to pull objects.
+
+    Parameters
+    ----------
+    pull_object_grpc : Callable[[PullObjectRequest], PullObjectResponse]
+        The gRPC function to pull objects, e.g., `FleetStub.PullObject`.
+    node : Node
+        The node making the request.
+    run_id : int
+        The run ID for the current operation.
+
+    Returns
+    -------
+    Callable[[str], bytes]
+        A function that takes an object ID and returns the object content as bytes.
+        The function raises `ObjectIdNotPreregisteredError` if the object ID is not
+        pre-registered, or `ObjectUnavailableError` if the object is not yet available.
+    """
+
+    def pull_object_fn(object_id: str) -> bytes:
+        request = PullObjectRequest(node=node, run_id=run_id, object_id=object_id)
+        response: PullObjectResponse = pull_object_grpc(request)
+        if not response.object_found:
+            raise ObjectIdNotPreregisteredError(object_id)
+        if not response.object_available:
+            raise ObjectUnavailableError(object_id)
+        return response.object_content
+
+    return pull_object_fn
+
+
+def make_push_object_fn_grpc(
+    push_object_grpc: Callable[[PushObjectRequest], PushObjectResponse],
+    node: Node,
+    run_id: int,
+) -> Callable[[str, bytes], None]:
+    """Create a push object function that uses gRPC to push objects.
+
+    Parameters
+    ----------
+    push_object_grpc : Callable[[PushObjectRequest], PushObjectResponse]
+        The gRPC function to push objects, e.g., `FleetStub.PushObject`.
+    node : Node
+        The node making the request.
+    run_id : int
+        The run ID for the current operation.
+
+    Returns
+    -------
+    Callable[[str, bytes], None]
+        A function that takes an object ID and its content as bytes, and pushes it
+        to the servicer. The function raises `ObjectIdNotPreregisteredError` if
+        the object ID is not pre-registered.
+    """
+
+    def push_object_fn(object_id: str, object_content: bytes) -> None:
+        request = PushObjectRequest(
+            node=node, run_id=run_id, object_id=object_id, object_content=object_content
+        )
+        response: PushObjectResponse = push_object_grpc(request)
+        if not response.stored:
+            raise ObjectIdNotPreregisteredError(object_id)
+
+    return push_object_fn

flwr_nightly-1.19.0.dev20250607/py/flwr/common/inflatable_grpc_utils.py → flwr_nightly-1.19.0.dev20250610/py/flwr/common/inflatable_utils.py

@@ -12,8 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 # ==============================================================================
-"""InflatableObject utils."""
-
+"""InflatableObject utilities."""
 
 import concurrent.futures
 import random
@@ -21,15 +20,9 @@ import threading
 import time
 from typing import Callable, Optional
 
-from flwr.proto.message_pb2 import (  # pylint: disable=E0611
-    PullObjectRequest,
-    PullObjectResponse,
-    PushObjectRequest,
-    PushObjectResponse,
-)
-from flwr.proto.node_pb2 import Node  # pylint: disable=E0611
-
 from .constant import (
+    HEAD_BODY_DIVIDER,
+    HEAD_VALUE_DIVIDER,
     MAX_CONCURRENT_PULLS,
     MAX_CONCURRENT_PUSHES,
     PULL_BACKOFF_CAP,
@@ -37,7 +30,14 @@ from .constant import (
     PULL_MAX_TIME,
     PULL_MAX_TRIES_PER_OBJECT,
 )
-from .inflatable import InflatableObject, get_object_head_values_from_object_content
+from .inflatable import (
+    InflatableObject,
+    UnexpectedObjectContentError,
+    _get_object_head,
+    get_object_head_values_from_object_content,
+    get_object_id,
+    is_valid_sha256_hash,
+)
 from .message import Message
 from .record import Array, ArrayRecord, ConfigRecord, MetricRecord, RecordDict
 
@@ -67,77 +67,6 @@ class ObjectIdNotPreregisteredError(Exception):
         super().__init__(f"Object with ID '{object_id}' could not be found.")
 
 
-def make_pull_object_fn_grpc(
-    pull_object_grpc: Callable[[PullObjectRequest], PullObjectResponse],
-    node: Node,
-    run_id: int,
-) -> Callable[[str], bytes]:
-    """Create a pull object function that uses gRPC to pull objects.
-
-    Parameters
-    ----------
-    pull_object_grpc : Callable[[PullObjectRequest], PullObjectResponse]
-        The gRPC function to pull objects, e.g., `FleetStub.PullObject`.
-    node : Node
-        The node making the request.
-    run_id : int
-        The run ID for the current operation.
-
-    Returns
-    -------
-    Callable[[str], bytes]
-        A function that takes an object ID and returns the object content as bytes.
-        The function raises `ObjectIdNotPreregisteredError` if the object ID is not
-        pre-registered, or `ObjectUnavailableError` if the object is not yet available.
-    """
-
-    def pull_object_fn(object_id: str) -> bytes:
-        request = PullObjectRequest(node=node, run_id=run_id, object_id=object_id)
-        response: PullObjectResponse = pull_object_grpc(request)
-        if not response.object_found:
-            raise ObjectIdNotPreregisteredError(object_id)
-        if not response.object_available:
-            raise ObjectUnavailableError(object_id)
-        return response.object_content
-
-    return pull_object_fn
-
-
-def make_push_object_fn_grpc(
-    push_object_grpc: Callable[[PushObjectRequest], PushObjectResponse],
-    node: Node,
-    run_id: int,
-) -> Callable[[str, bytes], None]:
-    """Create a push object function that uses gRPC to push objects.
-
-    Parameters
-    ----------
-    push_object_grpc : Callable[[PushObjectRequest], PushObjectResponse]
-        The gRPC function to push objects, e.g., `FleetStub.PushObject`.
-    node : Node
-        The node making the request.
-    run_id : int
-        The run ID for the current operation.
-
-    Returns
-    -------
-    Callable[[str, bytes], None]
-        A function that takes an object ID and its content as bytes, and pushes it
-        to the servicer. The function raises `ObjectIdNotPreregisteredError` if
-        the object ID is not pre-registered.
-    """
-
-    def push_object_fn(object_id: str, object_content: bytes) -> None:
-        request = PushObjectRequest(
-            node=node, run_id=run_id, object_id=object_id, object_content=object_content
-        )
-        response: PushObjectResponse = push_object_grpc(request)
-        if not response.stored:
-            raise ObjectIdNotPreregisteredError(object_id)
-
-    return push_object_fn
-
-
 def push_objects(
     objects: dict[str, InflatableObject],
     push_object_fn: Callable[[str, bytes], None],
@@ -360,3 +289,53 @@ def inflate_object_from_contents(
     del object_content  # Free memory after inflation
     objects[object_id] = obj
     return obj
+
+
+def validate_object_content(content: bytes) -> None:
+    """Validate the deflated content of an InflatableObject."""
+    try:
+        # Check if there is a head-body divider
+        index = content.find(HEAD_BODY_DIVIDER)
+        if index == -1:
+            raise ValueError(
+                "Unexpected format for object content. Head and body "
+                "could not be split."
+            )
+
+        head = _get_object_head(content)
+
+        # check if the head has three parts:
+        # <object_type> <children_ids> <object_body_len>
+        head_decoded = head.decode(encoding="utf-8")
+        head_parts = head_decoded.split(HEAD_VALUE_DIVIDER)
+
+        if len(head_parts) != 3:
+            raise ValueError("Unexpected format for object head.")
+
+        obj_type, children_str, body_len = head_parts
+
+        # Check that children IDs are valid IDs
+        children = children_str.split(",")
+        for children_id in children:
+            if children_id and not is_valid_sha256_hash(children_id):
+                raise ValueError(
+                    f"Detected invalid object ID ({children_id}) in children."
+                )
+
+        # Check that object type is recognized
+        if obj_type not in inflatable_class_registry:
+            if obj_type != "CustomDataClass":  # to allow for the class in tests
+                raise ValueError(f"Object of type {obj_type} is not supported.")
+
+        # Check if the body length in the head matches that of the body
+        actual_body_len = len(content) - len(head) - len(HEAD_BODY_DIVIDER)
+        if actual_body_len != int(body_len):
+            raise ValueError(
+                f"Object content length expected {body_len} bytes but got "
+                f"{actual_body_len} bytes."
+            )
+
+    except ValueError as err:
+        raise UnexpectedObjectContentError(
+            object_id=get_object_id(content), reason=str(err)
+        ) from err

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/server/grid/grpc_grid.py

@@ -30,9 +30,11 @@ from flwr.common.constant import (
 from flwr.common.grpc import create_channel, on_channel_state_change
 from flwr.common.inflatable import get_all_nested_objects
 from flwr.common.inflatable_grpc_utils import (
-    inflate_object_from_contents,
     make_pull_object_fn_grpc,
     make_push_object_fn_grpc,
+)
+from flwr.common.inflatable_utils import (
+    inflate_object_from_contents,
     pull_objects,
     push_objects,
 )

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/server/superlink/fleet/grpc_rere/fleet_servicer.py

@@ -15,13 +15,12 @@
 """Fleet API gRPC request-response servicer."""
 
 
-from logging import DEBUG, ERROR, INFO
+from logging import DEBUG, INFO
 
 import grpc
 from google.protobuf.json_format import MessageToDict
 
-from flwr.common.constant import Status
-from flwr.common.inflatable import check_body_len_consistency
+from flwr.common.inflatable import UnexpectedObjectContentError
 from flwr.common.logger import log
 from flwr.common.typing import InvalidRunStatusException
 from flwr.proto import fleet_pb2_grpc  # pylint: disable=E0611
@@ -50,9 +49,8 @@ from flwr.proto.run_pb2 import GetRunRequest, GetRunResponse  # pylint: disable=
 from flwr.server.superlink.ffs.ffs_factory import FfsFactory
 from flwr.server.superlink.fleet.message_handler import message_handler
 from flwr.server.superlink.linkstate import LinkStateFactory
-from flwr.server.superlink.utils import abort_grpc_context, check_abort
+from flwr.server.superlink.utils import abort_grpc_context
 from flwr.supercore.object_store import ObjectStoreFactory
-from flwr.supercore.object_store.object_store import NoObjectInStoreError
 
 
 class FleetServicer(fleet_pb2_grpc.FleetServicer):
@@ -185,39 +183,20 @@ class FleetServicer(fleet_pb2_grpc.FleetServicer):
             request.object_id,
         )
 
-        state = self.state_factory.state()
-
-        # Abort if the run is not running
-        abort_msg = check_abort(
-            request.run_id,
-            [Status.PENDING, Status.STARTING, Status.FINISHED],
-            state,
-        )
-        if abort_msg:
-            abort_grpc_context(abort_msg, context)
-
-        if request.node.node_id not in state.get_nodes(run_id=request.run_id):
-            # Cancel insertion in ObjectStore
-            context.abort(grpc.StatusCode.FAILED_PRECONDITION, "Unexpected node ID.")
-
-        if not check_body_len_consistency(request.object_content):
-            # Cancel insertion in ObjectStore
-            context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION, "Unexpected object length"
-            )
-
-        # Init store
-        store = self.objectstore_factory.store()
-
-        # Insert in store
-        stored = False
         try:
-            store.put(request.object_id, request.object_content)
-            stored = True
-        except (NoObjectInStoreError, ValueError) as e:
-            log(ERROR, str(e))
+            # Insert in Store
+            res = message_handler.push_object(
+                request=request,
+                state=self.state_factory.state(),
+                store=self.objectstore_factory.store(),
+            )
+        except InvalidRunStatusException as e:
+            abort_grpc_context(e.message, context)
+        except UnexpectedObjectContentError as e:
+            # Object content is not valid
+            context.abort(grpc.StatusCode.FAILED_PRECONDITION, str(e))
 
-        return PushObjectResponse(stored=stored)
+        return res
 
     def PullObject(
         self, request: PullObjectRequest, context: grpc.ServicerContext
@@ -229,31 +208,14 @@ class FleetServicer(fleet_pb2_grpc.FleetServicer):
             request.object_id,
         )
 
-        state = self.state_factory.state()
-
-        # Abort if the run is not running
-        abort_msg = check_abort(
-            request.run_id,
-            [Status.PENDING, Status.STARTING, Status.FINISHED],
-            state,
-        )
-        if abort_msg:
-            abort_grpc_context(abort_msg, context)
-
-        if request.node.node_id not in state.get_nodes(run_id=request.run_id):
-            # Cancel insertion in ObjectStore
-            context.abort(grpc.StatusCode.FAILED_PRECONDITION, "Unexpected node ID.")
-
-        # Init store
-        store = self.objectstore_factory.store()
-
-        # Fetch from store
-        content = store.get(request.object_id)
-        if content is not None:
-            object_available = content != b""
-            return PullObjectResponse(
-                object_found=True,
-                object_available=object_available,
-                object_content=content,
+        try:
+            # Fetch from store
+            res = message_handler.pull_object(
+                request=request,
+                state=self.state_factory.state(),
+                store=self.objectstore_factory.store(),
             )
-        return PullObjectResponse(object_found=False, object_available=False)
+        except InvalidRunStatusException as e:
+            abort_grpc_context(e.message, context)
+
+        return res

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/server/superlink/fleet/message_handler/message_handler.py

@@ -19,6 +19,7 @@ from typing import Optional
 
 from flwr.common import Message, log
 from flwr.common.constant import Status
+from flwr.common.inflatable import UnexpectedObjectContentError
 from flwr.common.serde import (
     fab_to_proto,
     message_from_proto,
@@ -42,7 +43,13 @@ from flwr.proto.heartbeat_pb2 import (  # pylint: disable=E0611
     SendNodeHeartbeatRequest,
     SendNodeHeartbeatResponse,
 )
-from flwr.proto.message_pb2 import ObjectIDs  # pylint: disable=E0611
+from flwr.proto.message_pb2 import (  # pylint: disable=E0611
+    ObjectIDs,
+    PullObjectRequest,
+    PullObjectResponse,
+    PushObjectRequest,
+    PushObjectResponse,
+)
 from flwr.proto.node_pb2 import Node  # pylint: disable=E0611
 from flwr.proto.run_pb2 import (  # pylint: disable=E0611
     GetRunRequest,
@@ -203,3 +210,52 @@ def get_fab(
         return GetFabResponse(fab=fab_to_proto(fab))
 
     raise ValueError(f"Found no FAB with hash: {request.hash_str}")
+
+
+def push_object(
+    request: PushObjectRequest, state: LinkState, store: ObjectStore
+) -> PushObjectResponse:
+    """Push Object."""
+    abort_msg = check_abort(
+        request.run_id,
+        [Status.PENDING, Status.STARTING, Status.FINISHED],
+        state,
+    )
+    if abort_msg:
+        raise InvalidRunStatusException(abort_msg)
+
+    stored = False
+    try:
+        store.put(request.object_id, request.object_content)
+        stored = True
+    except (NoObjectInStoreError, ValueError) as e:
+        log(ERROR, str(e))
+    except UnexpectedObjectContentError as e:
+        # Object content is not valid
+        log(ERROR, str(e))
+        raise
+    return PushObjectResponse(stored=stored)
+
+
+def pull_object(
+    request: PullObjectRequest, state: LinkState, store: ObjectStore
+) -> PullObjectResponse:
+    """Pull Object."""
+    abort_msg = check_abort(
+        request.run_id,
+        [Status.PENDING, Status.STARTING, Status.FINISHED],
+        state,
+    )
+    if abort_msg:
+        raise InvalidRunStatusException(abort_msg)
+
+    # Fetch from store
+    content = store.get(request.object_id)
+    if content is not None:
+        object_available = content != b""
+        return PullObjectResponse(
+            object_found=True,
+            object_available=object_available,
+            object_content=content,
+        )
+    return PullObjectResponse(object_found=False, object_available=False)

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/server/superlink/serverappio/serverappio_servicer.py

@@ -23,7 +23,10 @@ import grpc
 
 from flwr.common import Message
 from flwr.common.constant import SUPERLINK_NODE_ID, Status
-from flwr.common.inflatable import check_body_len_consistency, get_descendant_object_ids
+from flwr.common.inflatable import (
+    UnexpectedObjectContentError,
+    get_descendant_object_ids,
+)
 from flwr.common.logger import log
 from flwr.common.serde import (
     context_from_proto,
@@ -424,12 +427,6 @@ class ServerAppIoServicer(serverappio_pb2_grpc.ServerAppIoServicer):
             # Cancel insertion in ObjectStore
             context.abort(grpc.StatusCode.FAILED_PRECONDITION, "Unexpected node ID.")
 
-        if not check_body_len_consistency(request.object_content):
-            # Cancel insertion in ObjectStore
-            context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION, "Unexpected object length."
-            )
-
         # Init store
         store = self.objectstore_factory.store()
 
@@ -440,6 +437,9 @@ class ServerAppIoServicer(serverappio_pb2_grpc.ServerAppIoServicer):
             stored = True
         except (NoObjectInStoreError, ValueError) as e:
             log(ERROR, str(e))
+        except UnexpectedObjectContentError as e:
+            # Object content is not valid
+            context.abort(grpc.StatusCode.FAILED_PRECONDITION, str(e))
 
         return PushObjectResponse(stored=stored)
 

{flwr_nightly-1.19.0.dev20250607 → flwr_nightly-1.19.0.dev20250610}/py/flwr/supercore/object_store/in_memory_object_store.py

@@ -18,6 +18,7 @@
 from typing import Optional
 
 from flwr.common.inflatable import get_object_id, is_valid_sha256_hash
+from flwr.common.inflatable_utils import validate_object_content
 
 from .object_store import NoObjectInStoreError, ObjectStore
 
@@ -52,12 +53,15 @@ class InMemoryObjectStore(ObjectStore):
                 f"Object with ID '{object_id}' was not pre-registered."
             )
 
-        # Verify object_id and object_content match
         if self.verify:
+            # Verify object_id and object_content match
             object_id_from_content = get_object_id(object_content)
             if object_id != object_id_from_content:
                 raise ValueError(f"Object ID {object_id} does not match content hash")
 
+            # Validate object content
+            validate_object_content(content=object_content)
+
         # Return if object is already present in the store
         if self.store[object_id] != b"":
             return