flamapy-sharpsat 2.6.0.dev12__tar.gz → 2.9.0.dev0__tar.gz

{flamapy_sharpsat-2.6.0.dev12/flamapy_sharpsat.egg-info → flamapy_sharpsat-2.9.0.dev0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: flamapy-sharpsat
-Version: 2.6.0.dev12
+Version: 2.9.0.dev0
 Summary: flamapy-sharpsat is a plugin to flamapy providing approximate model counting and almost-uniform sampling
 Author-email: Flamapy <flamapy@us.es>
 License-Expression: GPL-3.0-or-later
@@ -8,9 +8,10 @@ Project-URL: Homepage, https://github.com/flamapy/sharpsat_metamodel
 Requires-Python: >=3.11
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: flamapy-fw~=2.6.0.dev12
-Requires-Dist: flamapy-fm~=2.6.0.dev12
+Requires-Dist: flamapy-fw~=2.9.0.dev0
+Requires-Dist: flamapy-fm~=2.9.0.dev0
 Requires-Dist: pyunigen~=2.5
+Requires-Dist: python-sat
 Provides-Extra: dev
 Requires-Dist: pytest; extra == "dev"
 Requires-Dist: pytest-mock; extra == "dev"

flamapy_sharpsat-2.9.0.dev0/flamapy/metamodels/sharpsat_metamodel/__init__.py

@@ -0,0 +1,26 @@
+from flamapy.core.manifest import OperationCapability, PluginManifest
+from flamapy.core.models.language_level import LanguageLevel, MajorLevel, MinorLevel
+
+# Approximate counting (ApproxMC) and almost-uniform sampling (UniGen): never chosen by the
+# planner unless the caller allows approximate results. Since 2.9 both operations pre-check
+# satisfiability (pyunigen segfaults on UNSAT input) and short-circuit void models.
+# Costs are estimated milliseconds from the 2026-11-06 calibration (betty synthetic models at
+# 1% and 30% constraint density plus JHipster and busybox; worst case, never decreasing):
+# counting takes 0.1 s at 100 features and 1.6 s at 200; from 500 features on it depends on the
+# model (1.5-8 s on the dense 1,000/2,000-feature models, but the sparse 500-feature one and
+# busybox did not finish within 3 minutes), so the curve carries the cap and the ceiling is the
+# largest size measured.
+MANIFEST = PluginManifest(
+    name='sharpsat',
+    calibration='2026-11-06',
+    extension='sharpsat',
+    supported_level=LanguageLevel(MajorLevel.BOOLEAN, {MinorLevel.GROUP_CARDINALITY}),
+    max_features=2000,
+    transformation_cost_curve=((200, 1), (500, 2), (1000, 4), (2000, 10)),
+    operations={
+        'configurations_number': OperationCapability(
+            exact=False, cost_curve=((50, 30), (100, 100), (200, 1600), (500, 180000))),
+        'sampling': OperationCapability(
+            exact=False, cost_curve=((50, 100), (100, 420), (200, 3500), (500, 70000))),
+    },
+)

flamapy_sharpsat-2.9.0.dev0/flamapy/metamodels/sharpsat_metamodel/operations/_satcheck.py

@@ -0,0 +1,16 @@
+"""Satisfiability pre-check guarding the pyunigen calls.
+
+pyunigen (the UniGen/ApproxMC binding) segfaults the whole interpreter when handed an
+unsatisfiable formula (found by the calibration runs during the 2.9 development, where it
+silently killed worker pools), so every operation checks the CNF with a plain SAT call first and
+short-circuits the trivial answer (count 0 / empty sample) instead of crashing.
+"""
+from pysat.solvers import Solver
+
+
+def satisfiable(clauses: list[list[int]]) -> bool:
+    solver = Solver(name='glucose3', bootstrap_with=clauses)
+    try:
+        return bool(solver.solve())
+    finally:
+        solver.delete()

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/flamapy/metamodels/sharpsat_metamodel/operations/sharpsat_configurations_number.py

@@ -6,6 +6,8 @@ from flamapy.core.models import VariabilityModel
 from flamapy.core.operations import ConfigurationsNumber
 from flamapy.metamodels.sharpsat_metamodel.models import SharpSATModel
 
+from ._satcheck import satisfiable
+
 
 class SharpSATConfigurationsNumber(ConfigurationsNumber):
     """Approximate the number of valid configurations with ApproxMC.
@@ -19,8 +21,13 @@ class SharpSATConfigurationsNumber(ConfigurationsNumber):
     mis-configures ApproxMC's projected counting on feature-model CNFs with implied variables
     (the root and mandatory-relation unit clauses), undercounting by a factor of two; UniGen's
     ApproxMC invocation does not have that problem.
+
+    Unsatisfiable models short-circuit to 0 through a plain SAT pre-check: pyunigen
+    segfaults the interpreter on UNSAT input.
     """
 
+    exact = False  # reported in the OperationResult provenance envelope
+
     def __init__(self, seed: int = 1) -> None:
         self._result = 0
         self._seed = seed
@@ -33,6 +40,9 @@ class SharpSATConfigurationsNumber(ConfigurationsNumber):
 
     def execute(self, model: VariabilityModel) -> 'SharpSATConfigurationsNumber':
         sharpsat_model = cast(SharpSATModel, model)
+        if not satisfiable(sharpsat_model.clauses):
+            self._result = 0
+            return self
         counter = pyunigen.Sampler(seed=self._seed)
         for clause in sharpsat_model.clauses:
             counter.add_clause(clause)

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/flamapy/metamodels/sharpsat_metamodel/operations/sharpsat_sampling.py

@@ -7,6 +7,8 @@ from flamapy.core.operations import Sampling
 from flamapy.metamodels.configuration_metamodel.models.configuration import Configuration
 from flamapy.metamodels.sharpsat_metamodel.models import SharpSATModel
 
+from ._satcheck import satisfiable
+
 
 class SharpSATSampling(Sampling):
     """Almost-uniform sampling of valid configurations with UniGen.
@@ -14,8 +16,14 @@ class SharpSATSampling(Sampling):
     Unlike an enumerate-first-N sampler, UniGen draws configurations almost uniformly at
     random. Sampling is projected onto the feature variables, and an optional partial
     configuration fixes features as assumptions.
+
+    Unsatisfiable input (a void model, or a partial configuration that contradicts it)
+    short-circuits to an empty sample through a plain SAT pre-check: pyunigen segfaults
+    the interpreter on UNSAT input.
     """
 
+    exact = False  # reported in the OperationResult provenance envelope
+
     def __init__(self, seed: int = 1) -> None:
         self._sample_size = 1
         self._with_replacement = False
@@ -40,14 +48,20 @@ class SharpSATSampling(Sampling):
 
     def execute(self, model: VariabilityModel) -> 'SharpSATSampling':
         sharpsat_model = cast(SharpSATModel, model)
-        sampler = pyunigen.Sampler(seed=self._seed)
-        for clause in sharpsat_model.clauses:
-            sampler.add_clause(clause)
+        clauses = [list(clause) for clause in sharpsat_model.clauses]
         if self._partial_configuration is not None:
             for name, value in self._partial_configuration.elements.items():
                 variable = sharpsat_model.variables.get(name)
                 if variable is not None:
-                    sampler.add_clause([variable if value else -variable])
+                    clauses.append([variable if value else -variable])
+
+        if not satisfiable(clauses):
+            self._result = []
+            return self
+
+        sampler = pyunigen.Sampler(seed=self._seed)
+        for clause in clauses:
+            sampler.add_clause(clause)
 
         _cells, _hashes, samples = sampler.sample(
             num=self._sample_size, sampling_set=sharpsat_model.feature_variables()

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/flamapy/metamodels/sharpsat_metamodel/transformations/fm_to_sharpsat.py

@@ -1,5 +1,5 @@
 from flamapy.core.transformations import ModelToModel
-from flamapy.metamodels.fm_metamodel.models import FeatureModel, ClauseSet
+from flamapy.metamodels.fm_metamodel.models import ClauseSet, DEFAULT_CNF_METHOD, FeatureModel
 from flamapy.metamodels.sharpsat_metamodel.models import SharpSATModel
 
 
@@ -19,7 +19,7 @@ class FmToSharpSAT(ModelToModel):
     def get_destination_extension() -> str:
         return 'sharpsat'
 
-    def __init__(self, source_model: FeatureModel, cnf_method: str = 'distributive') -> None:
+    def __init__(self, source_model: FeatureModel, cnf_method: str = DEFAULT_CNF_METHOD) -> None:
         self.source_model = source_model
         self.cnf_method = cnf_method
         self.destination_model = SharpSATModel()

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0/flamapy_sharpsat.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: flamapy-sharpsat
-Version: 2.6.0.dev12
+Version: 2.9.0.dev0
 Summary: flamapy-sharpsat is a plugin to flamapy providing approximate model counting and almost-uniform sampling
 Author-email: Flamapy <flamapy@us.es>
 License-Expression: GPL-3.0-or-later
@@ -8,9 +8,10 @@ Project-URL: Homepage, https://github.com/flamapy/sharpsat_metamodel
 Requires-Python: >=3.11
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: flamapy-fw~=2.6.0.dev12
-Requires-Dist: flamapy-fm~=2.6.0.dev12
+Requires-Dist: flamapy-fw~=2.9.0.dev0
+Requires-Dist: flamapy-fm~=2.9.0.dev0
 Requires-Dist: pyunigen~=2.5
+Requires-Dist: python-sat
 Provides-Extra: dev
 Requires-Dist: pytest; extra == "dev"
 Requires-Dist: pytest-mock; extra == "dev"

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/flamapy_sharpsat.egg-info/SOURCES.txt

@@ -6,6 +6,7 @@ flamapy/metamodels/sharpsat_metamodel/__init__.py
 flamapy/metamodels/sharpsat_metamodel/models/__init__.py
 flamapy/metamodels/sharpsat_metamodel/models/sharpsat_model.py
 flamapy/metamodels/sharpsat_metamodel/operations/__init__.py
+flamapy/metamodels/sharpsat_metamodel/operations/_satcheck.py
 flamapy/metamodels/sharpsat_metamodel/operations/sharpsat_configurations_number.py
 flamapy/metamodels/sharpsat_metamodel/operations/sharpsat_sampling.py
 flamapy/metamodels/sharpsat_metamodel/transformations/__init__.py
@@ -13,6 +14,7 @@ flamapy/metamodels/sharpsat_metamodel/transformations/fm_to_sharpsat.py
 flamapy_sharpsat.egg-info/PKG-INFO
 flamapy_sharpsat.egg-info/SOURCES.txt
 flamapy_sharpsat.egg-info/dependency_links.txt
+flamapy_sharpsat.egg-info/entry_points.txt
 flamapy_sharpsat.egg-info/requires.txt
 flamapy_sharpsat.egg-info/top_level.txt
 tests/test_sharpsat.py

flamapy_sharpsat-2.9.0.dev0/flamapy_sharpsat.egg-info/entry_points.txt

@@ -0,0 +1,2 @@
+[flamapy.plugins]
+sharpsat = flamapy.metamodels.sharpsat_metamodel

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/flamapy_sharpsat.egg-info/requires.txt

@@ -1,6 +1,7 @@
-flamapy-fw~=2.6.0.dev12
-flamapy-fm~=2.6.0.dev12
+flamapy-fw~=2.9.0.dev0
+flamapy-fm~=2.9.0.dev0
 pyunigen~=2.5
+python-sat
 
 [dev]
 pytest

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/pyproject.toml

@@ -4,16 +4,17 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "flamapy-sharpsat"
-version = "2.6.0.dev12"
+version = "2.9.0.dev0"
 description = "flamapy-sharpsat is a plugin to flamapy providing approximate model counting and almost-uniform sampling"
 readme = "README.md"
 license = "GPL-3.0-or-later"
 authors = [{ name = "Flamapy", email = "flamapy@us.es" }]
 requires-python = ">=3.11"
 dependencies = [
-    "flamapy-fw~=2.6.0.dev12",
-    "flamapy-fm~=2.6.0.dev12",
+    "flamapy-fw~=2.9.0.dev0",
+    "flamapy-fm~=2.9.0.dev0",
     "pyunigen~=2.5",
+    "python-sat",
 ]
 
 [project.optional-dependencies]
@@ -25,6 +26,9 @@ dev = [
     "coverage",
 ]
 
+[project.entry-points."flamapy.plugins"]
+sharpsat = "flamapy.metamodels.sharpsat_metamodel"
+
 [project.urls]
 Homepage = "https://github.com/flamapy/sharpsat_metamodel"
 

{flamapy_sharpsat-2.6.0.dev12 → flamapy_sharpsat-2.9.0.dev0}/tests/test_sharpsat.py

@@ -146,3 +146,97 @@ def test_without_replacement_deduplicates():
     sample = op.execute(model).get_sample()
     keys = [frozenset(n for n, v in c.elements.items() if v) for c in sample]
     assert len(keys) == len(set(keys))   # no duplicates
+
+
+# ---------------------------------------------------------------------------
+# UNSAT guard: pyunigen segfaults the interpreter on unsatisfiable input, so both
+# operations must short-circuit without ever reaching it.
+# ---------------------------------------------------------------------------
+
+_VOID_UVL = """features
+    Root {abstract}
+        mandatory
+            A
+            B
+constraints
+    A => !B
+"""
+
+
+def test_void_model_counts_zero_without_crashing():
+    model = FmToSharpSAT(_fm_from(_VOID_UVL)).transform()
+    operation = SharpSATConfigurationsNumber()
+    assert operation.execute(model).get_result() == 0
+
+
+def test_void_model_samples_empty_without_crashing():
+    model = FmToSharpSAT(_fm_from(_VOID_UVL)).transform()
+    operation = SharpSATSampling()
+    operation.set_sample_size(5)
+    assert operation.execute(model).get_result() == []
+
+
+def test_unsatisfiable_partial_configuration_samples_empty():
+    model = FmToSharpSAT(_fm()).transform()
+    operation = SharpSATSampling()
+    operation.set_sample_size(3)
+    # A and B are mutually exclusive in _UVL (A => !B).
+    operation.set_partial_configuration(Configuration({'A': True, 'B': True}))
+    assert operation.execute(model).get_result() == []
+
+
+def test_satisfiable_behavior_unchanged_by_the_guard():
+    fm = _fm()
+    model = FmToSharpSAT(fm).transform()
+    operation = SharpSATConfigurationsNumber()
+    assert operation.execute(model).get_result() == _exact_count(fm)
+
+
+_TSEYTIN_UVL = """features
+    Root {abstract}
+        optional
+            A
+            B
+            C
+            D
+            E
+            F
+constraints
+    (A & B & C) | (D & E & F) | (B & E & F)
+"""
+
+# [1..2] over A, B, C (3 + 3 selections) times D optional: 12 configurations.
+_GROUP_UVL = """features
+    Root {abstract}
+        [1..2]
+            A
+            B
+            C
+        optional
+            D
+"""
+
+
+def test_cnf_methods_agree():
+    """Tseytin auxiliary variables must not change the count or let samples leak them."""
+    fm = _fm_from(_TSEYTIN_UVL)
+    assert ClauseSet.from_feature_model(fm, cnf_method='auto').auxiliary_variables
+    exact = _exact_count(fm)
+    for method in ('distributive', 'tseytin', 'auto'):
+        model = FmToSharpSAT(fm, cnf_method=method).transform()
+        assert SharpSATConfigurationsNumber().execute(model).get_result() == exact, method
+        sampler = SharpSATSampling()
+        sampler.set_sample_size(5)
+        for config in sampler.execute(model).get_sample():
+            assert _is_valid(fm, set(config.get_selected_elements())), method
+
+
+def test_group_cardinality():
+    fm = _fm_from(_GROUP_UVL)
+    model = FmToSharpSAT(fm).transform()
+    assert SharpSATConfigurationsNumber().execute(model).get_result() == 12
+    sampler = SharpSATSampling()
+    sampler.set_sample_size(5)
+    for config in sampler.execute(model).get_sample():
+        selected = set(config.get_selected_elements())
+        assert 1 <= len(selected & {'A', 'B', 'C'}) <= 2