flake8-elegant-objects 1.1.0__tar.gz → 1.1.1__tar.gz

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.1] - 2024-06-30
+
+### Minor release
+
+- `EO006`: Allow `super()` calls in constructor
+
 ## [1.1.0] - 2024-06-28
 
 ### 🚀 Major Enhancements

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: flake8-elegant-objects
-Version: 1.1.0
+Version: 1.1.1
 Summary: Flake8 plugin enforcing Elegant Objects principles: no -er naming, no null, no getters/setters, immutable objects
 Project-URL: Homepage, https://github.com/AntonProkopyev/flake8-elegant-objects
 Project-URL: Repository, https://github.com/AntonProkopyev/flake8-elegant-objects.git

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/flake8_elegant_objects/__init__.py

@@ -17,7 +17,7 @@ class ElegantObjectsPlugin:
     """Flake8 plugin to check for Elegant Objects violations."""
 
     name = "flake8-elegant-objects"
-    version = "1.0.0"
+    version = "1.1.1"
 
     def __init__(self, tree: ast.AST) -> None:
         self.tree = tree

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/flake8_elegant_objects/no_constructor_code.py

@@ -39,7 +39,21 @@ class NoConstructorCode:
                         violations.extend(violation(stmt, ErrorCodes.EO006))
                 else:
                     violations.extend(violation(stmt, ErrorCodes.EO006))
+            elif isinstance(stmt, ast.Expr) and isinstance(stmt.value, ast.Call):
+                if self._is_super_call(stmt.value):
+                    continue
+                violations.extend(violation(stmt, ErrorCodes.EO006))
             elif not isinstance(stmt, ast.Pass):  # Allow pass statements
                 violations.extend(violation(stmt, ErrorCodes.EO006))
 
         return violations
+
+    def _is_super_call(self, call: ast.Call) -> bool:
+        """Check if a call is a super() call."""
+        if isinstance(call.func, ast.Name) and call.func.id == "super":
+            return True
+        if isinstance(call.func, ast.Attribute) and isinstance(
+            call.func.value, ast.Call
+        ):
+            return self._is_super_call(call.func.value)
+        return False

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "flake8-elegant-objects"
-version = "1.1.0"
+version = "1.1.1"
 description = "Flake8 plugin enforcing Elegant Objects principles: no -er naming, no null, no getters/setters, immutable objects"
 readme = "README.md"
 license = { text = "MIT" }

{flake8_elegant_objects-1.1.0 → flake8_elegant_objects-1.1.1}/tests/test_no_constructor_code.py

@@ -127,6 +127,67 @@ class DataContainer:
         self.items = items
         self.count = len(items)  # This should trigger violation
         self.first = items[0] if items else None  # This should trigger violation
+"""
+        violations = self._check_code(code)
+        assert len(violations) == 2
+        assert all("EO006" in v for v in violations)
+
+    def test_valid_constructor_with_super_call(self) -> None:
+        """Test that super() calls in constructors are allowed."""
+        code = """
+class Parent:
+    def __init__(self, name):
+        self.name = name
+
+class Child(Parent):
+    def __init__(self, name, age):
+        super().__init__(name)
+        self.age = age
+
+class GrandChild(Child):
+    def __init__(self, name, age, grade):
+        super().__init__(name, age)
+        self.grade = grade
+"""
+        violations = self._check_code(code)
+        assert len(violations) == 0
+
+    def test_valid_constructor_with_super_call_variations(self) -> None:
+        """Test various forms of super() calls are allowed."""
+        code = """
+class Base:
+    def __init__(self):
+        pass
+
+class Derived(Base):
+    def __init__(self):
+        super().__init__()
+
+class DerivedWithArgs(Base):
+    def __init__(self, value):
+        super().__init__()
+        self.value = value
+
+class ExplicitSuper(Base):
+    def __init__(self):
+        super(ExplicitSuper, self).__init__()
+"""
+        violations = self._check_code(code)
+        assert len(violations) == 0
+
+    def test_constructor_with_super_and_invalid_code(self) -> None:
+        """Test that super() calls are allowed but other code violations are still detected."""
+        code = """
+class Parent:
+    def __init__(self, name):
+        self.name = name
+
+class Child(Parent):
+    def __init__(self, name, items):
+        super().__init__(name)
+        self.items = items
+        self.count = len(items)  # This should trigger violation
+        print("Child initialized")  # This should trigger violation
 """
         violations = self._check_code(code)
         assert len(violations) == 2