flagsmith-sql-flag-engine 0.1.1__tar.gz → 0.1.3__tar.gz

{flagsmith_sql_flag_engine-0.1.1 → flagsmith_sql_flag_engine-0.1.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: flagsmith-sql-flag-engine
-Version: 0.1.1
+Version: 0.1.3
 Summary: SQL translator for Flagsmith segment predicates.
 Author: Flagsmith
 Author-email: Flagsmith <engineering@flagsmith.com>

{flagsmith_sql_flag_engine-0.1.1 → flagsmith_sql_flag_engine-0.1.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "flagsmith-sql-flag-engine"
-version = "0.1.1"
+version = "0.1.3"
 description = "SQL translator for Flagsmith segment predicates."
 readme = "README.md"
 authors = [{ name = "Flagsmith", email = "engineering@flagsmith.com" }]

{flagsmith_sql_flag_engine-0.1.1 → flagsmith_sql_flag_engine-0.1.3}/src/flagsmith_sql_flag_engine/translator.py

@@ -432,22 +432,15 @@ def translate_condition(cond: SegmentCondition, ctx: TranslateContext) -> str |
             # Engine: float() on the threshold raises → returns False.
             return "FALSE"
         threshold = float(threshold_lit)
-        identity: dict[str, object] = ctx.evaluation_context.get("identity") or {}  # type: ignore[assignment]
         kind = classification.kind
         if not prop:
-            # Implicit `$.identity.key` — engine returns False when no
-            # identity, or when the identity lacks `key`. The engine
-            # never synthesises one from env+identifier.
-            if not identity.get("key"):
-                return "FALSE"
+            # In traditional engine implementations, this branch implies
+            # an identity-less context, which makes no sense for the SQL engine.
+            # Assume identity key.
             value_expr = ctx.dialect.cast_string(ctx.identity_key_expr)
         elif kind == "key":
-            if not identity.get("key"):
-                return "FALSE"
             value_expr = ctx.dialect.cast_string(ctx.jsonpath_expr("$.identity.key"))
         elif kind == "identifier":
-            if not identity.get("identifier"):
-                return "FALSE"
             value_expr = ctx.dialect.cast_string(ctx.jsonpath_expr("$.identity.identifier"))
         elif kind == "identity_object":
             # PERCENTAGE_SPLIT on `$.identity` — the whole dict. Engine
@@ -463,13 +456,18 @@ def translate_condition(cond: SegmentCondition, ctx: TranslateContext) -> str |
             # future work and let the caller fall back to the engine.
             return None
         else:
-            # Plain trait key, or `$.identity.traits.<X>` rewritten to
-            # the bare key. Hash subject pulls from `i.traits:"<key>"`
-            # per row.
-            traits = identity.get("traits") or {}
-            if not isinstance(traits, dict) or prop not in traits:
-                return "FALSE"
-            value_expr = ctx.dialect.cast_string(ctx.trait_path(prop))
+            # Plain trait key, or `$.identity.traits.<X>` rewritten to the
+            # bare key. Hash the per-row trait value from `i.traits:"<key>"`.
+            # A row missing the trait has no value to bucket, so it cannot
+            # match — mirroring the engine's `context_value is None -> False`.
+            trait_sql = ctx.trait_path(prop)
+            split = _percentage_split_expr(
+                ctx,
+                ctx.segment_key,
+                ctx.dialect.cast_string(trait_sql),
+                threshold,
+            )
+            return f"({trait_sql} IS NOT NULL AND {split})"
         return _percentage_split_expr(ctx, ctx.segment_key, value_expr, threshold)
 
     if not prop: