fixtureqa 0.8.2__tar.gz → 0.8.3__tar.gz

{fixtureqa-0.8.2/fixtureqa.egg-info → fixtureqa-0.8.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fixtureqa
-Version: 0.8.2
+Version: 0.8.3
 Summary: FIXture — FIX Protocol Testing Tool
 Requires-Python: >=3.10
 License-File: LICENSE

{fixtureqa-0.8.2 → fixtureqa-0.8.3}/fixture/api/routers/sessions.py

@@ -127,7 +127,17 @@ async def create_session(body: SessionConfigRequest, sm: SM, us: US, user: Curre
         try:
             await sm.start_session(session_id)
         except Exception as e:
-            raise HTTPException(status_code=500, detail=f"Session added but failed to start: {e}")
+            # Creation is atomic: roll back the just-added session so a failed
+            # auto-start doesn't leave an orphan persisted. (Pre-0.8.2 a missing
+            # tzdata raised a TimeZone error here while the session stayed
+            # registered; the UI surfaced a failure, users retried, and the
+            # orphans piled up as duplicates.) The config is reported in the
+            # error so the user can fix and re-add.
+            try:
+                await sm.remove_session(session_id)
+            except Exception:
+                pass  # best-effort rollback; surface the original start failure
+            raise HTTPException(status_code=500, detail=f"Failed to start session: {e}")
 
     return _session_response(sm, session_id, _owner_store(us, user))
 

{fixtureqa-0.8.2 → fixtureqa-0.8.3/fixtureqa.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fixtureqa
-Version: 0.8.2
+Version: 0.8.3
 Summary: FIXture — FIX Protocol Testing Tool
 Requires-Python: >=3.10
 License-File: LICENSE

{fixtureqa-0.8.2 → fixtureqa-0.8.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "fixtureqa"
-version = "0.8.2"
+version = "0.8.3"
 description = "FIXture — FIX Protocol Testing Tool"
 requires-python = ">=3.10"
 dependencies = [

{fixtureqa-0.8.2 → fixtureqa-0.8.3}/tests/test_sessions.py

@@ -53,6 +53,23 @@ def test_create_session(authed):
     assert "session_id" in body
 
 
+def test_failed_autostart_rolls_back(authed):
+    """A failed auto-start must not leave an orphan persisted session.
+
+    Regression: pre-0.8.2 a missing tzdata raised a TimeZone error while the
+    session stayed registered; retries piled up duplicates. An invalid TimeZone
+    passes config validation (we don't pre-check the zone) but fails when the
+    engine builds the schedule on start — so it exercises the rollback path.
+    """
+    client, _ = authed
+    cfg = _ini(9876)
+    cfg["auto_start"] = True
+    cfg["time_zone"] = "Not/AZone"  # invalid IANA zone -> schedule build fails on start
+    resp = client.post("/api/sessions/", json=cfg)
+    assert resp.status_code == 500
+    assert client.get("/api/sessions/").json() == []   # rolled back — no orphan
+
+
 def _wait_persisted(sm, sid: str, n: int, timeout: float = 5.0) -> None:
     from fixture.core.message_store import MessageStore
     store = MessageStore(sid, sm.message_writer)