firefighter-incident 0.0.24__tar.gz → 0.0.26__tar.gz

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: firefighter-incident
-Version: 0.0.24
+Version: 0.0.26
 Summary: Incident Management tool made for Slack using Django
 Project-URL: Repository, https://github.com/ManoManoTech/firefighter-incident
 Project-URL: Documentation, https://manomanotech.github.io/firefighter-incident/latest/

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '0.0.24'
-__version_tuple__ = version_tuple = (0, 0, 24)
+__version__ = version = '0.0.26'
+__version_tuple__ = version_tuple = (0, 0, 26)
 
 __commit_id__ = commit_id = None

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/incidents/models/impact.py

@@ -40,29 +40,29 @@ class LevelChoices(models.TextChoices):
     @property
     def priority(self) -> int:
         """Send level choice priority ."""
-        priority_mapping = {
-            self.HIGHEST: 1,
-            self.HIGH: 2,
-            self.MEDIUM: 3,
-            self.LOW: 4,
-            self.LOWEST: 5,
-            self.NONE: 6,
+        priority_mapping: dict[str, int] = {
+            LevelChoices.HIGHEST: 1,
+            LevelChoices.HIGH: 2,
+            LevelChoices.MEDIUM: 3,
+            LevelChoices.LOW: 4,
+            LevelChoices.LOWEST: 5,
+            LevelChoices.NONE: 6,
         }
-        return priority_mapping.get(self, 6)  # type: ignore[call-overload]
+        return priority_mapping.get(self.value, 6)
 
     @property
     def emoji(self) -> str:
         """Send emoji un function of priority."""
         none_emoji = ""
-        emoji_mapping = {
-            self.HIGHEST: "⏫",
-            self.HIGH: "🔼",
-            self.MEDIUM: "➡️",
-            self.LOW: "🔽",
-            self.LOWEST: "⏬",
-            self.NONE: none_emoji,
+        emoji_mapping: dict[str, str] = {
+            LevelChoices.HIGHEST: "⏫",
+            LevelChoices.HIGH: "🔼",
+            LevelChoices.MEDIUM: "➡️",
+            LevelChoices.LOW: "🔽",
+            LevelChoices.LOWEST: "⏬",
+            LevelChoices.NONE: none_emoji,
         }
-        return emoji_mapping.get(self, none_emoji)  # type: ignore[call-overload]
+        return emoji_mapping.get(self.value, none_emoji)
 
 
 class ImpactLevel(models.Model):

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/jira_app/service_postmortem.py

@@ -229,7 +229,7 @@ class JiraPostMortemService:
         - Zoho desk ticket (customfield_10896)
         - Zendesk ticket (customfield_10895)
         - Seller Contract ID (customfield_10908)
-        - Platform (customfield_10201)
+        - Platforms (customfield_10201) - first platform from list
         - Business Impact (customfield_10936)
 
         Args:
@@ -264,9 +264,10 @@ class JiraPostMortemService:
             fields["customfield_10908"] = str(seller_contract_id)
 
         # Platform - customfield_10201 (option field)
-        platform = custom_fields.get("platform")
-        if platform:
-            # Remove "platform-" prefix if present
+        platforms = custom_fields.get("platforms", [])
+        if platforms:
+            # Extract first platform and remove "platform-" prefix if present
+            platform = platforms[0] if isinstance(platforms, list) else platforms
             platform_value = platform.replace("platform-", "") if isinstance(platform, str) else platform
             fields["customfield_10201"] = {"value": platform_value}
 

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/pagerduty/models.py

@@ -331,13 +331,13 @@ class PagerDutySchedule(models.Model):
     pagerduty_url = models.URLField(max_length=256, null=True, blank=True)
     # TODO: Add more fields
 
-    escalation_policies = models.ManyToManyField(
+    escalation_policies: models.ManyToManyField[PagerDutyEscalationPolicy, PagerDutyEscalationPolicy] = models.ManyToManyField(
         PagerDutyEscalationPolicy, related_name="pagerduty_schedule_set", blank=True
     )
-    users = models.ManyToManyField(
+    users: models.ManyToManyField[PagerDutyUser, PagerDutyUser] = models.ManyToManyField(
         PagerDutyUser, related_name="pagerduty_schedule_set", blank=True
     )
-    teams = models.ManyToManyField(
+    teams: models.ManyToManyField[PagerDutyTeam, PagerDutyTeam] = models.ManyToManyField(
         PagerDutyTeam, related_name="pagerduty_schedule_set", blank=True
     )
 

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/raid/service.py

@@ -24,6 +24,10 @@ error_jira_ticket_creation = "Could not create Jira ticket"
 
 
 def check_issue_id(issue: JiraObject, title: str, reporter: str) -> int | str:
+    """Check and return the issue ID from a JiraObject.
+
+    Raises JiraAPIError if the issue ID is missing or invalid.
+    """
     issue_id = issue.get("id")
     if issue_id is None:
         logger.error(

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/raid/types.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import TypedDict
+from typing import NotRequired, TypedDict
 
 _JiraId = int | str
 _Key = str
@@ -12,8 +12,8 @@ _BusinessImpact = str
 
 
 class JiraObject(TypedDict):
-    id: _JiraId
-    key: _Key
+    id: NotRequired[_JiraId]
+    key: NotRequired[_Key]
     assignee_id: _AssigneeId
     reporter_id: _ReporterId
     description: _Description

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter/slack/views/modals/closure_reason.py

@@ -115,20 +115,25 @@ class ClosureReasonModal(IncidentSelectableModalMixin, SlackModal):
         self, ack: Ack, body: dict[str, Any], incident: Incident, user: User
     ) -> bool | None:
         """Handle the closure reason modal submission."""
-        # Early validation: Check if incident can be closed BEFORE calling ack()
-        # This validation happens BEFORE ack() so we can display errors in the modal
-        can_close, reasons = incident.can_be_closed
-        if not can_close:
-            # Build error message from reasons
-            error_messages = [reason[1] for reason in reasons]
-            error_text = "\n".join([f"• {msg}" for msg in error_messages])
-            ack(
-                response_action="errors",
-                errors={
-                    "closure_message": f"Cannot close this incident:\n{error_text}"
-                }
-            )
-            return False
+        # For early closure (OPEN/INVESTIGATING), we bypass normal workflow checks
+        # For normal closure (MITIGATED/POST_MORTEM), we must validate key events
+        current_status = incident.status
+        is_early_closure = current_status.value in {IncidentStatus.OPEN, IncidentStatus.INVESTIGATING}
+
+        if not is_early_closure:
+            # Normal closure path - validate that incident can be closed
+            can_close, reasons = incident.can_be_closed
+            if not can_close:
+                # Build error message from reasons
+                error_messages = [reason[1] for reason in reasons]
+                error_text = "\n".join([f"• {msg}" for msg in error_messages])
+                ack(
+                    response_action="errors",
+                    errors={
+                        "closure_message": f"Cannot close this incident:\n{error_text}"
+                    }
+                )
+                return False
 
         # Clear ALL modals in the stack (not just this one)
         # This ensures the underlying "Update Status" modal is also closed

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/firefighter_tests/test_jira_app/test_postmortem_service.py

@@ -261,7 +261,7 @@ class TestJiraPostMortemService:
                 "zendesk_ticket_id": "12345",
                 "zoho_desk_ticket_id": "67890",
                 "seller_contract_id": "98765",
-                "platform": "platform-FR",
+                "platforms": ["platform-FR"],
                 "environments": ["PRD", "STG"],
             },
         )
@@ -404,7 +404,7 @@ class TestJiraPostMortemService:
             _status=IncidentStatus.POST_MORTEM,
             created_by=user,
             custom_fields={
-                "platform": "platform-DE",
+                "platforms": ["platform-DE"],
             },
         )
 

{firefighter_incident-0.0.24 → firefighter_incident-0.0.26}/pyproject.toml

@@ -401,7 +401,6 @@ warn_no_return = true
 disallow_subclassing_any = false
 implicit_reexport = true
 warn_return_any = false
-warn_unused_ignores = false
 # XXX More aggresive type checking
 
 [[tool.mypy.overrides]]