fiddler-client 3.3.0.dev1__tar.gz → 3.3.1__tar.gz

{fiddler_client-3.3.0.dev1/fiddler_client.egg-info → fiddler_client-3.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: fiddler-client
-Version: 3.3.0.dev1
+Version: 3.3.1
 Summary: Python client for Fiddler Platform
 Home-page: https://fiddler.ai
 Author: Fiddler Labs

fiddler_client-3.3.1/fiddler/VERSION

@@ -0,0 +1 @@
+3.3.1

{fiddler_client-3.3.0.dev1 → fiddler_client-3.3.1}/fiddler/decorators.py

@@ -39,7 +39,7 @@ def handle_api_error(func: _WrappedFuncType) -> _WrappedFuncType:
                 error_resp = ErrorResponse(**e.response.json())
             except requests.JSONDecodeError:
                 raise HttpError(
-                    message=f'Invalid response content-type - {e.response.content}'
+                    message=f"Invalid response content-type - {e.response.content}"  # type: ignore
                 )
 
             if status_code == HTTPStatus.CONFLICT:

{fiddler_client-3.3.0.dev1 → fiddler_client-3.3.1}/fiddler/entities/alert_rule.py

@@ -5,6 +5,8 @@ from datetime import datetime
 from typing import Any, Iterator
 from uuid import UUID
 
+from pydantic import ValidationError
+
 from fiddler.constants.alert_rule import AlertCondition, BinSize, CompareTo, Priority
 from fiddler.decorators import handle_api_error
 from fiddler.entities.base import BaseEntity
@@ -276,14 +278,18 @@ class AlertRule(
 
         :return: NotificationConfig object
         """
-        payload: dict[str, Any] = {}
-        if emails is not None:
-            payload['emails'] = emails
-        if pagerduty_services is not None:
-            payload['pagerduty_services'] = pagerduty_services
-            payload['pagerduty_severity'] = pagerduty_severity
-        if webhooks is not None:
-            payload['webhooks'] = webhooks
+
+        # Validating input
+        try:
+            payload: dict[str, Any] = NotificationConfig(
+                emails=emails,
+                pagerduty_services=pagerduty_services,
+                pagerduty_severity=pagerduty_severity,
+                webhooks=webhooks,
+            ).dict()
+        except ValidationError as e:
+            logger.exception('Invalid input: The format of input is not correct')
+            raise e
         response = self._client().patch(
             url=self._get_notification_url(id_=self.id),
             data=payload,

{fiddler_client-3.3.0.dev1 → fiddler_client-3.3.1}/fiddler/tests/apis/test_alert_rule.py

@@ -5,6 +5,7 @@ from uuid import UUID
 
 import pytest
 import responses
+from pydantic import ValidationError
 
 from fiddler.constants.alert_rule import AlertCondition, BinSize, CompareTo, Priority
 from fiddler.entities.alert_rule import AlertRule
@@ -349,12 +350,31 @@ def test_set_notifications() -> None:
     assert json.loads(resp.calls[0].request.body) == {
         'emails': TEST_EMAILS,
         'webhooks': TEST_WEBHOOKS,
+        'pagerduty_services': None,
+        'pagerduty_severity': None,
     }
     assert notifications == NotificationConfig(
         **ALERT_NOTIFICATION_API_RESPONSE_200['data']
     )
 
 
+@responses.activate
+def test_set_notifications_invalid_input(caplog) -> None:
+    responses.get(
+        url=f'{URL}/v3/alert-rules/{ALERT_RULE_ID}',
+        json=API_RESPONSE_200,
+    )
+
+    alert_rule = AlertRule.get(id_=ALERT_RULE_ID)
+
+    with pytest.raises(ValidationError):
+        alert_rule.set_notification_config(
+            emails=TEST_EMAILS[0],
+            webhooks=TEST_WEBHOOKS,
+        )
+    assert 'Invalid input: The format of input is not correct' in caplog.messages[0]
+
+
 @responses.activate
 def test_get_notifications() -> None:
     responses.get(

{fiddler_client-3.3.0.dev1 → fiddler_client-3.3.1}/fiddler/tests/test_logger.py

@@ -6,7 +6,7 @@ from fiddler.utils.logger import set_logging
 
 def test_set_logging() -> None:
     app_logger = logging.getLogger(LOGGER_NAME)
-    assert len(app_logger.handlers) == 0
+    assert len(app_logger.handlers) == 2
 
     set_logging(level=logging.ERROR)
-    assert len(app_logger.handlers) == 1
+    assert len(app_logger.handlers) == 3

{fiddler_client-3.3.0.dev1 → fiddler_client-3.3.1/fiddler_client.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: fiddler-client
-Version: 3.3.0.dev1
+Version: 3.3.1
 Summary: Python client for Fiddler Platform
 Home-page: https://fiddler.ai
 Author: Fiddler Labs

fiddler_client-3.3.0.dev1/fiddler/VERSION

@@ -1 +0,0 @@
-3.3.0.dev1