ffmpeg-normalize 1.37.8__tar.gz → 1.38.0__tar.gz

{ffmpeg_normalize-1.37.8 → ffmpeg_normalize-1.38.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ffmpeg-normalize
-Version: 1.37.8
+Version: 1.38.0
 Summary: Normalize audio via ffmpeg
 Keywords: ffmpeg,normalize,audio
 Author: Werner Robitza
@@ -64,6 +64,8 @@ This program normalizes media files to a certain loudness level using the EBU R1
 
 ## 🆕 What's New
 
+- Version 1.38.0 writes the normalized output  directly to the destination without using temporary files
+
 - Version 1.36.0 introduces **presets** with `--preset`! Save and reuse your favorite normalization configurations for different use cases. Comes with three built-in presets: `podcast` (AES standard), `music` (RMS-based batch normalization), and `streaming-video` (video content). Create custom presets too!
 
     Example:

{ffmpeg_normalize-1.37.8 → ffmpeg_normalize-1.38.0}/README.md

@@ -33,6 +33,8 @@ This program normalizes media files to a certain loudness level using the EBU R1
 
 ## 🆕 What's New
 
+- Version 1.38.0 writes the normalized output  directly to the destination without using temporary files
+
 - Version 1.36.0 introduces **presets** with `--preset`! Save and reuse your favorite normalization configurations for different use cases. Comes with three built-in presets: `podcast` (AES standard), `music` (RMS-based batch normalization), and `streaming-video` (video content). Create custom presets too!
 
     Example:

{ffmpeg_normalize-1.37.8 → ffmpeg_normalize-1.38.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "uv_build"
 
 [project]
 name = "ffmpeg-normalize"
-version = "1.37.8"
+version = "1.38.0"
 description = "Normalize audio via ffmpeg"
 readme = "README.md"
 license = "MIT"

{ffmpeg_normalize-1.37.8 → ffmpeg_normalize-1.38.0}/src/ffmpeg_normalize/__main__.py

@@ -1,6 +1,9 @@
 from __future__ import annotations
 
 import argparse
+
+# Import version from package
+import importlib.metadata
 import json
 import logging
 import os
@@ -15,9 +18,6 @@ from ._ffmpeg_normalize import NORMALIZATION_TYPES, FFmpegNormalize
 from ._logger import setup_cli_logger
 from ._presets import PresetManager
 
-# Import version from package
-import importlib.metadata
-
 __version__ = importlib.metadata.version("ffmpeg-normalize")
 
 _logger = logging.getLogger(__name__)
@@ -42,6 +42,7 @@ def create_parser() -> argparse.ArgumentParser:
               - `TMP` / `TEMP` / `TMPDIR`
                     Sets the path to the temporary directory in which files are
                     stored before being moved to the final output directory.
+                    Only valid for ReplayGain and when the input file == output file.
                     Note: You need to use full paths.
 
               - `FFMPEG_PATH`

{ffmpeg_normalize-1.37.8 → ffmpeg_normalize-1.38.0}/src/ffmpeg_normalize/_media_file.py

@@ -4,8 +4,8 @@ import logging
 import os
 import re
 import shlex
-from shutil import move, rmtree
-from tempfile import mkdtemp
+from shutil import rmtree
+from tempfile import mkdtemp, mkstemp
 from typing import TYPE_CHECKING, Iterable, Iterator, Literal, TypedDict, Union
 
 from mutagen.id3 import ID3, TXXX
@@ -297,14 +297,14 @@ class MediaFile:
                 f"Batch mode: Skipping first pass (already completed), using batch reference = {batch_reference:.2f}"
             )
 
-        # for second pass, create a temp file
-        temp_dir = mkdtemp()
-        self.temp_file = os.path.join(temp_dir, f"out.{self.output_ext}")
+        temp_dir = None
 
         if self.ffmpeg_normalize.replaygain:
             _logger.debug(
                 "ReplayGain mode: Second pass will run with temporary file to get stats."
             )
+            temp_dir = mkdtemp()
+            self.temp_file = os.path.join(temp_dir, f"out.{self.output_ext}")
             self.output_file = self.temp_file
 
         # run the second pass as a whole.
@@ -322,7 +322,7 @@ class MediaFile:
                 pass
 
         # remove temp dir; this will remove the temp file as well if it has not been renamed (e.g. for replaygain)
-        if os.path.exists(temp_dir):
+        if temp_dir and os.path.exists(temp_dir):
             rmtree(temp_dir, ignore_errors=True)
 
         # This will use stats from ebu_pass2 if available (from the main second pass),
@@ -836,39 +836,44 @@ class MediaFile:
             yield 100
             return
 
-        # track temp_dir for cleanup
-        temp_dir = None
-        temp_file = None
+        is_in_place_overwrite = os.path.realpath(self.input_file) == os.path.realpath(
+            self.output_file
+        )
 
-        # special case: if output is a null device, write directly to it
-        if self.output_file == os.devnull:
-            cmd.append(self.output_file)
-        else:
-            temp_dir = mkdtemp()
-            temp_file = os.path.join(temp_dir, f"out.{self.output_ext}")
+        temp_file: Union[str, None] = None
+        if is_in_place_overwrite:
+            # need to create a temporary file because we cannot override
+            # the same input file
+            output_dir = os.path.dirname(self.output_file) or "."
+            fd, temp_file = mkstemp(
+                suffix=f".{self.output_ext}",
+                prefix=f".{os.path.splitext(os.path.basename(self.output_file))[0]}.",
+                dir=output_dir,
+            )
+            os.close(fd)
+            _logger.debug(
+                f"Output file is the same as the input file, "
+                f"encoding to temporary file {temp_file} first"
+            )
             cmd.append(temp_file)
+        else:
+            cmd.append(self.output_file)
 
         cmd_runner = CommandRunner()
         try:
             yield from cmd_runner.run_ffmpeg_command(cmd)
         except Exception as e:
             _logger.error(f"Error while running command {shlex.join(cmd)}! Error: {e}")
+            if temp_file and os.path.exists(temp_file):
+                os.remove(temp_file)
             raise e
         else:
-            # only move the temp file if it's not a null device and ReplayGain is not enabled!
-            if (
-                self.output_file != os.devnull
-                and temp_file
-                and not self.ffmpeg_normalize.replaygain
-            ):
+            # for in-place normalization, move the finished temp file over the input
+            if temp_file:
                 _logger.debug(
                     f"Moving temporary file from {temp_file} to {self.output_file}"
                 )
-                move(temp_file, self.output_file)
-        finally:
-            # clean up temp directory if it was created
-            if temp_dir and os.path.exists(temp_dir):
-                rmtree(temp_dir, ignore_errors=True)
+                os.replace(temp_file, self.output_file)
 
         output = cmd_runner.get_output()
         # in the second pass, we do not normalize stream-by-stream, so we set the stats based on the