fastled 1.4.15__tar.gz → 1.4.17__tar.gz

{fastled-1.4.15 → fastled-1.4.17}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.4.15
+Version: 1.4.17
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies

{fastled-1.4.15 → fastled-1.4.17}/src/fastled/__version__.py

@@ -1,6 +1,6 @@
 # IMPORTANT! There's a bug in github which will REJECT any version update
 # that has any other change in the repo. Please bump the version as the
 # ONLY change in a commit, or else the pypi update and the release will fail.
-__version__ = "1.4.15"
+__version__ = "1.4.17"
 
 __version_url_latest__ = "https://raw.githubusercontent.com/zackees/fastled-wasm/refs/heads/main/src/fastled/__version__.py"

{fastled-1.4.15 → fastled-1.4.17}/src/fastled/live_client.py

@@ -60,13 +60,15 @@ class LiveClient:
 
     def url(self) -> str:
         """Get the URL of the server."""
+        from fastled.settings import SERVER_PORT
+
         if isinstance(self.host, CompileServer):
             return self.host.url()
         if self.host is None:
             import warnings
 
             warnings.warn("TODO: use the actual host.")
-            return "http://localhost:9021"
+            return f"http://localhost:{SERVER_PORT}"
         return self.host
 
     @property

{fastled-1.4.15 → fastled-1.4.17}/src/fastled/playwright/playwright_browser.py

@@ -369,8 +369,27 @@ class PlaywrightBrowser:
                     print(f"[PYTHON] Could not get browser info: {e}")
 
             except Exception as e:
-                print(f"[PYTHON] Error in browser tracking: {e}")
-                continue
+                error_message = str(e)
+                # Check if the error indicates the browser/page has been closed
+                if any(
+                    keyword in error_message.lower()
+                    for keyword in [
+                        "target page",
+                        "context",
+                        "browser has been closed",
+                        "page.evaluate",
+                        "browser closed",
+                        "target closed",
+                    ]
+                ):
+                    print(
+                        "[PYTHON] Browser has been closed, shutting down gracefully..."
+                    )
+                    self._should_exit.set()
+                    break
+                else:
+                    print(f"[PYTHON] Error in browser tracking: {e}")
+                    continue
 
     async def wait_for_close(self) -> None:
         """Wait for the browser to be closed."""
@@ -391,6 +410,9 @@ class PlaywrightBrowser:
 
     async def close(self) -> None:
         """Close the Playwright browser."""
+        # Signal all tracking loops to exit
+        self._should_exit.set()
+
         if self.page:
             await self.page.close()
             self.page = None

{fastled-1.4.15 → fastled-1.4.17}/src/fastled/settings.py

@@ -8,6 +8,11 @@ IS_ARM: bool = "arm" in MACHINE or "aarch64" in MACHINE
 PLATFORM_TAG: str = "-arm64" if IS_ARM else ""
 
 
+def _is_running_under_github_actions() -> bool:
+    """Detect if we're running under github actions."""
+    return "GITHUB_ACTIONS" in os.environ
+
+
 def _is_running_under_pytest() -> bool:
     """Detect if we're running under pytest."""
     # Check if pytest is in the loaded modules
@@ -25,7 +30,7 @@ def _get_container_name() -> str:
     """Get the appropriate container name based on runtime context."""
     base_name = "fastled-wasm-container"
 
-    if _is_running_under_pytest():
+    if not _is_running_under_github_actions() and _is_running_under_pytest():
         # Use test container name when running under pytest
         return f"{base_name}-test{PLATFORM_TAG}"
     else:
@@ -35,7 +40,7 @@ def _get_container_name() -> str:
 
 def _get_server_port() -> int:
     """Get the appropriate server port based on runtime context."""
-    if _is_running_under_pytest():
+    if not _is_running_under_github_actions() and _is_running_under_pytest():
         # Use test port when running under pytest to avoid conflicts
         return 9022
     else:
@@ -48,11 +53,7 @@ DEFAULT_URL = str(os.environ.get("FASTLED_URL", "https://fastled.onrender.com"))
 SERVER_PORT = _get_server_port()
 
 IMAGE_NAME = "niteris/fastled-wasm"
-DEFAULT_CONTAINER_NAME = (
-    "fastled-wasm-container-test"
-    if _is_running_under_pytest()
-    else "fastled-wasm-container"
-)
+DEFAULT_CONTAINER_NAME = _get_container_name()
 # IMAGE_TAG = "latest"
 
 DOCKER_FILE = (

{fastled-1.4.15 → fastled-1.4.17}/src/fastled/web_compile.py

@@ -317,8 +317,22 @@ def web_compile(
                     )
                     if has_embedded_status:
                         if embedded_status is not None and embedded_status != 200:
-                            print(
-                                f"Warning: libfastled compilation failed with embedded status {embedded_status}"
+                            msg = f"Warning: libfastled compilation failed with embedded status {embedded_status}"
+                            # this is a critical error
+                            stdout = libfastled_response.content
+                            if stdout is not None:
+                                stdout = (
+                                    stdout.decode("utf-8", errors="replace")
+                                    + "\n"
+                                    + msg
+                                )
+                            else:
+                                stdout = msg
+                            return CompileResult(
+                                success=False,
+                                stdout=msg,
+                                hash_value=None,
+                                zip_bytes=b"",
                             )
                             # Continue with sketch compilation even if libfastled fails
                         elif embedded_status is None:

{fastled-1.4.15 → fastled-1.4.17}/src/fastled.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.4.15
+Version: 1.4.17
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies

{fastled-1.4.15 → fastled-1.4.17}/tests/unit/test_cli.py

@@ -24,12 +24,13 @@ class MainTester(unittest.TestCase):
             COMMAND,
             shell=True,
             capture_output=True,
-            text=True,
             check=False,
         )
         ok = cp.returncode == 0
         if not ok:
-            error_msg = "stdout:\n" + cp.stdout + "\nstderr:\n" + cp.stderr
+            stdout = cp.stdout.decode("utf-8", errors="replace")
+            stderr = cp.stderr.decode("utf-8", errors="replace")
+            error_msg = "stdout:\n" + stdout + "\nstderr:\n" + stderr
             # self.assertEqual(0, cp.returncode, "Command failed: " + error_msg)
             self.fail(f"Command failed with return code {cp.returncode}:\n{error_msg}")