fastled 1.4.12__tar.gz → 1.4.16__tar.gz

{fastled-1.4.12 → fastled-1.4.16}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.4.12
+Version: 1.4.16
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies

{fastled-1.4.12 → fastled-1.4.16}/pyproject.toml

@@ -26,6 +26,7 @@ dependencies = [
     "livereload",
     "disklru>=2.0.4",
     "playwright>=1.40.0",
+
 ]
 
 dynamic = ["version"]

fastled-1.4.16/requirements.docker.txt

@@ -0,0 +1 @@
+fastled-wasm-server>=1.1.22

{fastled-1.4.12 → fastled-1.4.16}/src/fastled/__version__.py

@@ -1,6 +1,6 @@
 # IMPORTANT! There's a bug in github which will REJECT any version update
 # that has any other change in the repo. Please bump the version as the
 # ONLY change in a commit, or else the pypi update and the release will fail.
-__version__ = "1.4.12"
+__version__ = "1.4.16"
 
 __version_url_latest__ = "https://raw.githubusercontent.com/zackees/fastled-wasm/refs/heads/main/src/fastled/__version__.py"

{fastled-1.4.12 → fastled-1.4.16}/src/fastled/docker_manager.py

@@ -980,6 +980,7 @@ class DockerManager:
     def purge(self, image_name: str) -> None:
         """
         Remove all containers and images associated with the given image name.
+        Also removes FastLED containers by name pattern (including test containers).
 
         Args:
             image_name: The name of the image to purge (without tag)
@@ -990,8 +991,27 @@ class DockerManager:
         try:
             containers = self.client.containers.list(all=True)
             for container in containers:
+                should_remove = False
+
+                # Check if container uses the specified image
                 if any(image_name in tag for tag in container.image.tags):
-                    print(f"Removing container {container.name}")
+                    should_remove = True
+                    print(
+                        f"Removing container {container.name} (uses image {image_name})"
+                    )
+
+                # Also check for FastLED container name patterns (including test containers)
+                elif any(
+                    pattern in container.name
+                    for pattern in [
+                        "fastled-wasm-container",
+                        "fastled-wasm-container-test",
+                    ]
+                ):
+                    should_remove = True
+                    print(f"Removing FastLED container {container.name}")
+
+                if should_remove:
                     container.remove(force=True)
 
         except Exception as e:

{fastled-1.4.12 → fastled-1.4.16}/src/fastled/playwright/playwright_browser.py

@@ -369,8 +369,27 @@ class PlaywrightBrowser:
                     print(f"[PYTHON] Could not get browser info: {e}")
 
             except Exception as e:
-                print(f"[PYTHON] Error in browser tracking: {e}")
-                continue
+                error_message = str(e)
+                # Check if the error indicates the browser/page has been closed
+                if any(
+                    keyword in error_message.lower()
+                    for keyword in [
+                        "target page",
+                        "context",
+                        "browser has been closed",
+                        "page.evaluate",
+                        "browser closed",
+                        "target closed",
+                    ]
+                ):
+                    print(
+                        "[PYTHON] Browser has been closed, shutting down gracefully..."
+                    )
+                    self._should_exit.set()
+                    break
+                else:
+                    print(f"[PYTHON] Error in browser tracking: {e}")
+                    continue
 
     async def wait_for_close(self) -> None:
         """Wait for the browser to be closed."""
@@ -391,6 +410,9 @@ class PlaywrightBrowser:
 
     async def close(self) -> None:
         """Close the Playwright browser."""
+        # Signal all tracking loops to exit
+        self._should_exit.set()
+
         if self.page:
             await self.page.close()
             self.page = None

fastled-1.4.16/src/fastled/settings.py

@@ -0,0 +1,60 @@
+import os
+import platform
+import sys
+
+FILE_CHANGED_DEBOUNCE_SECONDS = 2.0
+MACHINE = platform.machine().lower()
+IS_ARM: bool = "arm" in MACHINE or "aarch64" in MACHINE
+PLATFORM_TAG: str = "-arm64" if IS_ARM else ""
+
+
+def _is_running_under_pytest() -> bool:
+    """Detect if we're running under pytest."""
+    # Check if pytest is in the loaded modules
+    if "pytest" in sys.modules:
+        return True
+
+    # Check for pytest environment variables
+    if "PYTEST_CURRENT_TEST" in os.environ:
+        return True
+
+    return False
+
+
+def _get_container_name() -> str:
+    """Get the appropriate container name based on runtime context."""
+    base_name = "fastled-wasm-container"
+
+    if _is_running_under_pytest():
+        # Use test container name when running under pytest
+        return f"{base_name}-test{PLATFORM_TAG}"
+    else:
+        # Use regular container name
+        return f"{base_name}{PLATFORM_TAG}"
+
+
+def _get_server_port() -> int:
+    """Get the appropriate server port based on runtime context."""
+    if _is_running_under_pytest():
+        # Use test port when running under pytest to avoid conflicts
+        return 9022
+    else:
+        # Use regular port
+        return 9021
+
+
+CONTAINER_NAME = _get_container_name()
+DEFAULT_URL = str(os.environ.get("FASTLED_URL", "https://fastled.onrender.com"))
+SERVER_PORT = _get_server_port()
+
+IMAGE_NAME = "niteris/fastled-wasm"
+DEFAULT_CONTAINER_NAME = (
+    "fastled-wasm-container-test"
+    if _is_running_under_pytest()
+    else "fastled-wasm-container"
+)
+# IMAGE_TAG = "latest"
+
+DOCKER_FILE = (
+    "https://raw.githubusercontent.com/zackees/fastled-wasm/refs/heads/main/Dockerfile"
+)

{fastled-1.4.12 → fastled-1.4.16}/src/fastled/web_compile.py

@@ -47,10 +47,10 @@ def _check_embedded_http_status(response_content: bytes) -> tuple[bool, int | No
         lines = content_str.strip().split("\n")
         if lines:
             last_line = lines[-1].strip()
-            if last_line.startswith("HTTP_STATUS:"):
-                # Extract the status code
+            if "HTTP_STATUS:" in last_line:
                 try:
-                    status_code = int(last_line.split(":", 1)[1].strip())
+                    right = last_line.split("HTTP_STATUS:")[-1].strip()
+                    status_code = int(right)
                     return True, status_code
                 except (ValueError, IndexError):
                     # Malformed status line
@@ -296,10 +296,20 @@ def web_compile(
 
                 # Check HTTP response status first
                 if libfastled_response.status_code != 200:
-                    print(
-                        f"Warning: libfastled compilation failed with HTTP status {libfastled_response.status_code}"
+                    msg = f"Error: libfastled compilation failed with HTTP status {libfastled_response.status_code}"
+
+                    # Error out here, this is a critical error
+                    stdout = libfastled_response.content
+                    if stdout is not None:
+                        stdout = stdout.decode("utf-8", errors="replace") + "\n" + msg
+                    else:
+                        stdout = msg
+                    return CompileResult(
+                        success=False,
+                        stdout=stdout,
+                        hash_value=None,
+                        zip_bytes=b"",
                     )
-                    # Continue with sketch compilation even if libfastled fails
                 else:
                     # Check for embedded HTTP status in response content
                     has_embedded_status, embedded_status = _check_embedded_http_status(

{fastled-1.4.12 → fastled-1.4.16}/src/fastled.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.4.12
+Version: 1.4.16
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies

{fastled-1.4.12 → fastled-1.4.16}/tests/integration/test_libcompile.py

@@ -231,6 +231,59 @@ void loop() {
                     print(f"   Output size: {len(result.zip_bytes)} bytes")
                     print(f"   Hash: {result.hash_value}")
 
+                    # Step 8: Test that libcompile fails when FastLED source is corrupted
+                    print("\n🔨 Testing libfastled compilation failure...")
+
+                    # Corrupt the FastLED source by adding an error directive
+                    fastled_cpp_path = fastled_dir / "src" / "FastLED.cpp"
+                    if not fastled_cpp_path.exists():
+                        print(f"⚠️  FastLED source file not found: {fastled_cpp_path}")
+                        print("Available files in src:")
+                        for f in (fastled_dir / "src").iterdir():
+                            print(f"  {f.name}")
+                    else:
+                        # Read the original content and append the error directive
+                        original_content = fastled_cpp_path.read_text(encoding="utf-8")
+                        corrupted_content = (
+                            original_content + '\n#error "Should fail"\n'
+                        )
+                        fastled_cpp_path.write_text(corrupted_content, encoding="utf-8")
+                        print(f"✅ Added error directive to {fastled_cpp_path}")
+
+                        # Try to compile libfastled directly via HTTP endpoint - this should fail with 400
+                        print(
+                            "🔨 Attempting libfastled compilation with corrupted source..."
+                        )
+
+                        # Make direct HTTP call to /compile/libfastled endpoint
+                        compile_url = f"{server_impl.url()}/compile/libfastled"
+                        headers = {
+                            "accept": "application/json",
+                            "authorization": "oBOT5jbsO4ztgrpNsQwlmFLIKB",  # Default auth token
+                            "build": BuildMode.QUICK.value.lower(),
+                        }
+
+                        with httpx.Client(timeout=60 * 3) as client:
+                            response = client.post(
+                                compile_url, headers=headers, follow_redirects=True
+                            )
+
+                        self.assertIn(
+                            "HTTP_STATUS: 400",
+                            response.text,
+                            "Should have HTTP_STATUS: 400 in response",
+                        )
+
+                        print(
+                            "✅ libfastled compilation correctly failed with 400 HTTP status!"
+                        )
+                        print("📊 Failed compilation stats:")
+                        print(f"   Response length: {len(response.text)} chars")
+
+                        # Restore the original content for cleanup
+                        fastled_cpp_path.write_text(original_content, encoding="utf-8")
+                        print("✅ Restored original FastLED source content")
+
                 finally:
                     # Clean up server
                     try:

{fastled-1.4.12 → fastled-1.4.16}/tests/unit/test_cli.py

@@ -24,12 +24,13 @@ class MainTester(unittest.TestCase):
             COMMAND,
             shell=True,
             capture_output=True,
-            text=True,
             check=False,
         )
         ok = cp.returncode == 0
         if not ok:
-            error_msg = "stdout:\n" + cp.stdout + "\nstderr:\n" + cp.stderr
+            stdout = cp.stdout.decode("utf-8", errors="replace")
+            stderr = cp.stderr.decode("utf-8", errors="replace")
+            error_msg = "stdout:\n" + stdout + "\nstderr:\n" + stderr
             # self.assertEqual(0, cp.returncode, "Command failed: " + error_msg)
             self.fail(f"Command failed with return code {cp.returncode}:\n{error_msg}")
 

fastled-1.4.12/requirements.docker.txt

@@ -1 +0,0 @@
-fastled-wasm-server>=1.1.21

fastled-1.4.12/src/fastled/settings.py

@@ -1,18 +0,0 @@
-import os
-import platform
-
-FILE_CHANGED_DEBOUNCE_SECONDS = 2.0
-MACHINE = platform.machine().lower()
-IS_ARM: bool = "arm" in MACHINE or "aarch64" in MACHINE
-PLATFORM_TAG: str = "-arm64" if IS_ARM else ""
-CONTAINER_NAME = f"fastled-wasm-container{PLATFORM_TAG}"
-DEFAULT_URL = str(os.environ.get("FASTLED_URL", "https://fastled.onrender.com"))
-SERVER_PORT = 9021
-
-IMAGE_NAME = "niteris/fastled-wasm"
-DEFAULT_CONTAINER_NAME = "fastled-wasm-container"
-# IMAGE_TAG = "latest"
-
-DOCKER_FILE = (
-    "https://raw.githubusercontent.com/zackees/fastled-wasm/refs/heads/main/Dockerfile"
-)