fastled 1.3.39__tar.gz → 1.4.0__tar.gz

{fastled-1.3.39 → fastled-1.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.3.39
+Version: 1.4.0
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies
@@ -81,10 +81,10 @@ For enhanced browser control and automation capabilities, you can install the fu
 $ pip install fastled[full]
 ```
 
-This enables the `--playwright` flag which opens your compiled sketch in a Playwright-controlled browser instead of your system's default browser:
+When installed, FastLED will automatically use Playwright to open your compiled sketch in a controlled browser environment instead of your system's default browser:
 
 ```bash
-$ fastled my_sketch --playwright
+$ fastled my_sketch
 ```
 
 The Playwright browser provides better automation capabilities and is especially useful for:
@@ -94,12 +94,13 @@ The Playwright browser provides better automation capabilities and is especially
 - Persistent browser sessions that stay open until the FastLED process exits
 
 **Key Benefits:**
+- Automatically enabled when `fastled[full]` is installed - no additional flags needed
 - The Playwright browser remains open throughout your development session
 - Automatic cleanup when the FastLED process exits
 - Better control over browser behavior and automation capabilities
 - Consistent behavior across different platforms
 
-If Playwright is not installed and you use the `--playwright` flag, the system will gracefully fall back to your default browser.
+If Playwright is not installed, the system will gracefully fall back to your default browser.
 
 # Install
 

{fastled-1.3.39 → fastled-1.4.0}/README.md

@@ -51,10 +51,10 @@ For enhanced browser control and automation capabilities, you can install the fu
 $ pip install fastled[full]
 ```
 
-This enables the `--playwright` flag which opens your compiled sketch in a Playwright-controlled browser instead of your system's default browser:
+When installed, FastLED will automatically use Playwright to open your compiled sketch in a controlled browser environment instead of your system's default browser:
 
 ```bash
-$ fastled my_sketch --playwright
+$ fastled my_sketch
 ```
 
 The Playwright browser provides better automation capabilities and is especially useful for:
@@ -64,12 +64,13 @@ The Playwright browser provides better automation capabilities and is especially
 - Persistent browser sessions that stay open until the FastLED process exits
 
 **Key Benefits:**
+- Automatically enabled when `fastled[full]` is installed - no additional flags needed
 - The Playwright browser remains open throughout your development session
 - Automatic cleanup when the FastLED process exits
 - Better control over browser behavior and automation capabilities
 - Consistent behavior across different platforms
 
-If Playwright is not installed and you use the `--playwright` flag, the system will gracefully fall back to your default browser.
+If Playwright is not installed, the system will gracefully fall back to your default browser.
 
 # Install
 

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/__init__.py

@@ -95,7 +95,6 @@ class Api:
         no_platformio: bool = False,
     ) -> CompileServer:
         """Uses docker to spawn a compile server from the given name."""
-        from fastled.compile_server import CompileServer
 
         out = CompileServer(
             container_name=container_name,

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/__version__.py

@@ -1,6 +1,6 @@
 # IMPORTANT! There's a bug in github which will REJECT any version update
 # that has any other change in the repo. Please bump the version as the
 # ONLY change in a commit, or else the pypi update and the release will fail.
-__version__ = "1.3.39"
+__version__ = "1.4.0"
 
 __version_url_latest__ = "https://raw.githubusercontent.com/zackees/fastled-wasm/refs/heads/main/src/fastled/__version__.py"

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/args.py

@@ -23,8 +23,6 @@ class Args:
     quick: bool
     release: bool
     ram_disk_size: str  # suffixed liked "25mb" or "1gb"
-    playwright: bool = False  # Use Playwright browser instead of system default
-    no_playwright_auto_resize: bool = False  # Disable Playwright auto-resize
     clear = False  # Force the last running container to be removed. Useful for benchmarking.
 
     @staticmethod
@@ -68,12 +66,6 @@ class Args:
         assert isinstance(
             args.release, bool
         ), f"expected bool, got {type(args.release)}"
-        assert isinstance(
-            args.playwright, bool
-        ), f"expected bool, got {type(args.playwright)}"
-        assert isinstance(
-            args.no_playwright_auto_resize, bool
-        ), f"expected bool, got {type(args.no_playwright_auto_resize)}"
 
         init: bool | str = False
         if args.init is None:
@@ -101,6 +93,4 @@ class Args:
             quick=args.quick,
             release=args.release,
             ram_disk_size=args.ram_disk_size,
-            playwright=args.playwright,
-            no_playwright_auto_resize=args.no_playwright_auto_resize,
         )

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/client_server.py

@@ -25,6 +25,16 @@ from fastled.web_compile import (
 )
 
 
+def _always_false() -> bool:
+    return False
+
+
+try:
+    from fastled.playwright_browser import is_playwright_available
+except ImportError:
+    is_playwright_available = _always_false
+
+
 def _create_error_html(error_message: str) -> str:
     return f"""<!DOCTYPE html>
 <html>
@@ -258,8 +268,6 @@ def run_client(
     ) = None,  # None means auto select a free port, http_port < 0 means no server.
     clear: bool = False,
     no_platformio: bool = False,
-    use_playwright: bool = False,
-    playwright_auto_resize: bool = True,
 ) -> int:
     has_checked_newer_version_yet = False
     compile_server: CompileServer | None = None
@@ -340,8 +348,6 @@ def run_client(
                 port=http_port,
                 compile_server_port=port,
                 open_browser=open_web_browser,
-                use_playwright=use_playwright,
-                playwright_auto_resize=playwright_auto_resize,
             )
         else:
             print("\nCompilation successful.")
@@ -564,8 +570,6 @@ def run_client_server(args: Args) -> int:
             profile=profile,
             clear=args.clear,
             no_platformio=no_platformio,
-            use_playwright=args.playwright,
-            playwright_auto_resize=not args.no_playwright_auto_resize,
         )
     except KeyboardInterrupt:
         return 1

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/open_browser.py

@@ -101,8 +101,6 @@ def spawn_http_server(
     compile_server_port: int,
     port: int | None = None,
     open_browser: bool = True,
-    use_playwright: bool = False,
-    playwright_auto_resize: bool = True,
 ) -> Process:
 
     if port is not None and not is_port_free(port):
@@ -131,28 +129,13 @@ def spawn_http_server(
     wait_for_server(port)
     if open_browser:
         url = f"http://localhost:{port}"
-        if use_playwright and PLAYWRIGHT_AVAILABLE and open_with_playwright is not None:
+        if PLAYWRIGHT_AVAILABLE and open_with_playwright is not None:
             print(f"Opening FastLED sketch in Playwright browser: {url}")
-            if playwright_auto_resize:
-                print(
-                    "Auto-resize enabled: Browser window will automatically adjust to content size"
-                )
-            global _playwright_browser_proxy
-            _playwright_browser_proxy = open_with_playwright(
-                url, auto_resize=playwright_auto_resize
-            )
-        elif use_playwright and not PLAYWRIGHT_AVAILABLE:
             print(
-                "Playwright requested but not available. Install with: pip install fastled[full]"
-            )
-            print(f"Falling back to system browser: {url}")
-            import webbrowser
-
-            webbrowser.open(
-                url=url,
-                new=1,
-                autoraise=True,
+                "Auto-resize enabled: Browser window will automatically adjust to content size"
             )
+            global _playwright_browser_proxy
+            _playwright_browser_proxy = open_with_playwright(url)
         else:
             print(f"Opening browser to {url}")
             import webbrowser

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/parse_args.py

@@ -35,15 +35,12 @@ FastLED WASM Compiler - Useful options:
   --profile             Enable profiling the C++ build system
   --update              Update the docker image for the wasm compiler
   --purge               Remove all FastLED containers and images
-  --playwright          Use Playwright browser (requires 'pip install fastled[full]')
-  --no-playwright-auto-resize  Disable automatic window resizing in Playwright
   --version             Show version information
   --help                Show detailed help
 Examples:
   fastled (will auto detect the sketch directory and prompt you)
   fastled my_sketch
   fastled my_sketch --web (compiles using the web compiler only)
-  fastled my_sketch --playwright (opens in Playwright browser)
   fastled --init Blink (initializes a new sketch directory with the Blink example)
   fastled --server (runs the compiler server in the current directory)
 
@@ -85,8 +82,8 @@ def parse_args() -> Args:
     parser.add_argument(
         "--ram-disk-size",
         type=str,
-        default="0",
-        help="Set the size of the ramdisk for the docker container. Use suffixes like '25mb' or '1gb'.",
+        default="1gb",
+        help="Size of the RAM disk for compilation (e.g., '1gb', '512mb')",
     )
     parser.add_argument(
         "--web",
@@ -116,7 +113,7 @@ def parse_args() -> Args:
     parser.add_argument(
         "--no-auto-updates",
         action="store_true",
-        help="Disable automatic updates of the wasm compiler image when using docker.",
+        help="Disable automatic updates of the wasm compiler image when using docker. (Default: False)",
     )
     parser.add_argument(
         "--no-platformio",
@@ -161,18 +158,6 @@ def parse_args() -> Args:
         help="Remove all FastLED containers and images",
     )
 
-    parser.add_argument(
-        "--playwright",
-        action="store_true",
-        help="Use Playwright browser instead of system default (requires 'pip install fastled[full]')",
-    )
-
-    parser.add_argument(
-        "--no-playwright-auto-resize",
-        action="store_true",
-        help="Disable automatic window resizing in Playwright browser",
-    )
-
     build_mode = parser.add_mutually_exclusive_group()
     build_mode.add_argument("--debug", action="store_true", help="Build in debug mode")
     build_mode.add_argument(

{fastled-1.3.39 → fastled-1.4.0}/src/fastled/playwright_browser.py

@@ -33,26 +33,23 @@ def is_playwright_available() -> bool:
 class PlaywrightBrowser:
     """Playwright browser manager for FastLED sketches."""
 
-    def __init__(self, headless: bool = False, auto_resize: bool = True):
+    def __init__(self, headless: bool = False):
         """Initialize the Playwright browser manager.
 
         Args:
             headless: Whether to run the browser in headless mode
-            auto_resize: Whether to automatically resize the browser window to fit content
         """
         if not PLAYWRIGHT_AVAILABLE:
             raise ImportError(
                 "Playwright is not installed. Install with: pip install fastled[full]"
             )
 
-        # debug
-        auto_resize = True
-
         self.headless = headless
-        self.auto_resize = auto_resize
+        self.auto_resize = True  # Always enable auto-resize
         self.browser: Any = None
         self.page: Any = None
         self.playwright: Any = None
+        self._should_exit = asyncio.Event()
 
     async def start(self) -> None:
         """Start the Playwright browser."""
@@ -158,8 +155,9 @@ class PlaywrightBrowser:
 
                 # Check if page is still alive
                 if self.page is None or self.page.is_closed():
-                    print("[PYTHON] Page closed, stopping browser tracking")
-                    break
+                    print("[PYTHON] Page closed, signaling exit")
+                    self._should_exit.set()
+                    return
 
                 # Get browser window dimensions
                 window_info = await self._get_window_info()
@@ -258,15 +256,12 @@ class PlaywrightBrowser:
             self.playwright = None
 
 
-def run_playwright_browser(
-    url: str, headless: bool = False, auto_resize: bool = True
-) -> None:
+def run_playwright_browser(url: str, headless: bool = False) -> None:
     """Run Playwright browser in a separate process.
 
     Args:
         url: The URL to open
         headless: Whether to run in headless mode
-        auto_resize: Whether to automatically resize the browser window to fit content
     """
     if not PLAYWRIGHT_AVAILABLE:
         warnings.warn(
@@ -276,7 +271,7 @@ def run_playwright_browser(
         return
 
     async def main():
-        browser = PlaywrightBrowser(headless=headless, auto_resize=auto_resize)
+        browser = PlaywrightBrowser(headless=headless)
         try:
             await browser.start()
             await browser.open_url(url)
@@ -309,14 +304,15 @@ class PlaywrightBrowserProxy:
     def __init__(self):
         self.process = None
         self.browser_manager = None
+        self.monitor_thread = None
+        self._closing_intentionally = False
 
-    def open(self, url: str, headless: bool = False, auto_resize: bool = True) -> None:
+    def open(self, url: str, headless: bool = False) -> None:
         """Open URL with Playwright browser and keep it alive.
 
         Args:
             url: The URL to open
             headless: Whether to run in headless mode
-            auto_resize: Whether to automatically resize the browser window to fit content
         """
         if not PLAYWRIGHT_AVAILABLE:
             warnings.warn(
@@ -335,10 +331,13 @@ class PlaywrightBrowserProxy:
 
             self.process = multiprocessing.Process(
                 target=run_playwright_browser_persistent,
-                args=(url, headless, auto_resize),
+                args=(url, headless),
             )
             self.process.start()
 
+            # Start monitoring thread to exit main process when browser subprocess exits
+            self._start_monitor_thread()
+
             # Register cleanup
             import atexit
 
@@ -352,10 +351,44 @@ class PlaywrightBrowserProxy:
 
             webbrowser.open(url)
 
+    def _start_monitor_thread(self) -> None:
+        """Start a thread to monitor the browser process and exit main process when it terminates."""
+        if self.monitor_thread is not None:
+            return
+
+        import os
+        import threading
+
+        def monitor_process():
+            """Monitor the browser process and exit when it terminates."""
+            if self.process is None:
+                return
+
+            try:
+                # Wait for the process to terminate
+                self.process.join()
+
+                # Check if the process terminated (and we didn't kill it ourselves)
+                if (
+                    self.process.exitcode is not None
+                    and not self._closing_intentionally
+                ):
+                    print("[MAIN] Browser closed, exiting main program")
+                    # Force exit the entire program
+                    os._exit(0)
+
+            except Exception as e:
+                print(f"[MAIN] Error monitoring browser process: {e}")
+
+        self.monitor_thread = threading.Thread(target=monitor_process, daemon=True)
+        self.monitor_thread.start()
+
     def close(self) -> None:
         """Close the Playwright browser."""
         if self.process and self.process.is_alive():
             print("Closing Playwright browser...")
+            # Mark that we're intentionally closing to prevent monitor from triggering exit
+            self._closing_intentionally = True
             self.process.terminate()
             self.process.join(timeout=5)
             if self.process.is_alive():
@@ -363,21 +396,18 @@ class PlaywrightBrowserProxy:
             self.process = None
 
 
-def run_playwright_browser_persistent(
-    url: str, headless: bool = False, auto_resize: bool = True
-) -> None:
+def run_playwright_browser_persistent(url: str, headless: bool = False) -> None:
     """Run Playwright browser in a persistent mode that stays alive until terminated.
 
     Args:
         url: The URL to open
         headless: Whether to run in headless mode
-        auto_resize: Whether to automatically resize the browser window to fit content
     """
     if not PLAYWRIGHT_AVAILABLE:
         return
 
     async def main():
-        browser = PlaywrightBrowser(headless=headless, auto_resize=auto_resize)
+        browser = PlaywrightBrowser(headless=headless)
         try:
             await browser.start()
             await browser.open_url(url)
@@ -386,9 +416,9 @@ def run_playwright_browser_persistent(
                 "Playwright browser opened. Browser will remain open until the FastLED process exits."
             )
 
-            # Keep the browser alive indefinitely
-            while True:
-                await asyncio.sleep(1)
+            # Keep the browser alive until exit is signaled
+            while not browser._should_exit.is_set():
+                await asyncio.sleep(0.1)
 
         except KeyboardInterrupt:
             print("\nClosing Playwright browser...")
@@ -405,9 +435,7 @@ def run_playwright_browser_persistent(
         print(f"Playwright browser failed: {e}")
 
 
-def open_with_playwright(
-    url: str, headless: bool = False, auto_resize: bool = True
-) -> PlaywrightBrowserProxy:
+def open_with_playwright(url: str, headless: bool = False) -> PlaywrightBrowserProxy:
     """Open URL with Playwright browser and return a proxy object for lifecycle management.
 
     This function can be used as a drop-in replacement for webbrowser.open().
@@ -415,13 +443,12 @@ def open_with_playwright(
     Args:
         url: The URL to open
         headless: Whether to run in headless mode
-        auto_resize: Whether to automatically resize the browser window to fit content
 
     Returns:
         PlaywrightBrowserProxy object for managing the browser lifecycle
     """
     proxy = PlaywrightBrowserProxy()
-    proxy.open(url, headless, auto_resize)
+    proxy.open(url, headless)
     return proxy
 
 

{fastled-1.3.39 → fastled-1.4.0}/src/fastled.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastled
-Version: 1.3.39
+Version: 1.4.0
 Summary: FastLED Wasm Compiler
 Home-page: https://github.com/zackees/fastled-wasm
 Maintainer: Zachary Vorhies
@@ -81,10 +81,10 @@ For enhanced browser control and automation capabilities, you can install the fu
 $ pip install fastled[full]
 ```
 
-This enables the `--playwright` flag which opens your compiled sketch in a Playwright-controlled browser instead of your system's default browser:
+When installed, FastLED will automatically use Playwright to open your compiled sketch in a controlled browser environment instead of your system's default browser:
 
 ```bash
-$ fastled my_sketch --playwright
+$ fastled my_sketch
 ```
 
 The Playwright browser provides better automation capabilities and is especially useful for:
@@ -94,12 +94,13 @@ The Playwright browser provides better automation capabilities and is especially
 - Persistent browser sessions that stay open until the FastLED process exits
 
 **Key Benefits:**
+- Automatically enabled when `fastled[full]` is installed - no additional flags needed
 - The Playwright browser remains open throughout your development session
 - Automatic cleanup when the FastLED process exits
 - Better control over browser behavior and automation capabilities
 - Consistent behavior across different platforms
 
-If Playwright is not installed and you use the `--playwright` flag, the system will gracefully fall back to your default browser.
+If Playwright is not installed, the system will gracefully fall back to your default browser.
 
 # Install
 

{fastled-1.3.39 → fastled-1.4.0}/tests/integration/test_playwright_integration.py

@@ -56,64 +56,6 @@ class PlaywrightIntegrationTester(unittest.TestCase):
                 # Test cleanup
                 proxy.close()  # Should not raise an exception
 
-    def test_args_integration(self):
-        """Test that the playwright argument is properly integrated into the Args class."""
-        import argparse
-
-        from fastled.args import Args
-
-        # Create a mock namespace with the playwright argument
-        namespace = argparse.Namespace()
-        namespace.directory = None
-        namespace.init = None
-        namespace.just_compile = False
-        namespace.web = None
-        namespace.interactive = False
-        namespace.profile = False
-        namespace.force_compile = False
-        namespace.no_platformio = False
-        namespace.no_auto_updates = False
-        namespace.update = False
-        namespace.localhost = False
-        namespace.build = False
-        namespace.server = False
-        namespace.purge = False
-        namespace.debug = False
-        namespace.quick = False
-        namespace.release = False
-        namespace.ram_disk_size = "0"
-        namespace.playwright = True
-
-        # Create Args from namespace
-        args = Args.from_namespace(namespace)
-
-        # Verify the playwright flag is set
-        self.assertTrue(args.playwright)
-
-    def test_parse_args_playwright_flag(self):
-        """Test that the --playwright flag is properly parsed."""
-        import sys
-
-        from fastled.parse_args import parse_args
-
-        # Save original argv
-        original_argv = sys.argv
-
-        try:
-            # Test with --playwright flag
-            sys.argv = ["fastled", "test_dir", "--playwright"]
-            args = parse_args()
-            self.assertTrue(args.playwright)
-
-            # Test without --playwright flag
-            sys.argv = ["fastled", "test_dir"]
-            args = parse_args()
-            self.assertFalse(args.playwright)
-
-        finally:
-            # Restore original argv
-            sys.argv = original_argv
-
 
 if __name__ == "__main__":
     unittest.main()