fastgpx 0.2.0__tar.gz → 0.2.2__tar.gz

{fastgpx-0.2.0 → fastgpx-0.2.2}/CMakeLists.txt

@@ -2,6 +2,14 @@ cmake_minimum_required(VERSION 3.30.2)
 
 project(fastgpx)
 
+if(NOT DEFINED FASTGPX_WARNINGS_AS_ERRORS)
+  set(FASTGPX_WARNINGS_AS_ERRORS "$ENV{FASTGPX_WARNINGS_AS_ERRORS}")
+endif()
+
+option(FASTGPX_WARNINGS_AS_ERRORS "Treat C++ warnings as errors" ${FASTGPX_WARNINGS_AS_ERRORS})
+
+message(STATUS "FASTGPX_WARNINGS_AS_ERRORS: ${FASTGPX_WARNINGS_AS_ERRORS}")
+
 # > The CTest module defines a BUILD_TESTING cache variable which defaults to true.
 # > It is used to decide whether the module calls enable_testing() or not, so the
 # > project does not have to make its own explicit call to enable_testing(). The

{fastgpx-0.2.0 → fastgpx-0.2.2}/Development.md

@@ -150,3 +150,7 @@ build\src\cpp\RelWithDebInfo\fastgpx_test.exe
 ```sh
 build\src\cpp\RelWithDebInfo\fastgpx_test.exe [!benchmark]
 ```
+
+## VSCode / CMake
+
+Building directly with CMake require pybind11 installed. Currently this is defined as a build tool dependency in `pyproject.toml` and will therefore have to be manually installed into the `.venv` using `pip install pybind11`.

{fastgpx-0.2.0 → fastgpx-0.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fastgpx
-Version: 0.2.0
+Version: 0.2.2
 Summary: An experimental Python library for parsing GPX files fast.
 Keywords: gpx,parser,fast
 Author: Thomas Thomassen
@@ -45,6 +45,19 @@ for track in gpx.tracks:
 
 [Documentation](https://thomthom.github.io/fastgpx/)
 
+## Requirements
+
+* Python 3.11+ (Tested with 3.11, 3.12)
+* C++23 Compiler
+
+### Windows
+
+* Tested with MSVC 17.12.4+ and Clang-cl 19+.
+
+### Linux (Tested on Ubuntu)
+
+* C++23 compatible runtime (GCC libstdc++ 14+ or Clang libc++ 18.1+)
+
 ## GPX/XML Performance (Background)
 
 `gpxpy` appear to be the most popular GPX library for Python.

{fastgpx-0.2.0 → fastgpx-0.2.2}/README.md

@@ -28,6 +28,19 @@ for track in gpx.tracks:
 
 [Documentation](https://thomthom.github.io/fastgpx/)
 
+## Requirements
+
+* Python 3.11+ (Tested with 3.11, 3.12)
+* C++23 Compiler
+
+### Windows
+
+* Tested with MSVC 17.12.4+ and Clang-cl 19+.
+
+### Linux (Tested on Ubuntu)
+
+* C++23 compatible runtime (GCC libstdc++ 14+ or Clang libc++ 18.1+)
+
 ## GPX/XML Performance (Background)
 
 `gpxpy` appear to be the most popular GPX library for Python.

{fastgpx-0.2.0 → fastgpx-0.2.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "scikit_build_core.build"
 
 [project]
 name = "fastgpx"
-version = "0.2.0"
+version = "0.2.2"
 requires-python = ">=3.11"
 
 description = "An experimental Python library for parsing GPX files fast."

{fastgpx-0.2.0 → fastgpx-0.2.2}/src/cpp/CMakeLists.txt

@@ -40,12 +40,16 @@ function(set_common_properties TARGET)
     # Elevate warning level.
     # Ignore unknown pragmas (mac).
     target_compile_options(${TARGET} PRIVATE
-        /W4 /WX
+        /W4
         /wd4068
     )
+    if(FASTGPX_WARNINGS_AS_ERRORS)
+      target_compile_options(${TARGET} PRIVATE /WX)
+    endif()
 
     if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-      # Clang pretending to be MSVC – add Clang-specific warnings
+      # Clang pretending to be MSVC – add Clang-specific warnings what /W4 does
+      # not cover.
       target_compile_options(${TARGET} PRIVATE
           -Wshadow -Wconversion
           -Wno-unknown-pragmas
@@ -59,14 +63,18 @@ function(set_common_properties TARGET)
     # Ensure MSVC report up to date version for __cplusplus macro.
     # https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-160
     target_compile_options(${TARGET} PRIVATE /Zc:__cplusplus)
+
   else()
     # Elevate warning level.
     # Ignore unknown pragmas (win).
     target_compile_options(${TARGET} PRIVATE
-        -Wall -Wextra -pedantic -Werror
+        -Wall -Wextra -pedantic
         -Wshadow -Wconversion
         -Wno-unknown-pragmas
     )
+    if(FASTGPX_WARNINGS_AS_ERRORS)
+      target_compile_options(${TARGET} PRIVATE -Werror)
+    endif()
   endif()
 endfunction()
 
@@ -97,7 +105,7 @@ set_target_properties(fastgpx-static PROPERTIES
 
 # fastgpx python module
 
-find_package(Python3 3.11 EXACT REQUIRED COMPONENTS Interpreter Development)
+find_package(Python3 3.11 REQUIRED COMPONENTS Interpreter Development)
 
 set(PYBIND11_NEWPYTHON ON)
 find_package(pybind11 CONFIG REQUIRED)

{fastgpx-0.2.0 → fastgpx-0.2.2}/src/cpp/fastgpx/polyline.cpp

@@ -12,7 +12,7 @@ namespace polyline {
 std::string encode(std::span<const LatLong> locations, Precision precision)
 {
   const int factor = (precision == Precision::Six) ? 1'000'000 : 100'000;
-  std::string encoded;
+  std::string encoded_polyline;
   int last_lat = 0;
   int last_lng = 0;
 
@@ -25,25 +25,25 @@ std::string encode(std::span<const LatLong> locations, Precision precision)
     const int delta_lng = lng - last_lng;
 
     auto encode_value = [](int value) -> std::string {
-      std::string encoded;
+      std::string encoded_latlong;
       value = (value < 0) ? ~(value << 1) : (value << 1);
       while (value >= 0x20)
       {
-        encoded += static_cast<char>((0x20 | (value & 0x1f)) + 63);
+        encoded_latlong += static_cast<char>((0x20 | (value & 0x1f)) + 63);
         value >>= 5;
       }
-      encoded += static_cast<char>(value + 63);
-      return encoded;
+      encoded_latlong += static_cast<char>(value + 63);
+      return encoded_latlong;
     };
 
-    encoded += encode_value(delta_lat);
-    encoded += encode_value(delta_lng);
+    encoded_polyline += encode_value(delta_lat);
+    encoded_polyline += encode_value(delta_lng);
 
     last_lat = lat;
     last_lng = lng;
   }
 
-  return encoded;
+  return encoded_polyline;
 }
 
 std::vector<LatLong> decode(std::string_view encoded, Precision precision)