fairagro-middleware-api-client 10.0.3.dev25__tar.gz → 10.0.3.dev26__tar.gz

{fairagro_middleware_api_client-10.0.3.dev25 → fairagro_middleware_api_client-10.0.3.dev26}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: fairagro-middleware-api-client
-Version: 10.0.3.dev25
+Version: 10.0.3.dev26
 Summary: The FAIRagro advanced middleware API client
 Requires-Python: >=3.12
 Requires-Dist: httpx>=0.28.1

{fairagro_middleware_api_client-10.0.3.dev25 → fairagro_middleware_api_client-10.0.3.dev26}/src/middleware/api_client/api_client.py

@@ -160,6 +160,23 @@ class ApiClient:
             return cls._should_retry_request_error(method, path, request_error)
         return False
 
+    @classmethod
+    def _format_request_error(cls, error: BaseException) -> str:
+        """Return a non-empty description for a transport/request error.
+
+        ``httpx.ConnectError`` (and similar) often stringify to ``""``, which
+        produces useless log lines like ``Request error: ``. Fall back to the
+        exception type name, then ``repr``.
+        """
+        message = str(error).strip()
+        if message:
+            return message
+        type_name = type(error).__name__
+        representation = repr(error).strip()
+        if representation and representation != type_name:
+            return f"{type_name}: {representation}"
+        return type_name
+
     @classmethod
     def _build_failure_error_message(
         cls,
@@ -175,9 +192,10 @@ class ApiClient:
                 return f"Request failed after {max_retries} retries: HTTP {status_code}", status_code
             return cls._format_http_error_message(status_code, failure.response.text), status_code
 
+        detail = cls._format_request_error(failure)
         if retryable:
-            return f"Request failed after {max_retries} retries: {failure}", None
-        return f"Request failed: {failure}", None
+            return f"Request failed after {max_retries} retries: {detail}", None
+        return f"Request failed: {detail}", None
 
     @classmethod
     def _should_retry_or_raise_failure(
@@ -204,7 +222,7 @@ class ApiClient:
             if isinstance(failure, httpx.HTTPStatusError):
                 logger.warning("Transient HTTP error %d from server, will retry", failure.response.status_code)
             else:
-                logger.warning("Request error: %s. Retrying...", failure)
+                logger.warning("Request error: %s. Retrying...", cls._format_request_error(failure))
             return True
 
         msg, normalized_status_code = cls._build_failure_error_message(

{fairagro_middleware_api_client-10.0.3.dev25 → fairagro_middleware_api_client-10.0.3.dev26}/tests/unit/test_client.py

@@ -371,6 +371,26 @@ async def test_get_timeout_not_retried(client_config: Config) -> None:
     assert route.call_count == 1
 
 
+def test_format_request_error_falls_back_when_message_empty() -> None:
+    """Empty ConnectError messages fall back to the exception type name."""
+    empty = httpx.ConnectError("")
+    assert str(empty) == ""
+    formatted = ApiClient._format_request_error(empty)  # noqa: SLF001
+    assert "ConnectError" in formatted
+    assert formatted.strip() != ""
+
+
+@pytest.mark.asyncio
+@respx.mock
+async def test_empty_connect_error_message_is_not_blank(client_config: Config) -> None:
+    """ApiClientError for empty ConnectError still carries a useful message."""
+    respx.post(f"{client_config.api_url}v3/harvests").mock(side_effect=httpx.ConnectError(""))
+    async with ApiClient(client_config) as client:
+        with pytest.raises(ApiClientError, match="Request failed: ConnectError") as exc_info:
+            await client.create_harvest(rdi="test-rdi")
+    assert str(exc_info.value).strip() != "Request failed:"
+
+
 @pytest.mark.asyncio
 @respx.mock
 async def test_global_max_concurrency_limits_parallel_requests(client_config: Config) -> None: