ethyca-fides 2.67.1rc1__tar.gz → 2.67.2b0__tar.gz

{ethyca_fides-2.67.1rc1/src/ethyca_fides.egg-info → ethyca_fides-2.67.2b0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ethyca_fides
-Version: 2.67.1rc1
+Version: 2.67.2b0
 Summary: Open-source ecosystem for data privacy as code.
 Home-page: https://github.com/ethyca/fides
 Author: Ethyca, Inc.
@@ -40,7 +40,7 @@ Requires-Dist: firebase-admin==5.3.0
 Requires-Dist: flower==2.0.1
 Requires-Dist: GitPython==3.1.41
 Requires-Dist: httpx==0.23.1
-Requires-Dist: hvac==0.11.2
+Requires-Dist: onepassword-sdk==0.3.0
 Requires-Dist: iab-tcf==0.2.2
 Requires-Dist: immutables==0.20
 Requires-Dist: importlib_resources==5.12.0

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/requirements.txt

@@ -24,7 +24,7 @@ firebase-admin==5.3.0
 flower==2.0.1
 GitPython==3.1.41
 httpx==0.23.1
-hvac==0.11.2
+onepassword-sdk==0.3.0
 iab-tcf==0.2.2
 immutables==0.20
 importlib_resources==5.12.0

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0/src/ethyca_fides.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ethyca_fides
-Version: 2.67.1rc1
+Version: 2.67.2b0
 Summary: Open-source ecosystem for data privacy as code.
 Home-page: https://github.com/ethyca/fides
 Author: Ethyca, Inc.
@@ -40,7 +40,7 @@ Requires-Dist: firebase-admin==5.3.0
 Requires-Dist: flower==2.0.1
 Requires-Dist: GitPython==3.1.41
 Requires-Dist: httpx==0.23.1
-Requires-Dist: hvac==0.11.2
+Requires-Dist: onepassword-sdk==0.3.0
 Requires-Dist: iab-tcf==0.2.2
 Requires-Dist: immutables==0.20
 Requires-Dist: importlib_resources==5.12.0

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/ethyca_fides.egg-info/SOURCES.txt

@@ -871,8 +871,6 @@ src/fides/ui-build/static/admin/properties.html
 src/fides/ui-build/static/admin/systems.html
 src/fides/ui-build/static/admin/taxonomy.html
 src/fides/ui-build/static/admin/user-management.html
-src/fides/ui-build/static/admin/_next/static/-pDvglWsgqfWeQixOy5zJ/_buildManifest.js
-src/fides/ui-build/static/admin/_next/static/-pDvglWsgqfWeQixOy5zJ/_ssgManifest.js
 src/fides/ui-build/static/admin/_next/static/chunks/1316-2606e19807c08aa5.js
 src/fides/ui-build/static/admin/_next/static/chunks/1467-8808ec8836e033f9.js
 src/fides/ui-build/static/admin/_next/static/chunks/1817-b78b58ae3b75d75a.js
@@ -1033,6 +1031,8 @@ src/fides/ui-build/static/admin/_next/static/css/ab65b8cc3144bfc8.css
 src/fides/ui-build/static/admin/_next/static/css/d2d4e9a6923e6730.css
 src/fides/ui-build/static/admin/_next/static/css/d9924caa849931b3.css
 src/fides/ui-build/static/admin/_next/static/css/dbcf63488933a4d5.css
+src/fides/ui-build/static/admin/_next/static/fnhwfkI-rGZMUPYfQ5ACP/_buildManifest.js
+src/fides/ui-build/static/admin/_next/static/fnhwfkI-rGZMUPYfQ5ACP/_ssgManifest.js
 src/fides/ui-build/static/admin/_next/static/media/inter-all-400-normal.2ae8ed37.woff
 src/fides/ui-build/static/admin/_next/static/media/inter-all-500-normal.56c3d87b.woff
 src/fides/ui-build/static/admin/_next/static/media/inter-all-600-normal.d9666969.woff

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/ethyca_fides.egg-info/requires.txt

@@ -24,7 +24,7 @@ firebase-admin==5.3.0
 flower==2.0.1
 GitPython==3.1.41
 httpx==0.23.1
-hvac==0.11.2
+onepassword-sdk==0.3.0
 iab-tcf==0.2.2
 immutables==0.20
 importlib_resources==5.12.0

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/_version.py

@@ -8,11 +8,11 @@ import json
 
 version_json = '''
 {
- "date": "2025-08-06T13:55:30-0600",
+ "date": "2025-08-06T14:57:15-0600",
  "dirty": false,
  "error": null,
- "full-revisionid": "26a23bed1280a763cfa3afd3ce567d5d80a336ab",
- "version": "2.67.1rc1"
+ "full-revisionid": "1a66c3d98293c724a40269b16c3329a607a0bced",
+ "version": "2.67.2b0"
 }
 '''  # END VERSION_JSON
 

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/db/crud.py

@@ -58,11 +58,9 @@ async def create_resource(
                 log.debug("Creating resource")
                 query = _insert(sql_model.__table__).values(resource_dict)
                 await async_session.execute(query)
-            except SQLAlchemyError:
+            except SQLAlchemyError as e:
+                log.exception(f"Failed to create resource with error: '{e}'")
                 sa_error = errors.QueryError()
-                log.bind(error=sa_error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to create resource"
-                )
                 raise sa_error
 
         return await get_resource(sql_model, resource_dict["fides_key"], async_session)
@@ -107,11 +105,9 @@ async def get_custom_fields_filtered(
                 query = query.where(or_(False, *criteria))
                 result = await async_session.execute(query)
                 return result.mappings().all()
-            except SQLAlchemyError:
+            except SQLAlchemyError as e:
                 sa_error = errors.QueryError()
-                log.bind(error=sa_error.detail["error"]).error(  # type: ignore[index]
-                    "Failed to fetch custom fields"
-                )
+                log.exception(f"Failed to fetch custom fields with error: '{e}'")
                 raise sa_error
 
 
@@ -132,11 +128,9 @@ async def get_resource(
                 log.debug("Fetching resource")
                 query = select(sql_model).where(sql_model.fides_key == fides_key)
                 result = await async_session.execute(query)
-            except SQLAlchemyError:
+            except SQLAlchemyError as e:
                 sa_error = errors.QueryError()
-                log.bind(error=sa_error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to fetch resource"
-                )
+                log.exception(f"Failed to fetch resource with error: '{e}'")
                 raise sa_error
 
             sql_resource = result.scalars().first()
@@ -178,11 +172,9 @@ async def get_resource_with_custom_fields(
                     )
                 )
                 result = await async_session.execute(query)
-            except SQLAlchemyError:
+            except SQLAlchemyError as e:
                 sa_error = errors.QueryError()
-                log.bind(error=sa_error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to fetch custom fields"
-                )
+                log.exception(f"Failed to fetch custom fields with error: '{e}'")
                 raise sa_error
 
             custom_fields = result.mappings().all()
@@ -225,12 +217,10 @@ async def list_resource_query(
                 log.debug("Fetching resources")
                 result = await async_session.execute(query)
                 sql_resources = result.scalars().all()
-            except SQLAlchemyError:
-                error = errors.QueryError()
-                log.bind(error=error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to fetch resources"
-                )
-                raise error
+            except SQLAlchemyError as e:
+                log.exception(f"Failed to fetch resources with error: '{e}'")
+                sa_error = errors.QueryError()
+                raise sa_error
 
             return sql_resources
 
@@ -253,12 +243,10 @@ async def update_resource(
                     .where(sql_model.fides_key == resource_dict["fides_key"])
                     .values(resource_dict)
                 )
-            except SQLAlchemyError:
-                error = errors.QueryError()
-                log.bind(error=error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to update resource"
-                )
-                raise error
+            except SQLAlchemyError as e:
+                log.exception(f"Failed to update resource with error: '{e}'")
+                sa_error = errors.QueryError()
+                raise sa_error
 
         return await get_resource(sql_model, resource_dict["fides_key"], async_session)
 
@@ -306,13 +294,10 @@ async def upsert_resources(
 
                 return (inserts, updates)
 
-            except SQLAlchemyError:
-                error = errors.QueryError()
-                log.bind(error=error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to upsert resources"
-                )
-                log.exception(error)
-                raise error
+            except SQLAlchemyError as e:
+                log.exception(f"Failed to upsert resources with error: '{e}'")
+                sa_error = errors.QueryError()
+                raise sa_error
 
 
 async def delete_resource(
@@ -361,11 +346,9 @@ async def delete_resource(
                     status_code=HTTP_422_UNPROCESSABLE_ENTITY,
                     detail=error_message,
                 )
-            except SQLAlchemyError:
-                error = errors.QueryError()
-                log.bind(error=error.detail["error"]).info(  # type: ignore[index]
-                    "Failed to delete resource"
-                )
-                raise error
+            except SQLAlchemyError as e:
+                log.exception(f"Failed to delete resource with error: '{e}'")
+                sa_error = errors.QueryError()
+                raise sa_error
 
         return sql_resource

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/main.py

@@ -232,7 +232,8 @@ async def log_request(request: Request, call_next: Callable) -> Response:
     # If the request fails, we still want to log it
     try:
         response = await call_next(request)
-    except:  # pylint: disable=bare-except
+    except Exception as e:  # pylint: disable=bare-except
+        logger.exception(f"Unhandled exception processing request: '{e}'")
         response = Response(status_code=500)
 
     handler_time = datetime.now() - start

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/models/manual_task/manual_task.py

@@ -383,15 +383,13 @@ class ManualTaskInstance(Base):
 
     @property
     def incomplete_fields(self) -> list["ManualTaskConfigField"]:
-        """Get all fields that haven't been completed yet.
-        A field is considered incomplete if:
-        1. It's required and has no submission
+        """Get all fields that have no submission.
         Returns:
             list[ManualTaskConfigField]: List of incomplete fields
         """
         return [
             field
-            for field in self.required_fields
+            for field in self.config.field_definitions
             if not self.get_submission_for_field(field.id)
         ]
 
@@ -401,8 +399,7 @@ class ManualTaskInstance(Base):
         return [
             field
             for field in self.config.field_definitions
-            if field.field_metadata.get("required", False)
-            and self.get_submission_for_field(field.id)
+            if self.get_submission_for_field(field.id)
         ]
 
     def get_submission_for_field(

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/models/privacy_request/privacy_request.py

@@ -47,8 +47,16 @@ from fides.api.models.attachment import (
 from fides.api.models.audit_log import AuditLog
 from fides.api.models.client import ClientDetail
 from fides.api.models.comment import Comment, CommentReference, CommentReferenceType
+from fides.api.models.connectionconfig import ConnectionConfig
 from fides.api.models.fides_user import FidesUser
 from fides.api.models.field_types import EncryptedLargeDataDescriptor
+from fides.api.models.manual_task import (
+    ManualTask,
+    ManualTaskConfig,
+    ManualTaskConfigurationType,
+    ManualTaskEntityType,
+    ManualTaskInstance,
+)
 from fides.api.models.manual_webhook import AccessManualWebhook
 from fides.api.models.masking_secret import MaskingSecret
 from fides.api.models.policy import (
@@ -200,6 +208,14 @@ class PrivacyRequest(
         viewonly=True,
         uselist=True,
     )
+    manual_task_instances = relationship(
+        "ManualTaskInstance",
+        lazy="select",
+        passive_deletes="all",
+        primaryjoin="and_(ManualTaskInstance.entity_id==foreign(PrivacyRequest.id), "
+        "ManualTaskInstance.entity_type=='privacy_request')",
+        uselist=True,
+    )
     property_id = Column(String, nullable=True)
 
     cancel_reason = Column(String(200))
@@ -1175,6 +1191,68 @@ class PrivacyRequest(
             db, manual_webhook_id, "erasure_manual_webhook"
         )
 
+    def create_manual_task_instances(
+        self, db: Session, connection_configs_with_manual_tasks: list[ConnectionConfig]
+    ) -> list[ManualTaskInstance]:
+        """Create ManualTaskInstance entries for all active manual tasks relevant to a privacy request."""
+        # Early return if no relevant policy rules
+        policy_rules = {
+            ActionType.access: bool(
+                self.policy.get_rules_for_action(action_type=ActionType.access)
+            ),
+            ActionType.erasure: bool(
+                self.policy.get_rules_for_action(action_type=ActionType.erasure)
+            ),
+        }
+
+        if not any(policy_rules.values()):
+            return []
+
+        # Build configuration types using list comprehension
+        config_types = [
+            (
+                ManualTaskConfigurationType.access_privacy_request
+                if action_type == ActionType.access
+                else ManualTaskConfigurationType.erasure_privacy_request
+            )
+            for action_type, has_rules in policy_rules.items()
+            if has_rules
+        ]
+
+        # Get all relevant manual tasks and configs in one query
+        connection_config_ids = [cc.id for cc in connection_configs_with_manual_tasks]
+        manual_tasks_with_configs = (
+            db.query(ManualTask, ManualTaskConfig)
+            .join(ManualTaskConfig, ManualTask.id == ManualTaskConfig.task_id)
+            .filter(
+                ManualTask.parent_entity_id.in_(connection_config_ids),
+                ManualTask.parent_entity_type == "connection_config",
+                ManualTaskConfig.is_current.is_(True),
+                ManualTaskConfig.config_type.in_(config_types),
+            )
+            .all()
+        )
+
+        # Get existing config IDs to avoid duplicates
+        existing_config_ids = {
+            instance.config_id for instance in self.manual_task_instances
+        }
+
+        # Create instances using list comprehension and filter out existing ones
+        return [
+            ManualTaskInstance.create(
+                db=db,
+                data={
+                    "entity_id": self.id,
+                    "entity_type": ManualTaskEntityType.privacy_request,
+                    "task_id": manual_task.id,
+                    "config_id": config.id,
+                },
+            )
+            for manual_task, config in manual_tasks_with_configs
+            if config.id not in existing_config_ids
+        ]
+
     def get_existing_request_task(
         self,
         db: Session,

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/service/privacy_request/dsr_package/dsr_report_builder.py

@@ -13,7 +13,7 @@ from loguru import logger
 
 from fides.api.models.privacy_request import PrivacyRequest
 from fides.api.schemas.policy import ActionType
-from fides.api.util.storage_util import StorageJSONEncoder
+from fides.api.util.storage_util import StorageJSONEncoder, format_size
 
 DSR_DIRECTORY = Path(__file__).parent.resolve()
 
@@ -204,7 +204,7 @@ class DsrReportBuilder:
 
             file_size = attachment.get("file_size")
             if isinstance(file_size, (int, float)):
-                file_size = self._format_size(float(file_size))
+                file_size = format_size(float(file_size))
             else:
                 file_size = "Unknown"
 
@@ -321,22 +321,6 @@ class DsrReportBuilder:
 
         return datasets
 
-    def _format_size(self, size_bytes: float) -> str:
-        """
-        Format size in bytes to human readable format.
-
-        Args:
-            size_bytes: Size in bytes
-
-        Returns:
-            Formatted string with appropriate unit (B, KB, MB, GB)
-        """
-        for unit in ["B", "KB", "MB", "GB"]:
-            if size_bytes < 1024.0:
-                return f"{size_bytes:.1f} {unit}"
-            size_bytes /= 1024.0
-        return f"{size_bytes:.1f} TB"
-
     def generate(self) -> BytesIO:
         """
         Processes the request and DSR data to build zip file containing the DSR report.
@@ -395,7 +379,7 @@ class DsrReportBuilder:
 
         # Calculate time taken and file size
         time_taken = time_module.time() - start_time
-        file_size = self._format_size(float(len(self.baos.getvalue())))
+        file_size = format_size(float(len(self.baos.getvalue())))
 
         logger.bind(time_to_generate=time_taken, dsr_package_size=file_size).info(
             "DSR report generation complete."

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/task/create_request_tasks.py

@@ -35,7 +35,7 @@ from fides.api.task.deprecated_graph_task import format_data_use_map_for_caching
 from fides.api.task.execute_request_tasks import log_task_queued, queue_request_task
 from fides.api.task.manual.manual_task_address import ManualTaskAddress
 from fides.api.task.manual.manual_task_utils import (
-    create_manual_task_instances_for_privacy_request,
+    get_connection_configs_with_manual_tasks,
 )
 from fides.api.util.logger_context_utils import log_context
 
@@ -92,7 +92,7 @@ def build_access_networkx_digraph(
     manual_nodes = [
         addr
         for addr in traversal_nodes.keys()
-        if addr.collection == ManualTaskAddress.MANUAL_DATA_COLLECTION
+        if ManualTaskAddress.is_manual_task_address(addr)
     ]
     for manual_node in manual_nodes:
         networkx_graph.add_edge(ROOT_COLLECTION_ADDRESS, manual_node)
@@ -472,7 +472,9 @@ def run_access_request(
             )
 
             # Snapshot manual task field instances for this privacy request
-            create_manual_task_instances_for_privacy_request(session, privacy_request)
+            privacy_request.create_manual_task_instances(
+                session, get_connection_configs_with_manual_tasks(session)
+            )
 
             # Save Access Request Tasks to the database
             ready_tasks = persist_new_access_request_tasks(

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/task/filter_results.py

@@ -39,7 +39,7 @@ def filter_data_categories(
             continue
 
         # Skip manual task data - it doesn't need filtering since it's controlled by field definitions
-        if f":{ManualTaskAddress.MANUAL_DATA_COLLECTION}" in node_address:
+        if ManualTaskAddress.is_manual_task_address(node_address):
             filtered_access_results[node_address].extend(results)
             continue
 

{ethyca_fides-2.67.1rc1 → ethyca_fides-2.67.2b0}/src/fides/api/task/manual/manual_task_address.py

@@ -1,3 +1,5 @@
+from typing import Union
+
 from fides.api.graph.config import CollectionAddress
 
 
@@ -20,7 +22,7 @@ class ManualTaskAddress:
         return collection_name == ManualTaskAddress.MANUAL_DATA_COLLECTION
 
     @staticmethod
-    def is_manual_task_address(address: CollectionAddress) -> bool:
+    def is_manual_task_address(address: Union[str, CollectionAddress]) -> bool:
         """Check if address represents manual task data"""
         if isinstance(address, str):
             # Handle string format "connection_key:collection_name"
@@ -33,7 +35,7 @@ class ManualTaskAddress:
         return ManualTaskAddress._is_manual_data_collection(address.collection)
 
     @staticmethod
-    def get_connection_key(address: CollectionAddress) -> str:
+    def get_connection_key(address: Union[str, CollectionAddress]) -> str:
         """Extract connection config key from manual task address"""
         if not ManualTaskAddress.is_manual_task_address(address):
             raise ValueError(f"Not a manual task address: {address}")