ethyca-fides 2.58.1b4__tar.gz → 2.58.1rc0__tar.gz

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ethyca_fides
-Version: 2.58.1b4
+Version: 2.58.1rc0
 Summary: Open-source ecosystem for data privacy as code.
 Home-page: https://github.com/ethyca/fides
 Author: Ethyca, Inc.

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/ethyca_fides.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ethyca-fides
-Version: 2.58.1b4
+Version: 2.58.1rc0
 Summary: Open-source ecosystem for data privacy as code.
 Home-page: https://github.com/ethyca/fides
 Author: Ethyca, Inc.

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/ethyca_fides.egg-info/SOURCES.txt

@@ -140,7 +140,6 @@ src/fides/api/alembic/migrations/versions/63b482f5b49b_upgrade_to_fideslang_1_4.
 src/fides/api/alembic/migrations/versions/643249f65453_case_insensitive_usernames_delete_.py
 src/fides/api/alembic/migrations/versions/66df7d9b8103_add_tcf_columns.py
 src/fides/api/alembic/migrations/versions/671358247251_migrate_meta_vendor.py
-src/fides/api/alembic/migrations/versions/67d01c4e124e_add_reject_all_mechanism_to_privacy_.py
 src/fides/api/alembic/migrations/versions/68a518a3c050_system_managers.py
 src/fides/api/alembic/migrations/versions/68c590ff6e89_add_rds_mysql_to_connector_type.py
 src/fides/api/alembic/migrations/versions/68cb26f3492d_remove_client_id_constraint.py
@@ -779,8 +778,6 @@ src/fides/service/dataset/validation_steps/masking_strategy.py
 src/fides/service/dataset/validation_steps/namespace_meta.py
 src/fides/service/dataset/validation_steps/saas.py
 src/fides/service/dataset/validation_steps/traversal.py
-src/fides/service/error_handling/__init__.py
-src/fides/service/error_handling/error_handler.py
 src/fides/service/messaging/__init__.py
 src/fides/service/messaging/aws_ses_service.py
 src/fides/service/messaging/messaging_service.py
@@ -807,8 +804,8 @@ src/fides/ui-build/static/admin/properties.html
 src/fides/ui-build/static/admin/systems.html
 src/fides/ui-build/static/admin/taxonomy.html
 src/fides/ui-build/static/admin/user-management.html
-src/fides/ui-build/static/admin/_next/static/LFNq-viakwWPa01GpNMoV/_buildManifest.js
-src/fides/ui-build/static/admin/_next/static/LFNq-viakwWPa01GpNMoV/_ssgManifest.js
+src/fides/ui-build/static/admin/_next/static/7Gn2YyMsVjWkBPSaVWEi9/_buildManifest.js
+src/fides/ui-build/static/admin/_next/static/7Gn2YyMsVjWkBPSaVWEi9/_ssgManifest.js
 src/fides/ui-build/static/admin/_next/static/chunks/1100-053fc6b76c65a00f.js
 src/fides/ui-build/static/admin/_next/static/chunks/1150-035a721a04f4451e.js
 src/fides/ui-build/static/admin/_next/static/chunks/1376-5cea5ef9362215e8.js
@@ -825,15 +822,15 @@ src/fides/ui-build/static/admin/_next/static/chunks/3855-b6b7865dedd7bc2a.js
 src/fides/ui-build/static/admin/_next/static/chunks/3872-4e053c20d546f027.js
 src/fides/ui-build/static/admin/_next/static/chunks/4060-8d165e1236ea521a.js
 src/fides/ui-build/static/admin/_next/static/chunks/4294-5b3aa9d605217915.js
-src/fides/ui-build/static/admin/_next/static/chunks/4450-074c2b59f59451b0.js
+src/fides/ui-build/static/admin/_next/static/chunks/4450-36234280bee624ff.js
 src/fides/ui-build/static/admin/_next/static/chunks/4481-aab99ff80f707473.js
-src/fides/ui-build/static/admin/_next/static/chunks/4723-1dd1d16f404d56a2.js
+src/fides/ui-build/static/admin/_next/static/chunks/4723-0a3c5e2ce143a7d0.js
 src/fides/ui-build/static/admin/_next/static/chunks/5258-0658dc2274df6832.js
 src/fides/ui-build/static/admin/_next/static/chunks/5277-e8a036319456127f.js
 src/fides/ui-build/static/admin/_next/static/chunks/5480-f49696df5e8ae500.js
 src/fides/ui-build/static/admin/_next/static/chunks/5487-3ad50d21cdbc9209.js
 src/fides/ui-build/static/admin/_next/static/chunks/570-c99f07161bd339cd.js
-src/fides/ui-build/static/admin/_next/static/chunks/5826-ef0aa43ffad83acc.js
+src/fides/ui-build/static/admin/_next/static/chunks/5826-e5dcb4e68cfe6289.js
 src/fides/ui-build/static/admin/_next/static/chunks/5973-52aee296edc44f7e.js
 src/fides/ui-build/static/admin/_next/static/chunks/6060-cb1ab5be7067bf7b.js
 src/fides/ui-build/static/admin/_next/static/chunks/618f8807-d15c33d1d6c8b961.js
@@ -846,10 +843,10 @@ src/fides/ui-build/static/admin/_next/static/chunks/6853-8941824350c3c1a8.js
 src/fides/ui-build/static/admin/_next/static/chunks/6954-3b887fb444f9228c.js
 src/fides/ui-build/static/admin/_next/static/chunks/7062.fda15dcb7df85675.js
 src/fides/ui-build/static/admin/_next/static/chunks/7088.eb76fca286e5f2e6.js
-src/fides/ui-build/static/admin/_next/static/chunks/7453-16efaa072db3fb50.js
+src/fides/ui-build/static/admin/_next/static/chunks/7453-39761c38da31257e.js
 src/fides/ui-build/static/admin/_next/static/chunks/7751-a8f31c062d4cb09d.js
-src/fides/ui-build/static/admin/_next/static/chunks/79-da725543986d4474.js
-src/fides/ui-build/static/admin/_next/static/chunks/7980-e39ce1290a97c1f5.js
+src/fides/ui-build/static/admin/_next/static/chunks/79-f9b948ebb186900f.js
+src/fides/ui-build/static/admin/_next/static/chunks/7980-4bd08957448dea32.js
 src/fides/ui-build/static/admin/_next/static/chunks/7c79804f.7a7112aece470725.js
 src/fides/ui-build/static/admin/_next/static/chunks/8433-b3008ecaf9834e7f.js
 src/fides/ui-build/static/admin/_next/static/chunks/8499-43606100edf42fdf.js
@@ -871,19 +868,19 @@ src/fides/ui-build/static/admin/_next/static/chunks/c78d26b1-88a3e1bacb2a03c2.js
 src/fides/ui-build/static/admin/_next/static/chunks/e3251fe7-5777b5d778e6fffa.js
 src/fides/ui-build/static/admin/_next/static/chunks/ea076c0a.84423f606aef37cd.js
 src/fides/ui-build/static/admin/_next/static/chunks/framework-c92fc3344e6fd165.js
-src/fides/ui-build/static/admin/_next/static/chunks/main-090643377c8254e6.js
-src/fides/ui-build/static/admin/_next/static/chunks/main-app-59156a9331ac7bce.js
+src/fides/ui-build/static/admin/_next/static/chunks/main-24f422f93845a596.js
+src/fides/ui-build/static/admin/_next/static/chunks/main-app-94a0711202e08b15.js
 src/fides/ui-build/static/admin/_next/static/chunks/polyfills-42372ed130431b0a.js
 src/fides/ui-build/static/admin/_next/static/chunks/webpack-2c7ccac5843c4d8e.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/404-b202c0d8f6fc75c3.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/_app-ebd046e432fec2dd.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/_app-fc89ce7bed454c84.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/_error-bede3a8288930dcf.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/add-systems-5b2f09f535f3902c.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/add-systems-d258f0c25fa020bf.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/ant-poc-b9932971a479f3a7.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/consent-39d65f13cc8f1cf8.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/data-catalog-900004e402c31797.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/datamap-8cb714cdd44ac40e.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset-632b1c68ccff81f7.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset-fa743ddc7f89d76b.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/datastore-connection-a78a73b65929853a.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/fides-js-docs-80b241bf6cddb72e.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/index-bfaacdb55a5a6c9f.js
@@ -897,9 +894,9 @@ src/fides/ui-build/static/admin/_next/static/chunks/pages/taxonomy-16b4d75c49276
 src/fides/ui-build/static/admin/_next/static/chunks/pages/user-management-6c9ad62479a7d03e.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/add-systems/manual-9acaab973dfe86e2.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/add-systems/multiple-ba975134a85588f8.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/configure-a4e636eecaba5324.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/privacy-experience-9c6f4f09da0e79aa.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/privacy-notices-f863d0089fea3a76.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/configure-723cc3d4f5740ea6.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/privacy-experience-c946b33b0322b8ad.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/privacy-notices-ea57f9d6ad17e957.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/properties-e5748812ba055a56.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/reporting-788cf0e34829af46.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/consent/configure/add-vendors-b34e5324461d0c87.js
@@ -921,12 +918,12 @@ src/fides/ui-build/static/admin/_next/static/chunks/pages/data-discovery/action-
 src/fides/ui-build/static/admin/_next/static/chunks/pages/data-discovery/detection/[resourceUrn]-054ca46a782e99a5.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/data-discovery/discovery/[resourceUrn]-1da20aeb6fc995e4.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset/[datasetId]-6ba18f92ba561114.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset/new-5ea3184b333a0604.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset/new-803c1b577ab17ae3.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset/[datasetId]/[collectionName]-7e5df4a0de7540bb.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/dataset/[datasetId]/[collectionName]/[...subfieldNames]-d79551d4c64c398c.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/datastore-connection/[id]-bbe1ca2793798e6b.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/datastore-connection/new-abc17fef69cd951b.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/integrations/[id]-aab61946892f8b2a.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/integrations/[id]-d4329043219fed9b.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/login/[provider]-c58beef131c3a82d.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/messaging/[id]-ad02e019b2467958.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/messaging/add-template-f9693cb6a0b7ded8.js
@@ -936,17 +933,17 @@ src/fides/ui-build/static/admin/_next/static/chunks/pages/privacy-requests/confi
 src/fides/ui-build/static/admin/_next/static/chunks/pages/privacy-requests/configure/storage-9f7eaad05e5b9292.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/properties/[id]-94e2faa73dd6a3e6.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/properties/add-property-630a6a3dd6502ba6.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/reporting/datamap-9ecac9a5c69e3c88.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/reporting/datamap-afedc48ef4e7f858.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/about-a49d0f84cf0cf05e.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/consent-50c05ccbf659258b.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/custom-fields-07d64b4b5ca57677.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/domain-records-72ec54ee8755a503.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/consent-89524101b7279f6e.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/custom-fields-52d030b1db2ca1b9.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/domain-records-fa42d8f18df44927.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/domains-24cba38685dc872c.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/email-templates-6fd6071e2009b8f2.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/locations-66c757325cb58467.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/organization-a08693d0d1e10bc8.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/settings/regulations-c6c239996cfa6ae8.js
-src/fides/ui-build/static/admin/_next/static/chunks/pages/systems/configure/[id]-8aae66669bdc0883.js
+src/fides/ui-build/static/admin/_next/static/chunks/pages/systems/configure/[id]-4f5a28226575c976.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/systems/configure/[id]/test-datasets-151571cff4e85894.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/user-management/new-be690621a944bfe2.js
 src/fides/ui-build/static/admin/_next/static/chunks/pages/user-management/profile/[id]-78eaf933f755bfe8.js

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/_version.py

@@ -8,11 +8,11 @@ import json
 
 version_json = '''
 {
- "date": "2025-03-31T14:46:07-0500",
+ "date": "2025-04-02T12:06:35-0600",
  "dirty": true,
  "error": null,
- "full-revisionid": "4dc777faf9597811772a978713d8444e651de0d1",
- "version": "2.58.1b4"
+ "full-revisionid": "8acf1908449d28a9d2b040b52b42b44afbc23628",
+ "version": "2.58.1rc0"
 }
 '''  # END VERSION_JSON
 

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/db/base.py

@@ -8,7 +8,6 @@ from fides.api.models.attachment import Attachment, AttachmentReference
 from fides.api.models.audit_log import AuditLog
 from fides.api.models.authentication_request import AuthenticationRequest
 from fides.api.models.client import ClientDetail
-from fides.api.models.comment import Comment, CommentReference
 from fides.api.models.connectionconfig import ConnectionConfig
 from fides.api.models.consent_automation import ConsentAutomation
 from fides.api.models.custom_asset import CustomAsset

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/models/attachment.py

@@ -1,13 +1,11 @@
 import os
 from enum import Enum as EnumType
-from io import BytesIO
-from typing import IO, TYPE_CHECKING, Any, Optional, Tuple, Union
+from typing import IO, Any, Optional
 
-from fideslang.validation import AnyHttpUrlString
 from loguru import logger as log
 from sqlalchemy import Column
 from sqlalchemy import Enum as EnumColumn
-from sqlalchemy import ForeignKey, String, UniqueConstraint, orm
+from sqlalchemy import ForeignKey, String, UniqueConstraint
 from sqlalchemy.ext.declarative import declared_attr
 from sqlalchemy.orm import Session, relationship
 
@@ -25,10 +23,6 @@ from fides.api.service.storage.util import (
     get_local_filename,
 )
 
-if TYPE_CHECKING:
-    from fides.api.models.comment import Comment
-    from fides.api.models.privacy_request import PrivacyRequest
-
 
 class AttachmentType(str, EnumType):
     """
@@ -59,9 +53,7 @@ class AttachmentReference(Base):
         """Overriding base class method to set the table name."""
         return "attachment_reference"
 
-    attachment_id = Column(
-        String, ForeignKey("attachment.id", ondelete="CASCADE"), nullable=False
-    )
+    attachment_id = Column(String, ForeignKey("attachment.id"), nullable=False)
     reference_id = Column(String, nullable=False)
     reference_type = Column(EnumColumn(AttachmentReferenceType), nullable=False)
 
@@ -71,8 +63,11 @@ class AttachmentReference(Base):
         ),
     )
 
-    # Relationships
-    attachment = relationship("Attachment", back_populates="references")
+    attachment = relationship(
+        "Attachment",
+        back_populates="references",
+        uselist=False,
+    )
 
     @classmethod
     def create(
@@ -105,11 +100,8 @@ class Attachment(Base):
     references = relationship(
         "AttachmentReference",
         back_populates="attachment",
-        cascade="all, delete-orphan",
+        cascade="all, delete",
         uselist=True,
-        foreign_keys=[AttachmentReference.attachment_id],
-        primaryjoin=lambda: Attachment.id
-        == orm.foreign(AttachmentReference.attachment_id),
     )
 
     config = relationship(
@@ -135,34 +127,13 @@ class Attachment(Base):
 
         if self.config.type == StorageType.local:
             filename = get_local_filename(self.id)
-
-            # Validate that attachment is a file-like object
-            if not hasattr(attachment, "read"):
-                raise TypeError(f"Expected a file-like object, got {type(attachment)}")
-
-            # Reset the file pointer to the beginning
-            try:
-                attachment.seek(0)
-            except Exception as e:
-                raise ValueError(f"Failed to reset file pointer for attachment: {e}")
-
-            # Write the file in chunks to avoid loading the entire content into memory
             with open(filename, "wb") as file:
-                for chunk in iter(
-                    lambda: attachment.read(1024 * 1024), b""
-                ):  # 1 MB chunks
-                    if not isinstance(chunk, bytes):
-                        raise TypeError(f"Expected bytes, got {type(chunk)}")
-                    file.write(chunk)
-
-            log.info(f"Uploaded {self.file_name} to local storage at {filename}")
+                file.write(attachment.read())
             return
 
         raise ValueError(f"Unsupported storage type: {self.config.type}")
 
-    def retrieve_attachment(
-        self,
-    ) -> Optional[Tuple[BytesIO, Union[AnyHttpUrlString, str]]]:
+    def retrieve_attachment(self) -> Optional[bytes]:
         """Returns the attachment from S3 in bytes form."""
         if self.config.type == StorageType.s3:
             bucket_name = f"{self.config.details[StorageDetails.BUCKET.value]}"
@@ -237,44 +208,4 @@ class Attachment(Base):
     def delete(self, db: Session) -> None:
         """Deletes an attachment record from the database and deletes the attachment from S3."""
         self.delete_attachment_from_storage()
-        for attachment_reference in self.references:
-            attachment_reference.delete(db)
         super().delete(db=db)
-
-    @staticmethod
-    def delete_attachments_for_reference_and_type(
-        db: Session, reference_id: str, reference_type: AttachmentReferenceType
-    ) -> None:
-        """
-        Deletes attachments associated with a given reference_id and reference_type.
-        Deletes all references to the attachments.
-
-        Args:
-            db: Database session
-            reference_id: ID of the reference
-            reference_type: Type of the reference
-
-        Examples:
-
-        - Delete all attachments associated with a comment.
-           ``Attachment.delete_attachments_for_reference_and_type(
-               db, comment.id, AttachmentReferenceType.comment
-           )``
-        - Delete all attachments associated with a privacy request.
-           ``Attachment.delete_attachments_for_reference_and_type(
-               db, privacy_request.id, AttachmentReferenceType.privacy_request
-            )``
-        """
-        # Query attachments explicitly to avoid lazy loading
-        attachments = (
-            db.query(Attachment)
-            .join(AttachmentReference)
-            .filter(
-                AttachmentReference.reference_id == reference_id,
-                AttachmentReference.reference_type == reference_type,
-            )
-            .all()
-        )
-
-        for attachment in attachments:
-            attachment.delete(db)

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/models/comment.py

@@ -3,17 +3,15 @@ from typing import TYPE_CHECKING, Any
 
 from sqlalchemy import Column
 from sqlalchemy import Enum as EnumColumn
-from sqlalchemy import ForeignKey, String, UniqueConstraint, orm
+from sqlalchemy import ForeignKey, String, UniqueConstraint
 from sqlalchemy.ext.declarative import declared_attr
 from sqlalchemy.orm import Session, relationship
 
 from fides.api.db.base_class import Base
-from fides.api.models.attachment import Attachment, AttachmentReferenceType
 
 if TYPE_CHECKING:
-    from fides.api.models.attachment import AttachmentReference
+    from fides.api.models.attachment import Attachment
     from fides.api.models.fides_user import FidesUser
-    from fides.api.models.privacy_request import PrivacyRequest
 
 
 class CommentType(str, EnumType):
@@ -89,51 +87,23 @@ class Comment(Base):
     references = relationship(
         "CommentReference",
         back_populates="comment",
-        cascade="all, delete-orphan",
+        cascade="all, delete",
+        uselist=True,
+    )
+
+    attachments = relationship(
+        "Attachment",
+        secondary="attachment_reference",
+        primaryjoin="Comment.id == AttachmentReference.reference_id",
+        secondaryjoin="Attachment.id == AttachmentReference.attachment_id",
+        order_by="Attachment.created_at",
         uselist=True,
-        foreign_keys=[CommentReference.comment_id],
-        primaryjoin=lambda: Comment.id == orm.foreign(CommentReference.comment_id),
     )
 
     def delete(self, db: Session) -> None:
         """Delete the comment and all associated references."""
         # Delete the comment
-        Attachment.delete_attachments_for_reference_and_type(
-            db, self.id, AttachmentReferenceType.comment
-        )
-        for reference in self.references:
-            reference.delete(db)
+        for attachment in self.attachments:
+            if len(attachment.references) == 1:
+                attachment.delete(db)
         db.delete(self)
-
-    @staticmethod
-    def delete_comments_for_reference_and_type(
-        db: Session, reference_id: str, reference_type: CommentReferenceType
-    ) -> None:
-        """
-        Deletes comments associated with a given reference_id and reference_type.
-        Delete all references to the comments.
-
-        Args:
-            db: Database session.
-            reference_id: The reference id to delete.
-            reference_type: The reference type to delete
-
-        Examples:
-          - Delete all comments associated with a privacy request.
-            ``Comment.delete_comments_for_reference_and_type(
-                db, privacy_request.id, CommentReferenceType.privacy_request
-            )``
-        """
-        # Query comments explicitly to avoid lazy loading
-        comments = (
-            db.query(Comment)
-            .join(CommentReference)
-            .filter(
-                CommentReference.reference_id == reference_id,
-                CommentReference.reference_type == reference_type,
-            )
-            .all()
-        )
-
-        for comment in comments:
-            comment.delete(db)

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/models/privacy_experience.py

@@ -46,21 +46,6 @@ class Layer1ButtonOption(Enum):
 
     ACKNOWLEDGE = "acknowledge"
     OPT_IN_OPT_OUT = "opt_in_opt_out"
-    OPT_IN_ONLY = "opt_in_only"
-
-
-class RejectAllMechanism(Enum):
-    """
-    Reject all mechanism options - not formalized in the db.
-    Used to configure the behavior of the reject all button in TCF experiences
-    """
-
-    # Reject both consent and legitimate interest preferences (all purposes, special features, vendors)
-    # This is the default behavior
-    REJECT_ALL = "reject_all"
-    # Reject only consent preferences (all purposes, special features, vendors).
-    # Do not reject any legitimate interest preferences.
-    REJECT_CONSENT_ONLY = "reject_consent_only"
 
 
 # Fides JS UX Types - there should only be one of these defined per region
@@ -194,10 +179,6 @@ class PrivacyExperienceConfig(PrivacyExperienceConfigBase, Base):
     The Privacy Experience Configuration model that stores shared configuration for Privacy Experiences.
 
     - Translations, Notices, and Regions (via Privacy Experiences) are linked to this resource.
-
-    If you're adding a new PrivacyExperienceConfig, make sure to use the `create` method since it has
-    custom logic that ensures other resources are created/updated as needed, as well as setting the
-    expected values for some fields in the experience config itself.
     """
 
     allow_language_selection = Column(
@@ -222,13 +203,6 @@ class PrivacyExperienceConfig(PrivacyExperienceConfigBase, Base):
         String, ForeignKey(ExperienceConfigTemplate.id_field_path)
     )  # The template from which this config was created if applicable
 
-    # Mechanism to use when the reject all button is clicked in a TCF experience
-    # Nullable because this is not applicable for other experience types
-    reject_all_mechanism = Column(
-        EnumColumn(RejectAllMechanism),
-        nullable=True,
-    )
-
     # Relationships
     experiences = relationship(
         "PrivacyExperience",
@@ -330,15 +304,6 @@ class PrivacyExperienceConfig(PrivacyExperienceConfigBase, Base):
         # Link Properties to this Privacy Experience config via the PrivacyExperienceConfigProperty table
         link_properties_to_experience_config(db, properties, experience_config)
 
-        # If the reject all mechanism is not set and the experience config is a TCF experience,
-        # set the reject all mechanism to REJECT_ALL
-        if (
-            experience_config.component == ComponentType.tcf_overlay
-            and experience_config.reject_all_mechanism is None
-        ):
-            experience_config.reject_all_mechanism = RejectAllMechanism.REJECT_ALL  # type: ignore
-            experience_config.save(db)
-
         return experience_config
 
     def update(self, db: Session, *, data: dict[str, Any]) -> PrivacyExperienceConfig:
@@ -542,13 +507,6 @@ class PrivacyExperienceConfigHistory(
         index=True,
     )  # If a translation is deleted, this is set to null, but the overall record remains in the database for reporting purposes
 
-    # Mechanism to use when the reject all button is clicked in a TCF experience
-    # Nullable because this is not applicable for other experience types
-    reject_all_mechanism = Column(
-        EnumColumn(RejectAllMechanism),
-        nullable=True,
-    )
-
     version = Column(Float, nullable=False, default=1.0)
 
 

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/models/privacy_request/privacy_request.py

@@ -39,14 +39,10 @@ from fides.api.graph.config import (
     CollectionAddress,
 )
 from fides.api.migrations.hash_migration_mixin import HashMigrationMixin
-from fides.api.models.attachment import (
-    Attachment,
-    AttachmentReference,
-    AttachmentReferenceType,
-)
+from fides.api.models.attachment import Attachment, AttachmentReference
 from fides.api.models.audit_log import AuditLog
 from fides.api.models.client import ClientDetail
-from fides.api.models.comment import Comment, CommentReference, CommentReferenceType
+from fides.api.models.comment import Comment, CommentReference
 from fides.api.models.fides_user import FidesUser
 from fides.api.models.manual_webhook import AccessManualWebhook
 from fides.api.models.policy import (
@@ -173,25 +169,18 @@ class PrivacyRequest(
         backref="privacy_requests",
     )
     attachments = relationship(
-        "Attachment",
+        Attachment,
         secondary="attachment_reference",
-        primaryjoin="and_(PrivacyRequest.id == AttachmentReference.reference_id, "
-        "AttachmentReference.reference_type == 'privacy_request')",
+        primaryjoin="PrivacyRequest.id == AttachmentReference.reference_id",
         secondaryjoin="Attachment.id == AttachmentReference.attachment_id",
         order_by="Attachment.created_at",
-        viewonly=True,
-        uselist=True,
     )
-
     comments = relationship(
-        "Comment",
+        Comment,
         secondary="comment_reference",
-        primaryjoin="and_(PrivacyRequest.id == CommentReference.reference_id, "
-        "CommentReference.reference_type == 'privacy_request')",
+        primaryjoin="PrivacyRequest.id == CommentReference.reference_id",
         secondaryjoin="Comment.id == CommentReference.comment_id",
         order_by="Comment.created_at",
-        viewonly=True,
-        uselist=True,
     )
     property_id = Column(String, nullable=True)
 
@@ -334,12 +323,6 @@ class PrivacyRequest(
         deleting this object from the database
         """
         self.clear_cached_values()
-        Attachment.delete_attachments_for_reference_and_type(
-            db, self.id, AttachmentReferenceType.privacy_request
-        )
-        Comment.delete_comments_for_reference_and_type(
-            db, self.id, CommentReferenceType.privacy_request
-        )
 
         for provided_identity in self.provided_identities:  # type: ignore[attr-defined]
             provided_identity.delete(db=db)

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/api/service/storage/s3.py

@@ -64,7 +64,7 @@ def generic_upload_to_s3(  # pylint: disable=R0913
     size_threshold: int = LARGE_FILE_THRESHOLD,  # 5 MB threshold
 ) -> Optional[AnyHttpUrlString]:
     """
-    Uploads file like objects to S3.
+    Uploads arbitrary data to S3 returned from an access request.
     Handles both small and large uploads.
 
     :param storage_secrets: S3 storage secrets
@@ -75,19 +75,6 @@ def generic_upload_to_s3(  # pylint: disable=R0913
     """
     logger.info("Starting S3 Upload of {}", file_key)
 
-    # Validate that the document is a file-like object
-    if not hasattr(document, "read") or not hasattr(document, "seek"):
-        raise TypeError(
-            f"The 'document' parameter must be a file-like object supporting 'read' and 'seek'. "
-            f"Received: {type(document)}"
-        )
-
-    # Ensure the file pointer is at the beginning
-    try:
-        document.seek(0)
-    except Exception as e:
-        raise ValueError(f"Failed to reset file pointer for document: {e}")
-
     s3_client = maybe_get_s3_client(auth_method, storage_secrets)
 
     # Define a transfer configuration for multipart uploads

{ethyca_fides-2.58.1b4 → ethyca_fides-2.58.1rc0}/src/fides/ui-build/static/admin/404.html

@@ -1 +1 @@
-<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link data-next-font="" rel="preconnect" href="/" crossorigin="anonymous"/><link rel="preload" href="/_next/static/css/113d823fe71f6af0.css" as="style"/><link rel="stylesheet" href="/_next/static/css/113d823fe71f6af0.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills-42372ed130431b0a.js"></script><script src="/_next/static/chunks/webpack-2c7ccac5843c4d8e.js" defer=""></script><script src="/_next/static/chunks/framework-c92fc3344e6fd165.js" defer=""></script><script src="/_next/static/chunks/main-090643377c8254e6.js" defer=""></script><script src="/_next/static/chunks/pages/_app-ebd046e432fec2dd.js" defer=""></script><script src="/_next/static/chunks/pages/404-b202c0d8f6fc75c3.js" defer=""></script><script src="/_next/static/LFNq-viakwWPa01GpNMoV/_buildManifest.js" defer=""></script><script src="/_next/static/LFNq-viakwWPa01GpNMoV/_ssgManifest.js" defer=""></script><style>.data-ant-cssinjs-cache-path{content:"";}</style></head><body><div id="__next"><div style="height:100%;display:flex"></div></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/404","query":{},"buildId":"LFNq-viakwWPa01GpNMoV","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script></body></html>
+<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link data-next-font="" rel="preconnect" href="/" crossorigin="anonymous"/><link rel="preload" href="/_next/static/css/113d823fe71f6af0.css" as="style"/><link rel="stylesheet" href="/_next/static/css/113d823fe71f6af0.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills-42372ed130431b0a.js"></script><script src="/_next/static/chunks/webpack-2c7ccac5843c4d8e.js" defer=""></script><script src="/_next/static/chunks/framework-c92fc3344e6fd165.js" defer=""></script><script src="/_next/static/chunks/main-24f422f93845a596.js" defer=""></script><script src="/_next/static/chunks/pages/_app-fc89ce7bed454c84.js" defer=""></script><script src="/_next/static/chunks/pages/404-b202c0d8f6fc75c3.js" defer=""></script><script src="/_next/static/7Gn2YyMsVjWkBPSaVWEi9/_buildManifest.js" defer=""></script><script src="/_next/static/7Gn2YyMsVjWkBPSaVWEi9/_ssgManifest.js" defer=""></script><style>.data-ant-cssinjs-cache-path{content:"";}</style></head><body><div id="__next"><div style="height:100%;display:flex"></div></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/404","query":{},"buildId":"7Gn2YyMsVjWkBPSaVWEi9","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script></body></html>