engineering-process 1.2.1__tar.gz → 1.2.3__tar.gz

{engineering_process-1.2.1/engineering_process.egg-info → engineering_process-1.2.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.2.1
+Version: 1.2.3
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process
@@ -422,6 +422,10 @@ review identities.
 It rejects missing, repeated, misplaced, hidden, unordered, or unsupported visible
 structure. Completion checkboxes belong only to the Completion gate section. Ready
 pull requests must have every checkbox checked; drafts may retain unchecked work.
+One trailing `Refs ISSUE.` line remains optional. A ready, contract-identified final
+consumer adoption may instead use `Closes ISSUE, closes OWNER/REPOSITORY#NUMBER.` with
+the complete keyword/reference syntax repeated for every issue; drafts cannot close
+issues. Producer and intermediate pull requests do not close release-source issues.
 The managed template never solicits execution identity,
 and authors plus independent review keep it out of free-form values. The validator is
 a positive grammar for public fields; it deliberately does not guess identities from

{engineering_process-1.2.1 → engineering_process-1.2.3}/README.md

@@ -398,6 +398,10 @@ review identities.
 It rejects missing, repeated, misplaced, hidden, unordered, or unsupported visible
 structure. Completion checkboxes belong only to the Completion gate section. Ready
 pull requests must have every checkbox checked; drafts may retain unchecked work.
+One trailing `Refs ISSUE.` line remains optional. A ready, contract-identified final
+consumer adoption may instead use `Closes ISSUE, closes OWNER/REPOSITORY#NUMBER.` with
+the complete keyword/reference syntax repeated for every issue; drafts cannot close
+issues. Producer and intermediate pull requests do not close release-source issues.
 The managed template never solicits execution identity,
 and authors plus independent review keep it out of free-form values. The validator is
 a positive grammar for public fields; it deliberately does not guess identities from

{engineering_process-1.2.1 → engineering_process-1.2.3}/engineering_process/__init__.py

@@ -1,3 +1,3 @@
 """Agent-neutral engineering process."""
 
-VERSION = "1.2.1"
+VERSION = "1.2.3"

{engineering_process-1.2.1 → engineering_process-1.2.3}/engineering_process/publication_compat.py

@@ -53,8 +53,9 @@ PR_CHECKS = (
 )
 FENCE = re.compile(r"^ {0,3}(`{3,}|~{3,})(.*)$")
 NON_MARKDOWN_LINE_SEPARATOR = re.compile("[\v\f\x85\u2028\u2029]")
+ISSUE_TARGET = r"(?:[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+)?#[1-9][0-9]*"
 ISSUE_REFERENCE = re.compile(
-    r"^Refs (?:[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+)?#[1-9][0-9]*\.$"
+    rf"^(?:Refs {ISSUE_TARGET}|Closes {ISSUE_TARGET}(?:, closes {ISSUE_TARGET})*)\.$"
 )
 
 
@@ -232,6 +233,10 @@ def _pull_request_body_issues(body: str, state: str) -> list[str]:
         and reference_positions[0] <= checklist_positions[-1]
     ):
         issues.append("pull request body issue reference must follow the checklist")
+    if state == "draft" and any(
+        lines[position].startswith("Closes ") for position in reference_positions
+    ):
+        issues.append("draft pull request cannot close issues")
     field_patterns = tuple(
         re.compile(rf"^- {re.escape(field)}:\s*.*$")
         for fields in PR_FIELDS.values()

{engineering_process-1.2.1 → engineering_process-1.2.3/engineering_process.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.2.1
+Version: 1.2.3
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process
@@ -422,6 +422,10 @@ review identities.
 It rejects missing, repeated, misplaced, hidden, unordered, or unsupported visible
 structure. Completion checkboxes belong only to the Completion gate section. Ready
 pull requests must have every checkbox checked; drafts may retain unchecked work.
+One trailing `Refs ISSUE.` line remains optional. A ready, contract-identified final
+consumer adoption may instead use `Closes ISSUE, closes OWNER/REPOSITORY#NUMBER.` with
+the complete keyword/reference syntax repeated for every issue; drafts cannot close
+issues. Producer and intermediate pull requests do not close release-source issues.
 The managed template never solicits execution identity,
 and authors plus independent review keep it out of free-form values. The validator is
 a positive grammar for public fields; it deliberately does not guess identities from

{engineering_process-1.2.1 → engineering_process-1.2.3}/engineering_process.egg-info/SOURCES.txt

@@ -67,6 +67,7 @@ tests/test_distribution.py
 tests/test_lifecycle.py
 tests/test_production_engineering.py
 tests/test_publication_compat.py
+tests/test_pypi_cache_horizon.py
 tests/test_release.py
 tests/test_repository.py
 tests/test_skills.py

{engineering_process-1.2.1 → engineering_process-1.2.3}/process_assets/skills/finish-change/SKILL.md

@@ -15,6 +15,12 @@ The command writes one bounded completion receipt and marks the run completed.
 Completion does not itself grant merge, deployment, or release authority; those
 remain project-owned operations. Never report completion from prose alone.
 
+Use a normal trailing `Refs ISSUE.` line for producer and intermediate pull requests.
+Only a contract-identified final consumer adoption that has verified the released
+behavior may use `Closes ISSUE, closes ISSUE.` after the completed public checklist.
+Repeat the full keyword and local or `OWNER/REPOSITORY#NUMBER` reference for every
+issue; never close source issues merely because the producer release merged.
+
 Report the readiness capabilities protected or advanced and the remaining planned
 gaps after completion. Carry the owner and stable record URL for every accepted-risk
 or tracked-follow-up disposition into the durable handoff. Finish never edits

{engineering_process-1.2.1 → engineering_process-1.2.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "engineering-process"
-version = "1.2.1"
+version = "1.2.3"
 description = "A small agent-neutral engineering lifecycle with managed adoption"
 readme = "README.md"
 license = "MIT"

{engineering_process-1.2.1 → engineering_process-1.2.3}/templates/PULL_REQUEST_TEMPLATE.md

@@ -34,4 +34,6 @@ tracked-follow-up entries need an owner and durable HTTPS record. -->
 - [ ] Required profiles pass on the reviewed snapshot.
 - [ ] Independent review approved with no blocking finding.
 - [ ] Every non-blocking finding has a recorded disposition.
+<!-- Producer/intermediate PR: Refs ISSUE. Final verified consumer adoption only:
+Closes ISSUE, closes OWNER/REPOSITORY#NUMBER. Repeat the keyword for every issue. -->
 <!-- engineering-process:pr-description:end -->

{engineering_process-1.2.1 → engineering_process-1.2.3}/tests/test_automation.py

@@ -55,6 +55,8 @@ class AutomationTests(unittest.TestCase):
             template.index("## Completion gate"),
         )
         self.assertIn("Every non-blocking finding has a recorded disposition.", template)
+        self.assertIn("Final verified consumer adoption only", template)
+        self.assertIn("Closes ISSUE, closes OWNER/REPOSITORY#NUMBER", template)
 
     def test_renovate_process_rule_materializes_the_complete_adoption(self) -> None:
         config = json.loads((ROOT / ".github" / "renovate.json").read_text(encoding="utf-8"))
@@ -103,6 +105,31 @@ class AutomationTests(unittest.TestCase):
             "  dispatch-adoption:\n    name: Dispatch consumer adoption\n", workflow
         )
         self.assertIn("needs: [metadata, publish]", workflow)
+        dispatch_job = workflow.split("\n  dispatch-adoption:\n", maxsplit=1)[1]
+        self.assertIn("    timeout-minutes: 20\n", dispatch_job)
+        cache_wait = dispatch_job.split(
+            "      - name: Wait for consumer Simple caches to expire\n", maxsplit=1
+        )[1].split(
+            "      - name: Create short-lived Renovate event token\n", maxsplit=1
+        )[0]
+        self.assertIn(
+            "python verification/wait_for_pypi_cache_horizon.py",
+            cache_wait,
+        )
+        self.assertIn("${{ steps.release.outputs.published_at }}", cache_wait)
+        self.assertIn(
+            "ref: ${{ github.sha }}",
+            dispatch_job,
+        )
+        self.assertNotIn("ref: ${{ needs.metadata.outputs.source_sha }}", dispatch_job)
+        self.assertIn(
+            'published_at=$(gh release view "$RELEASE_TAG"',
+            dispatch_job,
+        )
+        self.assertLess(
+            dispatch_job.index("      - name: Bind the published distribution\n"),
+            dispatch_job.index("      - name: Wait for consumer Simple caches to expire\n"),
+        )
         self.assertIn("Verify PyPI exposes the exact built hashes", workflow)
         visibility = workflow.split(
             "      - name: Verify PyPI exposes the exact built hashes\n", maxsplit=1
@@ -140,6 +167,8 @@ class AutomationTests(unittest.TestCase):
         publish_job = workflow.split("  publish:\n", maxsplit=1)[1].split(
             "\n  dispatch-adoption:\n", maxsplit=1
         )[0]
+        self.assertIn("ref: ${{ needs.metadata.outputs.source_sha }}", publish_job)
+        self.assertNotIn("ref: ${{ github.sha }}", publish_job)
         self.assertIn("id: release-token", publish_job)
         self.assertIn("repositories: engineering-process", publish_job)
         self.assertIn("permission-contents: write", publish_job)

{engineering_process-1.2.1 → engineering_process-1.2.3}/tests/test_publication_compat.py

@@ -290,6 +290,42 @@ class PublicationCompatibilityTests(unittest.TestCase):
             self.validate_body(repeated),
         )
 
+    def test_final_adoption_can_close_multiple_issues_only_when_ready(self) -> None:
+        closing = (
+            f"{CANONICAL_BODY}\n"
+            "Closes example/process#123, closes #456, closes other/repository#789.\n"
+        )
+        self.assertEqual([], self.validate_body(closing))
+        self.assertIn(
+            "draft pull request cannot close issues",
+            self.validate_body(closing, state="draft"),
+        )
+
+        unchecked = closing.replace(
+            "- [x] Required profiles", "- [ ] Required profiles", 1
+        )
+        self.assertIn(
+            "ready pull request has unchecked item: Required profiles pass on the reviewed snapshot.",
+            self.validate_body(unchecked),
+        )
+
+        for malformed in (
+            "Closes example/process#123, #456.",
+            "Closes example/process#123, Closes #456.",
+            "Fixes example/process#123.",
+            "Closes example/process#0.",
+        ):
+            with self.subTest(malformed=malformed):
+                issues = self.validate_body(f"{CANONICAL_BODY}\n{malformed}\n")
+                self.assertTrue(
+                    any(
+                        issue.startswith(
+                            "pull request body has unsupported visible content at line "
+                        )
+                        for issue in issues
+                    )
+                )
+
     def test_pull_request_ignores_template_comments(self) -> None:
         body = CANONICAL_BODY.replace(
             "- Outcome: Preserve the requested behavior.",

engineering_process-1.2.3/tests/test_pypi_cache_horizon.py

@@ -0,0 +1,81 @@
+from datetime import datetime, timezone
+from email.message import Message
+import unittest
+from unittest.mock import patch
+
+from verification.wait_for_pypi_cache_horizon import (
+    MAX_SIMPLE_CACHE_SECONDS,
+    read_simple_max_age,
+    parse_max_age,
+    remaining_seconds,
+)
+
+
+class _Response:
+    def __init__(self, headers: Message) -> None:
+        self.headers = headers
+
+    def __enter__(self) -> "_Response":
+        return self
+
+    def __exit__(self, *args: object) -> None:
+        return None
+
+
+class PyPICacheHorizonTests(unittest.TestCase):
+    NOW = datetime(2026, 9, 4, 13, 30, tzinfo=timezone.utc)
+
+    def test_parses_current_bounded_header(self) -> None:
+        self.assertEqual(600, parse_max_age(["max-age=600, public"]))
+        self.assertEqual(
+            MAX_SIMPLE_CACHE_SECONDS,
+            parse_max_age([f"public, max-age={MAX_SIMPLE_CACHE_SECONDS}"]),
+        )
+
+    def test_rejects_missing_duplicate_malformed_and_excessive_max_age(self) -> None:
+        invalid = [
+            None,
+            ["public"],
+            ["max-age=600", "max-age=300"],
+            ["max-age=-1"],
+            ["max-age=invalid"],
+            [f"max-age={MAX_SIMPLE_CACHE_SECONDS + 1}"],
+        ]
+        for values in invalid:
+            with self.subTest(values=values), self.assertRaises(RuntimeError):
+                parse_max_age(values)
+
+    def test_reads_every_cache_control_field(self) -> None:
+        headers = Message()
+        headers["Content-Type"] = "application/vnd.pypi.simple.v1+json"
+        headers["Cache-Control"] = "public, max-age=600"
+        headers["Cache-Control"] = "max-age=300"
+        with patch(
+            "verification.wait_for_pypi_cache_horizon.urlopen",
+            return_value=_Response(headers),
+        ), self.assertRaises(RuntimeError):
+            read_simple_max_age()
+
+    def test_current_horizon_and_elapsed_resume(self) -> None:
+        self.assertEqual(
+            305,
+            remaining_seconds("2026-09-04T13:20:00Z", 900, now=self.NOW),
+        )
+        self.assertEqual(
+            0,
+            remaining_seconds("2026-09-04T13:00:00Z", 600, now=self.NOW),
+        )
+
+    def test_rejects_malformed_naive_and_future_timestamps(self) -> None:
+        invalid = [
+            "invalid",
+            "2026-09-04T13:20:00",
+            "2026-09-04T13:31:01Z",
+        ]
+        for published_at in invalid:
+            with self.subTest(published_at=published_at), self.assertRaises(RuntimeError):
+                remaining_seconds(published_at, 600, now=self.NOW)
+
+
+if __name__ == "__main__":
+    unittest.main()

{engineering_process-1.2.1 → engineering_process-1.2.3}/tests/test_skills.py

@@ -78,6 +78,8 @@ class SkillTests(unittest.TestCase):
                 "Finish never edits\nreadiness",
                 "remaining planned\ngaps",
                 "owner and stable record URL",
+                "contract-identified final consumer adoption",
+                "Closes ISSUE, closes ISSUE",
             ),
             "improve-process": (
                 "new immutable pack version",