engineering-process 1.1.1__tar.gz → 1.1.2__tar.gz

{engineering_process-1.1.1/engineering_process.egg-info → engineering_process-1.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.1.1
+Version: 1.1.2
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process

{engineering_process-1.1.1 → engineering_process-1.1.2}/engineering_process/__init__.py

@@ -1,3 +1,3 @@
 """Agent-neutral engineering process."""
 
-VERSION = "1.1.1"
+VERSION = "1.1.2"

{engineering_process-1.1.1 → engineering_process-1.1.2}/engineering_process/commands.py

@@ -155,6 +155,7 @@ def _run_check(project_root: Path, check: dict[str, Any]) -> dict[str, Any]:
             )
             descendants = descendants or cleanup.descendants_found
             cleanup_error = cleanup_error or cleanup.error
+            cleanup_error = cleanup_error or (None if cleanup.bounded else "unbounded cleanup")
     exit_code = process.returncode if process.returncode is not None else -1
 
     for reader in readers:
@@ -173,7 +174,6 @@ def _run_check(project_root: Path, check: dict[str, Any]) -> dict[str, Any]:
         exit_code == 0
         and not timed_out
         and not output_exceeded
-        and not descendants
         and not stream_failed
     )
     return {

{engineering_process-1.1.1 → engineering_process-1.1.2/engineering_process.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.1.1
+Version: 1.1.2
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process

{engineering_process-1.1.1 → engineering_process-1.1.2}/process_assets/skills/verify-change/SKILL.md

@@ -11,9 +11,10 @@ profile through the lifecycle:
     processctl change verify --change-id ID --profile PROFILE
 
 Commands are exact argument arrays with timeouts. Do not substitute a different tool
-or narrower check when a required command fails. A command failure, timeout,
-surviving descendant, or tracked repository mutation is a failure and leaves the
-change in implementing.
+or narrower check when a required command fails. A command failure, timeout, output
+or stream failure, failed descendant cleanup, or tracked repository mutation is a
+failure and leaves the change in implementing. Successfully cleaned post-exit
+descendants remain recorded without replacing the foreground command result.
 
 The contract must already include conditional profiles required by affected enforced
 capabilities. Run those profiles exactly; do not run every planned production gate for

{engineering_process-1.1.1 → engineering_process-1.1.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "engineering-process"
-version = "1.1.1"
+version = "1.1.2"
 description = "A small agent-neutral engineering lifecycle with managed adoption"
 readme = "README.md"
 license = "MIT"

{engineering_process-1.1.1 → engineering_process-1.1.2}/tests/test_commands.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+import ctypes
+import io
 import os
 from pathlib import Path
 import subprocess
@@ -7,8 +9,38 @@ import sys
 import tempfile
 import time
 import unittest
+from unittest.mock import Mock, patch
 
 from engineering_process.commands import run_check, run_profile
+from engineering_process.supervision import CleanupOutcome
+
+
+def windows_process_is_running(process_id: int) -> bool:
+    from ctypes import wintypes
+
+    synchronize = 0x00100000
+    wait_failed = 0xFFFFFFFF
+    wait_timeout = 0x00000102
+    kernel32 = ctypes.WinDLL("kernel32", use_last_error=True)
+    kernel32.OpenProcess.argtypes = [wintypes.DWORD, wintypes.BOOL, wintypes.DWORD]
+    kernel32.OpenProcess.restype = wintypes.HANDLE
+    kernel32.WaitForSingleObject.argtypes = [wintypes.HANDLE, wintypes.DWORD]
+    kernel32.WaitForSingleObject.restype = wintypes.DWORD
+    kernel32.CloseHandle.argtypes = [wintypes.HANDLE]
+    kernel32.CloseHandle.restype = wintypes.BOOL
+    handle = kernel32.OpenProcess(synchronize, False, process_id)
+    if not handle:
+        error = ctypes.get_last_error()
+        if error == 87:  # ERROR_INVALID_PARAMETER: the PID no longer exists.
+            return False
+        raise ctypes.WinError(error)
+    try:
+        result = kernel32.WaitForSingleObject(handle, 0)
+        if result == wait_failed:
+            raise ctypes.WinError(ctypes.get_last_error())
+        return result == wait_timeout
+    finally:
+        kernel32.CloseHandle(handle)
 
 
 class CommandTests(unittest.TestCase):
@@ -64,6 +96,27 @@ class CommandTests(unittest.TestCase):
         self.assertEqual("failed", report["status"])
         self.assertTrue(report["timedOut"])
 
+    def test_unbounded_cleanup_fails_without_an_adapter_error(self) -> None:
+        process = Mock(stdout=io.BytesIO(), stderr=io.BytesIO(), returncode=0)
+        process.poll.return_value = 0
+        supervisor = Mock()
+        supervisor.spawn.return_value = process
+        supervisor.finalize.return_value = CleanupOutcome(bounded=False)
+        with tempfile.TemporaryDirectory() as directory, patch(
+            "engineering_process.commands.process_supervisor",
+            return_value=supervisor,
+        ):
+            report = run_check(
+                Path(directory),
+                {
+                    "id": "unbounded-cleanup",
+                    "run": [sys.executable, "-c", "raise SystemExit(0)"],
+                    "timeoutSeconds": 10,
+                },
+            )
+        self.assertEqual("failed", report["status"])
+        self.assertTrue(report["streamFailed"])
+
     @unittest.skipUnless(
         sys.platform.startswith("linux"), "Linux subreaper ownership assertion"
     )
@@ -93,7 +146,7 @@ class CommandTests(unittest.TestCase):
             unrelated.wait(timeout=3)
 
     @unittest.skipIf(os.name == "nt", "POSIX process-group assertion")
-    def test_surviving_descendant_is_terminated_and_fails(self) -> None:
+    def test_surviving_descendant_is_terminated_after_success(self) -> None:
         script = (
             "import subprocess, sys; "
             "subprocess.Popen([sys.executable, '-c', 'import time; time.sleep(30)']); "
@@ -108,7 +161,7 @@ class CommandTests(unittest.TestCase):
                     "timeoutSeconds": 10,
                 },
             )
-        self.assertEqual("failed", report["status"])
+        self.assertEqual("passed", report["status"])
         self.assertTrue(report["descendantsTerminated"])
 
     @unittest.skipUnless(
@@ -142,7 +195,7 @@ class CommandTests(unittest.TestCase):
     @unittest.skipUnless(
         sys.platform.startswith("linux"), "Linux subreaper containment assertion"
     )
-    def test_detached_descendant_is_terminated_and_fails(self) -> None:
+    def test_detached_descendant_is_terminated_after_success(self) -> None:
         with tempfile.TemporaryDirectory() as directory:
             root = Path(directory)
             pid_path = root / "child.pid"
@@ -166,12 +219,12 @@ class CommandTests(unittest.TestCase):
             deadline = time.monotonic() + 3
             while Path(f"/proc/{pid}").exists() and time.monotonic() < deadline:
                 time.sleep(0.02)
-        self.assertEqual("failed", report["status"])
+        self.assertEqual("passed", report["status"])
         self.assertTrue(report["descendantsTerminated"])
         self.assertFalse(Path(f"/proc/{pid}").exists())
 
     @unittest.skipUnless(os.name == "nt", "Windows Job Object containment assertion")
-    def test_windows_job_object_terminates_descendants(self) -> None:
+    def test_windows_job_object_terminates_descendants_after_success(self) -> None:
         with tempfile.TemporaryDirectory() as directory:
             root = Path(directory)
             pid_path = root / "child.pid"
@@ -189,8 +242,10 @@ class CommandTests(unittest.TestCase):
                     "timeoutSeconds": 10,
                 },
             )
-        self.assertEqual("failed", report["status"])
+            pid = int(pid_path.read_text(encoding="utf-8"))
+        self.assertEqual("passed", report["status"])
         self.assertTrue(report["descendantsTerminated"])
+        self.assertFalse(windows_process_is_running(pid))
 
 
 if __name__ == "__main__":