engineering-process 1.0.0__tar.gz → 1.0.1__tar.gz

{engineering_process-1.0.0/engineering_process.egg-info → engineering_process-1.0.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.0.0
+Version: 1.0.1
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process

{engineering_process-1.0.0 → engineering_process-1.0.1}/engineering_process/__init__.py

@@ -1,3 +1,3 @@
 """Agent-neutral engineering process."""
 
-VERSION = "1.0.0"
+VERSION = "1.0.1"

{engineering_process-1.0.0 → engineering_process-1.0.1}/engineering_process/_supervisor_posix.py

@@ -98,13 +98,24 @@ def _pid_alive(pid: int) -> bool:
     status = Path(f"/proc/{pid}/stat")
     if status.is_file():
         try:
-            return status.read_text(encoding="utf-8").split()[2] != "Z"
+            state = status.read_text(encoding="utf-8").rsplit(")", 1)[1].split()[0]
+            if state == "Z":
+                try:
+                    os.waitpid(pid, os.WNOHANG)
+                except OSError:
+                    pass
+                return False
         except (OSError, IndexError):
             pass
     return True
 
 
 def _process_group_exists(process_group: int) -> bool:
+    try:
+        while os.waitpid(-process_group, os.WNOHANG)[0]:
+            pass
+    except OSError:
+        pass
     try:
         os.killpg(process_group, 0)
     except ProcessLookupError:
@@ -114,6 +125,14 @@ def _process_group_exists(process_group: int) -> bool:
     return True
 
 
+def _signal_processes(processes: set[int], signal_number: int) -> None:
+    for pid in processes:
+        try:
+            os.kill(pid, signal_number)
+        except OSError:
+            pass
+
+
 def _wait_for_process_group(process_group: int, timeout: float) -> bool:
     deadline = time.monotonic() + timeout
     while time.monotonic() < deadline:
@@ -144,11 +163,7 @@ def _terminate_group(process_group: int, grace_seconds: float) -> CleanupOutcome
     return CleanupOutcome(
         bounded=bounded,
         descendants_found=True,
-        error=(
-            None
-            if bounded
-            else "command process group could not be terminated within the bounded grace period"
-        ),
+        error=None if bounded else "command process group exceeded its termination grace period",
     )
 
 
@@ -250,24 +265,12 @@ class PosixProcessSupervisor:
         live = {pid for pid in candidates if _pid_alive(pid)}
         if not live:
             return CleanupOutcome(bounded=True)
-        for pid in live:
-            try:
-                os.kill(pid, signal.SIGTERM)
-            except ProcessLookupError:
-                pass
-            except OSError:
-                pass
+        _signal_processes(live, signal.SIGTERM)
         deadline = time.monotonic() + grace_seconds
         while time.monotonic() < deadline and any(_pid_alive(pid) for pid in live):
             time.sleep(0.02)
         survivors = {pid for pid in live if _pid_alive(pid)}
-        for pid in survivors:
-            try:
-                os.kill(pid, signal.SIGKILL)
-            except ProcessLookupError:
-                pass
-            except OSError:
-                pass
+        _signal_processes(survivors, signal.SIGKILL)
         deadline = time.monotonic() + grace_seconds
         while time.monotonic() < deadline and any(
             _pid_alive(pid) for pid in survivors
@@ -282,11 +285,7 @@ class PosixProcessSupervisor:
         return CleanupOutcome(
             bounded=bounded,
             descendants_found=True,
-            error=(
-                None
-                if bounded
-                else "detached descendants survived bounded termination"
-            ),
+            error=None if bounded else "detached descendants survived bounded termination",
         )
 
     def terminate(

{engineering_process-1.0.0 → engineering_process-1.0.1/engineering_process.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 1.0.0
+Version: 1.0.1
 Summary: A small agent-neutral engineering lifecycle with managed adoption
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process

{engineering_process-1.0.0 → engineering_process-1.0.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "engineering-process"
-version = "1.0.0"
+version = "1.0.1"
 description = "A small agent-neutral engineering lifecycle with managed adoption"
 readme = "README.md"
 license = "MIT"

{engineering_process-1.0.0 → engineering_process-1.0.1}/tests/test_architecture.py

@@ -28,7 +28,7 @@ class ArchitectureTests(unittest.TestCase):
         actual = {path.name for path in (ROOT / "engineering_process").glob("*.py")}
         self.assertTrue(removed_modules.isdisjoint(actual))
         workflows = {path.name for path in (ROOT / ".github" / "workflows").glob("*.yml")}
-        self.assertEqual({"ci.yml", "release-pr.yml", "release.yml"}, workflows)
+        self.assertEqual({"ci.yml", "publish.yml", "release-pr.yml"}, workflows)
 
     def test_source_skills_have_no_orphaned_legacy_directories(self) -> None:
         skills = {

{engineering_process-1.0.0 → engineering_process-1.0.1}/tests/test_automation.py

@@ -43,7 +43,7 @@ class AutomationTests(unittest.TestCase):
         )
 
     def test_release_dispatches_the_published_version_to_the_control_plane(self) -> None:
-        workflow = (ROOT / ".github" / "workflows" / "release.yml").read_text(
+        workflow = (ROOT / ".github" / "workflows" / "publish.yml").read_text(
             encoding="utf-8"
         )
         self.assertIn("engineering-process-published", workflow)
@@ -54,6 +54,44 @@ class AutomationTests(unittest.TestCase):
         self.assertIn("SOURCE_DATE_EPOCH", workflow)
         self.assertIn("verification/normalize_sdist.py", workflow)
         self.assertIn("points to a different commit", workflow)
+        self.assertIn("workflow_dispatch:", workflow)
+        self.assertIn("release_sha:", workflow)
+        self.assertIn('git merge-base --is-ancestor "$RELEASE_SOURCE_SHA" origin/main', workflow)
+        self.assertIn("needs.metadata.outputs.source_sha", workflow)
+        self.assertNotIn('--target "$GITHUB_SHA"', workflow)
+        self.assertEqual(
+            3,
+            workflow.count(
+                'path.suffix == ".whl" or path.name.endswith(".tar.gz")'
+            ),
+        )
+        self.assertIn("for file in dist/*.whl dist/*.tar.gz; do", workflow)
+        self.assertNotIn("for file in dist/*; do", workflow)
+        publish_job = workflow.split("  publish:\n", maxsplit=1)[1].split(
+            "\n  dispatch-adoption:\n", maxsplit=1
+        )[0]
+        self.assertIn("id: release-token", publish_job)
+        self.assertIn("repositories: engineering-process", publish_job)
+        self.assertIn("permission-contents: write", publish_job)
+        self.assertIn(
+            "GH_TOKEN: ${{ steps.release-token.outputs.token }}", publish_job
+        )
+        self.assertNotIn("GH_TOKEN: ${{ github.token }}", publish_job)
+        self.assertIn('"repos/$GITHUB_REPOSITORY/git/refs"', publish_job)
+        self.assertIn('-f ref="refs/tags/$RELEASE_TAG"', publish_job)
+        self.assertIn('-f sha="${{ needs.metadata.outputs.source_sha }}"', publish_job)
+        self.assertIn("--verify-tag", publish_job)
+        self.assertNotIn("--target", publish_job)
+        trusted_checkout = workflow.index("          ref: main")
+        preflight = workflow.index("name: Authorize release source from trusted main")
+        source_checkout = workflow.index("ref: ${{ steps.release.outputs.source_sha }}")
+        editable_install = workflow.index(
+            "python -m pip install -r engineering_process/requirements-runtime.txt "
+            "--editable ."
+        )
+        self.assertLess(trusted_checkout, preflight)
+        self.assertLess(preflight, source_checkout)
+        self.assertLess(source_checkout, editable_install)
 
     def test_ci_checks_the_adopted_hash_locked_distribution_separately(self) -> None:
         workflow = (ROOT / ".github" / "workflows" / "ci.yml").read_text(

{engineering_process-1.0.0 → engineering_process-1.0.1}/tests/test_commands.py

@@ -111,6 +111,34 @@ class CommandTests(unittest.TestCase):
         self.assertEqual("failed", report["status"])
         self.assertTrue(report["descendantsTerminated"])
 
+    @unittest.skipUnless(
+        sys.platform.startswith("linux"), "Linux subreaper reaping assertion"
+    )
+    def test_exited_descendant_is_reaped_and_passes(self) -> None:
+        with tempfile.TemporaryDirectory() as directory:
+            root = Path(directory)
+            pid_path = root / "child.pid"
+            child = "import time; time.sleep(0.01)"
+            script = (
+                "import pathlib, subprocess, sys, time; "
+                f"p=subprocess.Popen([sys.executable, '-c', {child!r}]); "
+                "pathlib.Path(sys.argv[1]).write_text(str(p.pid), encoding='utf-8'); "
+                "time.sleep(0.05)"
+            )
+            report = run_check(
+                root,
+                {
+                    "id": "naturally-drained-descendant",
+                    "run": [sys.executable, "-c", script, str(pid_path)],
+                    "timeoutSeconds": 10,
+                },
+            )
+            pid = int(pid_path.read_text(encoding="utf-8"))
+        self.assertEqual("passed", report["status"])
+        self.assertFalse(report["descendantsTerminated"])
+        self.assertFalse(report["streamFailed"])
+        self.assertFalse(Path(f"/proc/{pid}").exists())
+
     @unittest.skipUnless(
         sys.platform.startswith("linux"), "Linux subreaper containment assertion"
     )