engineering-process 0.1.0__tar.gz → 0.1.1__tar.gz

{engineering_process-0.1.0 → engineering_process-0.1.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 0.1.0
+Version: 0.1.1
 Summary: Agent-neutral end-to-end engineering lifecycle and deterministic process CLI
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process
@@ -105,7 +105,7 @@ Install `processctl` from a tagged release and create a candidate manifest from
 standard in one command:
 
 ~~~text
-python -m pip install "engineering-process==0.1.0"
+python -m pip install "engineering-process==0.1.1"
 processctl project init --project-root . --manifest project.json \
   --bundle core --bundle delivery --bundle product
 processctl doctor --project-root .

{engineering_process-0.1.0 → engineering_process-0.1.1}/README.md

@@ -70,7 +70,7 @@ Install `processctl` from a tagged release and create a candidate manifest from
 standard in one command:
 
 ~~~text
-python -m pip install "engineering-process==0.1.0"
+python -m pip install "engineering-process==0.1.1"
 processctl project init --project-root . --manifest project.json \
   --bundle core --bundle delivery --bundle product
 processctl doctor --project-root .

{engineering_process-0.1.0 → engineering_process-0.1.1}/engineering_process/__init__.py

@@ -1,3 +1,3 @@
 """Agent-neutral engineering process."""
 
-VERSION = "0.1.0"
+VERSION = "0.1.1"

{engineering_process-0.1.0 → engineering_process-0.1.1}/engineering_process/tooling.py

@@ -19,13 +19,14 @@ import urllib.request
 from urllib.parse import urljoin, urlsplit
 import zipfile
 
+from . import VERSION
 from .contracts import ContractError, ManagedTool, ManagedToolArtifact
 from .helper_launch import isolated_helper_command
 
 
 DOWNLOAD_READ_TIMEOUT_SECONDS = 30
 MARKER_NAME = ".engineering-process-tool.json"
-USER_AGENT = "engineering-process/0.1.0"
+USER_AGENT = f"engineering-process/{VERSION}"
 
 
 @dataclass(frozen=True)
@@ -340,6 +341,15 @@ def _set_response_read_timeout(response: object, timeout: float) -> None:
         raise ContractError(f"cannot update the managed download timeout: {error}") from error
 
 
+def _response_is_closed(response: object) -> bool:
+    """Report a consumed HTTP response without depending on its private socket."""
+
+    is_closed = getattr(response, "isclosed", None)
+    if callable(is_closed):
+        return bool(is_closed())
+    return bool(getattr(response, "closed", False))
+
+
 def _download_artifact_direct(
     artifact: ManagedToolArtifact,
     destination: Path,
@@ -353,11 +363,14 @@ def _download_artifact_direct(
     ) as response:
         _validated_https_target(artifact.url, response.geturl())
         content_length = response.headers.get("Content-Length")
+        declared_size = None
         if content_length is not None:
             try:
                 declared_size = int(content_length)
             except ValueError as error:
                 raise ContractError("tool response has an invalid Content-Length") from error
+            if declared_size < 0:
+                raise ContractError("tool response has an invalid Content-Length")
             if declared_size > artifact.max_download_bytes:
                 raise ContractError(
                     f"tool artifact exceeds maxDownloadBytes: {declared_size} > "
@@ -367,6 +380,10 @@ def _download_artifact_direct(
         total = 0
         with destination.open("xb") as output:
             while True:
+                if declared_size is not None and total == declared_size:
+                    break
+                if _response_is_closed(response):
+                    break
                 _set_response_read_timeout(
                     response,
                     min(DOWNLOAD_READ_TIMEOUT_SECONDS, _remaining(deadline)),

{engineering_process-0.1.0 → engineering_process-0.1.1}/engineering_process.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-process
-Version: 0.1.0
+Version: 0.1.1
 Summary: Agent-neutral end-to-end engineering lifecycle and deterministic process CLI
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/phuongnse/engineering-process
@@ -105,7 +105,7 @@ Install `processctl` from a tagged release and create a candidate manifest from
 standard in one command:
 
 ~~~text
-python -m pip install "engineering-process==0.1.0"
+python -m pip install "engineering-process==0.1.1"
 processctl project init --project-root . --manifest project.json \
   --bundle core --bundle delivery --bundle product
 processctl doctor --project-root .

{engineering_process-0.1.0 → engineering_process-0.1.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "engineering-process"
-version = "0.1.0"
+version = "0.1.1"
 description = "Agent-neutral end-to-end engineering lifecycle and deterministic process CLI"
 readme = "README.md"
 license = "MIT"

{engineering_process-0.1.0 → engineering_process-0.1.1}/tests/test_tooling.py

@@ -162,6 +162,74 @@ class ManagedToolTests(unittest.TestCase):
             self.assertEqual(b"payload", destination.read_bytes())
             self.assertEqual([0.25, 0.1], response.socket.timeouts)
 
+    def test_download_does_not_touch_socket_after_content_length_closes_response(self):
+        class Socket:
+            def __init__(self):
+                self.timeouts = []
+
+            def settimeout(self, value):
+                self.timeouts.append(value)
+
+        class Raw:
+            def __init__(self, active_socket):
+                self._sock = active_socket
+
+        class Stream:
+            def __init__(self, active_socket):
+                self.raw = Raw(active_socket)
+
+        class Response:
+            def __init__(self):
+                self.socket = Socket()
+                self.fp = Stream(self.socket)
+                self.headers = {"Content-Length": "7"}
+
+            def __enter__(self):
+                return self
+
+            def __exit__(self, *unused):
+                return False
+
+            def geturl(self):
+                return "https://downloads.example.test/sample"
+
+            def isclosed(self):
+                return self.fp is None
+
+            def read(self, size):
+                del size
+                self.fp = None
+                return b"payload"
+
+        artifact = ManagedToolArtifact(
+            platform="linux-glibc-x64",
+            url="https://downloads.example.test/sample",
+            checksum=f"sha256:{'0' * 64}",
+            archive_format="file",
+            strip_components=0,
+            max_download_bytes=100,
+            max_extracted_bytes=100,
+            max_files=1,
+            commands={"sample": ManagedCommand("sample", None)},
+        )
+        response = Response()
+        with tempfile.TemporaryDirectory() as directory:
+            destination = Path(directory) / "artifact"
+            with (
+                patch(
+                    "engineering_process.tooling._HTTPS_OPENER.open",
+                    return_value=response,
+                ),
+                patch(
+                    "engineering_process.tooling._remaining",
+                    side_effect=[10.0, 0.25],
+                ),
+            ):
+                _download_artifact_direct(artifact, destination, deadline=123.0)
+
+            self.assertEqual(b"payload", destination.read_bytes())
+            self.assertEqual([0.25], response.socket.timeouts)
+
     def test_download_worker_is_force_terminated_at_the_wall_clock_deadline(self):
         artifact = ManagedToolArtifact(
             platform="linux-glibc-x64",