engineering-platform 2.3.93__tar.gz → 2.3.95__tar.gz

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: engineering-platform
-Version: 2.3.93
+Version: 2.3.95
 Summary: Local-first Engineering Platform execution operations runtime
 Author: Peter van Tol
 License: MIT

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "engineering-platform"
-version = "2.3.93"
+version = "2.3.95"
 description = "Local-first Engineering Platform execution operations runtime"
 readme = "README.md"
 requires-python = ">=3.14,<3.15"

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/ENGINEERING_PLATFORM_CONFIG.json

@@ -3,7 +3,7 @@
   "platform": {
     "id": "engineering-platform",
     "name": "Engineering Platform",
-    "version": "2.3.93",
+    "version": "2.3.95",
     "generation": 2,
     "documentation_namespace": "engineering-platform",
     "capability_registry_version": 1

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/ENGINEERING_PLATFORM_VERSION.json

@@ -1,15 +1,15 @@
 {
   "bootstrap_contract": "2026.12",
   "checkpoint_format": 1,
-  "dashboard_version": "2.3.93",
+  "dashboard_version": "2.3.95",
   "handoff_protocol": 1,
   "memory_format": 2,
   "minimum_codex_cli": "0.146.0",
   "inbox_protocol": 1,
-  "platform_version": "2.3.93",
+  "platform_version": "2.3.95",
   "report_format": 2,
-  "runner_version": "2.3.93",
+  "runner_version": "2.3.95",
   "status_model": 1,
   "storage_schema": 45,
-  "watcher_version": "2.3.93"
+  "watcher_version": "2.3.95"
 }

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/agent_state.py

@@ -458,13 +458,16 @@ class TransactionState:
             raise StateError("checkpoint assurance profile is invalid")
         review_fields = {"reviewer", "status", "candidate_sha", "profile_digest", "invocation_id", "findings"}
         current_review_fields = review_fields | {"contract_version", "started_at", "completed_at"}
+        integral_review_fields = current_review_fields | {"coverage", "finding_dispositions"}
         finding_fields = {"id", "fingerprint", "category", "criterion", "observation", "severity", "confidence", "blocking", "disposition"}
         current_finding_fields = finding_fields | {"evidence_ref"}
+        coverage_fields = {"surface", "status", "evidence_ref"}
+        finding_disposition_fields = {"finding_id", "disposition", "evidence_ref"}
         if (
             not isinstance(state.assurance_reviews, tuple)
             or len(state.assurance_reviews) > 16
             or any(
-                not isinstance(review, dict) or set(review) not in (review_fields, current_review_fields)
+                not isinstance(review, dict) or set(review) not in (review_fields, current_review_fields, integral_review_fields)
                 or review.get("reviewer") not in {"quality", "security"}
                 or review.get("status") not in {"PASS", "FAIL", "UNRESOLVED"}
                 or not isinstance(review.get("candidate_sha"), str) or not re.fullmatch(r"[0-9a-f]{40}", review["candidate_sha"])
@@ -486,6 +489,35 @@ class TransactionState:
                     or not isinstance(review.get("started_at"), str)
                     or not isinstance(review.get("completed_at"), str)
                 ))
+                or (set(review) == integral_review_fields and (
+                    review.get("contract_version") != "2.0"
+                    or not isinstance(review.get("started_at"), str)
+                    or not isinstance(review.get("completed_at"), str)
+                    or not isinstance(review.get("coverage"), list)
+                    or not 1 <= len(review["coverage"]) <= 16
+                    or any(
+                        not isinstance(item, dict) or set(item) != coverage_fields
+                        or item.get("status") not in {"REVIEWED", "NOT_APPLICABLE"}
+                        or any(
+                            not isinstance(value, str) or not value or len(value) > 240
+                            or value != redact_diagnostic(value, limit=240)
+                            for value in item.values()
+                        )
+                        for item in review["coverage"]
+                    )
+                    or not isinstance(review.get("finding_dispositions"), list)
+                    or len(review["finding_dispositions"]) > 64
+                    or any(
+                        not isinstance(item, dict) or set(item) != finding_disposition_fields
+                        or item.get("disposition") not in {"RESOLVED", "OPEN"}
+                        or any(
+                            not isinstance(value, str) or not value or len(value) > 240
+                            or value != redact_diagnostic(value, limit=240)
+                            for value in item.values()
+                        )
+                        for item in review["finding_dispositions"]
+                    )
+                ))
                 for review in state.assurance_reviews
             )
         ):

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/assets/dashboard.css

@@ -280,6 +280,8 @@ html[data-theme="light"] :is(#rateLimitReset,#codexCliUpdate){background:#e8fff5
 .prompt-detail-provider-review{display:grid;gap:18px;grid-column:1/-1;grid-template-columns:minmax(0,1fr) minmax(320px,.78fr)}@media (max-width:760px){.prompt-detail-provider-review{grid-template-columns:1fr}}
 .prompt-detail-provider-review-stack{display:grid;gap:18px;grid-column:1/-1}.prompt-detail-provider-review>.prompt-detail-card{align-self:stretch;box-sizing:border-box}.prompt-detail-card--commit-timeline{display:flex;flex-direction:column;min-height:0}.prompt-detail-commit-timeline__list{align-content:start;display:grid;flex:1;gap:10px;list-style:none;margin:0;max-height:none;min-height:0;overflow:auto;padding:0 8px 0 0;scrollbar-gutter:stable}.prompt-detail-commit-timeline__item{border-top:1px solid color-mix(in srgb,var(--category-color) 38%,transparent);display:grid;gap:3px;padding-top:10px}.prompt-detail-commit-timeline__item:first-child{border-top:0;padding-top:0}.prompt-detail-commit-timeline__meta{color:var(--dashboard-modal-muted);font-size:12px;line-height:1.35}.prompt-detail-commit-timeline__item code{font-size:12px;overflow-wrap:normal;white-space:nowrap}.prompt-detail-commit-timeline__item>span{font-size:13px;line-height:1.4;overflow-wrap:anywhere}
 .prompt-detail-card--evidence pre,.prompt-detail-card--reviewers pre,.prompt-detail-card--assurance-reviews pre{font-family:inherit}
+.reviewer-agent__status--failed{background:#ff6b6b;box-shadow:0 0 8px #ff6b6b66;color:#351313;font:800 14px/1 system-ui;height:16px;width:16px}
+.prompt-detail-reviewer{border-top:1px solid color-mix(in srgb,var(--category-color) 45%,transparent);display:grid;gap:7px;padding-top:14px}.prompt-detail-reviewer:first-of-type{border-top:0;padding-top:0}.prompt-detail-reviewer h4{color:var(--category-color);font-size:16px;margin:0 0 4px}.prompt-detail-reviewer>.field{margin:2px 0 0}.prompt-detail-reviewer__status{align-items:center;display:inline-flex;gap:8px}.prompt-detail-reviewer__status-icon{align-items:center;border-radius:50%;display:inline-flex;flex:0 0 18px;font:800 12px/1 system-ui;height:18px;justify-content:center}.prompt-detail-reviewer__status-icon--completed{background:#51d88a;box-shadow:0 0 8px #51d88a66;color:#11261d}.prompt-detail-reviewer__status-icon--failed{background:#ff6b6b;box-shadow:0 0 8px #ff6b6b66;color:#351313}.prompt-detail-reviewer__status-icon--neutral{background:#9a9aa3;color:#202027}
 .prompt-detail-commit-timeline__phase{border-top:1px solid color-mix(in srgb,var(--category-color) 52%,transparent);list-style:none;padding:13px 0 0}.prompt-detail-commit-timeline__phase:first-child{border-top:0;padding-top:0}.prompt-detail-commit-timeline__phase h4{color:var(--category-color);font-size:12px;letter-spacing:.04em;margin:0 0 9px;text-transform:uppercase}.prompt-detail-commit-timeline__phase-entries{display:grid;gap:10px;list-style:none;margin:0;padding:0 0 2px}.prompt-detail-commit-timeline__phase-entries .prompt-detail-commit-timeline__item{border-top:0;padding-top:0}
 .prompt-detail-commit-timeline__phase{--commit-kind-color:#8dc7ff;border-left:3px solid var(--commit-kind-color);padding-left:10px}.prompt-detail-commit-timeline__phase--implementation{--commit-kind-color:#65c5d9}.prompt-detail-commit-timeline__phase--validation{--commit-kind-color:#65d9a3}.prompt-detail-commit-timeline__phase--quality{--commit-kind-color:#c29aff}.prompt-detail-commit-timeline__phase--repair{--commit-kind-color:#f4c34f}.prompt-detail-commit-timeline__phase--finalization{--commit-kind-color:#ff99a7}.prompt-detail-commit-timeline__phase--implementation_merge,.prompt-detail-commit-timeline__phase--finalization_merge,.prompt-detail-commit-timeline__phase--reconciliation_merge{--commit-kind-color:#f3d36a}.prompt-detail-commit-timeline__phase--reconciliation{--commit-kind-color:#73d6b0}.prompt-detail-commit-timeline__phase h4{align-items:center;color:var(--commit-kind-color);display:flex;gap:7px}.prompt-detail-commit-timeline__kind{border:1px solid currentColor;border-radius:999px;font-size:10px;line-height:1;padding:4px 6px}.prompt-detail-commit-timeline__phase-name{color:var(--dashboard-modal-muted);font-size:11px;font-weight:500;letter-spacing:0;text-transform:none;white-space:nowrap}
 
@@ -1335,3 +1337,5 @@ html[data-theme="light"] :is(.dashboard-status-banner--provider-auth_required .p
 }
 .telemetry-note{color:var(--dashboard-muted,#b9b6c0);font-size:12px;line-height:1.45;margin:0 0 10px}.telemetry-run-detail{border-top:1px solid color-mix(in srgb,var(--category-color,#fb7185) 45%,transparent);display:grid;gap:16px;margin-top:16px;padding-top:16px}.telemetry-run-detail h4{color:var(--category-color,#fb7185);font-size:14px;margin:14px 0 8px}.telemetry-scope-switcher{display:flex;flex-wrap:wrap;gap:8px}.telemetry-scope-switcher button{background:var(--dashboard-expanded-content-surface,#24242d);border:1px solid color-mix(in srgb,var(--category-color,#fb7185) 72%,transparent);border-radius:7px;color:inherit;cursor:pointer;font:400 12px/1.2 system-ui;min-height:32px;padding:5px 9px}.telemetry-scope-switcher button:hover{background:color-mix(in srgb,var(--category-color,#fb7185) 14%,var(--dashboard-expanded-content-surface,#24242d));border-color:var(--category-color,#fb7185)}.telemetry-scope-switcher button[aria-selected="true"]{background:color-mix(in srgb,var(--category-color,#fb7185) 24%,var(--dashboard-expanded-content-surface,#24242d));border-color:var(--category-color,#fb7185);box-shadow:inset 3px 0 0 var(--category-color,#fb7185)}.telemetry-scope-switcher button:focus:not(:focus-visible){box-shadow:none!important;outline:0!important}.telemetry-scope-switcher button[aria-selected="true"]:focus:not(:focus-visible){box-shadow:inset 3px 0 0 var(--category-color,#fb7185)!important}.telemetry-timeline{display:grid;gap:5px;list-style:none;margin:0;padding:0}.telemetry-timeline li{border-left:2px solid color-mix(in srgb,var(--category-color,#fb7185) 60%,transparent);margin-left:calc(var(--timeline-depth,0) * 14px);padding:6px 8px;word-break:break-word}@media(max-width:620px){.telemetry-detail-modal__content .technical-grid{grid-template-columns:minmax(0,1fr)}.telemetry-scope-switcher{position:sticky;top:0;background:var(--dashboard-expanded-content-surface,#24242d);padding-block:6px;z-index:2}.telemetry-timeline li{margin-left:min(calc(var(--timeline-depth,0) * 9px),45px)}}
 .telemetry-timeline-axis{color:var(--dashboard-muted,#b9b6c0);display:flex;font:11px ui-monospace,monospace;justify-content:space-between;margin:4px 8px}.telemetry-timeline__label{font-size:12px;line-height:1.35}.telemetry-timeline__track{background:color-mix(in srgb,var(--category-color,#fb7185) 10%,transparent);border:1px solid color-mix(in srgb,var(--category-color,#fb7185) 24%,transparent);border-radius:4px;height:14px;margin:5px 0;overflow:hidden;position:relative}.telemetry-timeline__bar{background:var(--category-color,#fb7185);border-radius:3px;display:block;height:100%;min-width:2px;position:absolute}.telemetry-timeline__bar:focus-visible{outline:3px solid var(--house-style);outline-offset:2px}.telemetry-timeline__bar--unpositioned{background:repeating-linear-gradient(135deg,var(--category-color,#fb7185) 0 4px,transparent 4px 8px);inset:0;width:100%}.telemetry-timeline__identity{color:var(--dashboard-muted,#b9b6c0);display:block;font-size:10px;overflow-wrap:anywhere}.telemetry-export{min-width:38px}@media(max-width:620px){.telemetry-timeline-axis{margin-inline:0}.telemetry-timeline__identity{font-size:9px}.telemetry-actions{flex-wrap:wrap}}
+/* Status markers inside lifecycle assurance evidence mirror the main status language. */
+.lifecycle-detail-modal__assurance-heading{align-items:center;display:inline-flex;gap:8px}.lifecycle-detail-modal__assurance-status{align-items:center;border-radius:50%;display:inline-flex;flex:0 0 18px;font:800 12px/1 system-ui;height:18px;justify-content:center;width:18px!important}.lifecycle-detail-modal__assurance-status--passed{background:#51d88a;box-shadow:0 0 8px #51d88a66;color:#11261d!important}.lifecycle-detail-modal__assurance-status--failed{background:#ff6b6b;box-shadow:0 0 8px #ff6b6b66;color:#351313!important}.lifecycle-detail-modal__assurance-status--neutral{background:#9a9aa3;color:#202027!important}

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/assets/dashboard.js

@@ -148,6 +148,24 @@ function reviewerCapabilityLabel(value, fallback = t("format.not_available")) {
   const raw = String(value || "").trim();
   return raw ? enumLabel(raw.toUpperCase(), raw) : fallback;
 }
+function reviewerStatusPresentation(reviewer) {
+  const rawStatus = String(reviewer?.status || "completed").toLowerCase();
+  const failed = rawStatus === "failed", completed = ["completed", "uitgevoerd"].includes(rawStatus);
+  const label = document.createElement("span"), row = document.createElement("span"),
+    indicator = document.createElement("span"), text = document.createElement("span");
+  label.className = "label";
+  label.textContent = t("detail.prompt_status");
+  row.className = "prompt-detail-reviewer__status";
+  indicator.className = "prompt-detail-reviewer__status-icon prompt-detail-reviewer__status-icon--"
+    + (failed ? "failed" : completed ? "completed" : "neutral");
+  indicator.setAttribute("aria-hidden", "true");
+  indicator.textContent = failed ? "×" : completed ? "✓" : "•";
+  text.className = "prompt-detail-reviewer__status-text";
+  text.textContent = reviewerCapabilityLabel(reviewer?.capability || "ENGINEERING")
+    + " · " + reviewerStatusLabel(rawStatus);
+  row.append(indicator, text);
+  return { label, row };
+}
 function driftPresentationValue(field, drift = {}) {
   const value = String(drift?.[field] || "").trim();
   if (!value) return t("format.not_available");
@@ -831,12 +849,12 @@ function reviewerPresentationState(status = {}) {
 }
 function activeReviewerAgents(items, executionStatus = {}) {
   const reviewActive = String(executionStatus?.current_phase || "").toUpperCase() === "CAPABILITY_REVIEW";
-  // A later phase may retain only a fully successful review as compact
-  // historical evidence. Running, failed or incomplete projections stay
-  // phase-scoped so they can never look like live reviewer work.
-  const completedReview = Array.isArray(items) && items.length > 0
-    && items.every((agent) => String(agent?.status || "").toLowerCase() === "completed");
-  const agents = (reviewActive || completedReview) && Array.isArray(items) ? items : [];
+  // A later phase may retain a wholly terminal review as compact historical
+  // evidence. Running or incomplete projections stay phase-scoped so they can
+  // never look like live reviewer work.
+  const terminalReview = Array.isArray(items) && items.length > 0
+    && items.every((agent) => ["completed", "failed"].includes(String(agent?.status || "").toLowerCase()));
+  const agents = (reviewActive || terminalReview) && Array.isArray(items) ? items : [];
   let card = $("activeReviewerAgents");
   if (!card) {
     card = document.createElement("section");
@@ -871,19 +889,23 @@ function activeReviewerAgents(items, executionStatus = {}) {
       indicator = document.createElement("span"), rawStatus = String(agent?.status || "").toLowerCase(),
       status = rawStatus === "running" && presentation !== "active" ? presentation : rawStatus;
     const isRunning = status === "running";
-    const isCompleted = ["completed", "uitgevoerd"].includes(status);
+    const isCompleted = ["completed", "uitgevoerd"].includes(status), isFailed = status === "failed";
     row.className = "reviewer-agent";
     header.className = "reviewer-agent__header";
     name.className = "reviewer-agent__name";
     meta.className = "reviewer-agent__meta";
     name.textContent = reviewerLabel(agent.reviewer);
     meta.textContent = `${reviewerCapabilityLabel(agent.capability || "ENGINEERING")} · ${reviewerStatusLabel(status || "selected")}`;
-    if (isRunning || isCompleted) {
-      indicator.className = `reviewer-agent__status reviewer-agent__status--${isRunning ? "running" : "completed"}`;
+    if (isRunning || isCompleted || isFailed) {
+      const tone = isRunning ? "running" : isFailed ? "failed" : "completed";
+      indicator.className = `reviewer-agent__status reviewer-agent__status--${tone}`;
       indicator.setAttribute("role", "status");
-      indicator.setAttribute("aria-label", isRunning ? t("ui.reviewer_status_running") : t("ui.reviewer_status_completed"));
+      indicator.setAttribute("aria-label", isRunning
+        ? t("ui.reviewer_status_running")
+        : isFailed ? reviewerStatusLabel("failed") : t("ui.reviewer_status_completed"));
       indicator.setAttribute("title", indicator.getAttribute("aria-label"));
       if (isCompleted) indicator.textContent = "✓";
+      if (isFailed) indicator.textContent = "×";
     }
     header.append(name, indicator);
     row.append(header, meta);
@@ -2143,12 +2165,31 @@ function lifecycleAssuranceEvidence(step) {
   for (const review of reviews) {
     if (!review || typeof review !== "object") continue;
     const findings = Array.isArray(review.findings) ? review.findings : [];
-    const item = document.createElement("li");
-    const role = String(review.reviewer || ""); const status = String(review.status || "UNRESOLVED");
-    item.append(Object.assign(document.createElement("strong"), { textContent: `${reviewerLabel(role, role)} · ${assuranceStatusLabel(status, status)}` }));
+    const item = document.createElement("li"), heading = document.createElement("strong"),
+      statusIcon = document.createElement("span"), status = String(review.status || "UNRESOLVED"),
+      normalizedStatus = status.toUpperCase();
+    const role = String(review.reviewer || "");
+    const passed = normalizedStatus === "PASS", failed = ["FAIL", "FAILED", "UNRESOLVED"].includes(normalizedStatus);
+    heading.className = "lifecycle-detail-modal__assurance-heading";
+    statusIcon.className = "lifecycle-detail-modal__assurance-status lifecycle-detail-modal__assurance-status--"
+      + (passed ? "passed" : failed ? "failed" : "neutral");
+    statusIcon.setAttribute("aria-hidden", "true");
+    statusIcon.textContent = passed ? "✓" : failed ? "×" : "•";
+    heading.append(statusIcon, Object.assign(document.createElement("span"), {
+      textContent: `${reviewerLabel(role, role)} · ${assuranceStatusLabel(status, status)}`,
+    }));
+    item.append(heading);
     const summary = findings.map((finding) => String(finding?.observation || "").trim()).filter(Boolean).join("; ");
     const summaryElement = Object.assign(document.createElement("span"), { textContent: summary || t("lifecycle.assurance_no_findings") });
     item.append(summaryElement);
+    const coverage = Array.isArray(review.coverage) ? review.coverage : [];
+    const dispositions = Array.isArray(review.finding_dispositions) ? review.finding_dispositions : [];
+    if (coverage.length || dispositions.length) item.append(Object.assign(document.createElement("span"), {
+      className: "estimate-meta",
+      textContent: t("lifecycle.assurance_integral_evidence", {
+        coverage: coverage.length, dispositions: dispositions.length,
+      }),
+    }));
     if (summary) dynamicRows.push({ source: summary, element: summaryElement });
     list.append(item);
   }
@@ -2169,10 +2210,9 @@ function lifecycleCapabilityEvidence(step) {
   list.className = "lifecycle-detail-modal__phase-list";
   for (const reviewer of reviewers) {
     if (!reviewer || typeof reviewer !== "object") continue;
-    const item = document.createElement("li");
+    const item = document.createElement("li"), heading = document.createElement("strong"),
+      status = reviewerStatusPresentation(reviewer);
     const details = [
-      reviewerCapabilityLabel(reviewer.capability || "ENGINEERING"),
-      reviewerStatusLabel(reviewer.status || "completed"),
       reviewer.selected_because
         ? t("detail.selected_because") + ": " + String(reviewer.selected_because)
         : null,
@@ -2186,34 +2226,57 @@ function lifecycleCapabilityEvidence(step) {
         ? t("detail.rejected_recommendations") + ": " + reviewer.rejected_recommendations
         : null,
     ].filter(Boolean);
-    item.append(
-      Object.assign(document.createElement("strong"), {
-        textContent: reviewerLabel(reviewer.reviewer, t("detail.specialist_review")),
-      }),
-      Object.assign(document.createElement("span"), {
-        textContent: details.join("\n"),
-      }),
-    );
+    heading.textContent = reviewerLabel(reviewer.reviewer, t("detail.specialist_review"));
+    item.append(heading, status.label, status.row);
+    if (details.length) item.append(Object.assign(document.createElement("span"), {
+      textContent: details.join("\n"),
+    }));
     list.append(item);
   }
   if (!list.childElementCount) return null;
   section.append(list);
   return section;
 }
-function lifecycleImplementationEvidence(step) {
-  const evidence = step?.implementation_evidence;
+function lifecyclePullRequestField(label, pullRequest, repository) {
+  const field = lifecycleDetailField(label, `#${pullRequest}`);
+  const repositoryIdentity = String(repository || "").trim();
+  if (!/^[A-Za-z0-9_.-]+\/[A-Za-z0-9_.-]+$/.test(repositoryIdentity)) return field;
+  const link = document.createElement("a");
+  link.className = "prompt-detail-pr-link";
+  link.href = `https://github.com/${repositoryIdentity.split("/").map(encodeURIComponent).join("/")}/pull/${pullRequest}`;
+  link.target = "_blank";
+  link.rel = "noopener noreferrer";
+  link.textContent = `#${pullRequest} ↗`;
+  link.setAttribute("aria-label", `${label} #${pullRequest}`);
+  field.lastElementChild.replaceWith(link);
+  return field;
+}
+function lifecycleDeliveryEvidence(step) {
+  const evidence = step?.delivery_evidence || step?.implementation_evidence;
   if (!evidence || typeof evidence !== "object") return null;
+  const role = String(evidence.role || "implementation").toLowerCase();
+  const titles = {
+    implementation: "lifecycle.detail_implementation_evidence",
+    finalization: "lifecycle.detail_finalization_evidence",
+    reconciliation: "lifecycle.detail_reconciliation_evidence",
+  };
+  const pullRequestLabels = {
+    implementation: "detail.implementation_pull_request",
+    finalization: "detail.finalization_pull_request",
+    reconciliation: "detail.reconciliation_pull_request",
+  };
   const fields = [];
   if (evidence.branch) fields.push(lifecycleDetailField(t("workspace.current_branch"), String(evidence.branch)));
   if (evidence.candidate_sha) fields.push(lifecycleDetailField(t("detail.candidate_sha"), String(evidence.candidate_sha)));
   if (Number.isInteger(evidence.pull_request) && evidence.pull_request > 0) {
-    fields.push(lifecycleDetailField(t("detail.implementation_pull_request"), `#${evidence.pull_request}`));
+    const label = t(pullRequestLabels[role] || pullRequestLabels.implementation);
+    fields.push(lifecyclePullRequestField(label, evidence.pull_request, evidence.repository));
   }
   if (!fields.length) return null;
   const section = document.createElement("section");
   section.className = "lifecycle-detail-modal__implementation-evidence";
   section.append(
-    Object.assign(document.createElement("h3"), { textContent: t("lifecycle.detail_implementation_evidence") }),
+    Object.assign(document.createElement("h3"), { textContent: t(titles[role] || titles.implementation) }),
     Object.assign(document.createElement("div"), { className: "technical-grid" }),
   );
   section.lastElementChild.append(...fields);
@@ -2346,8 +2409,8 @@ function openLifecycleDetail(step, trigger, { presentationOnly = false } = {}) {
   if (capabilityEvidence) content.append(capabilityEvidence);
   const assuranceEvidence = lifecycleAssuranceEvidence(step);
   if (assuranceEvidence) content.append(assuranceEvidence);
-  const implementationEvidence = lifecycleImplementationEvidence(step);
-  if (implementationEvidence) content.append(implementationEvidence);
+  const deliveryEvidence = lifecycleDeliveryEvidence(step);
+  if (deliveryEvidence) content.append(deliveryEvidence);
   const repairEvidence = lifecycleRepairEvidence(step);
   if (repairEvidence) content.append(repairEvidence);
   if (!modal.open) modal.showModal();
@@ -2364,15 +2427,24 @@ function lifecycleStepWithEvidence(step, context = {}) {
       : Array.isArray(context.reviewers) ? context.reviewers : [];
     if (reviewers.length) enriched.reviewer_evidence = reviewers;
   }
-  if (id === "EXECUTE_AGENT") {
-    const candidate = String(context.implementation_candidate_sha || "").trim();
-    const branch = String(context.implementation_branch || "").trim();
-    const pullRequest = Number(context.implementation_pr);
+  const deliverySteps = {
+    EXECUTE_AGENT: { role: "implementation", candidate: "implementation_candidate_sha", branch: "implementation_branch", pullRequest: "implementation_pr" },
+    FINALIZE_AGENT: { role: "finalization", candidate: "finalization_candidate_sha", branch: "finalization_branch", pullRequest: "finalization_pr" },
+    RECONCILE_AGENT: { role: "reconciliation", candidate: "reconciliation_candidate_sha", branch: "reconciliation_branch", pullRequest: "reconciliation_pr" },
+  };
+  const delivery = deliverySteps[id];
+  if (delivery) {
+    const candidate = String(context[delivery.candidate] || "").trim();
+    const branch = String(context[delivery.branch] || "").trim();
+    const pullRequest = Number(context[delivery.pullRequest]);
+    const repository = String(context.github_repository || context.target_repository || "").trim();
     const evidence = {};
+    evidence.role = delivery.role;
     if (/^[0-9a-f]{40}$/.test(candidate)) evidence.candidate_sha = candidate;
     if (branch) evidence.branch = branch;
     if (Number.isInteger(pullRequest) && pullRequest > 0) evidence.pull_request = pullRequest;
-    if (Object.keys(evidence).length) enriched.implementation_evidence = evidence;
+    if (/^[A-Za-z0-9_.-]+\/[A-Za-z0-9_.-]+$/.test(repository)) evidence.repository = repository;
+    if (Object.keys(evidence).length > 1) enriched.delivery_evidence = evidence;
   }
   return enriched;
 }
@@ -8543,19 +8615,27 @@ function promptDetailRecommendationHandoff(handoff) {
 }
 function promptDetailReviewersSection(reviewers, { wide = true } = {}) {
   if (!reviewers.length) return null;
-  const fields = reviewers.map((reviewer) =>
-    detailField(
-      reviewerLabel(reviewer.reviewer, t("detail.specialist_review")),
-      t("detail.capability") + ": " +
-        reviewerCapabilityLabel(reviewer.capability || "ENGINEERING") + " · " +
-        reviewerStatusLabel(reviewer.status || "completed") + " · " +
-        t("detail.accepted_recommendations") + ": " +
-        (Number(reviewer.accepted_recommendations) || 0) + "\n" +
-        t("detail.selected_because") + ": " +
+  const fields = reviewers.map((reviewer) => {
+    const field = document.createElement("article"), heading = document.createElement("h4"),
+      status = reviewerStatusPresentation(reviewer);
+    field.className = "field prompt-detail-reviewer";
+    heading.textContent = reviewerLabel(reviewer.reviewer, t("detail.specialist_review"));
+    field.append(
+      heading,
+      status.label,
+      status.row,
+      detailField(
+        t("detail.selected_because"),
         String(reviewer.selected_because || t("detail.not_recorded")),
-      true,
-    ),
-  );
+        true,
+      ),
+      detailField(
+        t("detail.accepted_recommendations"),
+        String(Number(reviewer.accepted_recommendations) || 0),
+      ),
+    );
+    return field;
+  });
   return promptDetailCard(t("detail.specialist_reviews"), fields, wide, "prompt-detail-card--reviewers");
 }
 function promptDetailAssuranceReviewsSection(reviews) {

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/assets/dashboard_locales.mjs

@@ -4273,8 +4273,13 @@ Object.assign(DASHBOARD_MESSAGES.es, {
 // A repair step can be entered before a pull request exists and shares its
 // bounded budget across local validation, assurance, hosted checks and
 // finalization. Keep the flow label generic; detail evidence names the cause.
-Object.assign(DASHBOARD_MESSAGES.en, {"lifecycle.step.repair_agent":"Repair round","lifecycle.detail_repair_evidence":"Completed repair rounds","lifecycle.detail_implementation_evidence":"Implementation result","lifecycle.detail_validation_pass":"Validation pass {iteration}","detail.initial_observation":"Initial observation","detail.rejected_recommendations":"Rejected recommendations"});
-Object.assign(DASHBOARD_MESSAGES.nl, {"lifecycle.step.repair_agent":"Herstelronde","lifecycle.detail_repair_evidence":"Uitgevoerde herstelrondes","lifecycle.detail_implementation_evidence":"Implementatieresultaat","lifecycle.detail_validation_pass":"Validatiepass {iteration}","detail.initial_observation":"Initiële bevinding","detail.rejected_recommendations":"Afgewezen aanbevelingen"});
-Object.assign(DASHBOARD_MESSAGES.de, {"lifecycle.step.repair_agent":"Reparaturrunde","lifecycle.detail_repair_evidence":"Abgeschlossene Reparaturrunden","lifecycle.detail_implementation_evidence":"Implementierungsergebnis","lifecycle.detail_validation_pass":"Validierungsdurchlauf {iteration}","detail.initial_observation":"Erste Beobachtung","detail.rejected_recommendations":"Abgelehnte Empfehlungen"});
-Object.assign(DASHBOARD_MESSAGES.fr, {"lifecycle.step.repair_agent":"Cycle de réparation","lifecycle.detail_repair_evidence":"Cycles de réparation terminés","lifecycle.detail_implementation_evidence":"Résultat de l’implémentation","lifecycle.detail_validation_pass":"Passe de validation {iteration}","detail.initial_observation":"Observation initiale","detail.rejected_recommendations":"Recommandations rejetées"});
-Object.assign(DASHBOARD_MESSAGES.es, {"lifecycle.step.repair_agent":"Ronda de reparación","lifecycle.detail_repair_evidence":"Rondas de reparación completadas","lifecycle.detail_implementation_evidence":"Resultado de la implementación","lifecycle.detail_validation_pass":"Pasada de validación {iteration}","detail.initial_observation":"Observación inicial","detail.rejected_recommendations":"Recomendaciones rechazadas"});
+Object.assign(DASHBOARD_MESSAGES.en, {"lifecycle.step.repair_agent":"Repair round","lifecycle.detail_repair_evidence":"Completed repair rounds","lifecycle.detail_implementation_evidence":"Implementation result","lifecycle.detail_finalization_evidence":"Finalization result","lifecycle.detail_reconciliation_evidence":"Reconciliation result","lifecycle.detail_validation_pass":"Validation pass {iteration}","detail.initial_observation":"Initial observation","detail.rejected_recommendations":"Rejected recommendations"});
+Object.assign(DASHBOARD_MESSAGES.nl, {"lifecycle.step.repair_agent":"Herstelronde","lifecycle.detail_repair_evidence":"Uitgevoerde herstelrondes","lifecycle.detail_implementation_evidence":"Implementatieresultaat","lifecycle.detail_finalization_evidence":"Finalisatieresultaat","lifecycle.detail_reconciliation_evidence":"Reconciliatieresultaat","lifecycle.detail_validation_pass":"Validatiepass {iteration}","detail.initial_observation":"Initiële bevinding","detail.rejected_recommendations":"Afgewezen aanbevelingen"});
+Object.assign(DASHBOARD_MESSAGES.de, {"lifecycle.step.repair_agent":"Reparaturrunde","lifecycle.detail_repair_evidence":"Abgeschlossene Reparaturrunden","lifecycle.detail_implementation_evidence":"Implementierungsergebnis","lifecycle.detail_finalization_evidence":"Finalisierungsergebnis","lifecycle.detail_reconciliation_evidence":"Abstimmungsergebnis","lifecycle.detail_validation_pass":"Validierungsdurchlauf {iteration}","detail.initial_observation":"Erste Beobachtung","detail.rejected_recommendations":"Abgelehnte Empfehlungen"});
+Object.assign(DASHBOARD_MESSAGES.fr, {"lifecycle.step.repair_agent":"Cycle de réparation","lifecycle.detail_repair_evidence":"Cycles de réparation terminés","lifecycle.detail_implementation_evidence":"Résultat de l’implémentation","lifecycle.detail_finalization_evidence":"Résultat de la finalisation","lifecycle.detail_reconciliation_evidence":"Résultat de la réconciliation","lifecycle.detail_validation_pass":"Passe de validation {iteration}","detail.initial_observation":"Observation initiale","detail.rejected_recommendations":"Recommandations rejetées"});
+Object.assign(DASHBOARD_MESSAGES.es, {"lifecycle.step.repair_agent":"Ronda de reparación","lifecycle.detail_repair_evidence":"Rondas de reparación completadas","lifecycle.detail_implementation_evidence":"Resultado de la implementación","lifecycle.detail_finalization_evidence":"Resultado de la finalización","lifecycle.detail_reconciliation_evidence":"Resultado de la conciliación","lifecycle.detail_validation_pass":"Pasada de validación {iteration}","detail.initial_observation":"Observación inicial","detail.rejected_recommendations":"Recomendaciones rechazadas"});
+Object.assign(DASHBOARD_MESSAGES.en, {"lifecycle.assurance_integral_evidence":"Impact surfaces reviewed: {coverage} · Prior findings reassessed: {dispositions}"});
+Object.assign(DASHBOARD_MESSAGES.nl, {"lifecycle.assurance_integral_evidence":"Impactvlakken beoordeeld: {coverage} · Eerdere bevindingen herbeoordeeld: {dispositions}"});
+Object.assign(DASHBOARD_MESSAGES.de, {"lifecycle.assurance_integral_evidence":"Geprüfte Auswirkungsbereiche: {coverage} · Frühere Befunde erneut bewertet: {dispositions}"});
+Object.assign(DASHBOARD_MESSAGES.fr, {"lifecycle.assurance_integral_evidence":"Surfaces d’impact examinées : {coverage} · Constats antérieurs réévalués : {dispositions}"});
+Object.assign(DASHBOARD_MESSAGES.es, {"lifecycle.assurance_integral_evidence":"Superficies de impacto revisadas: {coverage} · Hallazgos anteriores reevaluados: {dispositions}"});

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/capability_review.py

@@ -44,10 +44,47 @@ REVIEWER_LABELS = {
     "documentation": "Documentation Reviewer",
     "finalization": "Finalization Reviewer",
 }
-MANDATORY_REVIEW_OUTPUT_CONTRACT_VERSION = "1.0"
+ADVISORY_REVIEW_OUTPUT_CONTRACT_VERSION = "1.0"
+MANDATORY_REVIEW_OUTPUT_CONTRACT_VERSION = "2.0"
 MANDATORY_FINDING_FIELDS = frozenset({
     "id", "observation", "category", "criterion", "severity", "confidence", "evidence_ref",
 })
+MANDATORY_COVERAGE_FIELDS = frozenset({"surface", "status", "evidence_ref"})
+MANDATORY_DISPOSITION_FIELDS = frozenset({"finding_id", "disposition", "evidence_ref"})
+MANDATORY_COVERAGE_SURFACES = {
+    "IMPLEMENTATION": {
+        "quality": (
+            "approved_criteria", "full_candidate_diff", "callers_and_consumers",
+            "service_lifecycle", "maintenance_recovery_cleanup", "persistence_concurrency",
+            "transport_schema_compatibility", "regression_validation",
+        ),
+        "security": (
+            "approved_criteria", "full_candidate_diff", "trust_authentication",
+            "data_integrity_concurrency", "maintenance_recovery_cleanup",
+            "failure_redaction", "availability_resource_bounds", "security_validation",
+        ),
+    },
+    "FINALIZATION": {
+        "quality": (
+            "delivery_role_scope", "full_candidate_diff", "record_consistency",
+            "lifecycle_state_claims", "regression_validation",
+        ),
+        "security": (
+            "delivery_role_scope", "full_candidate_diff", "authority_scope",
+            "sensitive_data", "lifecycle_state_claims", "security_validation",
+        ),
+    },
+    "RECONCILIATION": {
+        "quality": (
+            "delivery_role_scope", "full_candidate_diff", "record_consistency",
+            "lifecycle_state_claims", "regression_validation",
+        ),
+        "security": (
+            "delivery_role_scope", "full_candidate_diff", "authority_scope",
+            "sensitive_data", "lifecycle_state_claims", "security_validation",
+        ),
+    },
+}
 PRODUCT_MATCHERS = {
     "apple_platform": (("apps/apple/", "engineering-platform-app", "swiftui", "watchos", "macos", "ios"), "Apple platform capability"),
     "windows_platform": (("apps/windows/", "engineering-platform-windows", "maui", "windows packaging"), "Windows platform capability"),
@@ -77,13 +114,15 @@ class ReviewerResult:
     # In-process deterministic/test adapters construct this typed result only
     # after choosing the mandatory contract. Raw provider JSON is still
     # required to carry this field by ``CodexCliClient.review``.
-    contract_version: str | None = MANDATORY_REVIEW_OUTPUT_CONTRACT_VERSION
+    contract_version: str | None = ADVISORY_REVIEW_OUTPUT_CONTRACT_VERSION
     failed: bool = False
     usage: dict[str, object] = field(default_factory=dict)
     runtime_metadata: dict[str, object] = field(default_factory=dict)
     churn: dict[str, object] = field(default_factory=dict)
     duration_seconds: float | None = None
     usage_snapshots: tuple[dict[str, int], ...] = ()
+    coverage: tuple[dict[str, str], ...] = ()
+    finding_dispositions: tuple[dict[str, str], ...] = ()
 
 
 class ReviewerClient(Protocol):
@@ -164,6 +203,8 @@ def run_reviews(
                 result.churn,
                 result.duration_seconds,
                 result.usage_snapshots,
+                tuple(dict(item) for item in result.coverage if isinstance(item, dict)),
+                tuple(dict(item) for item in result.finding_dispositions if isinstance(item, dict)),
             )
         except Exception:  # Reviewer failure is advisory and cannot block the transaction.
             result = ReviewerResult(selection.reviewer, "Reviewer failed; primary review continues.", failed=True)
@@ -192,7 +233,8 @@ def mandatory_findings(result: ReviewerResult) -> tuple[dict[str, str], ...] | N
     """Return validated mandatory output, never advice-shaped pseudo-evidence."""
     if result.failed or result.contract_version != MANDATORY_REVIEW_OUTPUT_CONTRACT_VERSION:
         return None
-    if not isinstance(result.findings, tuple) or len(result.findings) > 64:
+    finding_limit = 12 if result.reviewer in {"quality", "security"} else 64
+    if not isinstance(result.findings, tuple) or len(result.findings) > finding_limit:
         return None
     normalized: list[dict[str, str]] = []
     seen: set[str] = set()
@@ -210,6 +252,65 @@ def mandatory_findings(result: ReviewerResult) -> tuple[dict[str, str], ...] | N
     return tuple(normalized)
 
 
+def mandatory_coverage_surfaces(reviewer: str, delivery_role: str) -> tuple[str, ...]:
+    """Return the host-owned complete impact checklist for one assurance role."""
+    return MANDATORY_COVERAGE_SURFACES.get(delivery_role, {}).get(reviewer, ())
+
+
+def mandatory_assessment(
+    result: ReviewerResult,
+    *,
+    delivery_role: str,
+    prior_finding_ids: tuple[str, ...],
+) -> tuple[tuple[dict[str, str], ...], tuple[dict[str, str], ...], tuple[dict[str, str], ...]] | None:
+    """Validate complete impact coverage and explicit prior-finding closure.
+
+    A syntactically valid list of findings is insufficient for mandatory
+    assurance.  Each reviewer must cover every host-owned impact surface and
+    explicitly reassess every still-open finding previously raised by that
+    same independent role.
+    """
+    findings = mandatory_findings(result)
+    required_surfaces = mandatory_coverage_surfaces(result.reviewer, delivery_role)
+    if findings is None or not required_surfaces:
+        return None
+    coverage = result.coverage
+    dispositions = result.finding_dispositions
+    if (
+        not isinstance(coverage, tuple)
+        or len(coverage) != len(required_surfaces)
+        or any(not isinstance(item, dict) or set(item) != MANDATORY_COVERAGE_FIELDS for item in coverage)
+        or any(
+            item["surface"] not in required_surfaces
+            or item["status"] not in {"REVIEWED", "NOT_APPLICABLE"}
+            or not isinstance(item["evidence_ref"], str) or not item["evidence_ref"].strip()
+            or len(item["evidence_ref"]) > 240
+            for item in coverage
+        )
+        or {item["surface"] for item in coverage} != set(required_surfaces)
+    ):
+        return None
+    if (
+        not isinstance(dispositions, tuple)
+        or len(dispositions) != len(prior_finding_ids)
+        or any(not isinstance(item, dict) or set(item) != MANDATORY_DISPOSITION_FIELDS for item in dispositions)
+        or any(
+            item["finding_id"] not in prior_finding_ids
+            or item["disposition"] not in {"RESOLVED", "OPEN"}
+            or not isinstance(item["evidence_ref"], str) or not item["evidence_ref"].strip()
+            or len(item["evidence_ref"]) > 240
+            for item in dispositions
+        )
+        or {item["finding_id"] for item in dispositions} != set(prior_finding_ids)
+    ):
+        return None
+    return (
+        findings,
+        tuple({key: redact_diagnostic(value, limit=240) for key, value in item.items()} for item in coverage),
+        tuple({key: redact_diagnostic(value, limit=240) for key, value in item.items()} for item in dispositions),
+    )
+
+
 def records_for_storage(selections: tuple[ReviewerSelection, ...], results: tuple[ReviewerResult, ...]) -> tuple[dict[str, object], ...]:
     by_reviewer = {result.reviewer: result for result in results}
     records: list[dict[str, object]] = []

{engineering_platform-2.3.93 → engineering_platform-2.3.95}/src/engineering_platform/dashboard_state.py

@@ -29,14 +29,15 @@ RunJsonReader = Callable[[Path, str | None], bytes]
 TERMINAL_PHASES = frozenset({"COMPLETE", "BLOCKED", "FAILED"})
 
 
-def _successful_reviewer_agents(value: object) -> list[dict[str, object]]:
-    """Expose only a wholly successful review beyond its live phase."""
+def _terminal_reviewer_agents(value: object) -> list[dict[str, object]]:
+    """Expose a wholly terminal review beyond its live phase."""
     if not isinstance(value, list):
         return []
     reviewers = [item for item in value if isinstance(item, dict)]
     if not reviewers or len(reviewers) != len(value):
         return []
-    return reviewers if all(item.get("status") == "completed" for item in reviewers) else []
+    terminal = {"completed", "failed"}
+    return reviewers if all(item.get("status") in terminal for item in reviewers) else []
 
 
 def _run_workspace_preflight(root: Path, run_id: object) -> dict[str, object]:
@@ -417,13 +418,13 @@ def status(root: Path) -> bytes:
                 "candidate_sha": live.get("candidate_sha"),
                 "repair_iteration": live.get("repair_iteration"),
                 "workspace_preflight": run_workspace_preflight,
-                # Only a wholly successful specialist review survives its
-                # live phase as historical evidence for this active run. A
-                # partial, failed or stale reviewer projection remains hidden.
+                # Only a wholly terminal specialist review survives its live
+                # phase as historical evidence for this active run. A running
+                # or malformed reviewer projection remains hidden.
                 "reviewer_agents": (
                     live.get("reviewer_agents", [])
                     if live.get("phase") == "CAPABILITY_REVIEW"
-                    else _successful_reviewer_agents(live.get("reviewer_agents"))
+                    else _terminal_reviewer_agents(live.get("reviewer_agents"))
                 ),
                 "runtime_metadata": live.get("runtime_metadata", {}),
                 "workspace_progress": live.get("workspace_progress"),