edwh-editorjs 2.4.0__tar.gz → 2.5.0a1__tar.gz

{edwh_editorjs-2.4.0 → edwh_editorjs-2.5.0a1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: edwh-editorjs
-Version: 2.4.0
+Version: 2.5.0a1
 Summary: EditorJS.py
 Project-URL: Homepage, https://github.com/educationwarehouse/edwh-EditorJS
 Author-email: SKevo <skevo.cw@gmail.com>, Robin van der Noord <robin.vdn@educationwarehouse.nl>

edwh_editorjs-2.5.0a1/editorjs/__about__.py

@@ -0,0 +1 @@
+__version__ = "2.5.0a1"

{edwh_editorjs-2.4.0 → edwh_editorjs-2.5.0a1}/editorjs/blocks.py

@@ -411,11 +411,8 @@ class ImageBlock(EditorJSBlock):
         with_background = "1" if data.get("withBackground") else ""
         stretched = "1" if data.get("stretched") else ""
 
-        if any((with_border, with_background, stretched)):
-            # custom type to support custom options:
-            return f"""<editorjs type="image" caption="{caption}" border="{with_border}" background="{with_background}" stretched="{stretched}" url="{url}" />\n\n"""
-        else:
-            return f"""![{caption}]({url} "{caption}")\n\n"""
+        # always custom type so we can render as <figure> instead of markdown2's default (simple <img>)
+        return f"""<editorjs type="image" caption="{caption}" border="{with_border}" background="{with_background}" stretched="{stretched}" url="{url}" />\n\n"""
 
     @classmethod
     def _caption(cls, node: MDChildNode):
@@ -450,7 +447,10 @@ class ImageBlock(EditorJSBlock):
             <div class="ce-block__content">
             <div class="cdx-block image-tool image-tool--filled {background and 'image-tool--withBackground'} {stretched and 'image-tool--stretched'} {border and 'image-tool--withBorder'}">
                 <div class="image-tool__image">
-                    <img class="image-tool__image-picture" src="{url}" title="{caption}" alt="{caption}">
+                    <figure>
+                        <img class="image-tool__image-picture" src="{url}" title="{caption}" alt="{caption}">
+                        <figcaption>{caption}</figcaption>
+                    </figure>
                 </div>
             </div>
         </div>

{edwh_editorjs-2.4.0 → edwh_editorjs-2.5.0a1}/editorjs/core.py

@@ -135,7 +135,6 @@ class EditorJS:
         Export HTML string
         """
         md = self.to_markdown()
-        # todo: deal with custom elements like linktool, attaches
         return self._md.convert(md)
 
     def __repr__(self):

{edwh_editorjs-2.4.0 → edwh_editorjs-2.5.0a1}/tests/test_core.py

@@ -256,3 +256,19 @@ def test_image_options():
     print(e.to_markdown())
     print(e.to_html())
     print(e.to_json())
+
+
+def test_figcaption():
+    # md = """![Party Time!](https://py4web.leiden.dockers.local/img/upload/23.png?hash=979795a433fc15cb94eccb3159f1f1e4054b1664 "Party Time!")"""
+    # e = EditorJS.from_markdown(md)
+
+    js = """{"time":1742471258492,"blocks":[{"id":"ZoA3rbc05C","type":"image","data":{"caption":"Party Time!","withBorder":false,"withBackground":false,"stretched":false,"file":{"url":"https://py4web.leiden.dockers.local/img/upload/23.png?hash=979795a433fc15cb94eccb3159f1f1e4054b1664"}}}],"version":"2.30.7"}"""
+    e = EditorJS.from_json(js)
+
+    html = e.to_html()
+
+    assert "figcaption" in html
+
+    print(
+        html
+    )

edwh_editorjs-2.4.0/editorjs/__about__.py

@@ -1 +0,0 @@
-__version__ = "2.4.0"