dynamicforms 0.81.9__tar.gz → 0.82.0__tar.gz

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: dynamicforms
-Version: 0.81.9
+Version: 0.82.0
 Summary: DyF performs all the visualisation & data entry of your DRF Serializers & ViewSets and adds some candy of its own
 Project-URL: Homepage, https://github.com/velis74/DynamicForms
 Project-URL: Repository, https://github.com/velis74/DynamicForms

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/dynamicforms/__init__.py

@@ -1,5 +1,5 @@
 __title__ = "DynamicForms"
-__version__ = "0.81.9"
+__version__ = "0.82.0"
 __author__ = "Jure Erznožnik"
 __email__ = "jure.erznoznik@gmail.com"
 __license__ = "BSD 3-Clause"

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/dynamicforms/serializers.py

@@ -524,7 +524,13 @@ class DynamicModelSerializerMixin(DynamicModelMixin):
 
     def __init__(self, *args, **kwargs):
         if model := self.determine_model_at_runtime(kwargs.get("context", {}).get("request")):
-            self.Meta.model = model
+            # `self.Meta` resolves to the CLASS's Meta unless shadowed here - `self.Meta.model = model`
+            # would mutate that shared class object, leaking into every other instance of this
+            # serializer (including ones already alive, and ones from unrelated, concurrent
+            # requests) until some other request's resolved model overwrites it again. Subclassing
+            # Meta and assigning the subclass as an INSTANCE attribute keeps the override local to
+            # this one instance.
+            self.Meta = type("Meta", (self.Meta,), {"model": model})
         super().__init__(*args, **kwargs)
 
     def determine_layout_at_runtime(self, request):

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "dynamicform-project",
-  "version": "0.81.9",
+  "version": "0.82.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "dynamicform-project",
-      "version": "0.81.9",
+      "version": "0.82.0",
       "license": "UNLICENSED",
       "workspaces": [
         "vue/*"
@@ -595,9 +595,9 @@
       }
     },
     "node_modules/@dynamicforms/vue-forms": {
-      "version": "1.0.0",
-      "resolved": "https://registry.npmjs.org/@dynamicforms/vue-forms/-/vue-forms-1.0.0.tgz",
-      "integrity": "sha512-FAyeFlU7LtcbvB9zfOnecrhPwKFylz1l5B9frztDTbIHnUQxhKfQvubQsPEfJ4jXcn7P4Pi5JYyDGCIhrqjCWg==",
+      "version": "2.0.2",
+      "resolved": "https://registry.npmjs.org/@dynamicforms/vue-forms/-/vue-forms-2.0.2.tgz",
+      "integrity": "sha512-bnq0USLpFb1xIZXzXnZh9QzME1R8XzlD1qSY1fIo5FFaVBgRtFY36lOMIC5lfFoL5I6KYDIaP+Igjnba48+ADQ==",
       "license": "MIT",
       "peer": true,
       "workspaces": [
@@ -615,9 +615,9 @@
       }
     },
     "node_modules/@dynamicforms/vuetify-inputs": {
-      "version": "0.11.0",
-      "resolved": "https://registry.npmjs.org/@dynamicforms/vuetify-inputs/-/vuetify-inputs-0.11.0.tgz",
-      "integrity": "sha512-Z8oRx9RHGT0sd9fDyQmOwqYIiaINlVKqOTefAvHTDUvfosMHykjRzAYB8xhxBj5sruF9OcqAJQAyWEcOKijpww==",
+      "version": "0.12.1",
+      "resolved": "https://registry.npmjs.org/@dynamicforms/vuetify-inputs/-/vuetify-inputs-0.12.1.tgz",
+      "integrity": "sha512-2K9HkUaGrjrxZpsD9ARYgcmtkGZ38k3ud82ugOfjYf7XLCTy8Qno4WVha3P4NzslJWONQPaXzvNGd3hmbAJH8Q==",
       "license": "MIT",
       "workspaces": [
         "docs"
@@ -627,7 +627,7 @@
       },
       "peerDependencies": {
         "@dynamicforms/translatable": "^0.1.0",
-        "@dynamicforms/vue-forms": "^1.0.0",
+        "@dynamicforms/vue-forms": "^2.0.2",
         "@mdi/font": "^7.4.47",
         "@tiptap/core": "^3.30.2",
         "@tiptap/extension-image": "^3.30.2",
@@ -12733,7 +12733,7 @@
     "vue/demo": {
       "version": "1.0.0",
       "dependencies": {
-        "@dynamicforms/vuetify-inputs": "^0.11.0",
+        "@dynamicforms/vuetify-inputs": "^0.12.1",
         "@fullcalendar/core": "^6.1.4",
         "@fullcalendar/daygrid": "^6.1.4",
         "@fullcalendar/interaction": "^6.1.4",
@@ -13269,7 +13269,7 @@
     },
     "vue/dynamicforms": {
       "name": "@velis/dynamicforms",
-      "version": "0.81.9",
+      "version": "0.82.0",
       "license": "Proprietary",
       "dependencies": {
         "resize-observer-polyfill": "^1.5.1"
@@ -13296,8 +13296,8 @@
         "node": ">=22"
       },
       "peerDependencies": {
-        "@dynamicforms/vue-forms": "^1.0.0",
-        "@dynamicforms/vuetify-inputs": "^0.11.0",
+        "@dynamicforms/vue-forms": "^2.0.2",
+        "@dynamicforms/vuetify-inputs": "^0.12.1",
         "@kyvg/vue3-notification": "^3.2.1",
         "axios": "^1.4.0",
         "date-fns": "^4.1.0",

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/package.json

@@ -1,7 +1,7 @@
 {
   "name": "dynamicform-project",
   "private": false,
-  "version": "0.81.9",
+  "version": "0.82.0",
   "description": "Data entry boilerplate components and a RESTful API consumer",
   "author": "velis74",
   "license": "UNLICENSED",

{dynamicforms-0.81.9 → dynamicforms-0.82.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "dynamicforms"
-version = "0.81.9"
+version = "0.82.0"
 description = "DyF performs all the visualisation & data entry of your DRF Serializers & ViewSets and adds some candy of its own"
 readme = "README.md"
 requires-python = ">=3.8"

dynamicforms-0.82.0/tests/unit/test_dynamic_model_mixin.py

@@ -0,0 +1,44 @@
+"""
+DynamicModelSerializerMixin.__init__() used to do `self.Meta.model = model` - since `self.Meta`
+resolves to the serializer CLASS's `Meta` unless shadowed, this mutated a shared class attribute
+instead of an instance one. Any other instance of the same serializer class (including ones already
+constructed, or ones built moments later by a concurrent/unrelated request) would see whichever
+model the LAST instantiation happened to resolve, instead of its own.
+"""
+
+from django.test import TestCase
+from django.test.client import RequestFactory
+
+from dynamicforms.serializers import DynamicModelSerializerMixin, ModelSerializer
+from examples.models import Filter, Validated
+
+
+class _SwitchableSerializer(DynamicModelSerializerMixin, ModelSerializer):
+    class Meta:
+        model = Validated
+        exclude = ()
+
+    def determine_model_at_runtime(self, request):
+        return getattr(request, "dynamic_model", None)
+
+
+class DynamicModelMixinTest(TestCase):
+    def test_instance_override_does_not_leak_into_other_instances_or_the_class(self):
+        original_model = _SwitchableSerializer.Meta.model
+
+        request_a = RequestFactory().get("/")
+        request_a.dynamic_model = Filter
+        serializer_a = _SwitchableSerializer(context={"request": request_a})
+        self.assertIs(serializer_a.Meta.model, Filter)
+        # The class itself must be untouched by instantiating serializer_a.
+        self.assertIs(_SwitchableSerializer.Meta.model, original_model)
+
+        # A second instance (simulating a later or concurrent, unrelated request) that resolves no
+        # dynamic model at all must fall back to the class default, not inherit serializer_a's Filter.
+        request_b = RequestFactory().get("/")
+        serializer_b = _SwitchableSerializer(context={"request": request_b})
+        self.assertIs(serializer_b.Meta.model, original_model)
+
+        # serializer_a must be unaffected by serializer_b's later construction - this is the actual
+        # regression: before the fix, this would now also read `original_model`, not `Filter`.
+        self.assertIs(serializer_a.Meta.model, Filter)