dsap-cli 1.1.2__tar.gz → 1.1.4__tar.gz

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to DSAP will be documented here.
 
+## [1.1.3] - 2026-05-08
+
+### Fixed
+
+- `dsap list` crashed with `ValidationError: solved_at cannot be before
+  first_attempted` for users who reviewed problems before v1.1.0. Root cause:
+  v1.1.0 back-filled `first_attempted` with the current timestamp on the next
+  review, which landed after the already-stored `solved_at`. Fix: the validator
+  now coerces `first_attempted` to `solved_at` instead of raising; a one-time
+  migration runs on startup to correct existing rows; and the UPDATE query
+  no longer sets `first_attempted` later than `solved_at`.
+
 ## [1.1.2] - 2026-05-08
 
 ### Fixed
@@ -98,6 +110,7 @@ Initial release.
 
 ---
 
+[1.1.3]: https://github.com/juma-paul/dsap-cli/compare/v1.1.2...v1.1.3
 [1.1.2]: https://github.com/juma-paul/dsap-cli/compare/v1.1.1...v1.1.2
 [1.1.1]: https://github.com/juma-paul/dsap-cli/compare/v1.1.0...v1.1.1
 [1.1.0]: https://github.com/juma-paul/dsap-cli/compare/v1.0.2...v1.1.0

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dsap-cli
-Version: 1.1.2
+Version: 1.1.4
 Summary: CLI tool for practicing data structures and algorithms using spaced repetition.
 Project-URL: Repository, https://github.com/juma-paul/dsap-cli
 Project-URL: Issues, https://github.com/juma-paul/dsap-cli/issues

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/src/dsap/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.1.2'
-__version_tuple__ = version_tuple = (1, 1, 2)
+__version__ = version = '1.1.4'
+__version_tuple__ = version_tuple = (1, 1, 4)
 
 __commit_id__ = commit_id = None

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/src/dsap/database.py

@@ -12,7 +12,7 @@ import os
 import sqlite3
 from collections.abc import Iterator
 from contextlib import contextmanager
-from datetime import datetime, timedelta
+from datetime import date, datetime, timedelta
 from pathlib import Path
 from typing import Any
 
@@ -141,6 +141,16 @@ class Database:
                 ON sessions(date);
             """)
 
+            # Fix rows where first_attempted was back-filled after solved_at
+            # (introduced by v1.1.0 when first_attempted was NULL for old records)
+            conn.execute("""
+                UPDATE progress
+                SET first_attempted = solved_at
+                WHERE first_attempted IS NOT NULL
+                  AND solved_at IS NOT NULL
+                  AND first_attempted > solved_at
+            """)
+
     # ==================== Problem Operations ====================
 
     def add_problem(self, problem: Problem) -> int:
@@ -241,9 +251,9 @@ class Database:
             params.append(problem_set)
 
         if due_only:
-            now = datetime.now().isoformat()
-            conditions.append("(pr.next_review <= ? OR pr.next_review IS NULL)")
-            params.append(now)
+            today = datetime.now().date().isoformat()
+            conditions.append("(DATE(pr.next_review) <= ? OR pr.next_review IS NULL)")
+            params.append(today)
 
         where_clause = "WHERE " + " AND ".join(conditions) if conditions else ""
         params.append(limit)
@@ -472,8 +482,9 @@ class Database:
                         attempts = attempts + 1,
                         solved = CASE WHEN ? >= 3 THEN 1 ELSE solved END,
                         first_attempted = CASE
-                            WHEN first_attempted IS NULL THEN ?
-                            ELSE first_attempted
+                            WHEN first_attempted IS NOT NULL THEN first_attempted
+                            WHEN solved_at IS NOT NULL THEN solved_at
+                            ELSE ?
                         END,
                         solved_at = CASE
                             WHEN ? >= 3 AND solved = 0 THEN ?
@@ -566,21 +577,21 @@ class Database:
             """).fetchone()
 
             # Due counts
-            now = datetime.now().isoformat()
-            week_later = (datetime.now() + timedelta(days=7)).isoformat()
+            today = date.today().isoformat()
+            week_later = (date.today() + timedelta(days=7)).isoformat()
 
             due_today = conn.execute(
                 """
                 SELECT COUNT(*) FROM progress
-                WHERE next_review <= ? OR next_review IS NULL
+                WHERE DATE(next_review) <= ? OR next_review IS NULL
             """,
-                (now,),
+                (today,),
             ).fetchone()[0]
 
             due_week = conn.execute(
                 """
                 SELECT COUNT(*) FROM progress
-                WHERE next_review <= ?
+                WHERE DATE(next_review) <= ? OR next_review IS NULL
             """,
                 (week_later,),
             ).fetchone()[0]

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/src/dsap/models.py

@@ -129,7 +129,10 @@ class ProblemProgress(DSAPBaseModel):
             and self.first_attempted
             and self.solved_at < self.first_attempted
         ):
-            raise ValueError("solved_at cannot be before first_attempted")
+            # Coerce: first_attempted cannot be later than solved_at.
+            # This can happen with data written by older versions where
+            # first_attempted was back-filled after solved_at was set.
+            self.first_attempted = self.solved_at
 
         if self.solved and self.solved_at is None:
             self.solved_at = datetime.now()

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/src/dsap/sm2.py

@@ -252,8 +252,7 @@ class SM2State:
             now = datetime.now()
         if self.next_review is None:
             return 0
-        delta = self.next_review - now
-        return delta.days
+        return (self.next_review.date() - now.date()).days
 
 
 def calculate_easiness_factor(current_ef: float, quality: int) -> float:

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/src/dsap/ui.py

@@ -8,7 +8,7 @@ Provides beautiful terminal output using Rich library:
 """
 
 import webbrowser
-from datetime import datetime
+from datetime import date
 
 from rich import box
 from rich.console import Console
@@ -137,8 +137,7 @@ def display_problem(
             f"  EF: {progress.easiness_factor:.2f} | Interval: {progress.interval} days"
         )
         if progress.next_review:
-            now = datetime.now()
-            delta = (progress.next_review - now).days
+            delta = (progress.next_review.date() - date.today()).days
             if delta < 0:
                 due_str = f"Overdue by {abs(delta)} day{'s' if abs(delta) != 1 else ''}"
             elif delta == 0:
@@ -372,12 +371,13 @@ def display_problem_list(
             ef = "-"
 
         if progress and progress.next_review:
-            now = datetime.now()
-            delta = (progress.next_review - now).days
+            delta = (progress.next_review.date() - date.today()).days
             if delta < 0:
                 due_text = f"[red]{abs(delta)}d late[/red]"
             elif delta == 0:
                 due_text = "[yellow]today[/yellow]"
+            elif delta == 1:
+                due_text = "[dim]tomorrow[/dim]"
             else:
                 due_text = f"[dim]in {delta}d[/dim]"
         else:

{dsap_cli-1.1.2 → dsap_cli-1.1.4}/tests/test_models.py

@@ -194,15 +194,17 @@ class TestProblemProgress:
             make_progress(last_quality=-1)
 
     def test_solved_date_validation(self) -> None:
+        # When solved_at is before first_attempted, first_attempted is coerced
+        # to match solved_at rather than raising — supports legacy data.
         first = datetime.now()
         before_first = first - timedelta(days=1)
 
-        with pytest.raises(ValueError, match="solved_at cannot be before"):
-            make_progress(
-                first_attempted=first,
-                solved_at=before_first,
-                solved=True,
-            )
+        progress = make_progress(
+            first_attempted=first,
+            solved_at=before_first,
+            solved=True,
+        )
+        assert progress.first_attempted == before_first
 
     def test_solved_sets_solved_at(self) -> None:
         progress = make_progress(solved=True)