ds-caselaw-marklogic-api-client 29.0.0__tar.gz → 29.0.1__tar.gz

{ds_caselaw_marklogic_api_client-29.0.0 → ds_caselaw_marklogic_api_client-29.0.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ds-caselaw-marklogic-api-client
-Version: 29.0.0
+Version: 29.0.1
 Summary: An API client for interacting with the underlying data in Find Caselaw.
 Home-page: https://github.com/nationalarchives/ds-caselaw-custom-api-client
 Keywords: national archives,caselaw

{ds_caselaw_marklogic_api_client-29.0.0 → ds_caselaw_marklogic_api_client-29.0.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "ds-caselaw-marklogic-api-client"
-version = "29.0.0"
+version = "29.0.1"
 description = "An API client for interacting with the underlying data in Find Caselaw."
 authors = ["The National Archives"]
 homepage = "https://github.com/nationalarchives/ds-caselaw-custom-api-client"

{ds_caselaw_marklogic_api_client-29.0.0 → ds_caselaw_marklogic_api_client-29.0.1}/src/caselawclient/models/identifiers/__init__.py

@@ -177,6 +177,6 @@ class Identifiers(dict[str, Identifier]):
 
         :return: Return the highest scoring identifier of the given type (or of any type, if none is specified). Returns `None` if no identifier is available.
         """
-        if len(self) == 0:
+        if len(self.by_score(type)) == 0:
             return None
         return self.by_score(type)[0]

{ds_caselaw_marklogic_api_client-29.0.0 → ds_caselaw_marklogic_api_client-29.0.1}/src/caselawclient/models/identifiers/unpacker.py

@@ -1,4 +1,5 @@
 from typing import Optional
+from warnings import warn
 
 from lxml import etree
 
@@ -19,12 +20,13 @@ def unpack_all_identifiers_from_etree(identifiers_etree: Optional[etree._Element
         return identifiers
     for identifier_etree in identifiers_etree.findall("identifier"):
         identifier = unpack_an_identifier_from_etree(identifier_etree)
-        identifiers.add(identifier)
+        if identifier:
+            identifiers.add(identifier)
     return identifiers
 
 
-def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Identifier:
-    """Given an etree representation of a single identifier, unpack it into an appropriate instance of an Identifier."""
+def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Optional[Identifier]:
+    """Given an etree representation of a single identifier, unpack it into an appropriate instance of an Identifier if the type is known (otherwise return `None`)."""
 
     namespace_element = identifier_xml.find("namespace")
 
@@ -33,6 +35,11 @@ def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Identifie
             "Identifer XML representation is not valid: namespace not present or empty"
         )
 
+    # If the identifier namespace isn't known, fail out
+    if namespace_element.text not in IDENTIFIER_NAMESPACE_MAP:
+        warn(f"Identifier type {namespace_element.text} is not known.")
+        return None
+
     kwargs: dict[str, str] = {}
 
     for attribute in IDENTIFIER_UNPACKABLE_ATTRIBUTES: