drydock-cli 3.0.17__tar.gz → 3.0.19__tar.gz

{drydock_cli-3.0.17/drydock_cli.egg-info → drydock_cli-3.0.19}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: drydock-cli
-Version: 3.0.17
+Version: 3.0.19
 Summary: Drydock — a local, provider-agnostic terminal coding agent for local LLMs
 Author: Frank Bobe III
 License-Expression: Apache-2.0

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/__init__.py

@@ -7,4 +7,4 @@ try:
     __version__ = _version("drydock-cli")
 except PackageNotFoundError:
     # Running from source before install (e.g. PYTHONPATH dev runs).
-    __version__ = "3.0.17"
+    __version__ = "3.0.19"

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/agent.py

@@ -103,6 +103,13 @@ def run(
     # a call to anything else is refused — never executed. Keeps a read-only
     # sub-agent read-only and stops it from recursing into `task`.
     allow = config.get("tool_allowlist")
+    # User STOP signal (a threading.Event the TUI sets on Escape / "/stop").
+    # Checked only at SAFE points — top of the loop and after a turn's tool
+    # results are all appended — so a stop never leaves an assistant tool_call
+    # without its matching tool result (which would corrupt the history).
+    cancel = config.get("_cancel")
+    def _stopped() -> bool:
+        return cancel is not None and cancel.is_set()
     tool_call_count = 0
     session_has_edited = False
     leaked_call_retries = 0
@@ -111,6 +118,8 @@ def run(
     loop_tracker = LoopTracker()
 
     while state.turn_count < max_turns:
+        if _stopped():
+            break
         state.turn_count += 1
         run_iteration += 1
         assistant_turn: AssistantTurn | None = None
@@ -264,6 +273,11 @@ def run(
                 "content": result,
             })
 
+        # Safe point (all tool results appended): honor a STOP requested while
+        # this turn's tools were running, before spending another LLM call.
+        if _stopped():
+            break
+
         # Real progress this turn — reset the consecutive stall-nudge counter so
         # a long, productive plan can run as far as it needs (the cap only
         # bounds back-to-back stalls).

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/cli.py

@@ -59,27 +59,6 @@ def load_project_instructions() -> str:
     return ""
 
 
-def ensure_agents_md() -> None:
-    """Auto-create AGENTS.md if no project instructions exist."""
-    for name in ("AGENTS.md", "DRYDOCK.md", ".drydock.md", "CLAUDE.md"):
-        if (Path.cwd() / name).exists():
-            return
-    (Path.cwd() / "AGENTS.md").write_text(
-        "# Project Instructions\n\n"
-        "DO NOT ask for confirmation. ACT IMMEDIATELY.\n"
-        "If there is a PRD.md, implement it. If there is code, work on it.\n\n"
-        "## Workflow\n"
-        "1. Read requirements or explore existing code\n"
-        "2. Create/edit files with Write or Edit\n"
-        "3. Test with Bash\n"
-        "4. Fix errors and verify\n\n"
-        "## Rules\n"
-        "- Use absolute imports for Python packages\n"
-        "- Always create __init__.py and __main__.py\n"
-        "- Test with python3 -m package_name\n"
-    )
-
-
 # ── REPL ──────────────────────────────────────────────────────────────────
 
 def print_colored(text: str, color: str = "") -> None:
@@ -245,10 +224,12 @@ def main():
         "onboarding": onboarding,
     }
 
-    ensure_agents_md()
-    # Loaded after ensure_agents_md so the auto-created AGENTS.md is included.
-    # The TUI reads this from config; CLI modes call load_project_instructions
-    # directly (see run_interactive/run_oneshot).
+    # Load a user's OWN AGENTS.md/DRYDOCK.md as background context if present.
+    # Drydock never CREATES one: auto-writing an AGENTS.md littered every
+    # directory the user ran drydock in, and its "ACT IMMEDIATELY, implement
+    # the PRD" content fought the system prompt and risked turning a plain
+    # greeting into a runaway build. The TUI reads this from config; CLI modes
+    # call load_project_instructions directly (see run_interactive/run_oneshot).
     config["project_instructions"] = load_project_instructions()
 
     if args.prompt:

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/compaction.py

@@ -35,18 +35,52 @@ def is_context_length_error(err: str) -> bool:
 
 
 def estimate_tokens(messages: list) -> int:
-    """Rough token estimate: chars / 3.5"""
+    """Rough token estimate: chars / 3.5.
+
+    CRUCIAL: a tool call's arguments live in a nested ``input`` dict — e.g. a
+    full-file Write puts the whole file in tool_calls[].input.content. Counting
+    only top-level strings missed that entirely, so a 40k-char Write read as ~0
+    tokens, compaction never fired, and the real request blew past the context
+    window. Count nested strings so the estimate reflects what's actually sent.
+    """
     total = 0
     for m in messages:
         content = m.get("content", "")
         if isinstance(content, str):
             total += len(content)
-        for tc in m.get("tool_calls", []):
-            if isinstance(tc, dict):
-                for v in tc.values():
-                    if isinstance(v, str):
-                        total += len(v)
-    return int(total / 3.5)
+        for tc in m.get("tool_calls", []) or []:
+            total += _count_chars(tc)
+    # /3.0, not /3.5: code is symbol-dense and tokenizes to MORE tokens than
+    # prose, so a conservative (slightly high) estimate keeps us off the wall.
+    return int(total / 3.0)
+
+
+def _count_chars(v) -> int:
+    """Total length of every string nested in v (str / dict / list)."""
+    if isinstance(v, str):
+        return len(v)
+    if isinstance(v, dict):
+        return sum(_count_chars(x) for x in v.values())
+    if isinstance(v, (list, tuple)):
+        return sum(_count_chars(x) for x in v)
+    return 0
+
+
+def _truncate_tool_call_args(messages: list, max_len: int) -> None:
+    """Shrink oversized string arguments inside OLD assistant tool calls (a
+    full-file Write/Edit is a top bloat source and nothing else truncates it).
+    The most recent tool-call message is left intact; truncating only the
+    argument *values* keeps each call's id, so tool-result pairing stays valid."""
+    last = max((i for i, m in enumerate(messages) if m.get("tool_calls")), default=-1)
+    for i, m in enumerate(messages):
+        if i == last:
+            continue
+        for tc in m.get("tool_calls") or []:
+            inp = tc.get("input") if isinstance(tc, dict) else None
+            if isinstance(inp, dict):
+                for k, v in inp.items():
+                    if isinstance(v, str) and len(v) > max_len:
+                        inp[k] = v[: max_len // 2] + "\n[... arg truncated ...]"
 
 
 def compact(messages: list, context_limit: int = 131072) -> list:
@@ -92,6 +126,10 @@ def compact(messages: list, context_limit: int = 131072) -> list:
             if current <= target:
                 break
 
+    # Pass 3: shrink big old tool-call arguments (full-file Write/Edit bodies).
+    if estimate_tokens(messages) > target:
+        _truncate_tool_call_args(messages, max_len=1500)
+
     return messages
 
 
@@ -135,6 +173,11 @@ def emergency_compact(messages: list, context_limit: int = 131072) -> list:
                 if isinstance(content, str) and len(content) > 500:
                     messages[i]["content"] = content[:300] + "\n[... truncated ...]"
 
+    # Pass 4: shrink big tool-CALL arguments — a full-file Write/Edit puts the
+    # whole file in tool_calls[].input and nothing above touches it. This was
+    # THE leak that let the real request stay over the window after compaction.
+    _truncate_tool_call_args(messages, max_len=300)
+
     return messages
 
 

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/tui/app.py

@@ -8,6 +8,7 @@ messages (see tui/messages.py). Nautical theme, original branding.
 from __future__ import annotations
 
 import random
+import threading
 import time
 
 from textual import work
@@ -119,6 +120,10 @@ class DrydockApp(App):
     BINDINGS = [
         Binding("ctrl+c", "copy_selection", "Copy", priority=True),
         Binding("ctrl+d", "quit", "Quit", priority=True),
+        # Escape stops a running turn (the agent ends cleanly, session kept) —
+        # the way out of a runaway task without quitting the whole app. "/stop"
+        # does the same. priority so it isn't swallowed by the focused prompt.
+        Binding("escape", "stop", "Stop the running turn", priority=True),
         Binding("ctrl+o", "toggle_tools", "Expand/collapse details"),
         # Scroll the transcript from the keyboard (focus stays on the prompt,
         # and SSH sessions often don't forward the mouse wheel). priority=True
@@ -129,6 +134,21 @@ class DrydockApp(App):
         Binding("ctrl+end", "scroll_bottom", "Bottom", priority=True, show=False),
     ]
 
+    def action_stop(self) -> None:
+        """STOP the running turn: signal the agent loop to end at its next safe
+        point, drop any queued prompts, and hand control back. The session
+        (history, files) is preserved — this is not a quit."""
+        if not self._busy:
+            return
+        self._cancel.set()
+        dropped = len(self._queue)
+        self._queue.clear()
+        note = "⏹ stopping after the current step…"
+        if dropped:
+            note += f" (discarded {dropped} queued)"
+        self._info(note)
+        self._refresh_status()
+
     def action_scroll_up(self) -> None:
         self._scroll.scroll_page_up()
 
@@ -185,6 +205,11 @@ class DrydockApp(App):
         self._current_assistant: AssistantMessage | None = None
         self._last_card: ToolCard | None = None
         self._busy = False
+        # STOP signal: Escape / "/stop" sets it; the agent loop checks it at safe
+        # points and ends the turn cleanly (session preserved). Lives in config
+        # so run() — and any sub-agent that copies config — can see it.
+        self._cancel = threading.Event()
+        self.config["_cancel"] = self._cancel
         self._queue: list[str] = []  # prompts submitted while a turn is running
         self._ctx_tokens = 0  # current context size (last turn's prompt tokens)
         self._ctrl_c_armed = False  # first Ctrl+C arms; second within ~2s exits
@@ -210,9 +235,9 @@ class DrydockApp(App):
             return "deny"
 
     def _build_system(self, model: str | None) -> str:
-        # The TUI must honor AGENTS.md/DRYDOCK.md like the CLI does — it's the
-        # primary surface, and project instructions carry the user's tool/style
-        # conventions. cli.main() loads them into config after ensure_agents_md.
+        # The TUI honors a user's OWN AGENTS.md/DRYDOCK.md like the CLI does —
+        # cli.main() loads it into config["project_instructions"] as background
+        # context (drydock never auto-creates one).
         return system_prompt_for_model(model) + self.config.get("project_instructions", "")
 
     # ── layout ────────────────────────────────────────────────────────────
@@ -318,6 +343,7 @@ class DrydockApp(App):
     def _begin(self, text: str) -> None:
         """Start an agent turn for an already-displayed user prompt."""
         self._current_assistant = None
+        self._cancel.clear()  # fresh turn — clear any prior STOP
         self._busy = True
         self._work_start = time.monotonic()
         self._work_word = random.choice(_WORKING_WORDS)
@@ -336,6 +362,11 @@ class DrydockApp(App):
         arg = parts[1].strip() if len(parts) > 1 else ""
         if cmd in ("/quit", "/exit", "/q"):
             self.exit()
+        elif cmd in ("/stop", "/cancel"):
+            if self._busy:
+                self.action_stop()
+            else:
+                self._info("Nothing is running.")
         elif cmd == "/clear":
             self.state = AgentState()
             self._scroll.remove_children()
@@ -377,10 +408,11 @@ class DrydockApp(App):
                 "  /cwd [path]      show or change the working directory\n"
                 "  /undo            revert the last file write/edit\n"
                 "  /back            rewind the last turn from the model's context\n"
+                "  /stop            stop the running turn (or press Esc)\n"
                 "  /status          session model, cwd, turns, tokens\n"
                 "  /clear           reset the conversation\n"
                 "  /quit            exit\n"
-                "Type a task and press Enter. ↑/↓ recall history · Ctrl+O expands tools."
+                "Type a task and press Enter. ↑/↓ recall history · Esc stops · Ctrl+O expands tools."
             )
         else:
             self._mount(ErrorMessage(f"unknown command: {cmd} (try /help)"))

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock/tui/widgets.py

@@ -16,12 +16,22 @@ _FAILURE_PREFIXES = ("Error", "REFUSED")
 # "[NOTE: …]" lines (see loop_detect.annotate). Strip them before judging
 # success, or a failed Edit behind a "[NOTE: write #9…]" reads as ✓.
 _LEADING_NOTES = re.compile(r"^\s*(?:\[NOTE:[^\]]*\]\s*)+")
+# Bash appends "[exit code: N]" only when a command FAILED (non-zero return).
+# Without this, a failed shell command (e.g. `command not found`, a compile
+# error, a failing test) renders as a green ✓ — which hides exactly the kind
+# of failure the operator relies on the TUI to surface.
+_BASH_EXIT = re.compile(r"\[exit code: (\d+)\]")
 
 
 def result_is_ok(result: str) -> bool:
     """Whether a tool result should render as success (✓) vs failure (✗)."""
     cleaned = _LEADING_NOTES.sub("", result or "")
-    return not cleaned.lstrip().startswith(_FAILURE_PREFIXES)
+    if cleaned.lstrip().startswith(_FAILURE_PREFIXES):
+        return False
+    m = _BASH_EXIT.search(cleaned)
+    if m and m.group(1) != "0":
+        return False
+    return True
 
 
 _TOOL_BODY_MAX = 8000

{drydock_cli-3.0.17 → drydock_cli-3.0.19/drydock_cli.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: drydock-cli
-Version: 3.0.17
+Version: 3.0.19
 Summary: Drydock — a local, provider-agnostic terminal coding agent for local LLMs
 Author: Frank Bobe III
 License-Expression: Apache-2.0

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/drydock_cli.egg-info/SOURCES.txt

@@ -30,6 +30,7 @@ drydock_cli.egg-info/top_level.txt
 tests/test_approval.py
 tests/test_back_command.py
 tests/test_bash_safety.py
+tests/test_cli_agents.py
 tests/test_compaction.py
 tests/test_config.py
 tests/test_detect.py
@@ -39,6 +40,7 @@ tests/test_leaked_tool_call.py
 tests/test_loop_detect.py
 tests/test_plan_autocontinue.py
 tests/test_providers_unreachable.py
+tests/test_stop.py
 tests/test_subagent.py
 tests/test_todo.py
 tests/test_tools_undo.py

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"
 # PyPI distribution name is drydock-cli (the established install name, continued
 # from the retired v2 fork); the import package + CLI command stay `drydock`.
 name = "drydock-cli"
-version = "3.0.17"
+version = "3.0.19"
 description = "Drydock — a local, provider-agnostic terminal coding agent for local LLMs"
 readme = "README.md"
 requires-python = ">=3.12"

drydock_cli-3.0.19/tests/test_cli_agents.py

@@ -0,0 +1,34 @@
+"""Drydock must LOAD a user's own AGENTS.md/DRYDOCK.md as background context,
+but must NEVER auto-create one (it littered every working directory and its
+'ACT IMMEDIATELY, implement the PRD' content fought the system prompt)."""
+from __future__ import annotations
+
+import os
+
+from drydock import cli
+
+
+def _in_dir(tmp_path, fn):
+    cwd = os.getcwd()
+    os.chdir(tmp_path)
+    try:
+        return fn()
+    finally:
+        os.chdir(cwd)
+
+
+def test_no_agents_md_is_created(tmp_path):
+    # An empty project must stay empty after loading instructions.
+    text = _in_dir(tmp_path, cli.load_project_instructions)
+    assert text == ""
+    assert list(tmp_path.iterdir()) == []  # nothing written
+    assert not hasattr(cli, "ensure_agents_md")  # the auto-creator is gone
+
+
+def test_existing_agents_md_loaded_as_background(tmp_path):
+    (tmp_path / "AGENTS.md").write_text("Use 4-space indent. Prefer pathlib.")
+    text = _in_dir(tmp_path, cli.load_project_instructions)
+    assert "Use 4-space indent" in text
+    # Framed as background context, NOT a command to act now.
+    assert "background context" in text.lower()
+    assert "not a" in text.lower() and "act now" in text.lower()

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/tests/test_compaction.py

@@ -15,6 +15,40 @@ from drydock.compaction import (
 )
 
 
+def test_estimate_counts_tool_call_input_args():
+    # A full-file Write hides its bulk in tool_calls[].input.content. The
+    # estimate MUST see it (this was the bug: it read as ~0 tokens).
+    big = "x" * 40000
+    msgs = [{"role": "assistant", "content": "",
+             "tool_calls": [{"id": "1", "name": "Write",
+                             "input": {"file_path": "a.py", "content": big}}]}]
+    assert estimate_tokens(msgs) > 10000  # ~40000/3.0, not ~0
+
+
+def test_emergency_compact_shrinks_big_write_arg_below_limit():
+    # Reproduce the operator's crash shape: history dominated by an OLD
+    # full-file Write arg. Emergency compaction must get the estimate under the
+    # real 64k window (it returned the SAME oversized request before).
+    limit = 65536
+    big = "y" * 250000  # ~83k est tokens — over the window
+    msgs = [
+        {"role": "user", "content": "refactor cli.py"},
+        {"role": "assistant", "content": "",
+         "tool_calls": [{"id": "1", "name": "Write",
+                         "input": {"file_path": "cli.py", "content": big}}]},
+        {"role": "tool", "tool_call_id": "1", "name": "Write", "content": "ok"},
+        {"role": "user", "content": "now run tests"},
+        {"role": "assistant", "content": "",
+         "tool_calls": [{"id": "2", "name": "Bash", "input": {"command": "pytest"}}]},
+        {"role": "tool", "tool_call_id": "2", "name": "Bash", "content": "passed"},
+    ]
+    assert estimate_tokens(msgs) > limit
+    emergency_compact(msgs, limit)
+    assert estimate_tokens(msgs) < limit  # actually under the window now
+    # The recent Bash tool_call (last) is preserved intact.
+    assert msgs[4]["tool_calls"][0]["input"]["command"] == "pytest"
+
+
 def test_is_context_length_error_matches_provider_phrasings():
     for msg in [
         "This model's maximum context length is 131072 tokens",

drydock_cli-3.0.19/tests/test_stop.py

@@ -0,0 +1,64 @@
+"""STOP/interrupt: a threading.Event in config["_cancel"] lets the TUI halt a
+running turn at a safe point. The agent must (a) not start a turn when stop is
+already set, and (b) end after the current turn's tools rather than looping —
+without leaving an assistant tool_call missing its tool result."""
+from __future__ import annotations
+
+import threading
+
+import drydock.agent as agent_mod
+from drydock.agent import AgentState, run
+from drydock.providers import AssistantTurn
+
+
+def test_no_turn_when_already_stopped(monkeypatch):
+    calls = {"n": 0}
+
+    def fake_stream(**kw):
+        calls["n"] += 1
+        yield AssistantTurn("hi", [], 1, 1)
+
+    monkeypatch.setattr(agent_mod, "stream", fake_stream)
+    ev = threading.Event()
+    ev.set()
+    st = AgentState()
+    list(run("go", st, {"model": "m", "_cancel": ev}, "sys"))
+    assert calls["n"] == 0  # loop broke before any model call
+
+
+def test_stop_ends_after_current_turn(monkeypatch):
+    # The model would loop forever (always returns a tool call); a stop set
+    # during the first turn must end the run after that turn's tools.
+    calls = {"n": 0}
+    ev = threading.Event()
+
+    def fake_stream(**kw):
+        calls["n"] += 1
+        ev.set()  # user hits STOP while this turn runs
+        yield AssistantTurn(
+            "", [{"id": str(calls["n"]), "name": "Read", "input": {"file_path": "nope"}}], 1, 1
+        )
+
+    monkeypatch.setattr(agent_mod, "stream", fake_stream)
+    st = AgentState()
+    list(run("go", st, {"model": "m", "_cancel": ev}, "sys"))
+    assert calls["n"] == 1  # exactly one turn, then stopped
+
+    # History is still valid: every assistant tool_call has a matching tool msg.
+    call_ids = [
+        tc["id"]
+        for msg in st.messages
+        if msg.get("role") == "assistant"
+        for tc in (msg.get("tool_calls") or [])
+    ]
+    tool_ids = [m["tool_call_id"] for m in st.messages if m["role"] == "tool"]
+    assert sorted(call_ids) == sorted(tool_ids)
+
+
+def test_no_cancel_event_runs_normally(monkeypatch):
+    # Absent a _cancel event, behaviour is unchanged.
+    seq = [AssistantTurn("done", [], 1, 1)]
+    monkeypatch.setattr(agent_mod, "stream", lambda **kw: iter([seq.pop(0)]))
+    st = AgentState()
+    list(run("go", st, {"model": "m"}, "sys"))
+    assert any(m.get("role") == "assistant" for m in st.messages)

{drydock_cli-3.0.17 → drydock_cli-3.0.19}/tests/test_tui.py

@@ -123,6 +123,13 @@ def test_result_is_ok_marks_failures():
     assert not result_is_ok("Error: nope")
     assert not result_is_ok("REFUSED: this command reformats a filesystem...")
     assert not result_is_ok("  Error: leading whitespace still counts")
+    # A failed shell command (Bash appends "[exit code: N]" only on failure)
+    # must render ✗, not a green ✓ — otherwise the TUI hides real failures.
+    assert not result_is_ok("bash: sqlite3: command not found\n[exit code: 127]")
+    assert not result_is_ok("test.c:1: error\n[exit code: 1]")
+    # Successful command output (no exit-code marker) stays ✓, even if it
+    # happens to mention the word 'error' in normal output.
+    assert result_is_ok("0 errors, 0 warnings\nBuild succeeded")
 
 
 def test_summarize_inputs_prefers_meaningful_keys():