draftwright 0.5.0rc2__tar.gz → 0.5.0rc3__tar.gz

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 ## Unreleased
 
+### Changed
+
+- The agent usage guide moved from `AGENTS.md` to `docs/using-draftwright.md`; `AGENTS.md`
+  now holds the contributor instructions formerly in `CLAUDE.md` (#1938).
+
+### Removed
+
+- Removed the eight expired `Drawing` methods (`add`, `add_view`, `clear_annotations`,
+  `set_view_coordinates`, `drop_view_coordinates`, `attach_part_model`,
+  `attach_solve_trace`, and `export_pdf`) and the legacy `Drawing.export` tuple
+  forms at their published 0.5.0 target. Pass `formats=` explicitly; export
+  returns a `{format: path}` dict. `Drawing.place_dim`, `Sheet.add_view`,
+  `Sheet.export`'s PDF default, and `make_drawing`'s SVG/DXF tuple remain (#2113).
+
+## v0.4.11–v0.5.0-rc1 — cumulative notes since v0.4.10
+
+These entries accumulated across patch releases and were all present by v0.4.31.
+They describe changes included by RC1; they do not assign each change to its first
+released version.
+
 ### Added
 
 - A hash-pinned AP242 CTC-01 canary now proves the full Pareto-first layout loop against
@@ -86,11 +106,6 @@
   `make_drawing`, and the CLI, including generated-script replay (#1612, #1589). Sergio's
   25/10/10/10 mm margins and 175 mm block are explicit options; existing defaults remain.
 
-### Changed
-
-- The agent usage guide moved from `AGENTS.md` to `docs/using-draftwright.md`; `AGENTS.md`
-  now holds the contributor instructions formerly in `CLAUDE.md` (#1938).
-
 ### Fixed
 
 - Assessment comparison now rejects an apparent resolution of measurement uncertainty when the

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: draftwright
-Version: 0.5.0rc2
+Version: 0.5.0rc3
 Summary: Automated technical-drawing generation for build123d
 Project-URL: Homepage, https://github.com/pzfreo/draftwright
 Project-URL: Repository, https://github.com/pzfreo/draftwright
@@ -807,8 +807,8 @@ issues = dwg.lint()                       # list[LintIssue] — coverage, page b
 paths = dwg.export("my_part", formats=("svg", "dxf"))   # {"svg": ..., "dxf": ...}
 ```
 
-`export()` with no `formats=` returns the old `(svg, dxf)` tuple; that shape is deprecated
-and removed in 0.5.0 (see [docs/deprecations.md](docs/deprecations.md)).
+`Drawing.export()` requires `formats=` and returns a `{format: path}` dict. For the
+SVG/DXF pair, pass `formats=("svg", "dxf")` (see [docs/deprecations.md](docs/deprecations.md)).
 
 ### Declarative drawings — reference features, declare intent
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/README.md

@@ -104,8 +104,8 @@ issues = dwg.lint()                       # list[LintIssue] — coverage, page b
 paths = dwg.export("my_part", formats=("svg", "dxf"))   # {"svg": ..., "dxf": ...}
 ```
 
-`export()` with no `formats=` returns the old `(svg, dxf)` tuple; that shape is deprecated
-and removed in 0.5.0 (see [docs/deprecations.md](docs/deprecations.md)).
+`Drawing.export()` requires `formats=` and returns a `{format: path}` dict. For the
+SVG/DXF pair, pass `formats=("svg", "dxf")` (see [docs/deprecations.md](docs/deprecations.md)).
 
 ### Declarative drawings — reference features, declare intent
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "draftwright"
-version = "0.5.0rc2"
+version = "0.5.0rc3"
 description = "Automated technical-drawing generation for build123d"
 readme = "README.md"
 license = { file = "LICENSE" }
@@ -89,17 +89,17 @@ testpaths = ["tests"]
 timeout = 300
 # `slow` covers end-to-end integration builds, including the large NIST CTC fixtures
 # (minutes each), deselected by default. `smoke` is a curated, build-light subset
-# (~30 s) for a quick local "did I break something obvious" check — run it with
+# for a quick local "did I break something obvious" check — run it with
 # `uv run pytest -m smoke`. The default run is the full supported-behavior tier
-# (`-m 'not slow and not scheduled'`; runtime depends on worker count). CI runs bounded
-# real-part canaries before merge, the scheduled tier after merge, and the full tier
-# across its compatibility matrix.
+# (`-m 'not slow and not scheduled'`; runtime depends on worker count). Ordinary PR
+# CI selects fast modules by changed source, with a bounded real-part canary; the
+# scheduled tier runs after merge, and the full-matrix label widens the PR sweep.
 markers = [
     "slow: end-to-end integration builds, including CTC fixtures (deselected by default)",
     "ctc04: scheduled tests that construct the CPU-heavy NIST CTC-04 drawing",
     "scheduled: compatibility and broad-corpus contracts selected by the scheduled tier",
     "real_part_canary: bounded real STEP semantic/export gate, selected once in PR CI",
-    "smoke: curated build-light subset for a fast local check (~30 s)",
+    "smoke: curated build-light subset for a quick local check",
     "unit: pure-logic inner-loop tier — constructs NO OCC geometry (enforced by conftest, #656)",
 ]
 # `SoftDeprecationWarning` marks a surface that is discouraged but SUPPORTED and not going
@@ -163,8 +163,12 @@ target-version = "py310"
 
 [tool.ruff.lint]
 select = ["E", "F", "I", "UP"]
+extend-select = ["B"]
 ignore = ["E501"]
 
+[tool.ruff.lint.flake8-bugbear]
+extend-immutable-calls = ["typer.Option"]
+
 [dependency-groups]
 docs = [
     "mkdocs>=1.6,<2",

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/skills/SKILL.md

@@ -12,12 +12,13 @@ to be installed in the execution environment.
 **There are two paths — start with the automatic one.**
 
 1. **Automatic (`make_drawing`)** — one call turns a part (or STEP file) into a
-   four-view SVG + DXF with dimensions, centrelines, and an ISO 7200 title
+   multi-view SVG + DXF with dimensions, centrelines, and an ISO 7200 title
    block.
 2. **Builder (`build_drawing`)** — the same pipeline, but it hands back a live
    `Drawing` you can edit before export.
 
-Requires `draftwright >= 0.4.0` and `build123d-drafting-helpers >= 0.14.1`.
+Requires `draftwright >= 0.4.0`; the current package requires
+`build123d-drafting-helpers >= 0.15.5`.
 Install: `pip install draftwright`.
 
 (The old floor said 0.1.9, which cannot run this guide: none of the feature-backed
@@ -63,8 +64,8 @@ svg, dxf = make_drawing(
 )
 ```
 
-`make_drawing` chooses the scale + ISO page size, projects front/plan/side/iso
-views, and annotates automatically — then lints and writes both SVG and DXF.
+`make_drawing` chooses the scale, ISO page size, and views required by the part,
+then annotates, lints, and writes both SVG and DXF.
 
 Automatic annotation covers **prismatic parts in full**: every recognised hole
 gets a grouped callout ("4× ø10 THRU", counterbore/depth symbols), bolt circles
@@ -87,11 +88,10 @@ name a detected *feature* and the measurement you want; the engine decides the
 offset, stacking, and strip slot.** You give *what*, never *where on the page*:
 placement is automatic and constraint-based.
 
-Prefer the feature-backed verbs (`dimension` / `locate` / `callout` / `note` /
-`drop`) over the raw page-coordinate primitives. The low-level API (`place_dim`,
-`add`, `add_view`, the view-coordinate plumbing) is **deprecated** — see
-`docs/deprecations.md` — because a raw coordinate does not route through the
-layout solve, so it cannot be re-flowed when anything around it moves.
+Use the feature-backed verbs (`dimension` / `locate` / `callout` / `note` /
+`drop`) for edits. `Drawing.place_dim` remains a deprecated raw-coordinate
+escape hatch; `Drawing.add`, `Drawing.add_view`, and the public view-coordinate
+plumbing were removed in 0.5.0. See `docs/deprecations.md`.
 
 ```python
 from draftwright import build_drawing
@@ -109,7 +109,7 @@ dwg.annotations()           # {name: type} of every named annotation already on
 dwg.get_annotation(name)    # the named annotation object, or None
 dwg.view_bounds("front")    # (x_min, y_min, x_max, y_max) page bbox of a view, or None
 dwg.items                   # the ordered, mutable list of annotation objects
-dwg.views                   # {"front","plan","side","iso"} → (visible, hidden) compounds
+dwg.views                   # selected view names → (visible, hidden) compounds
 dwg.draft / dwg.scale / dwg.page_w / dwg.page_h
 ```
 
@@ -179,16 +179,15 @@ paths = dwg.export("drawings/bracket", formats=("svg", "dxf", "pdf"))
 svg, dxf = paths["svg"], paths["dxf"]
 ```
 
-Pass `formats=` and read the `{format: path}` dict. Calling `export()` with no
-`formats` — or with the `svg=`/`dxf=` booleans — takes the legacy path and returns
-a `(svg, dxf)` tuple. Both are deprecated (v0.3.1) and removed in 0.5.0, and both
-warn from 0.4.0. See `docs/deprecations.md`.
+Pass `formats=` and read the `{format: path}` dict. `Drawing.export()` without
+`formats`, with `formats=None`, or with the old `svg=`/`dxf=` booleans was removed
+in 0.5.0. See `docs/deprecations.md`.
 
 `make_drawing(...)` is unaffected and does not warn: it still returns
 `(svg_path, dxf_path)`, and passes `formats=` internally to get them.
 
-`make_drawing(...)` is `build_drawing(...).export(formats=("svg", "dxf"))`, unpacked to a
-tuple — not a bare `.export()`, which is the deprecated shape above.
+`make_drawing(...)` calls `build_drawing(...).export(formats=("svg", "dxf"))`
+and returns the two paths as a tuple.
 
 **Authored section views** use `section_view()` alongside an explicit dimension and
 view set. This complete example declares the bore diameter and overall extents;
@@ -240,14 +239,12 @@ method for your view source above. `Drawing.section()` remains the automatic
 post-build section operation: it may return no section when the geometry does not
 warrant one. It does not replace an explicit authored section request.
 
-Arbitrary **auxiliary** views have no public verb: `add_view()` was the way to
-project one and is deprecated, so a custom viewing direction is not currently part
-of the supported surface.
+Arbitrary **auxiliary** views have no public `Drawing` verb, so a custom viewing
+direction is not currently part of the supported surface.
 
-`add_view()` and the view-coordinate plumbing (`set_view_coordinates`,
-`drop_view_coordinates`, and the `vc.pp(...)` projector) are **deprecated** (#817):
-view projection is engine plumbing, and hand-placed views do not participate in the
-compose-then-pack layout.
+`Drawing.add_view()` and its public view-coordinate plumbing were removed in
+0.5.0 (#2113). `Sheet.add_view()` is a separate supported verb for augmenting an
+automatic view set; view projection itself remains engine plumbing.
 
 ---
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/_build_profile.py

@@ -100,7 +100,7 @@ def pytest_configure(config) -> None:
     # The public lazy package attribute and Sheet's import-time binding otherwise bypass a
     # patch installed only on builder.py. That omission made the first #1307 census a lower
     # bound, so all three bindings are explicit here.
-    setattr(draftwright, "build_drawing", builder_public)
+    setattr(draftwright, "build_drawing", builder_public)  # noqa: B010 - lazy package attribute
     sheet.build_drawing = _timed("sheet.build_drawing", sheet.build_drawing)
     builder._build_drawing_once = _timed(
         "builder._build_drawing_once", builder._build_drawing_once

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/_core.py

@@ -1184,21 +1184,22 @@ def y_chain_detail_scale_needed(
     if not segments:
         return None
     centres = sorted(
-        ((pa + pb) / 2, width) for (pa, pb, _length), width in zip(segments, label_widths)
+        ((pa + pb) / 2, width)
+        for (pa, pb, _length), width in zip(segments, label_widths, strict=True)
     )
     labels_clear = all(
         next_centre - centre >= (width + next_width) / 2 + text_padding
-        for (centre, width), (next_centre, next_width) in zip(centres, centres[1:])
+        for (centre, width), (next_centre, next_width) in zip(centres, centres[1:], strict=False)
     )
     inside_arrows_fit = all(
         abs(pb - pa) >= width + 2 * arrow_length + 2 * text_padding
-        for (pa, pb, _length), width in zip(segments, label_widths)
+        for (pa, pb, _length), width in zip(segments, label_widths, strict=True)
     )
     if labels_clear and inside_arrows_fit:
         return None
     return max(
         (width + 2 * arrow_length + 2 * text_padding) / length
-        for (_pa, _pb, length), width in zip(segments, label_widths)
+        for (_pa, _pb, length), width in zip(segments, label_widths, strict=True)
         if length > 0
     )
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/_geometry.py

@@ -315,7 +315,9 @@ def _turned_profile_site(site, axis: str, view: str, cylinders) -> tuple[float,
         )
         surface_gap = abs(radial_distance - float(cylinder["diameter"]) / 2)
         direction = tuple(float(value) for value in cylinder["dir_xyz"])
-        axial_station = sum(value * component for value, component in zip(values, direction))
+        axial_station = sum(
+            value * component for value, component in zip(values, direction, strict=False)
+        )
         s_lo = float(cylinder["s_lo"])
         s_hi = float(cylinder["s_hi"])
         axial_gap = max(s_lo - axial_station, 0.0, axial_station - s_hi)
@@ -615,7 +617,7 @@ def _fmt_angle(value, decimals=None, tolerance=None) -> str:
 
 def _boxes_overlap(a, b) -> bool:
     """True when two ``(x0, y0, x1, y1)`` AABBs overlap (strict: a touch is not
-    an overlap). The one pairwise test behind both the placement-side
+    an overlap). A shared pairwise test behind both the placement-side
     ``_box_hits`` and the lint-side overlap checks (#700). Nuance: a degenerate
     (zero-width/height) box strictly inside the other counts as overlapping
     here, where the pre-#700 ``_box_hits`` form said no — the conservative

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/analysis.py

@@ -157,13 +157,14 @@ def _automatic_y_chain_detail_footprints(
     # line. A single pre-sheet box would otherwise plan a phantom combined
     # chain and could enlarge the sheet without any matching detail request.
     if any(
-        abs(previous[1] - current[0]) > 1e-3 + 1e-9 for previous, current in zip(rows, rows[1:])
+        abs(previous[1] - current[0]) > 1e-3 + 1e-9
+        for previous, current in zip(rows, rows[1:], strict=False)
     ):
         return None
     # The renderer states a contiguous repeated pitch of three or more once on
     # the parent view. Such a chain does not request an enlarged detail.
     repeat = 1
-    for prev, current in zip(rows, rows[1:]):
+    for prev, current in zip(rows, rows[1:], strict=False):
         old, new = prev[2], current[2]
         same_text = (
             old.value_text == new.value_text
@@ -302,7 +303,8 @@ def _automatic_x_head_detail_footprints(
         # different physically sorted run until both boundaries share ordering.
         return None
     if any(
-        abs(previous[1] - current[0]) > 1e-3 + 1e-9 for previous, current in zip(rows, rows[1:])
+        abs(previous[1] - current[0]) > 1e-3 + 1e-9
+        for previous, current in zip(rows, rows[1:], strict=False)
     ):
         return None
     # The renderer crops against the controlled step's physical profile, not
@@ -1063,7 +1065,7 @@ def _validate_explicit_scale(
         if advisories is not None:
             advisories.append(("legibility_floor_breached", message))
         if warn_advisory:
-            warnings.warn(message)
+            warnings.warn(message, stacklevel=1)
 
 
 @dataclass(frozen=True)
@@ -1939,7 +1941,6 @@ def _select_sheet(
             _measure_strips(
                 strip_sizing_model,
                 n_steps_i,
-                bb,
                 arrow_length=_arrow_length,
                 pad_around_text=_pad_around_text,
                 bore_callout_width=bore_callout_width,
@@ -2090,7 +2091,6 @@ def _place_sheet(
         _measure_strips(
             strip_sizing_model,
             n_steps,
-            bb,
             arrow_length=_arrow_length,
             pad_around_text=_pad_around_text,
             bore_callout_width=bore_callout_width,

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotate.py

@@ -1,9 +1,8 @@
 """Compat facade: the annotation passes moved to the annotations/ subpackage (#164).
 
-`_auto_annotate` (the orchestrator) now lives in `annotations.orchestrator`; the
-individual passes in `annotations.{sections,turned,pmi,holes}`. This module re-exports
-the orchestrator entry point and the two helpers still referenced by name elsewhere,
-so `from draftwright.annotate import _auto_annotate` keeps working.
+`_auto_annotate` and its companion entry points live in
+`annotations.orchestrator`; rendering passes live in `annotations/`. This module
+retains the historical import path for callers of those entry points.
 """
 
 import warnings

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_axial_render.py

@@ -117,7 +117,7 @@ def _step_measurements(segs: list[_StepChainSegment]) -> tuple[Any, ...]:
     return tuple(result)
 
 
-def _record_step_chain_drop(dwg, why: str, *, ctx, measurement=()) -> None:
+def _record_step_chain_drop(why: str, *, ctx, measurement=()) -> None:
     """Record the ``step_dim_dropped`` warning for unresolved turned lengths.
     These drops were silent (debug log only) — the user got
     a drawing with no step-length dimensioning and no signal. Mirrors
@@ -221,7 +221,7 @@ def _draw_step_chain(
             def _clear(items):
                 return all(
                     c2 - c1 >= (w1 + w2) / 2 + draft.pad_around_text
-                    for (c1, w1), (c2, w2) in zip(items, items[1:])
+                    for (c1, w1), (c2, w2) in zip(items, items[1:], strict=False)
                 )
 
             if _clear(cw):
@@ -231,7 +231,6 @@ def _draw_step_chain(
             else:
                 _log.info("step-length chain skipped: too dense even when staggered")
                 _record_step_chain_drop(
-                    dwg,
                     "shoulders too dense to dimension even when staggered",
                     ctx=ctx,
                     measurement=_step_measurements(segs),
@@ -300,7 +299,6 @@ def _draw_step_chain(
             page[0] <= box[0] and box[2] <= page[2] and page[1] <= box[1] and box[3] <= page[3]
         ):
             _record_step_chain_drop(
-                dwg,
                 "a dimension would fall off the drawable page",
                 ctx=ctx,
                 measurement=measurements,

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_common.py

@@ -1286,6 +1286,9 @@ class PlacementContext:
         source=None,
         outcome_stage=None,
         evidence_reason=None,
+        annotation_name=None,
+        view=None,
+        related_annotation_names=(),
     ) -> None:
         """Record a build-time lint issue on the run's registry (#639). Replaces the passes'
         old `dwg._record_build_issue`."""
@@ -1316,6 +1319,9 @@ class PlacementContext:
                 outcome_stage=outcome_stage,
                 measurement_spans=spans,
                 evidence_reason=evidence_reason,
+                annotation_name=annotation_name,
+                view=view,
+                related_annotation_names=tuple(related_annotation_names),
             )
         )
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_diameters.py

@@ -73,9 +73,9 @@ def _diameter_row_below(
     """ø-callout row BELOW the front view for X-turned step/boss diameters (#77).
     *items* is ``[(anchor, dia, value_text, feature, tolerance, thread, mids), ...]``. The row is dropped clear of anything
     already below the profile; labels spread along page-x by the ADR 2 (was 0003) strip
-    solve. Skips (returns 0) if there is no room — the diameters then surface as
-    ``feature_not_dimensioned``. *trace* (#736): one ``pass_events`` record with a
-    placed/dropped item per callout."""
+    solve. Skips (returns 0) if there is no room; the caller may then try radial
+    leaders, and any still-missing diameter reaches coverage lint. *trace* (#736): one
+    ``pass_events`` record with a placed/dropped item per callout."""
     if not items:
         return 0
     ev = trace.pass_event("diameter_row_below", view="front") if trace is not None else None
@@ -86,8 +86,8 @@ def _diameter_row_below(
         # `view_bounds` has always documented `None` for a view it does not have; with a
         # fixed four-view topology that could not happen, so the caller unpacked it directly
         # and a view set without the front crashed here. Skipping is the established
-        # behaviour of this function when there is no room — the diameters then surface as
-        # `feature_not_dimensioned` — and it is what lets the requirement gate WEIGH a view
+        # behaviour of this function when there is no room. Later radial fallback or
+        # coverage lint resolves the outcome, letting the requirement gate WEIGH a view
         # set instead of the build dying inside a pass.
         return 0
     fx0, fy0, fx1, _ = bounds
@@ -95,8 +95,25 @@ def _diameter_row_below(
     for o in dwg.items:
         try:
             ob = o.bounding_box()
-        except Exception:  # noqa: BLE001 — not every annotation bbox-es cleanly
-            continue
+        except Exception as exc:  # noqa: BLE001 — an unreadable obstacle cannot be ignored
+            for _, _, text, _, _, _, mids in items:
+                ctx.record_issue(
+                    "warning",
+                    "diameter_row_obstacle_unverified",
+                    f"ø{text} shared row withheld: below-front obstacle could not be measured "
+                    f"({type(exc).__name__})",
+                    measurement=mids,
+                    evidence_reason="obstacle_unverified",
+                )
+                if ev is not None:
+                    ev["items"].append(
+                        {
+                            "label": f"ø{text}",
+                            "outcome": "dropped",
+                            "reason": "obstacle_unverified",
+                        }
+                    )
+            return 0
         if ob.min.Y < fy0 and ob.max.X > fx0 and ob.min.X < fx1:
             obstacle_bottom = min(obstacle_bottom, ob.min.Y)
     label_y = obstacle_bottom - (draft.font_size + 4 * draft.pad_around_text)
@@ -156,7 +173,7 @@ def _diameter_row_below(
         return out
 
     def _collides(ivals):
-        pairs = zip(sorted(ivals), sorted(ivals)[1:])
+        pairs = zip(sorted(ivals), sorted(ivals)[1:], strict=False)
         return any(a1 > b0 for (_a0, a1), (b0, _b1) in pairs)
 
     while len(survivors) > 1 and _collides(_label_ivals(survivors, xs)):
@@ -179,7 +196,7 @@ def _diameter_row_below(
             for s in specs
             if id(s) not in kept
         )
-    for i, ((tip, dia, label, feat, mids), lx) in enumerate(zip(survivors, xs, strict=True)):
+    for i, ((tip, _dia, label, feat, mids), lx) in enumerate(zip(survivors, xs, strict=True)):
         ctx.place(
             Leader(tip=(tip[0], tip[1], 0), elbow=(lx, label_y, 0), label=label, draft=draft),
             f"m_dia_x{start + i}",
@@ -258,7 +275,7 @@ def _diameter_column_left(
         )
     occupied = strip_obstacles(dwg, view="front", crossable=CROSSABLE_TYPES)
     placed = 0
-    for i, ((tip, dia, label, feat, mids), ly) in enumerate(zip(survivors, ys, strict=True)):
+    for i, ((tip, _dia, label, feat, mids), ly) in enumerate(zip(survivors, ys, strict=True)):
         ldr = Leader(tip=(tip[0], tip[1], 0), elbow=(elbow_x, ly, 0), label=label, draft=draft)
         if _box_hits(_anno_box(ldr), occupied):
             if ev is not None:

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_envelope.py

@@ -268,7 +268,7 @@ def render_envelope(
             # The same model-space X span is visible in front. Route it there
             # before the shared corridor solve if that view has a real tier;
             # neither a later drop nor an interior retry can create strip depth.
-            def _one_tier_fits(strip):
+            def _one_tier_fits(strip, slot=slot):
                 if strip is None:
                     return False
                 lo, hi, _inner = strip_free_span(strip)
@@ -299,6 +299,7 @@ def render_envelope(
         p1, p2 = dwg.at(view, *start_pt), dwg.at(view, *end_pt)
         witness = p1[1] - _WITNESS_LIFT_MM
         zones = frame.zones(view)
+        label = _env_label(extent, dwg.draft)
         _queue(
             ann_name,
             zones.below,
@@ -307,8 +308,8 @@ def render_envelope(
             slot,
             abs(end_pt[index] - start_pt[index]),
             (p1[0], p2[0]),
-            _env_label(extent, dwg.draft),
-            lambda pos, _p1=p1, _p2=p2, _w=witness, _v=_env_label(extent, dwg.draft): dim_builder(
+            label,
+            lambda pos, _p1=p1, _p2=p2, _w=witness, _v=label: dim_builder(
                 (_p1[0], _w, 0),
                 (_p2[0], _w, 0),
                 "below",
@@ -319,8 +320,8 @@ def render_envelope(
             # Measure the same rendered label used by the Dimension. The span
             # usually dominates this footprint, but outside arrows can make the
             # label affect its extent.
-            footprint=lambda pos, _p1=p1, _p2=p2, _w=witness, _v=_env_label(extent, dwg.draft): (
-                dim_footprint((_p1[0], _w, 0), (_p2[0], _w, 0), "below", _w - pos, dwg.draft, _v)
+            footprint=lambda pos, _p1=p1, _p2=p2, _w=witness, _v=label: dim_footprint(
+                (_p1[0], _w, 0), (_p2[0], _w, 0), "below", _w - pos, dwg.draft, _v
             ),
             measurement=extent.id,
             measurement_span=extent.span,

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_locations.py

@@ -722,7 +722,7 @@ def _register_y_locations(
         and any(SX(ry) + 10 > iso_x0 - 4 for _, ry, _feat, _pin, _mids, _facts, _entries in y_refs)
     ):
         a.sv_zones.above.outer_limit = min(a.sv_zones.above.outer_limit, iso_y0 - 4)
-    for i, (rx, ry, feat, pin_ref, mids, location_facts, location_entries) in enumerate(
+    for i, (_rx, ry, feat, pin_ref, mids, location_facts, location_entries) in enumerate(
         sorted(y_refs, key=lambda r: abs(r[1] - datum_y))
     ):
         if abs(ry - datum_y) * a.SCALE < 1.0:

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_machined_leaders.py

@@ -72,9 +72,7 @@ class _MachinedJobContext:
         if view not in self.foreign_boxes_by_view:
             self.foreign_boxes_by_view[view] = tuple(
                 (box, has_label)
-                for _name, owner, box, has_label in self.bindings.attribute_annotations(
-                    self.dwg, self.a
-                )
+                for _name, owner, box, has_label in self.bindings.attribute_annotations(self.dwg)
                 if owner != view
             )
         pad = self.dwg.draft.pad_around_text
@@ -362,14 +360,14 @@ class _MachinedJobContext:
                 )
                 search_tip = normal_stub
 
-            def build_at(elbow, _tip=tip, _feature=feature):
+            def build_at(elbow, _tip=tip, _feature=feature, normal_stub=normal_stub):
                 if normal_stub is not None:
                     return decorate(
                         bindings.RoutedLeader(_tip, (normal_stub,), elbow, label, dwg.draft)
                     )
                 return build(_tip, (*elbow, 0), _feature)
 
-            def build_routed(bends, elbow, _tip=tip):
+            def build_routed(bends, elbow, _tip=tip, normal_stub=normal_stub):
                 route_bends = (normal_stub, *bends) if normal_stub is not None else bends
                 return decorate(bindings.RoutedLeader(_tip, route_bends, elbow, label, dwg.draft))
 

{draftwright-0.5.0rc2 → draftwright-0.5.0rc3}/src/draftwright/annotations/_patterns.py

@@ -132,7 +132,8 @@ def _coalesce_aligned_linear_pitch_dims(dwg, a: Analysis, *, ctx) -> None:
             dwg.remove(name)
         identity["measurement"] = tuple(measurements)
         ctx.registry.reapply(chosen_name, identity)
-        setattr(chosen, "source_features", tuple(owners))
+        # Feature annotations acquire this provenance after they are built.
+        setattr(chosen, "source_features", tuple(owners))  # noqa: B010
 
 
 def _add_grid_pitch_dims(