draftwright 0.4.27__tar.gz → 0.4.28__tar.gz

{draftwright-0.4.27 → draftwright-0.4.28}/CHANGELOG.md

@@ -154,6 +154,21 @@
 
 ### Changed
 
+- Updated the exact Quiddity runtime and declared-inspection contract to **0.2.8**, which stops
+  a modelled thread being read as a stack of turned shoulders and coalesces contiguous
+  equal-diameter bands into the one span they physically are. Measured on the repo corpus,
+  NIST CTC-05 is again the only fixture that moves: its ⌀304.8 region was three adjacent
+  rungs and is now one, in both STEP encodings (#1135, quiddity#587).
+
+- Updated the exact Quiddity runtime and declared-inspection contract to **0.2.7**. Unlike the
+  0.2.5 adoption below, this one changes drawings: the provider now requires circumferential
+  cylinder support to establish a turned-profile axis line, so rounded plate corners and parallel
+  offset cylinders no longer form a false stepped shaft. Measured on the repo corpus, NIST CTC-05
+  is the only fixture whose recognised turned profile moves — its two STEP encodings previously
+  disagreed (3 steps and 9 steps for the same solid) and now agree on 5 — and a plate part that
+  previously raised out of `generate_sheet_script` now emits and builds. No family, record schema
+  or adapter changed (#1555, quiddity#586).
+
 - Updated the exact Quiddity runtime and declared-inspection contract to 0.2.5 for the
   provider's recognition performance improvements.
 

{draftwright-0.4.27 → draftwright-0.4.28}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: draftwright
-Version: 0.4.27
+Version: 0.4.28
 Summary: Automated technical-drawing generation for build123d
 Project-URL: Homepage, https://github.com/pzfreo/draftwright
 Project-URL: Repository, https://github.com/pzfreo/draftwright
@@ -692,7 +692,7 @@ Requires-Dist: numpy>=1.24
 Requires-Dist: ocp-gordon<0.3
 Requires-Dist: pillow>=10
 Requires-Dist: pypdfium2>=4
-Requires-Dist: quiddity==0.2.6
+Requires-Dist: quiddity==0.2.8
 Requires-Dist: reportlab>=4.0
 Requires-Dist: rich>=10.11
 Requires-Dist: steputils==0.1

{draftwright-0.4.27 → draftwright-0.4.28}/docs/reference/recogniser-capabilities.md

@@ -70,11 +70,24 @@ issue. The contract test derives package record outputs, converter registries, l
 and emitter branches independently, so copying a new name into the declaration alone cannot make CI
 pass.
 
-### Quiddity 0.2.6 runtime contract
+### Quiddity 0.2.8 runtime contract
 
-The runtime pins the published `quiddity==0.2.6` package, following the 0.2.4 adoption in
+The runtime pins the published `quiddity==0.2.8` package, following the 0.2.4 adoption in
 [#1486](https://github.com/pzfreo/draftwright/pull/1486) and the migration in
-[#1471](https://github.com/pzfreo/draftwright/issues/1471). Its public `quiddity`, `quiddity.evidence` and
+[#1471](https://github.com/pzfreo/draftwright/issues/1471). 0.2.7 is a patch adoption: it requires
+circumferential cylinder support to establish a turned-profile axis line, so rounded plate corners
+and parallel offset cylinders no longer form a false stepped shaft
+([quiddity#586](https://github.com/pzfreo/quiddity/issues/586), [#1555](https://github.com/pzfreo/draftwright/issues/1555)).
+No family, record schema or adapter changed.
+
+0.2.7 also partitions bands by physical axis line rather than by axis direction, requiring two
+distinct diameters *per line*. One body can therefore publish **several** coaxial
+`TurnedProfile`s where 0.2.6 published at most one. `Analysis.profiles` already holds every
+body-local profile and is unaffected; `Analysis.prof` remains the compatible zero/one view and
+is `None` for a plural result, which sends `holes.py`'s `a.prof is not None` branches down their
+non-rotational path. **No fixture in this repository reaches plural cardinality on either
+version**, so the green tiers are not evidence that path behaves well — it is newly reachable
+and untested. Its public `quiddity`, `quiddity.evidence` and
 `quiddity.inspection` surfaces supply recognition, exact occurrence evidence and declared geometry
 reads. There is one recognition aggregate per build; consumers project that result rather than
 calling the document builder to obtain another run.

{draftwright-0.4.27 → draftwright-0.4.28}/docs/reference/sheet.md

@@ -278,7 +278,7 @@ produces `angular_support_unverifiable`; contradictory supports produce
 `angular_support_mismatch`.
 
 Automatic drawings derive outside-profile angular requirements from ordered face
-supports in Quiddity 0.2.6. Angles already defined by a recognised chamfer or
+supports, available since Quiddity 0.2.6. Angles already defined by a recognised chamfer or
 regular-polygon callout do not add duplicate automatic requirements. This requires
 the same run's exact face or shared-edge evidence, not matching numerical angles;
 explicit angle declarations remain available on those corners.

{draftwright-0.4.27 → draftwright-0.4.28}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "draftwright"
-version = "0.4.27"
+version = "0.4.28"
 description = "Automated technical-drawing generation for build123d"
 readme = "README.md"
 license = { file = "LICENSE" }
@@ -23,7 +23,7 @@ dependencies = [
     # published wheels, not only uv's development resolver constraints.
     "cadquery-ocp-novtk!=7.9.3.1.1 ; python_full_version >= '3.13'",
     "build123d-drafting-helpers>=0.15.1",
-    "quiddity==0.2.6",
+    "quiddity==0.2.8",
     "numpy>=1.24",
     # PNG raster export (SVG→PDF→PNG). Both permissively licensed (Pillow HPND; pypdfium2
     # Apache-2.0 wrapping Google PDFium BSD-3) and ship pre-built wheels with NO native system

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/_core.py

@@ -174,6 +174,15 @@ def _zone_divisions(page_w: float, page_h: float) -> tuple[int, int]:
 
 _TB_CLEAR = _MARGIN + 1.0  # title-block inset: one extra mm over _MARGIN for clearance
 
+#: What the general-tolerance cell states when no tolerance was authored or sourced.
+#: A blank cell is indistinguishable from an oversight and invites a shop to assume its
+#: own house standard, so the absent case is named rather than left empty (#1157).
+#: The cell is not tight — 48 mm on A4's 120 mm block, 60 mm above it, against 16.9 mm of
+#: ink here — so this is a wording choice, not a width-forced one. The paired test still
+#: measures it against the block's own `cell_bbox` on A4, the narrowest supported width,
+#: because a longer replacement (a sentence, say) would overflow there and nowhere else.
+_TOLERANCE_UNSPECIFIED = "UNSPECIFIED"
+
 _FONT_SIZE = 3.0  # annotation text height (page-mm); the draft preset is built with this
 
 
@@ -1236,7 +1245,12 @@ class Analysis:
     step_file: str | Path | Shape
     title: str
     number: str
-    tolerance: str
+    #: The general tolerance for the title block. ``None`` means the caller supplied none
+    #: and none was sourced — a distinct state from an explicitly authored string, because a
+    #: general tolerance is a manufacturing requirement and defaulting one invents intent
+    #: the source model may not carry (#1157). ``""`` is the explicit request for a blank
+    #: cell. `_make_title_block` renders `None` as `_TOLERANCE_UNSPECIFIED`.
+    tolerance: str | None
     drawn_by: str
     out: str
     # Canonical AP242 source census + extraction outcomes for a STEP input, including off mode
@@ -1351,7 +1365,7 @@ def _make_title_block(dwg, a: Analysis):
     so the two never drift."""
     title = _font_safe_text(a.title)
     number = _font_safe_text(a.number)
-    tolerance = _font_safe_text(a.tolerance)
+    tolerance = _font_safe_text(_TOLERANCE_UNSPECIFIED if a.tolerance is None else a.tolerance)
     designed_by = _font_safe_text(_attribution_author(a.drawn_by))
     material = _font_safe_text(a.material)
     date = _font_safe_text(a.date)

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/analysis.py

@@ -771,6 +771,7 @@ def _analyse(
     scale=None,
     page=None,
     pmi=None,
+    source=None,
     model=None,
     decorations=None,
     authored=None,
@@ -933,12 +934,23 @@ def _analyse(
         # Semantic PMI census (AP242 only; separate read-only pass). Framed extraction receives
         # the provider frame before it classifies correlation topology, preserving tight local
         # boxes and arbitrary directions (#1401 / ADR 3 (was 0020)). Even off mode inventories a STEP
-        # source so it can report ignored authored PMI; in-memory Shapes have no AP242 document.
-        if not isinstance(step_file, Shape):
+        # source so it can report ignored authored PMI.
+        #
+        # An in-memory Shape has no AP242 document of its own, which used to end the matter — and
+        # a `Sheet` ALWAYS holds one, so no script-built drawing reconciled its PMI at all, not
+        # even to say it had not (#1563). `source` is the caller naming the STEP the solid was
+        # read from; a generated script already opens exactly that path in its own `part =
+        # import_step(...)` line, so the emitter can state it. It is the caller's claim, not a
+        # proof the bytes produced this solid, so `pmi_source` records name and digest and the
+        # stage summary reports them rather than leaving the link assumed.
+        pmi_source = None if isinstance(step_file, Shape) else step_file
+        if pmi_source is None and source is not None:
+            pmi_source = source
+        if pmi_source is not None:
             from draftwright.pmi import PmiExtractionReport, extract_pmi_report
 
             try:
-                pmi_report = extract_pmi_report(step_file, frame=recognition_frame)
+                pmi_report = extract_pmi_report(pmi_source, frame=recognition_frame)
                 if pmi_mode != "off":
                     pmi_records = list(pmi_report.records)
             except Exception as exc:

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/builder.py

@@ -75,7 +75,6 @@ from draftwright.linting.coverage import lint_axial_coverage
 from draftwright.model import (
     Datum,
     Feature,
-    GrooveFeature,
     PartModel,
     StepFeature,
     build_pmi_features,
@@ -461,9 +460,7 @@ def _check_dimension_sources(model: PartModel) -> None:
 def _detect_part_model_analysis(part, *, pmi="off") -> tuple[PartModel, Analysis]:
     """Return one detected model together with the exact analysis run that produced it."""
 
-    a = _analyse(
-        part, title="", number="", tolerance="ISO 2768-m", drawn_by="", out="model", pmi=pmi
-    )
+    a = _analyse(part, title="", number="", tolerance=None, drawn_by="", out="model", pmi=pmi)
     # `_analyse` already detected and stored the model, so calling `build_model(a)`
     # unconditionally re-ran every detector `build_part_model` doesn't take by injection —
     # the #602 duplicate-detection bug, fixed in `_assemble` but never here. It went unnoticed
@@ -567,62 +564,13 @@ def _assemble(
         # measurements actually reach the page is settled downstream and reported by lint
         # (`axial_length_missing`). Guard on the tiling condition rather than a classifier
         # proxy (is_rotational / prof both have blind spots).
-        z_steps = [f for f in pm.features if isinstance(f, StepFeature) and f.frame.axis == "z"]
-        # The global-envelope check is meaningful only in its legacy single-solid domain;
-        # caller-owned group strings cannot turn one solid into several physical bodies.
-        # Multiple solids can be parallel, axially disjoint, or accompanied by unrelated
-        # compound members, so their steps need not tile the compound bbox (#1357).
-        owns_global_envelope = any(feature.kind == "envelope" for feature in pm.features)
-        if (
-            z_steps
-            and len(a.part.solids()) == 1
-            and (pm.orientation == "z" or owns_global_envelope)
-        ):
-            tol = 1e-3 * max(a.z_size, 1.0)  # small absolute float epsilon, floored
-            # Tiling means the segments run end to end — a single reach to each end isn't
-            # enough, since an interior gap is a stretch of part no declared step describes.
-            # Walk the spans low→high, extending coverage.
-            # A GROOVE counts as one of those segments (#953): it is machined INTO the turned
-            # profile, so a shaft that has one is still a turned profile, which is the only
-            # thing this guard is asking. Without it the emitted script for any grooved shaft
-            # RAISED — the detector produces exactly this model (step, groove, step) and the
-            # direct build draws it, so the engine rejected its own detector's output the
-            # moment that output was declared rather than detected. Grooves are the only
-            # detected feature that splits the chain: a chamfered or filleted shoulder leaves
-            # the two step spans meeting (checked), and a bore or cross-hole carves no axial
-            # interval. #631's own repro still raises.
-            # What this does NOT do is verify the declaration against the solid, and it never
-            # did: `.step(diameter=20, length=48, at=…)` fabricating one full-extent segment
-            # already defeats it on its own, groove or no groove (checked). Declared spans are
-            # the author's statement of intent, which ADR 4 (was 0011) takes at face value rather than
-            # re-deriving, so this catches the honest mistake #631 reported — declaring the
-            # boss you can see and getting a worse drawing — not a fabricated coverage claim.
-            # Hardening it into a real verb-domain check is #956.
-            # NOT claimed here: that the resulting drawing dimensions the height. On this very
-            # fixture the step chain drops at placement (crowded shoulders) and the height,
-            # suppressed at compile time on the premise the chain conveys it, is then conveyed
-            # by nothing — identically on the detected path. That is a real defect, tracked
-            # separately (#955); raising here would not fix it, only hide it from one of the
-            # two front doors.
-            spans = sorted(
-                [(min(p0[2], p1[2]), max(p0[2], p1[2])) for f in z_steps for (p0, p1) in [f.span]]
-                + [
-                    (f.frame.origin[2] - f.width / 2, f.frame.origin[2] + f.width / 2)
-                    for f in pm.features
-                    if isinstance(f, GrooveFeature) and f.frame.axis == "z"
-                ]
-            )
-            covered = a.bb.min.Z
-            for lo, hi in spans:
-                if lo <= covered + tol:
-                    covered = max(covered, hi)
-            if spans[0][0] > a.bb.min.Z + tol or covered < a.bb.max.Z - tol:
-                raise ValueError(
-                    "step() declares a segment of a turned profile, but the declared steps "
-                    "don't span this part's full height — it is not a turned (rotational) "
-                    "body. For a boss (an external cylinder on a prismatic part) use .boss() "
-                    "— it renders its own ø and height."
-                )
+        # The z-turned span check that used to RAISE here now reports from
+        # `linting.coverage.lint_turned_profile_span` instead (#1132). Raising made
+        # `generate_sheet_script` return nothing at all for a part whose recognised
+        # profile does not tile, and an entry point that produces no script and no
+        # drawing is the one failure a consumer cannot route around. The check itself is
+        # unchanged in substance; only its severity and its home moved, and the annotate
+        # pass's `reset_issues()` is why it cannot be recorded from here.
         # PMI (STEP AP242) is likewise detection-sourced, so a declared / emitted-script model
         # carries none. When PMI annotation is on, synthesise the same imported drafting
         # annotations detection would (render_pmi reads them off the model, gated on a.pmi_mode)
@@ -1175,7 +1123,7 @@ def _build_drawing_once(
     out: str | None = None,
     title: str | None = None,
     number: str = "DWG-001",
-    tolerance: str = "ISO 2768-m",
+    tolerance: str | None = None,
     drawn_by: str = "",
     scale: float | None = None,
     page: str | tuple | None = None,
@@ -1211,6 +1159,12 @@ def _build_drawing_once(
     _required_tables=(),
     _select_automatic_views: bool = False,
     _document_input=None,
+    *,
+    #: The STEP document the geometry came from, when it is not `step_file` itself
+    #: (#1563). Keyword-only: inserting it among the positional parameters would shift
+    #: every later binding, which `test_existing_positional_arguments_keep_their_bindings`
+    #: exists to catch — and did.
+    source: str | Path | None = None,
 ) -> Drawing:
     """Build a customisable 4-view :class:`Drawing` without exporting it.
 
@@ -1326,6 +1280,7 @@ def _build_drawing_once(
             scale=scale,
             page=page,
             pmi=pmi,
+            source=source,
             model=model,
             decorations=decorations,
             authored=authored,
@@ -1881,7 +1836,7 @@ def build_drawing(
     out: str | None = None,
     title: str | None = None,
     number: str = "DWG-001",
-    tolerance: str = "ISO 2768-m",
+    tolerance: str | None = None,
     drawn_by: str = "",
     scale: float | None = None,
     page: str | tuple | None = None,
@@ -1915,6 +1870,11 @@ def build_drawing(
     _document_input=None,
     *,
     projection_symbol: bool = True,
+    #: The STEP document the geometry came from, when it is not `step_file` itself
+    #: (#1563). Keyword-only: inserting it among the positional parameters would shift
+    #: every later binding, which `test_existing_positional_arguments_keep_their_bindings`
+    #: exists to catch — and did.
+    source: str | Path | None = None,
 ) -> Drawing:
     """Build a drawing, protecting required annotations under an explicit scale.
 
@@ -1954,6 +1914,7 @@ def build_drawing(
         auto_dims=auto_dims,
         detail_view=detail_view,
         pmi=pmi,
+        source=source,
         repair=repair,
         assembly=assembly,
         model=model,
@@ -2839,7 +2800,7 @@ def make_drawing(
     out: str | None = None,
     title: str | None = None,
     number: str = "DWG-001",
-    tolerance: str = "ISO 2768-m",
+    tolerance: str | None = None,
     drawn_by: str = "",
     scale: float | None = None,
     page: str | tuple | None = None,
@@ -2861,6 +2822,11 @@ def make_drawing(
     text_orientation: str = "aligned",
     *,
     projection_symbol: bool = True,
+    #: The STEP document the geometry came from, when it is not `step_file` itself
+    #: (#1563). Keyword-only: inserting it among the positional parameters would shift
+    #: every later binding, which `test_existing_positional_arguments_keep_their_bindings`
+    #: exists to catch — and did.
+    source: str | Path | None = None,
 ) -> tuple[str, str]:
     """Generate a 4-view technical drawing from a STEP file or build123d object.
 
@@ -2871,7 +2837,10 @@ def make_drawing(
             when a build123d object is passed).
         title: Part title for the title block (default: stem uppercased).
         number: Drawing number (e.g. ``"DWG-042"``).
-        tolerance: General tolerance string (e.g. ``"ISO 2768-m"``).
+        tolerance: General tolerance string (e.g. ``"ISO 2768-m"``). ``None`` (the
+            default) states none: the title block says the tolerance is unspecified
+            rather than inventing a manufacturing requirement the source never
+            carried (#1157). ``""`` requests a blank cell.
         drawn_by: Designer name for the title block.
         scale: Drawing-scale override (e.g. ``5`` for 5:1, ``0.5`` for 1:2).
             Default: chosen automatically by :func:`choose_scale`.
@@ -2918,6 +2887,7 @@ def make_drawing(
         auto_dims=auto_dims,
         detail_view=detail_view,
         pmi=pmi,
+        source=source,
         assembly=assembly,
         material=material,
         date=date,

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/cli.py

@@ -159,7 +159,10 @@ def main(
     out: str | None = typer.Option(None, help="Output prefix (default: input stem)"),
     title: str | None = typer.Option(None, help="Part title for title block"),
     number: str = typer.Option("DWG-001", help="Drawing number"),
-    tolerance: str = typer.Option("ISO 2768-m", help="General tolerance"),
+    tolerance: str | None = typer.Option(
+        None,
+        help="General tolerance (e.g. 'ISO 2768-m'); omitted, the title block says UNSPECIFIED",
+    ),
     drawn_by: str = typer.Option("", "--drawn-by", help="Designer name"),
     material: str = typer.Option("", help="Material for the title block"),
     date: str = typer.Option("", help="Date for the title block"),

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/drawing.py

@@ -125,6 +125,8 @@ from draftwright.linting import (
     lint_pmi_ignored,
     lint_pmi_lowering,
     lint_pmi_rendering,
+    lint_pmi_source_unknown,
+    lint_pmi_unreconciled,
     lint_pocket_coverage,
     lint_pocket_pattern_coverage,
     lint_polygonal_boss_coverage,
@@ -136,6 +138,7 @@ from draftwright.linting import (
     lint_round_bottom_blind_slot_coverage,
     lint_slot_coverage,
     lint_through_step_coverage,
+    lint_turned_profile_span,
     pmi_stage_summary,
 )
 from draftwright.linting.angular import lint_angular_supports, lint_profile_angle_coverage
@@ -210,6 +213,12 @@ _GEOMETRY_AWARE_CODES = frozenset(
         "unrecognised_defining_geometry",
         "pmi_not_lowered",
         "pmi_not_rendered",
+        # Registered here for the same reason as the two above: an unverified or
+        # fabricated AP242 claim is a statement about the geometry, not about layout
+        # (#1563). Leaving them out would let a drawing carrying either report
+        # `geometry_issues: 0`, which is the shape of defect this register exists for.
+        "pmi_unreconciled",
+        "pmi_source_unknown",
         # These REPLACE `pmi_not_rendered` for a record that produced no annotation (#1177);
         # the content is equally missing, so the count must not fall just because the
         # reason improved. `authored_dim_degenerate` suppressed that error without
@@ -219,6 +228,10 @@ _GEOMETRY_AWARE_CODES = frozenset(
         "authored_dim_degenerate",
         "authored_dim_source_unresolved",
         "axial_length_missing",
+        # A turned profile that leaves part of the body undescribed (#1132). Registered
+        # here for the same reason as `axial_length_missing` beside it: the shortfall is
+        # about the part, not about where an annotation landed.
+        "turned_profile_not_spanned",
         "flat_requirement_suppressed",
         "flat_requirement_missing",
         "flat_requirement_unverifiable",
@@ -4458,6 +4471,23 @@ class Drawing:
                     cyls,
                     recognition=recognition,
                 )
+                # Declared-vs-geometry in the axial direction (#1132): a z-turned profile that
+                # leaves part of the body undescribed. Gated with the reconciliation check
+                # above because both are only meaningful for a caller-declared model — the
+                # detection path is NOT immune — it is scoped this way for a different reason.
+                #
+                # Measured on CADGenBench 132: a plain `build_drawing(<step file>)` detects
+                # z-steps covering 0..113 of a 140 mm body and reports nothing here, while this
+                # predicate applied to that same detected model returns the warning. Same part,
+                # same shortfall, one door silent. It is scoped to the declared model because
+                # that is where the raise it replaces lived, so this change alters no automatic
+                # drawing. Widening it is a real question and a separate one.
+                issues += lint_turned_profile_span(
+                    features,
+                    (self._analysis.bb.min.Z, self._analysis.bb.max.Z),
+                    orientation=getattr(self._part_model, "orientation", None),
+                    single_solid=len(self._analysis.part.solids()) == 1,
+                )
         if physical and self._analysis is not None:
             issues += lint_pmi_ignored(
                 self._analysis.pmi_report,
@@ -4477,6 +4507,20 @@ class Drawing:
                 self._analysis.pmi_mode,
                 decorations=getattr(self._part_model, "decorations", {}),
             )
+            # The two directions the four checks above cannot cover, because each of them
+            # reasons FROM the census: content whose census is missing entirely, and content
+            # claiming an identity the census does not contain (#1563). Both take the report
+            # itself rather than the mode — an absent census is the condition, not a setting.
+            issues += lint_pmi_unreconciled(
+                self._analysis.pmi_report,
+                getattr(self._part_model, "features", ()),
+                decorations=getattr(self._part_model, "decorations", {}),
+            )
+            issues += lint_pmi_source_unknown(
+                self._analysis.pmi_report,
+                getattr(self._part_model, "features", ()),
+                decorations=getattr(self._part_model, "decorations", {}),
+            )
         issues += list(self._registry.issues)
         # Attach a ready-to-paste fix snippet where one is computable (#29).
         # str | None — None when no concrete repair can be inferred.

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/inspection_contract.py

@@ -17,7 +17,7 @@ from quiddity.inspection import inspection_api_manifest
 CONSUMER_INSPECTION_FORMAT = "draftwright-inspection-api"
 CONSUMER_INSPECTION_FORMAT_VERSION = 1
 SUPPORTED_INSPECTION_API_MAJOR = 1
-SUPPORTED_RECOGNISER_VERSION = "0.2.6"
+SUPPORTED_RECOGNISER_VERSION = "0.2.8"
 _DISTRIBUTION = "quiddity"
 _PROVIDER_FORMAT = "quiddity-inspection-api"
 _NAMESPACE = "quiddity.inspection"

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/linting/__init__.py

@@ -31,6 +31,7 @@ from draftwright.linting.coverage import (
     lint_location_coverage,
     lint_principal_profile_coverage,
     lint_prismatic_coverage,
+    lint_turned_profile_span,
 )
 from draftwright.linting.evidence import (
     ClaimOutcome,
@@ -53,6 +54,8 @@ from draftwright.linting.pmi_coverage import (
     lint_pmi_ignored,
     lint_pmi_lowering,
     lint_pmi_rendering,
+    lint_pmi_source_unknown,
+    lint_pmi_unreconciled,
     pmi_stage_summary,
 )
 from draftwright.linting.pocket_coverage import lint_pocket_coverage
@@ -97,6 +100,7 @@ __all__ = [
     "lint_circular_blind_step_coverage",
     "lint_chamfer_coverage",
     "lint_declaration_reconciliation",
+    "lint_turned_profile_span",
     "lint_drawing",
     "lint_feature_coverage",
     "lint_flat_coverage",
@@ -114,6 +118,8 @@ __all__ = [
     "lint_pmi_extraction",
     "lint_pmi_lowering",
     "lint_pmi_rendering",
+    "lint_pmi_source_unknown",
+    "lint_pmi_unreconciled",
     "pmi_stage_summary",
     "lint_principal_profile_coverage",
     "lint_profiled_bore_coverage",

{draftwright-0.4.27 → draftwright-0.4.28}/src/draftwright/linting/coverage.py

@@ -2306,6 +2306,117 @@ def lint_boss_height_coverage(
     ]
 
 
+def lint_turned_profile_span(features, z_extent, *, orientation, single_solid) -> list:
+    """Flag a z-turned profile whose declared steps leave part of the body undescribed (#1132).
+
+    This began as #631's verb-misuse diagnostic, raised from ``builder._assemble``: a caller
+    reaching for ``.step()`` on a boss — an external cylinder on a prismatic part — declared a
+    turned segment, which flipped the height ladder into turned-suppression and silently
+    dropped the overall height. Raising made that visible.
+
+    Warning is sufficient because the symptom cannot co-occur with it:
+    ``model/compiled.py::_compile_overall_height`` retains the overall-height rung whenever
+    ``_step_chain_covers_extent(...)`` is false — the same tiling question, asked independently
+    of the approved plan. Measured, ``dim_height`` is drawn on every part that trips this check
+    and on none that declares its profile fully. So #631's dropped height is not what a warning
+    now permits; it was already prevented elsewhere, and raising was belt and braces.
+
+    It stopped being only a hand-authoring mistake. ``generate_sheet_script`` settles its layout
+    through the same path, so a part whose *recognised* profile does not tile produced no script
+    and no drawing — and an entry point that returns nothing is the one failure a consumer
+    cannot route around. A generated script is indistinguishable from hand-written code when it
+    is re-run, so there is no provenance to branch on: the choice is raise for both or report for
+    both, and reporting is what lets the drawing exist and say what it does not cover.
+
+    The two CADGenBench fixtures that still reach this carry profiles that are correct and
+    merely partial — a threaded region on one, a 27 mm stretch on the other — since the false
+    step sets behind the rest were fixed upstream (quiddity#586, #587).
+
+    Reported here rather than recorded during assembly because the annotate pass calls
+    ``reset_issues()`` to keep a repack from duplicating drop records, which discards anything
+    the builder recorded first. ``features`` is read duck-typed, like every check in this module.
+    """
+    if not single_solid:
+        return []
+
+    def _axis(feature) -> str | None:
+        # Duck-typed like the rest of this module, and defensive: a caller-supplied model may
+        # carry a feature with no frame at all, and a lint check must not raise on one.
+        return getattr(getattr(feature, "frame", None), "axis", None)
+
+    def _groove_band(feature) -> tuple[float, float] | None:
+        # The same defensiveness as `_axis`, which a first pass applied to the step branch and
+        # not to this one — leaving a groove with no `width` or no `origin` raising two lines
+        # below the guard that was added. A lint check that crashes on a malformed model
+        # reinstates the failure #1132 exists to remove.
+        origin = getattr(getattr(feature, "frame", None), "origin", None)
+        width = getattr(feature, "width", None)
+        if origin is None or width is None or len(origin) < 3:
+            return None
+        return (origin[2] - width / 2, origin[2] + width / 2)
+
+    # A step with no usable span is skipped rather than guessed at: without endpoints its
+    # extent is unknown, and inventing one would be worse than the silence. If that leaves no
+    # steps at all the function returns below, reporting nothing — the honest outcome when
+    # coverage is uncomputable, and the reason this filter is explicit rather than incidental.
+    steps = [
+        f
+        for f in features
+        if getattr(f, "kind", None) == "step" and _axis(f) == "z" and getattr(f, "span", None)
+    ]
+    if not steps:
+        return []
+    if orientation != "z" and not any(getattr(f, "kind", None) == "envelope" for f in features):
+        return []
+    lo_z, hi_z = z_extent
+    tol = 1e-3 * max(hi_z - lo_z, 1.0)
+    spans = sorted(
+        [(min(a[2], b[2]), max(a[2], b[2])) for f in steps for (a, b) in [f.span]]
+        + [
+            band
+            for f in features
+            if getattr(f, "kind", None) == "groove" and _axis(f) == "z"
+            for band in [_groove_band(f)]
+            if band is not None
+        ]
+    )
+    # Merge the spans, then report EVERY uncovered interval. A forward walk that stops at the
+    # first gap misreports the rest: on CADGenBench 109 it stopped at 343.13 and named
+    # `343.13..420`, while a declared step covers `366.82..420` — the real shortfall is 23.69 mm,
+    # not 76.87. A diagnostic that overstates the gap is one nobody can act on.
+    merged: list[list[float]] = []
+    for lo, hi in spans:
+        if merged and lo <= merged[-1][1] + tol:
+            merged[-1][1] = max(merged[-1][1], hi)
+        else:
+            merged.append([lo, hi])
+    uncovered = []
+    cursor = lo_z
+    for lo, hi in merged:
+        if lo > cursor + tol:
+            uncovered.append((cursor, lo))
+        cursor = max(cursor, hi)
+    if cursor < hi_z - tol:
+        uncovered.append((cursor, hi_z))
+    if not uncovered:
+        return []
+    where = ", ".join(f"{lo:g}..{hi:g}" for lo, hi in uncovered)
+    total = sum(hi - lo for lo, hi in uncovered)
+    return [
+        LintIssue(
+            severity="warning",
+            code="turned_profile_not_spanned",
+            message=(
+                f"step() declares a segment of a turned profile, but the declared steps leave "
+                f"{total:g} mm of this part's height undescribed ({where}). If these are bosses "
+                "— external cylinders on a prismatic part — .boss() renders each with its own ø "
+                "and height; if the profile is genuinely partial, the uncovered stretch is "
+                "dimensioned by nothing."
+            ),
+        )
+    ]
+
+
 def lint_declaration_reconciliation(features, cyls, *, recognition=None) -> list:
     """Flag a *declared* cylindrical feature with no matching geometry in the part (#487).