dls-dodal 1.29.2__tar.gz → 1.29.4__tar.gz

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: dls-dodal
-Version: 1.29.2
+Version: 1.29.4
 Summary: Ophyd devices and other utils that could be used across DLS beamlines
 Author-email: Dominic Oram <dominic.oram@diamond.ac.uk>
 License:                                  Apache License
@@ -215,12 +215,12 @@ Description-Content-Type: text/x-rst
 License-File: LICENSE
 Requires-Dist: click
 Requires-Dist: ophyd
-Requires-Dist: ophyd-async>=0.3.1
+Requires-Dist: ophyd-async<0.4.0
 Requires-Dist: bluesky
 Requires-Dist: pyepics
 Requires-Dist: dataclasses-json
 Requires-Dist: pillow
-Requires-Dist: zocalo
+Requires-Dist: zocalo>=0.32.0
 Requires-Dist: requests
 Requires-Dist: graypy
 Requires-Dist: pydantic

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/pyproject.toml

@@ -14,12 +14,12 @@ description = "Ophyd devices and other utils that could be used across DLS beaml
 dependencies = [
     "click",
     "ophyd",
-    "ophyd-async>=0.3.1",
+    "ophyd-async<0.4.0",      # Need to pin to <0.4.0 as this requires pydantic>2.0 see https://github.com/DiamondLightSource/dodal/issues/679
     "bluesky",
     "pyepics",
     "dataclasses-json",
     "pillow",
-    "zocalo",
+    "zocalo>=0.32.0",
     "requests",
     "graypy",
     "pydantic",

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dls_dodal.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: dls-dodal
-Version: 1.29.2
+Version: 1.29.4
 Summary: Ophyd devices and other utils that could be used across DLS beamlines
 Author-email: Dominic Oram <dominic.oram@diamond.ac.uk>
 License:                                  Apache License
@@ -215,12 +215,12 @@ Description-Content-Type: text/x-rst
 License-File: LICENSE
 Requires-Dist: click
 Requires-Dist: ophyd
-Requires-Dist: ophyd-async>=0.3.1
+Requires-Dist: ophyd-async<0.4.0
 Requires-Dist: bluesky
 Requires-Dist: pyepics
 Requires-Dist: dataclasses-json
 Requires-Dist: pillow
-Requires-Dist: zocalo
+Requires-Dist: zocalo>=0.32.0
 Requires-Dist: requests
 Requires-Dist: graypy
 Requires-Dist: pydantic

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dls_dodal.egg-info/SOURCES.txt

@@ -149,6 +149,7 @@ src/dodal/devices/i24/I24_detector_motion.py
 src/dodal/devices/i24/__init__.py
 src/dodal/devices/i24/aperture.py
 src/dodal/devices/i24/beamstop.py
+src/dodal/devices/i24/dcm.py
 src/dodal/devices/i24/dual_backlight.py
 src/dodal/devices/i24/i24_vgonio.py
 src/dodal/devices/i24/pmac.py
@@ -265,7 +266,6 @@ tests/devices/unit_tests/i24/test_pmac.py
 tests/devices/unit_tests/oav/__init__.py
 tests/devices/unit_tests/oav/test_oav.py
 tests/devices/unit_tests/oav/test_oav_parameters.py
-tests/devices/unit_tests/oav/test_oav_utils.py
 tests/devices/unit_tests/oav/image_recognition/test_pin_tip_detect.py
 tests/devices/unit_tests/oav/image_recognition/test_pin_tip_detect_utils.py
 tests/devices/unit_tests/test_daq_configuration/domain/beamlineParameters

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dls_dodal.egg-info/requires.txt

@@ -1,11 +1,11 @@
 click
 ophyd
-ophyd-async>=0.3.1
+ophyd-async<0.4.0
 bluesky
 pyepics
 dataclasses-json
 pillow
-zocalo
+zocalo>=0.32.0
 requests
 graypy
 pydantic

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/_version.py

@@ -12,5 +12,5 @@ __version__: str
 __version_tuple__: VERSION_TUPLE
 version_tuple: VERSION_TUPLE
 
-__version__ = version = '1.29.2'
-__version_tuple__ = version_tuple = (1, 29, 2)
+__version__ = version = '1.29.4'
+__version_tuple__ = version_tuple = (1, 29, 4)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/beamlines/i24.py

@@ -5,6 +5,7 @@ from dodal.devices.eiger import EigerDetector
 from dodal.devices.hutch_shutter import HutchShutter
 from dodal.devices.i24.aperture import Aperture
 from dodal.devices.i24.beamstop import Beamstop
+from dodal.devices.i24.dcm import DCM
 from dodal.devices.i24.dual_backlight import DualBacklight
 from dodal.devices.i24.I24_detector_motion import DetectorMotion
 from dodal.devices.i24.i24_vgonio import VGonio
@@ -82,6 +83,19 @@ def detector_motion(
     )
 
 
+def dcm(wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False) -> DCM:
+    """Get the i24 DCM device, instantiate it if it hasn't already been.
+    If this is called when already instantiated in i24, it will return the existing object.
+    """
+    return device_instantiation(
+        device_factory=DCM,
+        name="dcm",
+        prefix="",
+        wait=wait_for_connection,
+        fake=fake_with_ophyd_sim,
+    )
+
+
 @skip_device(lambda: BL == "s24")
 def eiger(
     wait_for_connection: bool = True,

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/areadetector/plugins/MJPG.py

@@ -8,7 +8,6 @@ from ophyd import Component, Device, DeviceStatus, EpicsSignal, EpicsSignalRO, S
 from PIL import Image, ImageDraw
 
 from dodal.devices.oav.oav_parameters import OAVConfigParams
-from dodal.devices.oav.utils import save_thumbnail
 from dodal.log import LOGGER
 
 
@@ -50,9 +49,6 @@ class MJPG(Device, ABC):
 
         LOGGER.info(f"Saving image to {path}")
         image.save(path)
-
-        save_thumbnail(Path(path), image)
-
         self.last_saved_path.put(path)
 
     def trigger(self):

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/attenuator.py

@@ -48,7 +48,7 @@ class Attenuator(StandardReadable, Movable):
         super().__init__(name)
 
     @AsyncStatus.wrap
-    async def set(self, transmission: float):
+    async def set(self, value: float):
         """Set the transmission to the fractional (0-1) value given.
 
         The attenuator IOC will then insert filters to reach the desired transmission for
@@ -58,8 +58,8 @@ class Attenuator(StandardReadable, Movable):
 
         LOGGER.debug("Using current energy ")
         await self._use_current_energy.trigger()
-        LOGGER.info(f"Setting desired transmission to {transmission}")
-        await self._desired_transmission.set(transmission)
+        LOGGER.info(f"Setting desired transmission to {value}")
+        await self._desired_transmission.set(value)
         LOGGER.debug("Sending change filter command")
         await self._change.trigger()
 
@@ -67,7 +67,7 @@ class Attenuator(StandardReadable, Movable):
             *[
                 wait_for_value(
                     self._filters_in_position[i],
-                    await self._calculated_filter_states[i].get_value(),
+                    bool(await self._calculated_filter_states[i].get_value()),
                     None,
                 )
                 for i in range(16)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/detector/detector.py

@@ -54,13 +54,14 @@ class DetectorParams(BaseModel):
             DetectorSizeConstants: lambda d: d.det_type_string,
         }
 
-    @root_validator(pre=True, skip_on_failure=True)  # type: ignore # should be replaced with model_validator once move to pydantic 2 is complete
+    # should be replaced with model_validator once move to pydantic 2 is complete
+    @root_validator(pre=True)
     def create_beamxy_and_runnumber(cls, values: dict[str, Any]) -> dict[str, Any]:
         values["beam_xy_converter"] = DetectorDistanceToBeamXYConverter(
             values["det_dist_to_beam_converter_path"]
         )
         if values.get("run_number") is None:
-            values["run_number"] = get_run_number(values["directory"])
+            values["run_number"] = get_run_number(values["directory"], values["prefix"])
         return values
 
     @validator("detector_size_constants", pre=True)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/eiger.py

@@ -2,7 +2,7 @@ from enum import Enum
 
 from ophyd import Component, Device, EpicsSignalRO, Signal
 from ophyd.areadetector.cam import EigerDetectorCam
-from ophyd.status import AndStatus, Status, SubscriptionStatus
+from ophyd.status import AndStatus, Status, StatusBase
 
 from dodal.devices.detector import DetectorParams, TriggerMode
 from dodal.devices.eiger_odin import EigerOdin
@@ -27,6 +27,7 @@ class InternalEigerTriggerMode(Enum):
 class EigerDetector(Device):
     class ArmingSignal(Signal):
         def set(self, value, *, timeout=None, settle_time=None, **kwargs):
+            assert isinstance(self.parent, EigerDetector)
             return self.parent.async_stage()
 
     do_arm = Component(ArmingSignal)
@@ -38,10 +39,12 @@ class EigerDetector(Device):
 
     STALE_PARAMS_TIMEOUT = 60
     GENERAL_STATUS_TIMEOUT = 10
+    # Long timeout for meta file to compensate for filesystem issues
+    META_FILE_READY_TIMEOUT = 30
     ALL_FRAMES_TIMEOUT = 120
     ARMING_TIMEOUT = 60
 
-    filewriters_finished: SubscriptionStatus
+    filewriters_finished: StatusBase
 
     detector_params: DetectorParams | None = None
 
@@ -155,7 +158,7 @@ class EigerDetector(Device):
     def enable_roi_mode(self):
         return self.change_roi_mode(True)
 
-    def change_roi_mode(self, enable: bool) -> Status:
+    def change_roi_mode(self, enable: bool) -> StatusBase:
         assert self.detector_params is not None
         detector_dimensions = (
             self.detector_params.detector_size_constants.roi_size_pixels
@@ -206,7 +209,7 @@ class EigerDetector(Device):
         )
         return status
 
-    def set_odin_pvs(self) -> Status:
+    def set_odin_pvs(self) -> StatusBase:
         assert self.detector_params is not None
         file_prefix = self.detector_params.full_filename
         status = self.odin.file_writer.file_path.set(
@@ -264,7 +267,7 @@ class EigerDetector(Device):
             status.set_finished()
             return status
 
-    def set_num_triggers_and_captures(self) -> Status:
+    def set_num_triggers_and_captures(self) -> StatusBase:
         """Sets the number of triggers and the number of images for the Eiger to capture
         during the datacollection. The number of images is the number of images per
         trigger.
@@ -295,7 +298,7 @@ class EigerDetector(Device):
 
         return status
 
-    def _wait_for_odin_status(self) -> Status:
+    def _wait_for_odin_status(self) -> StatusBase:
         self.forward_bit_depth_to_filewriter()
         await_value(self.odin.meta.active, 1).wait(self.GENERAL_STATUS_TIMEOUT)
 
@@ -304,11 +307,11 @@ class EigerDetector(Device):
         )
         LOGGER.info("Eiger staging: awaiting odin metadata")
         status &= await_value(
-            self.odin.meta.ready, 1, timeout=self.GENERAL_STATUS_TIMEOUT
+            self.odin.meta.ready, 1, timeout=self.META_FILE_READY_TIMEOUT
         )
         return status
 
-    def _wait_fan_ready(self) -> Status:
+    def _wait_fan_ready(self) -> StatusBase:
         self.filewriters_finished = self.odin.create_finished_status()
         LOGGER.info("Eiger staging: awaiting odin fan ready")
         return await_value(self.odin.fan.ready, 1, self.GENERAL_STATUS_TIMEOUT)
@@ -332,6 +335,7 @@ class EigerDetector(Device):
 
     def do_arming_chain(self) -> Status:
         functions_to_do_arm = []
+        assert self.detector_params
         detector_params: DetectorParams = self.detector_params
         if detector_params.use_roi_mode:
             functions_to_do_arm.append(self.enable_roi_mode)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/eiger_odin.py

@@ -3,7 +3,7 @@ from typing import List, Tuple
 from ophyd import Component, Device, EpicsSignal, EpicsSignalRO, EpicsSignalWithRBV
 from ophyd.areadetector.plugins import HDF5Plugin_V22
 from ophyd.sim import NullStatus
-from ophyd.status import Status, SubscriptionStatus
+from ophyd.status import StatusBase
 
 from dodal.devices.status import await_value
 
@@ -120,7 +120,7 @@ class EigerOdin(Device):
     meta = Component(OdinMetaListener, "OD:META:")
     nodes = Component(OdinNodesStatus, "")
 
-    def create_finished_status(self) -> SubscriptionStatus:
+    def create_finished_status(self) -> StatusBase:
         writing_finished = await_value(self.meta.ready, 0)
         for node_pv in self.nodes.nodes:
             writing_finished &= await_value(node_pv.writing, 0)
@@ -157,7 +157,7 @@ class EigerOdin(Device):
 
         return not errors, "\n".join(errors)
 
-    def stop(self) -> Status:
+    def stop(self) -> StatusBase:
         """Stop odin manually"""
         status = self.file_writer.capture.set(0)
         status &= self.meta.stop_writing.set(1)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/focusing_mirror.py

@@ -1,12 +1,16 @@
-from enum import Enum, IntEnum
-from typing import Any
-
-from ophyd import Component, Device, EpicsSignal
-from ophyd.status import Status, StatusBase
-from ophyd_async.core import StandardReadable
+from enum import Enum
+
+from ophyd_async.core import (
+    AsyncStatus,
+    Device,
+    DeviceVector,
+    StandardReadable,
+    observe_value,
+)
 from ophyd_async.core.signal import soft_signal_r_and_setter
 from ophyd_async.epics.motion import Motor
 from ophyd_async.epics.signal import (
+    epics_signal_r,
     epics_signal_rw,
     epics_signal_x,
 )
@@ -32,11 +36,11 @@ class MirrorStripe(str, Enum):
     PLATINUM = "Platinum"
 
 
-class MirrorVoltageDemand(IntEnum):
-    N_A = 0
-    OK = 1
-    FAIL = 2
-    SLEW = 3
+class MirrorVoltageDemand(str, Enum):
+    N_A = "N/A"
+    OK = "OK"
+    FAIL = "FAIL"
+    SLEW = "SLEW"
 
 
 class MirrorVoltageDevice(Device):
@@ -44,14 +48,16 @@ class MirrorVoltageDevice(Device):
     the demanded voltage setpoint is accepted, without blocking the caller as this process can take significant time.
     """
 
-    _actual_v: EpicsSignal = Component(EpicsSignal, "R")
-    _setpoint_v: EpicsSignal = Component(EpicsSignal, "D")
-    _demand_accepted: EpicsSignal = Component(EpicsSignal, "DSEV")
+    def __init__(self, name: str = "", prefix: str = ""):
+        self._actual_v = epics_signal_r(int, prefix + "R")
+        self._setpoint_v = epics_signal_rw(int, prefix + "D")
+        self._demand_accepted = epics_signal_r(MirrorVoltageDemand, prefix + "DSEV")
+        super().__init__(name=name)
 
-    def set(self, value, *args, **kwargs) -> StatusBase:
+    @AsyncStatus.wrap
+    async def set(self, value, *args, **kwargs):
         """Combine the following operations into a single set:
         1. apply the value to the setpoint PV
-        2. Return to the caller with a Status future
         3. Wait until demand is accepted
         4. When either demand is accepted or DEFAULT_SETTLE_TIME expires, signal the result on the Status
         """
@@ -59,66 +65,60 @@ class MirrorVoltageDevice(Device):
         setpoint_v = self._setpoint_v
         demand_accepted = self._demand_accepted
 
-        if demand_accepted.get() != MirrorVoltageDemand.OK:
+        if await demand_accepted.get_value() != MirrorVoltageDemand.OK:
             raise AssertionError(
                 f"Attempted to set {setpoint_v.name} when demand is not accepted."
             )
 
-        if setpoint_v.get() == value:
+        if await setpoint_v.get_value() == value:
             LOGGER.debug(f"{setpoint_v.name} already at {value} - skipping set")
-            return Status(success=True, done=True)
+            return
 
         LOGGER.debug(f"setting {setpoint_v.name} to {value}")
-        demand_accepted_status = Status(self, DEFAULT_SETTLE_TIME_S)
-
-        subscription: dict[str, Any] = {"handle": None}
 
-        def demand_check_callback(old_value, value, **kwargs):
-            LOGGER.debug(f"Got event old={old_value} new={value} for {setpoint_v.name}")
-            if old_value != MirrorVoltageDemand.OK and value == MirrorVoltageDemand.OK:
-                LOGGER.debug(f"Demand accepted for {setpoint_v.name}")
-                subs_handle = subscription.pop("handle", None)
-                if subs_handle is None:
-                    raise AssertionError("Demand accepted before set attempted")
-                demand_accepted.unsubscribe(subs_handle)
-
-                demand_accepted_status.set_finished()
-            # else timeout handled by parent demand_accepted_status
+        # Register an observer up front to ensure we don't miss events after we
+        # perform the set
+        demand_accepted_iterator = observe_value(
+            demand_accepted, timeout=DEFAULT_SETTLE_TIME_S
+        )
+        # discard the current value (OK) so we can await a subsequent change
+        await anext(demand_accepted_iterator)
+        await setpoint_v.set(value)
+
+        # The set should always change to SLEW regardless of whether we are
+        # already at the set point, then change back to OK/FAIL depending on
+        # success
+        accepted_value = await anext(demand_accepted_iterator)
+        assert accepted_value == MirrorVoltageDemand.SLEW
+        LOGGER.debug(
+            f"Demand not accepted for {setpoint_v.name}, waiting for acceptance..."
+        )
+        while MirrorVoltageDemand.SLEW == (
+            accepted_value := await anext(demand_accepted_iterator)
+        ):
+            pass
 
-        subscription["handle"] = demand_accepted.subscribe(demand_check_callback)
-        setpoint_status = setpoint_v.set(value)
-        status = setpoint_status & demand_accepted_status
-        return status
+        if accepted_value != MirrorVoltageDemand.OK:
+            raise AssertionError(
+                f"Voltage slew failed for {setpoint_v.name}, new state={accepted_value}"
+            )
 
 
-class VFMMirrorVoltages(Device):
-    def __init__(self, *args, daq_configuration_path: str, **kwargs):
-        super().__init__(*args, **kwargs)
+class VFMMirrorVoltages(StandardReadable):
+    def __init__(
+        self, name: str, prefix: str, *args, daq_configuration_path: str, **kwargs
+    ):
         self.voltage_lookup_table_path = (
             daq_configuration_path + "/json/mirrorFocus.json"
         )
-
-    _channel14_voltage_device = Component(MirrorVoltageDevice, "BM:V14")
-    _channel15_voltage_device = Component(MirrorVoltageDevice, "BM:V15")
-    _channel16_voltage_device = Component(MirrorVoltageDevice, "BM:V16")
-    _channel17_voltage_device = Component(MirrorVoltageDevice, "BM:V17")
-    _channel18_voltage_device = Component(MirrorVoltageDevice, "BM:V18")
-    _channel19_voltage_device = Component(MirrorVoltageDevice, "BM:V19")
-    _channel20_voltage_device = Component(MirrorVoltageDevice, "BM:V20")
-    _channel21_voltage_device = Component(MirrorVoltageDevice, "BM:V21")
-
-    @property
-    def voltage_channels(self) -> list[MirrorVoltageDevice]:
-        return [
-            self._channel14_voltage_device,
-            self._channel15_voltage_device,
-            self._channel16_voltage_device,
-            self._channel17_voltage_device,
-            self._channel18_voltage_device,
-            self._channel19_voltage_device,
-            self._channel20_voltage_device,
-            self._channel21_voltage_device,
-        ]
+        with self.add_children_as_readables():
+            self.voltage_channels = DeviceVector(
+                {
+                    i - 14: MirrorVoltageDevice(prefix=f"{prefix}BM:V{i}")
+                    for i in range(14, 22)
+                }
+            )
+        super().__init__(*args, name=name, **kwargs)
 
 
 class FocusingMirror(StandardReadable):

dls_dodal-1.29.4/src/dodal/devices/i24/dcm.py

@@ -0,0 +1,42 @@
+from ophyd_async.core import StandardReadable
+from ophyd_async.epics.motion import Motor
+from ophyd_async.epics.signal import epics_signal_r
+
+
+class DCM(StandardReadable):
+    """
+    A double crystal monocromator device, used to select the beam energy.
+    """
+
+    def __init__(self, prefix: str, name: str = "") -> None:
+        with self.add_children_as_readables():
+            # Motors
+            self.bragg_in_degrees = Motor(prefix + "-MO-DCM-01:BRAGG")
+            self.x_translation_in_mm = Motor(prefix + "-MO-DCM-01:X")
+            self.offset_in_mm = Motor(prefix + "-MO-DCM-01:OFFSET")
+            self.gap_in_mm = Motor(prefix + "-MO-DCM-01:GAP")
+            self.energy_in_kev = Motor(prefix + "-MO-DCM-01:ENERGY")
+            self.xtal1_roll = Motor(prefix + "-MO-DCM-01:XTAL1:ROLL")
+            self.xtal2_roll = Motor(prefix + "-MO-DCM-01:XTAL2:ROLL")
+            self.xtal2_pitch = Motor(prefix + "-MO-DCM-01:XTAL2:PITCH")
+
+            # Wavelength is calculated in epics from the energy
+            self.wavelength_in_a = epics_signal_r(float, prefix + "-MO-DCM-01:LAMBDA")
+
+            # Temperatures
+            self.xtal1_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-1")
+            self.xtal1_heater_temp = epics_signal_r(
+                float, prefix + "-DI-DCM-01:PT100-2"
+            )
+            self.xtal2_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-4")
+            self.xtal2_heater_temp = epics_signal_r(
+                float, prefix + "-DI-DCM-01:PT100-5"
+            )
+
+            self.roll_plate_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-3")
+            self.pitch_plate_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-6")
+            self.backplate_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-7")
+            self.b1_plate_temp = epics_signal_r(float, prefix + "-DI-DCM-01:PT100-7")
+            self.gap_temp = epics_signal_r(float, prefix + "-DI-DCM-01:TC-1")
+
+        super().__init__(name)

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/oav/oav_detector.py

@@ -46,6 +46,7 @@ class ZoomController(Device):
     sxst = Component(EpicsSignal, "MP:SELECT.SXST")
 
     def set_flatfield_on_zoom_level_one(self, value):
+        self.parent: "OAV"
         flat_applied = self.parent.proc.port_name.get()
         no_flat_applied = self.parent.cam.port_name.get()
         return self.parent.grid_snapshot.input_plugin.set(

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/oav/pin_image_recognition/__init__.py

@@ -50,11 +50,13 @@ class PinTipDetection(StandardReadable):
         self._prefix: str = prefix
         self._name = name
 
-        self.triggered_tip, _ = soft_signal_r_and_setter(Tip, name="triggered_tip")
-        self.triggered_top_edge, _ = soft_signal_r_and_setter(
+        self.triggered_tip, self._tip_setter = soft_signal_r_and_setter(
+            Tip, name="triggered_tip"
+        )
+        self.triggered_top_edge, self._top_edge_setter = soft_signal_r_and_setter(
             NDArray[np.uint32], name="triggered_top_edge"
         )
-        self.triggered_bottom_edge, _ = soft_signal_r_and_setter(
+        self.triggered_bottom_edge, self._bottom_edge_setter = soft_signal_r_and_setter(
             NDArray[np.uint32], name="triggered_bottom_edge"
         )
         self.array_data = epics_signal_r(NDArray[np.uint8], f"pva://{prefix}PVA:ARRAY")
@@ -85,14 +87,14 @@ class PinTipDetection(StandardReadable):
 
         super().__init__(name=name)
 
-    async def _set_triggered_values(self, results: SampleLocation):
+    def _set_triggered_values(self, results: SampleLocation):
         tip = (results.tip_x, results.tip_y)
         if tip == self.INVALID_POSITION:
             raise InvalidPinException
         else:
-            await self.triggered_tip._backend.put(tip)
-        await self.triggered_top_edge._backend.put(results.edge_top)
-        await self.triggered_bottom_edge._backend.put(results.edge_bottom)
+            self._tip_setter(tip)
+        self._top_edge_setter(results.edge_top)
+        self._bottom_edge_setter(results.edge_bottom)
 
     async def _get_tip_and_edge_data(
         self, array_data: NDArray[np.uint8]
@@ -150,7 +152,7 @@ class PinTipDetection(StandardReadable):
             async for value in observe_value(self.array_data):
                 try:
                     location = await self._get_tip_and_edge_data(value)
-                    await self._set_triggered_values(location)
+                    self._set_triggered_values(location)
                 except Exception as e:
                     LOGGER.warn(
                         f"Failed to detect pin-tip location, will retry with next image: {e}"
@@ -166,6 +168,6 @@ class PinTipDetection(StandardReadable):
             LOGGER.error(
                 f"No tip found in {await self.validity_timeout.get_value()} seconds."
             )
-            await self.triggered_tip._backend.put(self.INVALID_POSITION)
-            await self.triggered_bottom_edge._backend.put(np.array([]))
-            await self.triggered_top_edge._backend.put(np.array([]))
+            self._tip_setter(self.INVALID_POSITION)
+            self._bottom_edge_setter(np.array([]))
+            self._top_edge_setter(np.array([]))

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/oav/utils.py

@@ -1,17 +1,14 @@
 from enum import IntEnum
-from pathlib import Path
 from typing import Generator, Tuple
 
 import bluesky.plan_stubs as bps
 import numpy as np
 from bluesky.utils import Msg
-from PIL.Image import Image
 
 from dodal.devices.oav.oav_calculations import camera_coordinates_to_xyz
-from dodal.devices.oav.oav_parameters import OAVConfigParams
+from dodal.devices.oav.oav_detector import OAVConfigParams
 from dodal.devices.oav.pin_image_recognition import PinTipDetection
 from dodal.devices.smargon import Smargon
-from dodal.log import LOGGER
 
 Pixel = Tuple[int, int]
 
@@ -110,14 +107,3 @@ def wait_for_tip_to_be_found(
         raise PinNotFoundException(f"No pin found after {timeout} seconds")
 
     return found_tip  # type: ignore
-
-
-def save_thumbnail(full_file_path: Path, full_image: Image, new_height=192):
-    """Scales an image down to have the height specified in new_height and saves it
-    to the same location as the full image with a t appended to the filename"""
-    thumbnail_path = full_file_path.with_stem(full_file_path.stem + "t")
-    LOGGER.info(f"Saving thumbnail to {thumbnail_path}")
-    full_size = full_image.size
-    new_width = (new_height / full_size[1]) * full_size[0]
-    full_image.thumbnail((new_width, new_height))
-    full_image.save(thumbnail_path.as_posix())

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/robot.py

@@ -60,7 +60,8 @@ class BartRobot(StandardReadable, Movable):
         self.program_running = epics_signal_r(bool, prefix + "PROGRAM_RUNNING")
         self.program_name = epics_signal_r(str, prefix + "PROGRAM_NAME")
         self.error_str = epics_signal_r(str, prefix + "PRG_ERR_MSG")
-        self.error_code = epics_signal_r(int, prefix + "PRG_ERR_CODE")
+        # Change error_code to int type when https://github.com/bluesky/ophyd-async/issues/280 released
+        self.error_code = epics_signal_r(float, prefix + "PRG_ERR_CODE")
         super().__init__(name=name)
 
     async def pin_mounted_or_no_pin_found(self):

{dls_dodal-1.29.2 → dls_dodal-1.29.4}/src/dodal/devices/util/epics_util.py

@@ -1,5 +1,5 @@
 from functools import partial
-from typing import Callable
+from typing import Callable, Sequence
 
 from bluesky.protocols import Movable
 from ophyd import Component, EpicsSignal
@@ -26,7 +26,7 @@ def epics_signal_put_wait(pv_name: str, wait: float = 3.0) -> Component[EpicsSig
 
 
 def run_functions_without_blocking(
-    functions_to_chain: list[Callable[[], StatusBase]],
+    functions_to_chain: Sequence[Callable[[], StatusBase]],
     timeout: float = 60.0,
     associated_obj: OphydDevice | None = None,
 ) -> Status: