dkist-processing-visp 5.9.2__tar.gz → 5.10.0__tar.gz

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/CHANGELOG.rst

@@ -1,3 +1,24 @@
+v5.10.0 (2026-10-19)
+====================
+
+Removals
+--------
+
+- Remove the redundant ``VispAssembleQualityData`` task and use common's ``AssembleQualityData`` in the production, trial, and manual workflows. (`#342 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/342>`__)
+
+
+Misc
+----
+
+- Write polcal and solar vignette quality metrics through the new common quality API. (`#342 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/342>`__)
+
+
+Documentation
+-------------
+
+- Update the README clone command to use Bitbucket's new SSH hostname. (`#346 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/346>`__)
+
+
 v5.9.2 (2026-10-14)
 ===================
 

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-visp
-Version: 5.9.2
+Version: 5.10.0
 Summary: Science processing code for the ViSP instrument on DKIST
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -13,7 +13,7 @@ Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.13
 Requires-Python: >=3.13
 Description-Content-Type: text/x-rst
-Requires-Dist: dkist-processing-common==14.6.1
+Requires-Dist: dkist-processing-common==14.7.0
 Requires-Dist: dkist-processing-math==3.0.1
 Requires-Dist: dkist-processing-pac==3.1.2
 Requires-Dist: dkist-header-validator==6.0.0
@@ -75,7 +75,7 @@ Requires-Dist: PyJWT==2.15.1; extra == "frozen"
 Requires-Dist: PyYAML==6.0.3; extra == "frozen"
 Requires-Dist: PyYAML-ft==8.0.0; extra == "frozen"
 Requires-Dist: Pygments==2.21.0; extra == "frozen"
-Requires-Dist: SQLAlchemy==2.1.4; extra == "frozen"
+Requires-Dist: SQLAlchemy==2.1.5; extra == "frozen"
 Requires-Dist: Send2Trash==2.1.0; extra == "frozen"
 Requires-Dist: a2wsgi==1.10.10; extra == "frozen"
 Requires-Dist: aioftp==0.28.3; extra == "frozen"
@@ -92,7 +92,7 @@ Requires-Dist: anyio==4.15.1; extra == "frozen"
 Requires-Dist: apache-airflow==3.3.1; extra == "frozen"
 Requires-Dist: apache-airflow-core==3.3.1; extra == "frozen"
 Requires-Dist: apache-airflow-providers-celery==3.25.0; extra == "frozen"
-Requires-Dist: apache-airflow-providers-common-compat==1.21.0; extra == "frozen"
+Requires-Dist: apache-airflow-providers-common-compat==1.22.0; extra == "frozen"
 Requires-Dist: apache-airflow-providers-common-io==1.10.1; extra == "frozen"
 Requires-Dist: apache-airflow-providers-common-sql==2.3.0; extra == "frozen"
 Requires-Dist: apache-airflow-providers-postgres==7.1.1; extra == "frozen"
@@ -109,7 +109,7 @@ Requires-Dist: asdf_standard==1.5.0; extra == "frozen"
 Requires-Dist: asgiref==3.12.1; extra == "frozen"
 Requires-Dist: asteval==1.0.10; extra == "frozen"
 Requires-Dist: astropy==7.0.2; extra == "frozen"
-Requires-Dist: astropy-iers-data==0.2026.10.12.1.3.27; extra == "frozen"
+Requires-Dist: astropy-iers-data==0.2026.10.19.0.52.1; extra == "frozen"
 Requires-Dist: asttokens==3.0.2; extra == "frozen"
 Requires-Dist: async-lru==2.4.0; extra == "frozen"
 Requires-Dist: asyncpg==0.32.0; extra == "frozen"
@@ -118,12 +118,12 @@ Requires-Dist: babel==2.18.0; extra == "frozen"
 Requires-Dist: beautifulsoup4==4.15.0; extra == "frozen"
 Requires-Dist: billiard==4.3.1; extra == "frozen"
 Requires-Dist: bleach==6.4.0; extra == "frozen"
-Requires-Dist: boto3==1.43.113; extra == "frozen"
-Requires-Dist: botocore==1.43.113; extra == "frozen"
-Requires-Dist: cachetools==7.2.1; extra == "frozen"
+Requires-Dist: boto3==1.43.115; extra == "frozen"
+Requires-Dist: botocore==1.43.115; extra == "frozen"
+Requires-Dist: cachetools==7.2.4; extra == "frozen"
 Requires-Dist: cadwyn==7.0.0; extra == "frozen"
 Requires-Dist: celery==5.6.3; extra == "frozen"
-Requires-Dist: certifi==2026.7.22; extra == "frozen"
+Requires-Dist: certifi==2026.10.18; extra == "frozen"
 Requires-Dist: cffi==2.1.1; extra == "frozen"
 Requires-Dist: charset-normalizer==3.5.2; extra == "frozen"
 Requires-Dist: click==8.5.0; extra == "frozen"
@@ -143,11 +143,11 @@ Requires-Dist: decorator==5.3.1; extra == "frozen"
 Requires-Dist: defusedxml==0.7.1; extra == "frozen"
 Requires-Dist: dill==0.4.1; extra == "frozen"
 Requires-Dist: dkist-header-validator==6.0.0; extra == "frozen"
-Requires-Dist: dkist-processing-common==14.6.1; extra == "frozen"
+Requires-Dist: dkist-processing-common==14.7.0; extra == "frozen"
 Requires-Dist: dkist-processing-core==7.5.0; extra == "frozen"
 Requires-Dist: dkist-processing-math==3.0.1; extra == "frozen"
 Requires-Dist: dkist-processing-pac==3.1.2; extra == "frozen"
-Requires-Dist: dkist-processing-visp==5.9.2; extra == "frozen"
+Requires-Dist: dkist-processing-visp==5.10.0; extra == "frozen"
 Requires-Dist: dkist-service-configuration==4.3.0; extra == "frozen"
 Requires-Dist: dkist-spectral-lines==3.0.1; extra == "frozen"
 Requires-Dist: dkist_fits_specifications==4.30.0; extra == "frozen"
@@ -185,7 +185,7 @@ Requires-Dist: jedi==0.20.1; extra == "frozen"
 Requires-Dist: jmespath==1.1.0; extra == "frozen"
 Requires-Dist: joblib==1.6.0; extra == "frozen"
 Requires-Dist: json5==0.17.3; extra == "frozen"
-Requires-Dist: jsonpointer==3.2.1; extra == "frozen"
+Requires-Dist: jsonpointer==3.4; extra == "frozen"
 Requires-Dist: jsonschema==4.26.0; extra == "frozen"
 Requires-Dist: jsonschema-specifications==2025.9.1; extra == "frozen"
 Requires-Dist: jupyter-events==0.12.1; extra == "frozen"
@@ -202,7 +202,7 @@ Requires-Dist: kiwisolver==1.5.1; extra == "frozen"
 Requires-Dist: kombu==5.6.2; extra == "frozen"
 Requires-Dist: lark==1.3.1; extra == "frozen"
 Requires-Dist: lazy-loader==0.6; extra == "frozen"
-Requires-Dist: lazy-object-proxy==1.12.0; extra == "frozen"
+Requires-Dist: lazy-object-proxy==1.13.0; extra == "frozen"
 Requires-Dist: libcst==1.9.0; extra == "frozen"
 Requires-Dist: linkify-it-py==2.2.0; extra == "frozen"
 Requires-Dist: lmfit==1.3.4; extra == "frozen"
@@ -213,8 +213,8 @@ Requires-Dist: matplotlib==3.11.2; extra == "frozen"
 Requires-Dist: matplotlib-inline==0.2.2; extra == "frozen"
 Requires-Dist: mdurl==0.1.2; extra == "frozen"
 Requires-Dist: methodtools==0.4.7; extra == "frozen"
-Requires-Dist: mistune==3.3.4; extra == "frozen"
-Requires-Dist: more-itertools==11.2.0; extra == "frozen"
+Requires-Dist: mistune==3.4.0; extra == "frozen"
+Requires-Dist: more-itertools==11.2.1; extra == "frozen"
 Requires-Dist: moviepy==2.1.2; extra == "frozen"
 Requires-Dist: msgspec==0.22.0; extra == "frozen"
 Requires-Dist: multidict==7.1.0; extra == "frozen"
@@ -267,8 +267,8 @@ Requires-Dist: pexpect==4.9.0; extra == "frozen"
 Requires-Dist: pika==1.4.4; extra == "frozen"
 Requires-Dist: pillow==10.4.0; extra == "frozen"
 Requires-Dist: pip==26.2.1; extra == "frozen"
-Requires-Dist: platformdirs==4.13.0; extra == "frozen"
-Requires-Dist: pluggy==1.6.0; extra == "frozen"
+Requires-Dist: platformdirs==4.13.5; extra == "frozen"
+Requires-Dist: pluggy==1.7.0; extra == "frozen"
 Requires-Dist: pooch==1.9.0; extra == "frozen"
 Requires-Dist: proglog==0.1.12; extra == "frozen"
 Requires-Dist: prometheus_client==0.26.0; extra == "frozen"
@@ -307,7 +307,7 @@ Requires-Dist: rich==15.0.0; extra == "frozen"
 Requires-Dist: rich-argparse==1.8.0; extra == "frozen"
 Requires-Dist: rich-toolkit==0.20.6; extra == "frozen"
 Requires-Dist: rpds-py==2026.9.1; extra == "frozen"
-Requires-Dist: s3transfer==0.19.2; extra == "frozen"
+Requires-Dist: s3transfer==0.19.3; extra == "frozen"
 Requires-Dist: scikit-image==0.25.2; extra == "frozen"
 Requires-Dist: scikit-learn==1.6.1; extra == "frozen"
 Requires-Dist: scipy==1.15.3; extra == "frozen"
@@ -321,7 +321,7 @@ Requires-Dist: soupsieve==3.0.3; extra == "frozen"
 Requires-Dist: sqids==0.5.1; extra == "frozen"
 Requires-Dist: sqlparse==0.6.0; extra == "frozen"
 Requires-Dist: stack-data==0.6.3; extra == "frozen"
-Requires-Dist: starlette==1.8.0; extra == "frozen"
+Requires-Dist: starlette==1.9.0; extra == "frozen"
 Requires-Dist: structlog==26.1.0; extra == "frozen"
 Requires-Dist: sunpy==6.1.1; extra == "frozen"
 Requires-Dist: svcs==26.2.0; extra == "frozen"
@@ -332,7 +332,7 @@ Requires-Dist: termcolor==3.3.0; extra == "frozen"
 Requires-Dist: terminado==0.18.1; extra == "frozen"
 Requires-Dist: text-unidecode==1.3; extra == "frozen"
 Requires-Dist: threadpoolctl==3.7.0; extra == "frozen"
-Requires-Dist: tifffile==2026.9.20; extra == "frozen"
+Requires-Dist: tifffile==2026.10.15; extra == "frozen"
 Requires-Dist: tinycss2==1.5.1; extra == "frozen"
 Requires-Dist: tornado==6.5.10; extra == "frozen"
 Requires-Dist: tqdm==4.70.1; extra == "frozen"
@@ -356,7 +356,7 @@ Requires-Dist: wcwidth==0.9.2; extra == "frozen"
 Requires-Dist: webcolors==25.10.0; extra == "frozen"
 Requires-Dist: webencodings==0.6.1; extra == "frozen"
 Requires-Dist: websocket-client==1.9.2; extra == "frozen"
-Requires-Dist: websockets==17.2; extra == "frozen"
+Requires-Dist: websockets==17.3; extra == "frozen"
 Requires-Dist: wirerope==1.0.0; extra == "frozen"
 Requires-Dist: wrapt==2.5.1; extra == "frozen"
 Requires-Dist: yamale==6.1.0; extra == "frozen"
@@ -492,7 +492,7 @@ Development
 -----------
 .. code-block:: bash
 
-    git clone git@bitbucket.org:dkistdc/dkist-processing-visp.git
+    git clone git@ssh.bitbucket.org:dkistdc/dkist-processing-visp.git
     cd dkist-processing-visp
     pre-commit install
     pip install -e .[test]

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/README.rst

@@ -127,7 +127,7 @@ Development
 -----------
 .. code-block:: bash
 
-    git clone git@bitbucket.org:dkistdc/dkist-processing-visp.git
+    git clone git@ssh.bitbucket.org:dkistdc/dkist-processing-visp.git
     cd dkist-processing-visp
     pre-commit install
     pip install -e .[test]

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tasks/__init__.py

@@ -5,7 +5,6 @@ from dkist_processing_visp.tasks.background_light import *
 from dkist_processing_visp.tasks.dark import *
 from dkist_processing_visp.tasks.geometric import *
 from dkist_processing_visp.tasks.instrument_polarization import *
-from dkist_processing_visp.tasks.l1_output_data import *
 from dkist_processing_visp.tasks.lamp import *
 from dkist_processing_visp.tasks.make_movie_frames import *
 from dkist_processing_visp.tasks.parse import *

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tasks/instrument_polarization.py

@@ -4,7 +4,6 @@ from collections import defaultdict
 
 import numpy as np
 import scipy.ndimage as spnd
-from astropy.io import fits
 from dkist_processing_common.codecs.fits import fits_access_decoder
 from dkist_processing_common.codecs.fits import fits_array_decoder
 from dkist_processing_common.codecs.fits import fits_array_encoder
@@ -513,17 +512,13 @@ class InstrumentPolarizationCalibration(
 
     def record_polcal_quality_metrics(self, beam: int, polcal_fitter: PolcalFitter):
         """Record various quality metrics from PolCal fits."""
-        self.quality_store_polcal_results(
+        self.quality_metrics_polcal(
             polcal_fitter=polcal_fitter,
             label=f"Beam {beam}",
             # Yes, the first bin is actually hard-coded right now
             bin_nums=[1, self.parameters.polcal_num_spatial_bins],
             bin_labels=["spectral", "spatial"],
-            ## This is a bit of a hack and thus needs some explanation
-            # By using the ``skip_recording_constant_pars`` switch we DON'T record the "polcal constant parameters" metric
-            # for beam 2. This is because both beam 1 and beam 2 will have the same table. The way `*-common` is built
-            # it will look for all metrics for both beam 1 and beam 2 so if we did save that metric for beam 2 then the
-            # table would show up twice in the quality report. The following line avoids that.
+            # Both beams use the same constant parameters; record the table once.
             skip_recording_constant_pars=beam != 1,
         )
 

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tasks/solar.py

@@ -13,6 +13,10 @@ from dkist_processing_common.codecs.asdf import asdf_encoder
 from dkist_processing_common.codecs.fits import fits_access_decoder
 from dkist_processing_common.codecs.fits import fits_array_decoder
 from dkist_processing_common.codecs.fits import fits_array_encoder
+from dkist_processing_common.models.quality import FloatSeriesData
+from dkist_processing_common.models.quality import MultiPlotData
+from dkist_processing_common.models.quality import QualityMetric
+from dkist_processing_common.models.quality import XYData
 from dkist_processing_common.models.task_name import TaskName
 from dkist_processing_common.tasks.mixin.quality import QualityMixin
 from dkist_processing_math.arithmetic import closest_datetime
@@ -1038,42 +1042,184 @@ class SolarCalibration(
         fit_result: FitResult,
         vignette_corrected_gain: np.ndarray,
     ) -> None:
-        """
-        Save vignette fit results to disk for later quality metric building.
-
-        We save the atlas fit of the initial vignette estimation and the global solar spectrum derived from the
-        vignette-corrected 2D gain images.
-        """
+        """Write complete quality metrics for the initial and final vignette corrections."""
         logger.info(f"Recording initial vignette quality data for {beam = }")
-        first_vignette_quality_outputs = {
-            "output_wave_vec": fit_result.best_fit_wavelength_vector,
-            "input_spectrum": representative_spectrum,
-            "best_fit_atlas": fit_result.best_fit_atlas,
-            "best_fit_continuum": fit_result.best_fit_continuum,
-            "residuals": fit_result.minimizer_result.residual,
+        self._write_first_vignette_metric(beam, representative_spectrum, fit_result)
+
+        logger.info(f"Recording final vignette-corrected gain quality data for {beam = }")
+        self._write_final_vignette_metric(
+            beam, fit_result.best_fit_wavelength_vector, vignette_corrected_gain
+        )
+
+    def _write_first_vignette_metric(
+        self, beam: int, representative_spectrum: np.ndarray, fit_result: FitResult
+    ) -> None:
+        """Write the initial atlas-with-continuum fit and residuals as a complete metric."""
+        wave_vec = fit_result.best_fit_wavelength_vector
+        input_spectrum = representative_spectrum
+        best_fit_atlas = fit_result.best_fit_atlas
+        continuum = fit_result.best_fit_continuum
+        residuals = fit_result.minimizer_result.residual
+        finite_idx = (
+            np.isfinite(wave_vec)
+            & np.isfinite(input_spectrum)
+            & np.isfinite(best_fit_atlas)
+            & np.isfinite(continuum)
+            & np.isfinite(residuals)
+        )
+        wave_vec = wave_vec[finite_idx].tolist()
+        input_spectrum = input_spectrum[finite_idx].tolist()
+        best_fit_atlas = best_fit_atlas[finite_idx].tolist()
+        continuum = continuum[finite_idx].tolist()
+        residuals = residuals[finite_idx].tolist()
+
+        fit_series = {
+            "Raw input spectrum": FloatSeriesData(x_values=wave_vec, y_values=input_spectrum),
+            "Best fit atlas": FloatSeriesData(x_values=wave_vec, y_values=best_fit_atlas),
+            "Best fit continuum": FloatSeriesData(x_values=wave_vec, y_values=continuum),
         }
-        self.write(
-            data=first_vignette_quality_outputs,
-            tags=[VispTag.quality(VispMetricCode.solar_first_vignette), VispTag.beam(beam)],
-            encoder=asdf_encoder,
+
+        fit_plot_kwargs = {
+            "Raw input spectrum": {
+                "ls": "-",
+                "ms": 0,
+                "color": "#FAA61C",
+                "zorder": 2.0,
+                "lw": 4,
+                "alpha": 0.6,
+            },
+            "Best fit atlas": {"color": "k", "ls": "-", "ms": 0, "zorder": 2.1},
+            "Best fit continuum": {"ls": "-", "ms": 0, "color": "g", "zorder": 2.2},
+        }
+
+        fit_plot = XYData(
+            xlabel="Wavelength [nm]",
+            ylabel="Signal",
+            series_data=fit_series,
+            plot_kwargs=fit_plot_kwargs,
+            sort_series=False,
+        )
+
+        residuals_series = {"Residuals": FloatSeriesData(x_values=wave_vec, y_values=residuals)}
+        residuals_plot_kwargs = {"Residuals": {"ls": "-", "color": "k", "ms": 0}}
+
+        y_min = np.nanpercentile(residuals, 2)
+        y_max = np.nanpercentile(residuals, 98)
+        y_range = y_max - y_min
+        y_min -= 0.1 * y_range
+        y_max += 0.1 * y_range
+        residuals_plot = XYData(
+            xlabel="Wavelength [nm]",
+            ylabel=r"$\frac{\mathrm{Obs - Atlas}}{\mathrm{Obs}}$",
+            series_data=residuals_series,
+            plot_kwargs=residuals_plot_kwargs,
+            ylim=(y_min, y_max),
+        )
+
+        plot_list = [fit_plot, residuals_plot]
+        height_ratios = [1.5, 1.0]
+
+        full_plot = MultiPlotData(
+            top_to_bottom_plot_list=plot_list,
+            match_x_axes=True,
+            no_gap=True,
+            top_to_bottom_height_ratios=height_ratios,
         )
 
-        logger.info(f"Recording final vignette-correced gain quality data for {beam = }")
-        global_median = np.nanmedian(vignette_corrected_gain, axis=1)
-        low_deviation = np.nanpercentile(vignette_corrected_gain, 5, axis=1)
-        high_deviation = np.nanpercentile(vignette_corrected_gain, 95, axis=1)
-        final_correction_quality_outputs = {
-            "output_wave_vec": fit_result.best_fit_wavelength_vector,
-            "median_spec": global_median,
-            "low_deviation": low_deviation,
-            "high_deviation": high_deviation,
+        metric = QualityMetric(
+            name=f"Initial Vignette Estimation - Beam {beam}",
+            description="These plots show the solar atlas fit used to estimate the initial, 1D spectral vignette "
+            "present in solar gain frames. The vignette signature is taken to be the fit continuum shown.",
+            metric_code=VispMetricCode.solar_first_vignette,
+            facet=f"Beam {beam}",
+            multi_plot_data=full_plot,
+        )
+
+        self._write_quality_metric(metric)
+
+    def _write_final_vignette_metric(
+        self, beam: int, output_wave_vec: np.ndarray, vignette_corrected_gain: np.ndarray
+    ) -> None:
+        """Write the quality of the vignette correction on solar gain data."""
+        finite_gain = np.isfinite(vignette_corrected_gain)
+        valid_rows = np.isfinite(output_wave_vec) & np.any(finite_gain, axis=1)
+        output_wave_vec = output_wave_vec[valid_rows]
+        gain = np.where(finite_gain[valid_rows], vignette_corrected_gain[valid_rows], np.nan)
+        median_spec = np.nanmedian(gain, axis=1)
+        low_deviation = np.nanpercentile(gain, 5, axis=1)
+        high_deviation = np.nanpercentile(gain, 95, axis=1)
+        finite_idx = (
+            np.isfinite(output_wave_vec)
+            & np.isfinite(median_spec)
+            & np.isfinite(low_deviation)
+            & np.isfinite(high_deviation)
+        )
+        wave_vec = output_wave_vec[finite_idx].tolist()
+        median_spec = median_spec[finite_idx].tolist()
+        diff = (high_deviation[finite_idx] - low_deviation[finite_idx]).tolist()
+        low_deviation = low_deviation[finite_idx].tolist()
+        high_deviation = high_deviation[finite_idx].tolist()
+
+        bounds_series = {
+            "Median solar signal": FloatSeriesData(x_values=wave_vec, y_values=median_spec),
+            "5th percentile bounds": FloatSeriesData(x_values=wave_vec, y_values=low_deviation),
+            "95th percentile bounds": FloatSeriesData(x_values=wave_vec, y_values=high_deviation),
         }
-        self.write(
-            data=final_correction_quality_outputs,
-            tags=[VispTag.quality(VispMetricCode.solar_final_vignette), VispTag.beam(beam)],
-            encoder=asdf_encoder,
+
+        bounds_plot_kwargs = {
+            "Median solar signal": {"ls": "-", "color": "k", "alpha": 0.8, "ms": 0, "zorder": 2.2},
+            "5th percentile bounds": {"color": "#1E317A", "ls": "-", "ms": 0, "zorder": 2.0},
+            "95th percentile bounds": {"ls": "-", "color": "#FAA61C", "ms": 0, "zorder": 2.1},
+        }
+
+        bounds_plot = XYData(
+            xlabel="Wavelength [nm]",
+            ylabel="Signal",
+            series_data=bounds_series,
+            plot_kwargs=bounds_plot_kwargs,
+            sort_series=False,
         )
 
+        residuals_series = {"Residuals": FloatSeriesData(x_values=wave_vec, y_values=diff)}
+        residuals_plot_kwargs = {"Residuals": {"ls": "-", "color": "k", "ms": 0}}
+
+        y_min = np.nanpercentile(diff, 5)
+        y_max = np.nanpercentile(diff, 95)
+        y_range = y_max - y_min
+        y_min -= 0.1 * y_range
+        y_max += 0.1 * y_range
+        residuals_plot = XYData(
+            xlabel="Wavelength [nm]",
+            ylabel="95th - 5th percentile",
+            series_data=residuals_series,
+            plot_kwargs=residuals_plot_kwargs,
+            ylim=(y_min, y_max),
+        )
+
+        plot_list = [bounds_plot, residuals_plot]
+        height_ratios = [1.5, 1.0]
+
+        full_plot = MultiPlotData(
+            top_to_bottom_plot_list=plot_list,
+            match_x_axes=True,
+            no_gap=True,
+            top_to_bottom_height_ratios=height_ratios,
+        )
+
+        metric = QualityMetric(
+            name=f"Final Vignette Estimation - Beam {beam}",
+            description="These plots show how well the full, 2D vignette signal was removed from solar gain frames. "
+            "The median solar signal shows a full spatial median of the vignette corrected solar gain; "
+            "this should be very close to the true solar spectrum incident on the DKIST optics. "
+            "The 5th and 95th percentile ranges show how stable this spectrum is along the spatial dimension "
+            "after removing the vignette signal.",
+            metric_code=VispMetricCode.solar_final_vignette,
+            facet=f"Beam {beam}",
+            multi_plot_data=full_plot,
+        )
+
+        self._write_quality_metric(metric)
+
     def _log_wavecal_parameters(
         self,
         dispersion: Quantity,

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tests/local_trial_workflows/l0_polcals_as_science.py

@@ -13,6 +13,7 @@ from dkist_processing_common.codecs.basemodel import basemodel_encoder
 from dkist_processing_common.manual import ManualProcessing
 from dkist_processing_common.models.fits_access import MetadataKey
 from dkist_processing_common.models.input_dataset import InputDatasetPartDocumentList
+from dkist_processing_common.tasks import AssembleQualityData
 from dkist_processing_common.tasks import CreateTrialQualityReport
 from dkist_processing_common.tasks import QualityL1Metrics
 from dkist_processing_common.tasks import WorkflowTaskBase
@@ -27,7 +28,6 @@ from dkist_processing_visp.tasks.background_light import BackgroundLightCalibrat
 from dkist_processing_visp.tasks.dark import DarkCalibration
 from dkist_processing_visp.tasks.geometric import GeometricCalibration
 from dkist_processing_visp.tasks.instrument_polarization import InstrumentPolarizationCalibration
-from dkist_processing_visp.tasks.l1_output_data import VispAssembleQualityData
 from dkist_processing_visp.tasks.lamp import LampCalibration
 from dkist_processing_visp.tasks.science import ScienceCalibration
 from dkist_processing_visp.tasks.solar import SolarCalibration
@@ -321,7 +321,7 @@ def main(
 
         manual_processing_run.run_task(task=write_L1_files_task(prefix=prefix))
         manual_processing_run.run_task(task=QualityL1Metrics)
-        manual_processing_run.run_task(task=VispAssembleQualityData)
+        manual_processing_run.run_task(task=AssembleQualityData)
         manual_processing_run.run_task(task=ValidateL1Output)
         manual_processing_run.run_task(task=MakeVispMovieFrames)
         manual_processing_run.run_task(task=AssembleVispMovie)

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tests/local_trial_workflows/l0_solar_gain_as_science.py

@@ -10,6 +10,7 @@ from random import randint
 from dkist_processing_common.codecs.basemodel import basemodel_encoder
 from dkist_processing_common.manual import ManualProcessing
 from dkist_processing_common.models.input_dataset import InputDatasetPartDocumentList
+from dkist_processing_common.tasks import AssembleQualityData
 from dkist_processing_common.tasks import CreateTrialQualityReport
 from dkist_processing_common.tasks import QualityL1Metrics
 from dkist_processing_common.tasks import WorkflowTaskBase
@@ -19,7 +20,6 @@ from dkist_processing_visp.models.tags import VispTag
 from dkist_processing_visp.tasks import AssembleVispMovie
 from dkist_processing_visp.tasks import MakeVispMovieFrames
 from dkist_processing_visp.tasks import ScienceCalibration
-from dkist_processing_visp.tasks import VispAssembleQualityData
 from dkist_processing_visp.tasks import VispWriteL1Frame
 from dkist_processing_visp.tasks.background_light import BackgroundLightCalibration
 from dkist_processing_visp.tasks.dark import DarkCalibration
@@ -261,7 +261,7 @@ def main(
 
         manual_processing_run.run_task(task=VispWriteL1Frame)
         manual_processing_run.run_task(task=QualityL1Metrics)
-        manual_processing_run.run_task(task=VispAssembleQualityData)
+        manual_processing_run.run_task(task=AssembleQualityData)
         manual_processing_run.run_task(task=ValidateL1Output)
         manual_processing_run.run_task(task=MakeVispMovieFrames)
         manual_processing_run.run_task(task=AssembleVispMovie)

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tests/local_trial_workflows/l0_to_l1.py

@@ -10,6 +10,7 @@ from dkist_processing_common.codecs.basemodel import basemodel_encoder
 from dkist_processing_common.codecs.fits import fits_access_decoder
 from dkist_processing_common.manual import ManualProcessing
 from dkist_processing_common.models.input_dataset import InputDatasetPartDocumentList
+from dkist_processing_common.tasks import AssembleQualityData
 from dkist_processing_common.tasks import CreateTrialAsdf
 from dkist_processing_common.tasks import CreateTrialQualityReport
 from dkist_processing_common.tasks import QualityL1Metrics
@@ -23,7 +24,6 @@ from dkist_processing_visp.tasks.background_light import BackgroundLightCalibrat
 from dkist_processing_visp.tasks.dark import DarkCalibration
 from dkist_processing_visp.tasks.geometric import GeometricCalibration
 from dkist_processing_visp.tasks.instrument_polarization import InstrumentPolarizationCalibration
-from dkist_processing_visp.tasks.l1_output_data import VispAssembleQualityData
 from dkist_processing_visp.tasks.lamp import LampCalibration
 from dkist_processing_visp.tasks.make_movie_frames import MakeVispMovieFrames
 from dkist_processing_visp.tasks.parse import ParseL0VispInputData
@@ -282,7 +282,7 @@ def main(
         manual_processing_run.run_task(task=VispWriteL1Frame)
         manual_processing_run.run_task(task=VispWriteL1DatasetExtras)
         manual_processing_run.run_task(task=QualityL1Metrics)
-        manual_processing_run.run_task(task=VispAssembleQualityData)
+        manual_processing_run.run_task(task=AssembleQualityData)
         manual_processing_run.run_task(task=ValidateL1Output)
         manual_processing_run.run_task(task=MakeVispMovieFrames)
         manual_processing_run.run_task(task=AssembleVispMovie)

{dkist_processing_visp-5.9.2 → dkist_processing_visp-5.10.0}/dkist_processing_visp/tests/test_instrument_polarization.py

@@ -148,7 +148,7 @@ def test_instrument_polarization_calibration_task(
 
     # Don't test place-holder QA stuff for now
     quality_metric_mocker = mocker.patch(
-        "dkist_processing_visp.tasks.instrument_polarization.InstrumentPolarizationCalibration.quality_store_polcal_results",
+        "dkist_processing_visp.tasks.instrument_polarization.InstrumentPolarizationCalibration.quality_metrics_polcal",
         autospec=True,
     )