dkist-processing-visp 5.8.1__tar.gz → 5.8.2__tar.gz

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/CHANGELOG.rst

@@ -1,3 +1,12 @@
+v5.8.2 (2026-09-04)
+===================
+
+Bugfixes
+--------
+
+- Update movie generation for "sit'n'stare" datasets to avoid out-of-memory failures. Movies for sit'n'stare observations (when the slit doesn't move) are now displayed with time on the "spatial" axis; each column is the wavelength-integrated signal of a single slit observation. Genuine spatial raster scans, of any polarization mode, are unaffected and continue to use the existing algorithm. (`#329 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/329>`__)
+
+
 v5.8.1 (2026-08-28)
 ===================
 

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-visp
-Version: 5.8.1
+Version: 5.8.2
 Summary: Science processing code for the ViSP instrument on DKIST
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -84,11 +84,11 @@ Requires-Dist: aiohttp==3.14.3; extra == "frozen"
 Requires-Dist: aiosignal==1.4.0; extra == "frozen"
 Requires-Dist: aiosmtplib==5.1.2; extra == "frozen"
 Requires-Dist: aiosqlite==0.22.1; extra == "frozen"
-Requires-Dist: alembic==1.19.1; extra == "frozen"
+Requires-Dist: alembic==1.19.2; extra == "frozen"
 Requires-Dist: amqp==5.3.1; extra == "frozen"
 Requires-Dist: annotated-doc==0.0.5; extra == "frozen"
 Requires-Dist: annotated-types==0.8.0; extra == "frozen"
-Requires-Dist: anyio==4.14.2; extra == "frozen"
+Requires-Dist: anyio==4.15.0; extra == "frozen"
 Requires-Dist: apache-airflow==3.3.1; extra == "frozen"
 Requires-Dist: apache-airflow-core==3.3.1; extra == "frozen"
 Requires-Dist: apache-airflow-providers-celery==3.23.1; extra == "frozen"
@@ -109,7 +109,7 @@ Requires-Dist: asdf_standard==1.5.0; extra == "frozen"
 Requires-Dist: asgiref==3.12.1; extra == "frozen"
 Requires-Dist: asteval==1.0.10; extra == "frozen"
 Requires-Dist: astropy==7.0.2; extra == "frozen"
-Requires-Dist: astropy-iers-data==0.2026.8.24.0.24.29; extra == "frozen"
+Requires-Dist: astropy-iers-data==0.2026.8.31.0.57.9; extra == "frozen"
 Requires-Dist: asttokens==3.0.2; extra == "frozen"
 Requires-Dist: async-lru==2.3.0; extra == "frozen"
 Requires-Dist: asyncpg==0.31.0; extra == "frozen"
@@ -118,9 +118,9 @@ Requires-Dist: babel==2.18.0; extra == "frozen"
 Requires-Dist: beautifulsoup4==4.15.0; extra == "frozen"
 Requires-Dist: billiard==4.2.4; extra == "frozen"
 Requires-Dist: bleach==6.4.0; extra == "frozen"
-Requires-Dist: boto3==1.43.82; extra == "frozen"
-Requires-Dist: botocore==1.43.82; extra == "frozen"
-Requires-Dist: cachetools==7.1.7; extra == "frozen"
+Requires-Dist: boto3==1.43.88; extra == "frozen"
+Requires-Dist: botocore==1.43.88; extra == "frozen"
+Requires-Dist: cachetools==7.1.8; extra == "frozen"
 Requires-Dist: cadwyn==7.0.0; extra == "frozen"
 Requires-Dist: celery==5.6.3; extra == "frozen"
 Requires-Dist: certifi==2026.7.22; extra == "frozen"
@@ -130,6 +130,7 @@ Requires-Dist: click==8.5.0; extra == "frozen"
 Requires-Dist: click-didyoumean==0.3.1; extra == "frozen"
 Requires-Dist: click-plugins==1.1.1.2; extra == "frozen"
 Requires-Dist: click-repl==0.3.0; extra == "frozen"
+Requires-Dist: cloudpickle==3.1.2; extra == "frozen"
 Requires-Dist: colorlog==6.12.0; extra == "frozen"
 Requires-Dist: comm==0.2.3; extra == "frozen"
 Requires-Dist: contourpy==1.3.3; extra == "frozen"
@@ -146,7 +147,7 @@ Requires-Dist: dkist-processing-common==14.4.0; extra == "frozen"
 Requires-Dist: dkist-processing-core==7.5.0; extra == "frozen"
 Requires-Dist: dkist-processing-math==2.2.3; extra == "frozen"
 Requires-Dist: dkist-processing-pac==3.1.2; extra == "frozen"
-Requires-Dist: dkist-processing-visp==5.8.1; extra == "frozen"
+Requires-Dist: dkist-processing-visp==5.8.2; extra == "frozen"
 Requires-Dist: dkist-service-configuration==4.3.0; extra == "frozen"
 Requires-Dist: dkist-spectral-lines==3.0.1; extra == "frozen"
 Requires-Dist: dkist_fits_specifications==4.28.1; extra == "frozen"
@@ -157,12 +158,12 @@ Requires-Dist: fastapi==0.136.3; extra == "frozen"
 Requires-Dist: fastapi-cli==0.0.32; extra == "frozen"
 Requires-Dist: fastjsonschema==2.22.2; extra == "frozen"
 Requires-Dist: flower==2.1.0; extra == "frozen"
-Requires-Dist: fonttools==4.63.0; extra == "frozen"
+Requires-Dist: fonttools==4.64.0; extra == "frozen"
 Requires-Dist: fqdn==1.5.1; extra == "frozen"
 Requires-Dist: frozenlist==1.8.0; extra == "frozen"
 Requires-Dist: fsspec==2026.7.0; extra == "frozen"
 Requires-Dist: globus-sdk==4.9.0; extra == "frozen"
-Requires-Dist: googleapis-common-protos==1.75.2; extra == "frozen"
+Requires-Dist: googleapis-common-protos==1.75.3; extra == "frozen"
 Requires-Dist: gqlclient==2.0.0; extra == "frozen"
 Requires-Dist: greenback==1.3.0; extra == "frozen"
 Requires-Dist: greenlet==3.5.5; extra == "frozen"
@@ -174,22 +175,22 @@ Requires-Dist: httpx==0.28.1; extra == "frozen"
 Requires-Dist: humanize==4.16.0; extra == "frozen"
 Requires-Dist: idna==3.19; extra == "frozen"
 Requires-Dist: imageio-ffmpeg==0.6.0; extra == "frozen"
-Requires-Dist: importlib_metadata==9.0.0; extra == "frozen"
+Requires-Dist: importlib_metadata==9.0.1; extra == "frozen"
 Requires-Dist: ipykernel==7.3.0; extra == "frozen"
-Requires-Dist: ipython==9.17.0; extra == "frozen"
+Requires-Dist: ipython==9.17.1; extra == "frozen"
 Requires-Dist: ipython_pygments_lexers==1.1.1; extra == "frozen"
 Requires-Dist: isoduration==20.11.0; extra == "frozen"
 Requires-Dist: itsdangerous==2.2.0; extra == "frozen"
 Requires-Dist: jedi==0.20.0; extra == "frozen"
 Requires-Dist: jmespath==1.1.0; extra == "frozen"
-Requires-Dist: joblib==1.5.3; extra == "frozen"
+Requires-Dist: joblib==1.6.0; extra == "frozen"
 Requires-Dist: json5==0.15.0; extra == "frozen"
 Requires-Dist: jsonpointer==3.1.1; extra == "frozen"
 Requires-Dist: jsonschema==4.26.0; extra == "frozen"
 Requires-Dist: jsonschema-specifications==2025.9.1; extra == "frozen"
 Requires-Dist: jupyter-events==0.12.1; extra == "frozen"
 Requires-Dist: jupyter-lsp==2.3.1; extra == "frozen"
-Requires-Dist: jupyter_builder==1.2.2; extra == "frozen"
+Requires-Dist: jupyter_builder==1.2.3; extra == "frozen"
 Requires-Dist: jupyter_client==8.10.0; extra == "frozen"
 Requires-Dist: jupyter_core==5.9.1; extra == "frozen"
 Requires-Dist: jupyter_server==2.21.0; extra == "frozen"
@@ -203,7 +204,7 @@ Requires-Dist: lark==1.3.1; extra == "frozen"
 Requires-Dist: lazy-loader==0.5; extra == "frozen"
 Requires-Dist: lazy-object-proxy==1.12.0; extra == "frozen"
 Requires-Dist: libcst==1.9.0; extra == "frozen"
-Requires-Dist: linkify-it-py==2.1.1; extra == "frozen"
+Requires-Dist: linkify-it-py==2.2.0; extra == "frozen"
 Requires-Dist: lmfit==1.3.4; extra == "frozen"
 Requires-Dist: lockfile==0.12.2; extra == "frozen"
 Requires-Dist: loguru==0.7.3; extra == "frozen"
@@ -264,17 +265,17 @@ Requires-Dist: pexpect==4.9.0; extra == "frozen"
 Requires-Dist: pika==1.4.4; extra == "frozen"
 Requires-Dist: pillow==10.4.0; extra == "frozen"
 Requires-Dist: pip==26.2.1; extra == "frozen"
-Requires-Dist: platformdirs==4.11.5; extra == "frozen"
+Requires-Dist: platformdirs==4.11.7; extra == "frozen"
 Requires-Dist: pluggy==1.6.0; extra == "frozen"
 Requires-Dist: pooch==1.9.0; extra == "frozen"
 Requires-Dist: proglog==0.1.12; extra == "frozen"
 Requires-Dist: prometheus_client==0.26.0; extra == "frozen"
 Requires-Dist: prompt_toolkit==3.0.53; extra == "frozen"
 Requires-Dist: propcache==0.5.2; extra == "frozen"
-Requires-Dist: protobuf==7.36.0; extra == "frozen"
+Requires-Dist: protobuf==7.36.1; extra == "frozen"
 Requires-Dist: psutil==7.2.2; extra == "frozen"
-Requires-Dist: psycopg==3.3.4; extra == "frozen"
-Requires-Dist: psycopg-binary==3.3.4; extra == "frozen"
+Requires-Dist: psycopg==3.3.5; extra == "frozen"
+Requires-Dist: psycopg-binary==3.3.5; extra == "frozen"
 Requires-Dist: psycopg2-binary==2.9.12; extra == "frozen"
 Requires-Dist: ptyprocess==0.7.0; extra == "frozen"
 Requires-Dist: pure_eval==0.2.3; extra == "frozen"
@@ -284,7 +285,7 @@ Requires-Dist: pydantic-extra-types==2.11.1; extra == "frozen"
 Requires-Dist: pydantic-settings==2.15.0; extra == "frozen"
 Requires-Dist: pydantic_core==2.46.5; extra == "frozen"
 Requires-Dist: pyerfa==2.0.1.5; extra == "frozen"
-Requires-Dist: pygtrie==2.5.0; extra == "frozen"
+Requires-Dist: pygtrie==2.6.1; extra == "frozen"
 Requires-Dist: pyparsing==3.3.2; extra == "frozen"
 Requires-Dist: python-daemon==3.1.2; extra == "frozen"
 Requires-Dist: python-dateutil==2.9.0.post0; extra == "frozen"
@@ -302,7 +303,7 @@ Requires-Dist: rfc3986-validator==0.1.1; extra == "frozen"
 Requires-Dist: rfc3987-syntax==1.1.0; extra == "frozen"
 Requires-Dist: rich==15.0.0; extra == "frozen"
 Requires-Dist: rich-argparse==1.8.0; extra == "frozen"
-Requires-Dist: rich-toolkit==0.20.3; extra == "frozen"
+Requires-Dist: rich-toolkit==0.20.4; extra == "frozen"
 Requires-Dist: rpds-py==2026.6.3; extra == "frozen"
 Requires-Dist: s3transfer==0.19.2; extra == "frozen"
 Requires-Dist: scikit-image==0.25.2; extra == "frozen"
@@ -339,7 +340,6 @@ Requires-Dist: typing-inspection==0.4.4; extra == "frozen"
 Requires-Dist: typing_extensions==4.16.0; extra == "frozen"
 Requires-Dist: tzdata==2026.3; extra == "frozen"
 Requires-Dist: tzlocal==5.4.4; extra == "frozen"
-Requires-Dist: uc-micro-py==2.0.0; extra == "frozen"
 Requires-Dist: uncertainties==3.2.3; extra == "frozen"
 Requires-Dist: universal_pathlib==0.3.10; extra == "frozen"
 Requires-Dist: uri-template==1.3.0; extra == "frozen"
@@ -350,13 +350,13 @@ Requires-Dist: uvloop==0.22.1; extra == "frozen"
 Requires-Dist: vine==5.1.0; extra == "frozen"
 Requires-Dist: voluptuous==0.16.0; extra == "frozen"
 Requires-Dist: watchfiles==1.2.0; extra == "frozen"
-Requires-Dist: wcwidth==0.8.2; extra == "frozen"
+Requires-Dist: wcwidth==0.8.3; extra == "frozen"
 Requires-Dist: webcolors==25.10.0; extra == "frozen"
 Requires-Dist: webencodings==0.6.1; extra == "frozen"
-Requires-Dist: websocket-client==1.9.0; extra == "frozen"
+Requires-Dist: websocket-client==1.9.2; extra == "frozen"
 Requires-Dist: websockets==17.1; extra == "frozen"
 Requires-Dist: wirerope==1.0.0; extra == "frozen"
-Requires-Dist: wrapt==2.3.0; extra == "frozen"
+Requires-Dist: wrapt==2.4.0; extra == "frozen"
 Requires-Dist: yamale==6.1.0; extra == "frozen"
 Requires-Dist: yarl==1.24.5; extra == "frozen"
 Requires-Dist: zipp==4.1.0; extra == "frozen"

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/models/constants.py

@@ -34,6 +34,7 @@ class VispBudName(Enum):
     axis_3_type = "AXIS_3_TYPE"
     dark_readout_exp_time_picky_bud = "DARK_READOUT_EXP_TIME_PICKY_BUD"
     dark_readout_to_total_exp_times_lookup = "DARK_READOUT_TO_TOTAL_EXP_TIMES_LOOKUP"
+    slit_velocity_mm_per_s = "SLIT_VELOCITY_MM_PER_S"
 
 
 class VispConstants(ConstantsBase):
@@ -196,3 +197,19 @@ class VispConstants(ConstantsBase):
         raw_return = self._db_dict[VispBudName.dark_readout_to_total_exp_times_lookup]
         # convert JSON string keys back to float
         return {float(k): v for k, v in raw_return.items()}
+
+    @property
+    def slit_velocity_mm_per_s(self) -> float:
+        """Return observation slit velocity [mm/s]."""
+        return self._db_dict[VispBudName.slit_velocity_mm_per_s.value]
+
+    @property
+    def is_sit_n_stare(self) -> bool:
+        """
+        Return True if the data were acquired in the intensity-only, no-slit-motion "sit'n'stare" mode.
+
+        The data are sit'n'stare if they were acquired in intensity mode with a slit velocity of
+        exactly zero (the slit never moved).
+        """
+        is_slit_stationary = self.slit_velocity_mm_per_s == 0.0
+        return self.polarimeter_mode == "observe_intensity" and is_slit_stationary

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/models/fits_access.py

@@ -15,6 +15,7 @@ class VispMetadataKey(StrEnum):
     grating_angle_deg = "VSPGRTAN"
     arm_position_deg = "VSPARMPS"
     grating_constant_inverse_mm = "VSPGRTCN"
+    slit_velocity_mm_per_s = "VSPSLTSV"
     axis_1_type = "CTYPE1"
     axis_2_type = "CTYPE2"
     axis_3_type = "CTYPE3"

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/parsers/visp_l0_fits_access.py

@@ -54,6 +54,10 @@ class VispL0FitsAccess(L0FitsAccess):
         self.grating_constant_inverse_mm: float = self.header[
             VispMetadataKey.grating_constant_inverse_mm
         ]
+        # Only present for intensity-mode data
+        self.slit_velocity_mm_per_s: float = self.header.get(
+            VispMetadataKey.slit_velocity_mm_per_s, HEADER_KEY_NOT_FOUND
+        )
         self.axis_1_type: str = self.header[VispMetadataKey.axis_1_type]
         self.axis_2_type: str = self.header[VispMetadataKey.axis_2_type]
         self.axis_3_type: str = self.header[VispMetadataKey.axis_3_type]

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/tasks/assemble_movie.py

@@ -44,9 +44,16 @@ class AssembleVispMovie(AssembleMovie):
     def num_images(self) -> int:
         """Total number of images in final movie.
 
-        Overloaded from `dkist-processing-common` because DSPS repeat does not correspond to map scan in ViSP
+        Overridden from `dkist-processing-common` because DSPS repeat does not correspond to map scan in ViSP.
+
+        This counts the movie frames actually written by `MakeVispMovieFrames`, rather than trusting
+        `self.constants.num_map_scans`. For the map-scan movie-frame path those two numbers are
+        always the same (one movie frame per map scan), but for the sit'n'stare movie-frame path a
+        single map scan can be chunked into many movie frames, so `num_map_scans` (which correctly
+        continues to describe the real map-scan structure of the science data, and is used as such
+        elsewhere) doesn't equal the number of movie frames in that case.
         """
-        return self.constants.num_map_scans
+        return self.count(tags=[VispTag.movie_frame()])
 
     def tags_for_image_n(self, n: int) -> list[str]:
         """Return tags that grab the n'th movie image.

dkist_processing_visp-5.8.2/dkist_processing_visp/tasks/make_movie_frames.py

@@ -0,0 +1,351 @@
+"""Visp make movie frames task."""
+
+import numpy as np
+from astropy.io import fits
+from astropy.visualization import ZScaleInterval
+from dkist_processing_common.codecs.fits import fits_access_decoder
+from dkist_processing_common.codecs.fits import fits_array_encoder
+from dkist_processing_common.models.fits_access import MetadataKey
+from dkist_service_configuration.logging import logger
+
+from dkist_processing_visp.models.tags import VispTag
+from dkist_processing_visp.parsers.visp_l1_fits_access import VispL1FitsAccess
+from dkist_processing_visp.tasks.assemble_movie import AssembleVispMovie
+from dkist_processing_visp.tasks.visp_base import VispTaskBase
+
+__all__ = ["MakeVispMovieFrames"]
+
+MOVIE_FRAME_WIDTH = AssembleVispMovie.MOVIE_FRAME_SHAPE[0]
+
+
+class MakeVispMovieFrames(VispTaskBase):
+    """
+    Make ViSP movie frames and tag with VispTag.movie_frame().
+
+    Frames are built via one of two code paths, chosen per-dataset in `run` based on
+    `self.constants.is_sit_n_stare`:
+
+    Map-scan path (`make_map_scan_movie_frames`): genuine spatially-scanning maps, of any
+    polarization mode, build one movie frame per map scan.
+
+    Sit'n'stare path (`make_sit_n_stare_movie_frames`): the single map scan is split into
+    fixed-size chunks of raster steps (see `generate_sit_n_stare_chunk_ranges`), and one movie
+    frame, capped at `MOVIE_FRAME_WIDTH`, is built per chunk. The final chunk is zero-padded up to
+    full width if it's undersized, guaranteeing that any dataset with at least one raster step
+    produces at least one movie frame. `self.constants.num_map_scans == 1` is required and checked
+    explicitly, since sit'n'stare is defined as a single, continuous, non-moving-slit observation
+    and this path only ever reads/writes `map_scan=1` frames.
+
+    Parameters
+    ----------
+    recipe_run_id : int
+        id of the recipe run used to identify the workflow run this task is part of
+    workflow_name : str
+        name of the workflow to which this instance of the task belongs
+    workflow_version : str
+        version of the workflow to which this instance of the task belongs
+
+
+    """
+
+    def run(self) -> None:
+        """
+        Decide which movie-frame code path applies, based on `self.constants.is_sit_n_stare`, and build/write the frames.
+
+        Returns
+        -------
+        None
+        """
+        if self.constants.is_sit_n_stare:
+            logger.info(
+                "Sit'n'stare mode detected. Building movie frames by chunking raster steps."
+            )
+            with self.telemetry_span("Making and writing sit'n'stare movie frames"):
+                self.make_sit_n_stare_movie_frames()
+        else:
+            logger.info("Building one movie frame per map scan.")
+            with self.telemetry_span("Making and writing movie frames"):
+                self.make_map_scan_movie_frames()
+
+    @staticmethod
+    def generate_sit_n_stare_chunk_ranges(
+        num_raster_steps: int, chunk_size: int = MOVIE_FRAME_WIDTH
+    ) -> list[range]:
+        """
+        Split a number of raster steps into consecutive, non-overlapping ranges of at most `chunk_size`.
+
+        Parameters
+        ----------
+        num_raster_steps
+            Total number of raster steps (time samples) in the single map scan. Can be arbitrarily
+            large.
+
+        chunk_size
+            The number of raster steps per full range/movie frame. Defaults to `MOVIE_FRAME_WIDTH`
+            so the produced frames need no resizing before being handed to `AssembleVispMovie`.
+
+        Returns
+        -------
+        A list of `range` objects, in ascending, non-overlapping, time order, together covering every raster step from `0` to `num_raster_steps`.
+        """
+        num_chunks = -(-num_raster_steps // chunk_size)  # ceiling division, no float round-trip
+        return [
+            range(i * chunk_size, min((i + 1) * chunk_size, num_raster_steps))
+            for i in range(num_chunks)
+        ]
+
+    def make_sit_n_stare_movie_frames(self) -> None:
+        """
+        For the single map scan, build one movie frame per fixed-size range of raster steps.
+
+        Stokes handling isn't needed here because this mode is intensity-only by definition.
+
+        For each range of up to `MOVIE_FRAME_WIDTH` sequential raster steps:
+
+        #. Integrate each raster step in the range over wavelength into a single column of
+           pixels
+        #. Build a movie frame by lining the columns up side by side, zero-padding out to
+           `MOVIE_FRAME_WIDTH` if this is a final, undersized chunk - guaranteeing at least one
+           frame is written even for a whole dataset smaller than `MOVIE_FRAME_WIDTH`
+        #. Write the frame as a "MOVIE_FRAME", tagged sequentially (chunk order, 1-indexed) -
+           *not* by any real map scan number, since there is only one
+
+        Raises
+        ------
+        ValueError
+            If `self.constants.num_map_scans != 1`. Sit'n'stare is defined as a single,
+            continuous, non-moving-slit observation, so this code path only ever reads/writes
+            `map_scan=1` frames.
+        """
+        num_map_scans = self.constants.num_map_scans
+        if num_map_scans != 1:
+            raise ValueError(
+                f"Sit'n'stare data is expected to have exactly one map scan, but {num_map_scans = }."
+            )
+
+        num_raster_steps = self.constants.num_raster_steps
+        chunk_ranges = self.generate_sit_n_stare_chunk_ranges(
+            num_raster_steps, chunk_size=MOVIE_FRAME_WIDTH
+        )
+
+        for chunk_index, raster_step_chunk_range in enumerate(chunk_ranges, start=1):
+            logger.info(
+                f"Making and writing sit'n'stare movie frame for {chunk_index = }, "
+                f"{raster_step_chunk_range = }"
+            )
+            (
+                movie_frame_data,
+                time_obs,
+                calibrated_frame,
+            ) = self.generate_frame_from_raster_steps(
+                stokes_state="I", map_scan=1, raster_steps=raster_step_chunk_range
+            )
+            # `num_raster_steps > 1` excludes the single-raster-step-in-the-whole-dataset
+            # special case in `generate_frame_from_raster_steps`, which returns the raw
+            # spectral frame (not a per-raster-step column stack) and so isn't paddable the same
+            # way; that one frame *is* the whole movie already, regardless of its native width.
+            if num_raster_steps > 1 and len(raster_step_chunk_range) < MOVIE_FRAME_WIDTH:
+                pad_width = MOVIE_FRAME_WIDTH - len(raster_step_chunk_range)
+                logger.info(
+                    f"{chunk_index = } has only {len(raster_step_chunk_range)} raster "
+                    f"steps; padding with {pad_width} zero-filled columns to reach "
+                    f"{MOVIE_FRAME_WIDTH = }."
+                )
+                movie_frame_data = np.pad(
+                    movie_frame_data, ((0, 0), (0, pad_width)), mode="constant"
+                )
+            header = self.build_movie_frame_header(
+                calibrated_frame=calibrated_frame,
+                time_obs=time_obs,
+            )
+            self.write_movie_frame(
+                movie_frame_data=movie_frame_data, header=header, index=chunk_index
+            )
+
+    def make_map_scan_movie_frames(self) -> None:
+        """
+        For each map scan, build one movie frame from all its raster steps, for each stokes state.
+
+        For each map scan:
+
+        #. For each stokes state present in the data:
+
+           #. Integrate each raster step in the scan over wavelength into a single column of
+              pixels
+           #. Build a movie frame by lining the columns up side by side
+
+        #. Combine stokes frames (normalizing across intensities if polarimetric)
+        #. Write the frame as a "MOVIE_FRAME", tagged by map scan number
+        """
+        stokes_states = ["I", "Q", "U", "V"]
+        # Loop over the number of raster scans
+        for map_scan in range(1, self.constants.num_map_scans + 1):
+            logger.info(f"Making movie frame for {map_scan = }")
+            stokes_frames = dict()
+            time_obs = []
+
+            # Loop over the stokes states to add them to the frame array
+            for stokes_state in stokes_states:
+                num_stokes_frames = self.count(
+                    tags=[
+                        VispTag.frame(),
+                        VispTag.calibrated(),
+                        VispTag.stokes(stokes_state),
+                    ]
+                )
+                if num_stokes_frames > 0:
+                    (
+                        stokes_frames[stokes_state],
+                        step_time_obs,
+                        calibrated_frame,
+                    ) = self.generate_frame_from_raster_steps(
+                        stokes_state=stokes_state,
+                        map_scan=map_scan,
+                        raster_steps=range(0, self.constants.num_raster_steps),
+                    )
+                    time_obs += step_time_obs
+
+            header = self.build_movie_frame_header(
+                calibrated_frame=calibrated_frame,
+                time_obs=time_obs,
+            )
+            movie_frame_data = self.combine_stokes_frames(
+                stokes_frames, self.constants.correct_for_polarization
+            )
+
+            logger.info(f"Writing movie frame for {map_scan = }")
+            self.write_movie_frame(movie_frame_data=movie_frame_data, header=header, index=map_scan)
+
+    def read_calibrated_frame(
+        self, *, stokes_state: str, map_scan: int, raster_step: int
+    ) -> VispL1FitsAccess:
+        """Read a single calibrated frame for the given stokes state, map scan, and raster step."""
+        return next(
+            self.read(
+                tags=[
+                    VispTag.frame(),
+                    VispTag.calibrated(),
+                    VispTag.stokes(stokes_state),
+                    VispTag.map_scan(map_scan),
+                    VispTag.raster_step(raster_step),
+                ],
+                decoder=fits_access_decoder,
+                fits_access_class=VispL1FitsAccess,
+            )
+        )
+
+    def generate_frame_from_raster_steps(
+        self, *, stokes_state: str, map_scan: int, raster_steps: range
+    ) -> tuple[np.ndarray, list[str], VispL1FitsAccess]:
+        """
+        Read and wavelength-integrate each raster step into a column, lining columns up side by side.
+
+        This is the piece of logic shared by both movie-frame code paths; only the `raster_steps`
+        being looped over (and whether this is called once per stokes state or just once for "I")
+        differs between them.
+
+        Parameters
+        ----------
+        stokes_state
+            Which stokes state to read ("I", "Q", "U", or "V")
+
+        map_scan
+            The map scan number to read frames from. Always `1` for the sit'n'stare path, since
+            that mode is defined as a single map scan.
+
+        raster_steps
+            The raster steps (in time order) to line up side-by-side into the frame. This is the
+            full `range(0, num_raster_steps)` for the per-map-scan path, or a single
+            `generate_sit_n_stare_chunk_ranges` window for the sit'n'stare path.
+
+        Returns
+        -------
+        The assembled 2D frame data (shape `(spectral_size, len(raster_steps))`, unless there's only a single raster step in the *entire dataset*, in which case the raw spectral frame is returned instead)
+
+        The list of time_obs values seen, in raster-step order
+
+        The `FitsAccess` object for the last-read raster step, used for movie-frame metadata
+        """
+        time_obs = []
+        frame_data = None
+
+        for i, raster_step in enumerate(raster_steps):
+            calibrated_frame = self.read_calibrated_frame(
+                stokes_state=stokes_state, map_scan=map_scan, raster_step=raster_step
+            )
+            data = np.nan_to_num(calibrated_frame.data, nan=0)
+            time_obs.append(calibrated_frame.time_obs)
+
+            if self.constants.num_raster_steps == 1:
+                logger.info("Only a single raster step found. Making a spectral movie.")
+                frame_data = data
+            else:
+                wavelength_integrated_data = np.sum(np.abs(data), axis=0)
+                if frame_data is None:
+                    frame_data = np.empty((wavelength_integrated_data.shape[0], len(raster_steps)))
+                frame_data[:, i] = wavelength_integrated_data
+
+        return frame_data, time_obs, calibrated_frame
+
+    def build_movie_frame_header(
+        self,
+        *,
+        calibrated_frame: VispL1FitsAccess,
+        time_obs: list[str],
+    ) -> fits.Header:
+        """Build the header for a movie frame, updating `time_obs` to the start time of the raster scan."""
+        # Use the most recently read header as the base header because we need to be able to read it
+        # with VispL1FitsAccess.
+        header = fits.Header(calibrated_frame.header)
+        # The timestamp of a movie frame will be the time of raster scan start
+        header[MetadataKey.time_obs] = time_obs[0]
+        return header
+
+    @staticmethod
+    def combine_stokes_frames(
+        stokes_frames: dict[str, np.ndarray], is_polarized: bool
+    ) -> np.ndarray:
+        """Combine per-stokes frame data into the final movie frame, normalizing if polarimetric."""
+        if is_polarized:
+            i_norm = ZScaleInterval()(stokes_frames["I"])
+            q_norm = ZScaleInterval()(stokes_frames["Q"])
+            u_norm = ZScaleInterval()(stokes_frames["U"])
+            v_norm = ZScaleInterval()(stokes_frames["V"])
+            return np.concatenate(
+                (
+                    np.concatenate((i_norm, q_norm), axis=1),
+                    np.concatenate((u_norm, v_norm), axis=1),
+                ),
+                axis=0,
+            )
+        return stokes_frames["I"]
+
+    def write_movie_frame(
+        self, *, movie_frame_data: np.ndarray, header: fits.Header, index: int
+    ) -> None:
+        """
+        Write a single movie frame to disk, tagged with VispTag.movie_frame().
+
+        Parameters
+        ----------
+        movie_frame_data
+            The 2D frame array to write
+
+        header
+            The header to write alongside the frame
+
+        index
+            The sequential index used to tag the frame (reusing the `map_scan` tag stem). For the
+            map-scan path this is the real map scan number. For the sit'n'stare path this is the
+            1-indexed chunk number - *not* a real map scan number, since sit'n'stare data always
+            has exactly one.
+        """
+        self.write(
+            data=movie_frame_data,
+            tags=[
+                VispTag.map_scan(index),
+                VispTag.movie_frame(),
+            ],
+            encoder=fits_array_encoder,
+            header=header,
+        )

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/tasks/parse.py

@@ -90,6 +90,11 @@ class ParseL0VispInputData(ParseL0InputDataBase):
             TotalRasterStepsBud(),
             NumCSStepBud(max_cs_step_time_sec=self.parameters.max_cs_step_time_sec),
             NumFramesPerCSStepBud(max_cs_step_time_sec=self.parameters.max_cs_step_time_sec),
+            TaskUniqueBud(
+                constant_name=VispBudName.slit_velocity_mm_per_s.value,
+                metadata_key=VispMetadataKey.slit_velocity_mm_per_s,
+                ip_task_types=TaskName.observe.value,
+            ),
             ObsIpStartTimeBud(),
             NumberModulatorStatesBud(),
             ObserveWavelengthBud(),

{dkist_processing_visp-5.8.1 → dkist_processing_visp-5.8.2}/dkist_processing_visp/tests/conftest.py

@@ -20,6 +20,7 @@ from dkist_header_validator.translator import translate_spec122_to_spec214_l0
 from dkist_processing_common.codecs.basemodel import basemodel_encoder
 from dkist_processing_common.codecs.fits import fits_array_encoder
 from dkist_processing_common.codecs.fits import fits_hdulist_encoder
+from dkist_processing_common.models.fits_access import HEADER_KEY_NOT_FOUND
 from dkist_processing_common.models.input_dataset import InputDatasetPartDocumentList
 from dkist_processing_common.tasks import WorkflowTaskBase
 
@@ -53,6 +54,11 @@ def init_visp_constants_db():
 class VispConstantsDb:
     ARM_ID: int = 1
     POLARIMETER_MODE: str = "observe_polarimetric"
+    # Real polarimetric data never has this header key at all; every other default in this
+    # dataclass already models a non-sit'n'stare dataset, so this sentinel default is consistent
+    # with that: `VispConstants.is_sit_n_stare` is False regardless of this value whenever
+    # POLARIMETER_MODE isn't "observe_intensity".
+    SLIT_VELOCITY_MM_PER_S: float | str = HEADER_KEY_NOT_FOUND
     OBS_IP_START_TIME: str = "2022-11-28T13:54:00"
     NUM_MODSTATES: int = 10
     NUM_MAP_SCANS: int = 2
@@ -712,6 +718,7 @@ def write_calibrated_frames_to_task(
     wcs_axis_names: tuple[str, str] = ("HPLT-TAN", "AWAV"),
     num_maps: int = 1,
     num_steps: int = 1,
+    slit_velocity_mm_per_s: float = 1.5,
 ):
     array_shape = (1, *data_shape)
     dataset = VispHeadersValidCalibratedFrames(
@@ -721,6 +728,7 @@ def write_calibrated_frames_to_task(
         num_raster_steps=num_steps,
         polarimeter_mode=pol_mode,
         wcs_axis_names=wcs_axis_names,
+        slit_velocity_mm_per_s=slit_velocity_mm_per_s,
     )
 
     num_written_frames = write_frames_to_task(