dkist-processing-visp 5.6.4__tar.gz → 5.6.5__tar.gz

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/.readthedocs.yml

@@ -1,6 +1,6 @@
 version: 2
 build:
-  os: ubuntu-20.04
+  os: ubuntu-24.04
   tools:
     python: "3.13"
   apt_packages:

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/CHANGELOG.rst

@@ -1,3 +1,19 @@
+v5.6.5 (2026-04-16)
+===================
+
+Misc
+----
+
+- Update test demodulation matrices to have a gradient. (`#281 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/281>`__)
+- Configure pyproject.toml to turn warnings raised during testing into errors.
+  Ignore certain testing warnings that we know are okay. (`#281 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/281>`__)
+- Remove CompImageHeader tests due to Astropy deprecation. (`#281 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/281>`__)
+- Convert fits.open usage in tests to context managers. (`#281 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/281>`__)
+- Replace VispHeadersInputPolcalFrame, VispHeadersInputPolcalDarkFrames, and VispHeadersInputPolcalGainFrames with VispHeadersValidPolcalFrames which makes a completely valid Calibration Sequence (i.e., with darks, clears, etc.).
+  Refactor test POLCAL frame generation to correctly tag with cs_step. (`#281 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/281>`__)
+- Upgrade Read the Docs LTS build image to Ubuntu 24.04. (`#300 <https://bitbucket.org/dkistdc/dkist-processing-visp/pull-requests/300>`__)
+
+
 v5.6.4 (2026-04-14)
 ===================
 

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-visp
-Version: 5.6.4
+Version: 5.6.5
 Summary: Science processing code for the ViSP instrument on DKIST
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -13,12 +13,12 @@ Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.13
 Requires-Python: >=3.13
 Description-Content-Type: text/x-rst
-Requires-Dist: dkist-processing-common==13.0.3
+Requires-Dist: dkist-processing-common==13.0.4
 Requires-Dist: dkist-processing-math==2.2.1
 Requires-Dist: dkist-processing-pac==3.1.1
 Requires-Dist: dkist-header-validator==5.3.0
 Requires-Dist: dkist-fits-specifications==4.24.0
-Requires-Dist: solar-wavelength-calibration==2.0.1
+Requires-Dist: solar-wavelength-calibration==2.0.3
 Requires-Dist: dkist-service-configuration==4.3.0
 Requires-Dist: dkist-spectral-lines==3.0.0
 Requires-Dist: astropy==7.0.2
@@ -111,8 +111,8 @@ Requires-Dist: asyncpg==0.31.0; extra == "frozen"
 Requires-Dist: attrs==26.1.0; extra == "frozen"
 Requires-Dist: babel==2.18.0; extra == "frozen"
 Requires-Dist: billiard==4.2.4; extra == "frozen"
-Requires-Dist: boto3==1.42.89; extra == "frozen"
-Requires-Dist: botocore==1.42.89; extra == "frozen"
+Requires-Dist: boto3==1.42.90; extra == "frozen"
+Requires-Dist: botocore==1.42.90; extra == "frozen"
 Requires-Dist: cadwyn==5.4.6; extra == "frozen"
 Requires-Dist: celery==5.6.3; extra == "frozen"
 Requires-Dist: certifi==2026.2.25; extra == "frozen"
@@ -132,11 +132,11 @@ Requires-Dist: dacite==1.9.2; extra == "frozen"
 Requires-Dist: decorator==5.2.1; extra == "frozen"
 Requires-Dist: dill==0.4.1; extra == "frozen"
 Requires-Dist: dkist-header-validator==5.3.0; extra == "frozen"
-Requires-Dist: dkist-processing-common==13.0.3; extra == "frozen"
-Requires-Dist: dkist-processing-core==7.1.0; extra == "frozen"
+Requires-Dist: dkist-processing-common==13.0.4; extra == "frozen"
+Requires-Dist: dkist-processing-core==7.2.1; extra == "frozen"
 Requires-Dist: dkist-processing-math==2.2.1; extra == "frozen"
 Requires-Dist: dkist-processing-pac==3.1.1; extra == "frozen"
-Requires-Dist: dkist-processing-visp==5.6.4; extra == "frozen"
+Requires-Dist: dkist-processing-visp==5.6.5; extra == "frozen"
 Requires-Dist: dkist-service-configuration==4.3.0; extra == "frozen"
 Requires-Dist: dkist-spectral-lines==3.0.0; extra == "frozen"
 Requires-Dist: dkist_fits_specifications==4.24.0; extra == "frozen"
@@ -235,9 +235,9 @@ Requires-Dist: protobuf==6.33.6; extra == "frozen"
 Requires-Dist: psutil==7.2.2; extra == "frozen"
 Requires-Dist: psycopg2-binary==2.9.11; extra == "frozen"
 Requires-Dist: pycparser==3.0; extra == "frozen"
-Requires-Dist: pydantic==2.13.0; extra == "frozen"
+Requires-Dist: pydantic==2.13.1; extra == "frozen"
 Requires-Dist: pydantic-settings==2.13.1; extra == "frozen"
-Requires-Dist: pydantic_core==2.46.0; extra == "frozen"
+Requires-Dist: pydantic_core==2.46.1; extra == "frozen"
 Requires-Dist: pyerfa==2.0.1.5; extra == "frozen"
 Requires-Dist: pygtrie==2.5.0; extra == "frozen"
 Requires-Dist: pyparsing==3.3.2; extra == "frozen"
@@ -263,7 +263,7 @@ Requires-Dist: setproctitle==1.3.7; extra == "frozen"
 Requires-Dist: shellingham==1.5.4; extra == "frozen"
 Requires-Dist: six==1.17.0; extra == "frozen"
 Requires-Dist: sniffio==1.3.1; extra == "frozen"
-Requires-Dist: solar-wavelength-calibration==2.0.1; extra == "frozen"
+Requires-Dist: solar-wavelength-calibration==2.0.3; extra == "frozen"
 Requires-Dist: sqids==0.5.1; extra == "frozen"
 Requires-Dist: sqlparse==0.5.5; extra == "frozen"
 Requires-Dist: starlette==0.48.0; extra == "frozen"

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/dkist_processing_visp/tests/conftest.py

@@ -3,14 +3,17 @@ from dataclasses import asdict
 from dataclasses import dataclass
 from dataclasses import field
 from dataclasses import is_dataclass
+from functools import partial
 from random import randint
 from typing import Any
 from typing import Callable
 from typing import Type
 
+import astropy.units as u
 import numpy as np
 import pytest
 from astropy.io import fits
+from astropy.time import Time
 from dkist_data_simulator.spec122 import Spec122Dataset
 from dkist_header_validator.translator import sanitize_to_spec214_level1
 from dkist_header_validator.translator import translate_spec122_to_spec214_l0
@@ -28,6 +31,7 @@ from solar_wavelength_calibration import DownloadConfig
 from dkist_processing_visp.models.constants import VispConstants
 from dkist_processing_visp.models.parameters import VispParameters
 from dkist_processing_visp.models.tags import VispTag
+from dkist_processing_visp.tests.header_models import VispCSStepPolcalFrames
 from dkist_processing_visp.tests.header_models import VispHeaders
 from dkist_processing_visp.tests.header_models import VispHeadersValidCalibratedFrames
 
@@ -375,6 +379,31 @@ def make_random_data(frame: Spec122Dataset) -> np.ndarray:
     return data
 
 
+@dataclass
+class CalibrationSequence:
+    pol_status: tuple = (
+        "clear",
+        "clear",
+        "Sapphire Polarizer",
+        "Sapphire Polarizer",
+        "Sapphire Polarizer",
+        "clear",
+        "clear",
+    )
+    pol_theta: tuple = (0.0, 0.0, 60.0, 0.0, 120.0, 0.0, 0.0)
+    ret_status: tuple = ("clear", "clear", "clear", "SiO2 OC", "clear", "clear", "clear")
+    ret_theta: tuple = (0.0, 0.0, 0.0, 45.0, 0.0, 0.0, 0.0)
+    dark_status: tuple = (
+        "DarkShutter",
+        "FieldStop (5arcmin)",
+        "FieldStop (5arcmin)",
+        "FieldStop (5arcmin)",
+        "FieldStop (5arcmin)",
+        "FieldStop (5arcmin)",
+        "DarkShutter",
+    )
+
+
 def tag_on_modstate(frame: VispHeaders) -> list[str]:
     """Tage a given frame based on its current modstate value."""
     modstate = frame.current_modstate(
@@ -571,33 +600,99 @@ def write_intermediate_solar_cals_to_task(
         )
 
 
-def write_intermediate_polcal_darks_to_task(
-    task, *, dark_signal: float, readout_exp_time: float, data_shape: tuple[int, int]
+def make_cs_data(
+    frame: VispCSStepPolcalFrames, dark_signal: float, clear_signal: float
+) -> np.ndarray:
+    shape = frame.array_shape[1:]
+    ny, nx = shape
+
+    y = np.linspace(0.0, 1.0, ny)[:, None]
+    x = np.linspace(0.0, 1.0, nx)[None, :]
+
+    modstate = frame.current_modstate("dummy_arg")
+    cs_step = frame.current_cs_step
+
+    gradient = 1.0 + 0.03 * x + 0.02 * y
+
+    if frame.pol_status == "clear" and frame.ret_status == "clear":
+        if frame.dark_status == "DarkShutter":
+            data = np.random.random(shape) + dark_signal
+        else:
+            data = clear_signal * gradient + dark_signal
+    else:
+        data = clear_signal * (1.0 + 0.2 * cs_step + 0.1 * modstate) * gradient + dark_signal
+    return data
+
+
+def write_calibration_sequence_frames_to_task(
+    task,
+    num_modstates: int,
+    pol_status: tuple[str, ...],
+    pol_theta: tuple[float, ...],
+    ret_status: tuple[str, ...],
+    ret_theta: tuple[float, ...],
+    dark_status: tuple[str, ...],
+    exp_time: float = 7.0,
+    dark_signal: float = 5.0,
+    clear_signal: float = 10.0,
+    data_shape: tuple[int, ...] = (10, 10),
+    num_frames_per_cs_step: int = 1,
+    tags: list[str] | None = None,
+    tag_func: Callable = tag_on_modstate,
+    no_additional_tags: bool = False,
+    **kwargs,
 ):
-    dark_cal = np.ones(data_shape) * dark_signal
-    # Need a dark for each beam
-    for beam in [1, 2]:
-        task.write(
-            data=dark_cal,
-            tags=VispTag.intermediate_frame_polcal_dark(
-                beam=beam, readout_exp_time=readout_exp_time
-            ),
-            encoder=fits_array_encoder,
+    array_shape = (1, *data_shape)
+    data_func = partial(make_cs_data, dark_signal=dark_signal, clear_signal=clear_signal)
+
+    base_time = Time("2023-01-01T01:23:45")
+
+    for step, (pol_s, pol_t, ret_s, ret_t, dark_s) in enumerate(
+        zip(pol_status, pol_theta, ret_status, ret_theta, dark_status)
+    ):
+
+        step_start = (base_time + (step * 60) * u.s).fits
+
+        dataset = VispCSStepPolcalFrames(
+            num_modstates=num_modstates,
+            pol_status=pol_s,
+            pol_theta=pol_t,
+            ret_status=ret_s,
+            dark_status=dark_s,
+            cs_step_num=step,
+            ret_theta=ret_t,
+            array_shape=array_shape,
+            exp_time=exp_time,
+            ip_start_time=step_start,
+            num_frames_per_cs_step=num_frames_per_cs_step,
+            **kwargs,
         )
 
+        if no_additional_tags:
+            step_tags = tags
+        else:
+            step_tags = list(
+                set(
+                    tags
+                    + [
+                        VispTag.cs_step(step),
+                        VispTag.task_polcal(),
+                    ]
+                )
+            )
 
-def write_intermediate_polcal_gains_to_task(
-    task, *, gain_signal: float, readout_exp_time: float, data_shape: tuple[int, int]
-):
-    gain_cal = np.ones(data_shape) * gain_signal
-    # Need a dark for each beam
-    for beam in [1, 2]:
-        task.write(
-            data=gain_cal,
-            tags=VispTag.intermediate_frame_polcal_gain(
-                beam=beam, readout_exp_time=readout_exp_time
-            ),
-            encoder=fits_array_encoder,
+            if pol_s == "clear" and ret_s == "clear":
+                if dark_s == "DarkShutter":
+                    step_tags += [VispTag.task_polcal_dark()]
+                else:
+                    step_tags += [VispTag.task_polcal_gain()]
+
+        write_frames_to_task(
+            task=task,
+            frame_generator=dataset,
+            data_func=data_func,
+            extra_tags=step_tags,
+            tag_func=tag_func,
         )
 
 

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/dkist_processing_visp/tests/header_models.py

@@ -11,8 +11,6 @@ actually control the output of the generators themselves.
 
 import uuid
 from itertools import product
-from random import choice
-from random import random
 from random import randrange
 from typing import Literal
 
@@ -246,48 +244,53 @@ class VispHeadersInputSolarGainFrames(VispHeaders):
         return self.index + 1
 
 
-class VispHeadersInputPolcalFrames(VispHeaders):
+class VispCSStepPolcalFrames(VispHeaders):
     def __init__(
         self,
-        array_shape: tuple[int, ...],
-        time_delta: float,
         num_modstates: int,
-        num_cs_steps: int = 1,
-        num_frames_per_cs_step: int = 1,
+        pol_status: str,
+        pol_theta: float,
+        ret_status: str,
+        ret_theta: float,
+        dark_status: str,
+        cs_step_num: int,
+        array_shape: tuple[int, ...],
         exp_time: float = 0.01,
+        num_cs_steps: int = 1,
         readout_exp_time: float = 0.02,
         ip_start_time="2022-11-28T13:50:00",
         ip_end_time="2022-11-28T13:51:00",
+        num_frames_per_cs_step: int = 1,
         **kwargs,
     ):
         ################################################
         # See module docstring and README for usage info
         ################################################
+
         num_frames = num_modstates * num_cs_steps * num_frames_per_cs_step
         dataset_shape = (num_frames, *array_shape[-2:])
+        indices = list(product(range(1, num_modstates + 1), range(num_frames_per_cs_step)))
+
         super().__init__(
             dataset_shape,
             array_shape,
-            time_delta,
             num_modstates_header_value=num_modstates,
             ip_start_time=ip_start_time,
             ip_end_time=ip_end_time,
             **kwargs,
         )
-        indices = list(
-            product(
-                range(num_cs_steps),
-                range(1, num_modstates + 1),
-                range(num_frames_per_cs_step),
-            )
-        )
 
-        self.index_to_cs_step = [cs for (cs, _, _) in indices]
-        self.index_to_modstate = [ms for (_, ms, _) in indices]
-        self.index_to_cs_step_frame = [csf for (_, _, csf) in indices]
+        self.index_to_modstate = [ms for (ms, _) in indices]
+        self.index_to_cs_step_frame = [csf for (_, csf) in indices]
 
-        self.polarizer_choices = ["Sapphire Polarizer", "clear"]
-        self.retarder_choices = ["SiO2 OC", "clear"]
+        self.cs_step_num = (
+            cs_step_num  # This doesn't become a header key, but helps with making fake data
+        )
+        self.pol_status = pol_status
+        self.pol_theta = pol_theta
+        self.ret_status = ret_status
+        self.ret_theta = ret_theta
+        self.dark_status = dark_status
 
         self.add_constant_key("DKIST004", TaskName.polcal.value.lower())
         self.add_constant_key("DKIST008", 1)
@@ -296,24 +299,24 @@ class VispHeadersInputPolcalFrames(VispHeaders):
         self.add_constant_key("VISP_020", 1)
         self.add_constant_key("TELSCAN", "Raster")
         self.add_constant_key("ID___004")
-        self.add_constant_key("PAC__004", "Sapphire Polarizer")
-        self.add_constant_key("PAC__005", "60.")
-        self.add_constant_key("PAC__007", "0.0")
-        self.add_constant_key("PAC__008", "FieldStop (5arcmin)")
+        self.add_constant_key("PAC__004", pol_status)
+        self.add_constant_key("PAC__006", ret_status)
+        self.add_constant_key("PAC__008", dark_status)
         self.add_constant_key("CAM__004", exp_time)
         self.add_constant_key("CAM__005", readout_exp_time)
         self.add_constant_key("CAM__014", 10)
 
-    @key_function("PAC__006")
-    def retarder_name(self, key: str) -> str:
-        if self.index % 2:
-            return self.retarder_choices[1]
-        return self.retarder_choices[0]
+    @key_function("PAC__005")
+    def polarizer_angle(self, key: str) -> float | str:
+        return "none" if self.pol_status == "clear" else self.pol_theta
+
+    @key_function("PAC__007")
+    def retarder_angle(self, key: str) -> float | str:
+        return "none" if self.ret_status == "clear" else self.ret_theta
 
     @property
     def current_cs_step(self) -> int:
-        # There is no header value for CS step; this property is used to help data generator fixtures with tagging
-        return self.index_to_cs_step[self.index]
+        return self.cs_step_num
 
     @property
     def current_cs_step_frame(self) -> int:
@@ -324,96 +327,6 @@ class VispHeadersInputPolcalFrames(VispHeaders):
     def current_modstate(self, key: str) -> int:
         return self.index_to_modstate[self.index]
 
-    @key_function("PAC__004")
-    def polarizer(self, key: str) -> str:
-        return choice(self.polarizer_choices)
-
-    @key_function("PAC__005")
-    def pol_angle(self, key: str) -> float:
-        return random() * 120.0
-
-    @key_function("PAC__007")
-    def ret_angle(self, key: str) -> float:
-        return random() * 120.0
-
-
-class VispHeadersInputPolcalDarkFrames(VispHeaders):
-    def __init__(
-        self,
-        array_shape: tuple[int, ...],
-        time_delta: float,
-        num_modstates: int,
-        exp_time: float = 0.01,
-        readout_exp_time: float = 0.02,
-        ip_start_time="2022-11-28T13:50:00",
-        ip_end_time="2022-11-28T13:51:00",
-        **kwargs,
-    ):
-        num_frames = num_modstates
-        dataset_shape = (num_frames, *array_shape[-2:])
-        super().__init__(
-            dataset_shape,
-            array_shape,
-            time_delta,
-            ip_start_time=ip_start_time,
-            ip_end_time=ip_end_time,
-            **kwargs,
-        )
-        self.add_constant_key("DKIST004", TaskName.polcal.value.lower())
-        self.add_constant_key("DKIST008", 1)
-        self.add_constant_key("DKIST009", 1)
-        self.add_constant_key("VISP_019", 1)
-        self.add_constant_key("VISP_020", 1)
-        self.add_constant_key("TELSCAN", "Raster")
-        self.add_constant_key("ID___004")
-        self.add_constant_key("PAC__004", "clear")
-        self.add_constant_key("PAC__005", "60.")
-        self.add_constant_key("PAC__006", "clear")
-        self.add_constant_key("PAC__007", "0.0")
-        self.add_constant_key("PAC__008", "DarkShutter")
-        self.add_constant_key("CAM__004", exp_time)
-        self.add_constant_key("CAM__005", readout_exp_time)
-        self.add_constant_key("CAM__014", 10)
-
-
-class VispHeadersInputPolcalGainFrames(VispHeaders):
-    def __init__(
-        self,
-        array_shape: tuple[int, ...],
-        time_delta: float,
-        num_modstates: int,
-        exp_time: float = 0.01,
-        readout_exp_time: float = 0.02,
-        ip_start_time="2022-11-28T13:50:00",
-        ip_end_time="2022-11-28T13:51:00",
-        **kwargs,
-    ):
-        num_frames = num_modstates
-        dataset_shape = (num_frames, *array_shape[-2:])
-        super().__init__(
-            dataset_shape,
-            array_shape,
-            time_delta,
-            ip_start_time=ip_start_time,
-            ip_end_time=ip_end_time,
-            **kwargs,
-        )
-        self.add_constant_key("DKIST004", TaskName.polcal.value.lower())
-        self.add_constant_key("DKIST008", 1)
-        self.add_constant_key("DKIST009", 1)
-        self.add_constant_key("VISP_019", 1)
-        self.add_constant_key("VISP_020", 1)
-        self.add_constant_key("TELSCAN", "Raster")
-        self.add_constant_key("ID___004")
-        self.add_constant_key("PAC__004", "clear")
-        self.add_constant_key("PAC__005", "60.")
-        self.add_constant_key("PAC__006", "clear")
-        self.add_constant_key("PAC__007", "0.0")
-        self.add_constant_key("PAC__008", "FieldStop (5arcmin)")
-        self.add_constant_key("CAM__004", exp_time)
-        self.add_constant_key("CAM__005", readout_exp_time)
-        self.add_constant_key("CAM__014", 10)
-
 
 class VispHeadersValidObserveFrames(VispHeaders):
     def __init__(

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/dkist_processing_visp/tests/local_trial_workflows/l0_polcals_as_science.py

@@ -161,13 +161,12 @@ class TagPolcalAsScience(VispTaskBase):
                     self.scratch._tag_db.clear_value(file_name)
                     logging.info(f"\tafter removing, the tags are {self.tags(file_name)}")
 
-                    hdul = fits.open(file_name, mode="update")
-                    idx = 0
-                    if hdul[idx].data is None:
-                        idx = 1
-                    hdul[idx].header[VispMetadataKey.raster_scan_step] = raster_step
-                    hdul.flush()
-                    del hdul
+                    with fits.open(file_name, mode="update") as hdul:
+                        idx = 0
+                        if hdul[idx].data is None:
+                            idx = 1
+                        hdul[idx].header[VispMetadataKey.raster_scan_step] = raster_step
+                        hdul.flush()
 
                     new_tags = [
                         VispTag.task_observe(),

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/dkist_processing_visp/tests/local_trial_workflows/local_trial_helpers.py

@@ -600,21 +600,18 @@ def translate_122_to_214l0_task(suffix: str):
                     file
                 )
                 logger.info(f"Translating {file} -> {translated_file_name}")
-                hdl = fits.open(file)
-                i = 0
-                if hdl[i].data is None:
-                    i = 1
-
-                header = spec122_validator.validate_and_translate_to_214_l0(
-                    hdl[i].header, return_type=fits.HDUList
-                )[0].header
-
-                comp_hdu = fits.CompImageHDU(header=header, data=hdl[i].data)
-                comp_hdl = fits.HDUList([fits.PrimaryHDU(), comp_hdu])
-                comp_hdl.writeto(translated_file_name, overwrite=True)
-
-                hdl.close()
-                del hdl
+                with fits.open(file, memmap=False) as hdl:
+                    i = 0
+                    if hdl[i].data is None:
+                        i = 1
+
+                    header = spec122_validator.validate_and_translate_to_214_l0(
+                        hdl[i].header, return_type=fits.HDUList
+                    )[0].header
+
+                    comp_hdu = fits.CompImageHDU(header=header, data=hdl[i].data)
+                    comp_hdl = fits.HDUList([fits.PrimaryHDU(), comp_hdu])
+                    comp_hdl.writeto(translated_file_name, overwrite=True)
                 comp_hdl.close()
                 del comp_hdl
 
@@ -648,9 +645,9 @@ class TagSingleSolarGainAsScience(VispTaskBase):
             VispTag.task_solar_gain(),
         ]
         file_list = list(self.read(tags=tags))
-        first_hdul = fits.open(file_list[0])
-        idx = 1 if first_hdul[0].data is None else 0
-        first_header = first_hdul[idx].header
+        with fits.open(file_list[0]) as first_hdul:
+            idx = 1 if first_hdul[0].data is None else 0
+            first_header = first_hdul[idx].header
         logger.info(f"Averaging {len(file_list)} files")
         arrays = self.read(tags=tags, decoder=fits_array_decoder)
         avg_array = average_numpy_arrays(arrays=arrays)
@@ -699,9 +696,9 @@ class TagModulatedSolarGainsAsScience(VispTaskBase):
                 VispTag.modstate(modstate),
             ]
             file_list = list(self.read(tags=tags))
-            first_hdul = fits.open(file_list[0])
-            idx = 1 if first_hdul[0].data is None else 0
-            first_header = first_hdul[idx].header
+            with fits.open(file_list[0]) as first_hdul:
+                idx = 1 if first_hdul[0].data is None else 0
+                first_header = first_hdul[idx].header
             logger.info(f"Averaging {len(file_list)} files")
             arrays = self.read(tags=tags, decoder=fits_array_decoder)
             avg_array = average_numpy_arrays(arrays=arrays)

{dkist_processing_visp-5.6.4 → dkist_processing_visp-5.6.5}/dkist_processing_visp/tests/test_dark.py

@@ -143,9 +143,8 @@ def test_dark_calibration_task(
             )
             assert len(files) == 1
             expected = np.ones((data_shape[0] // 2, data_shape[1])) * (b + 1) * e / n
-            hdul = fits.open(files[0])
-            np.testing.assert_allclose(expected, hdul[0].data, rtol=1e-15)
-            hdul.close()
+            with fits.open(files[0], memmap=False) as hdul:
+                np.testing.assert_allclose(expected, hdul[0].data, rtol=1e-15)
 
     unused_time_read = task.read(
         tags=[