dkist-processing-common 14.9.1rc1__tar.gz → 14.9.2__tar.gz
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.pre-commit-config.yaml +4 -4
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.rovodev/.review-agent.md +78 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.snyk +15 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/CHANGELOG.rst +25 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/PKG-INFO +3 -3
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/README.rst +1 -1
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/PKG-INFO +3 -3
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/SOURCES.txt +0 -3
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/requires.txt +1 -1
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/scm_file_list.json +0 -3
- dkist_processing_common-14.9.2/dkist_processing_common.egg-info/scm_version.json +8 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/pyproject.toml +1 -1
- dkist_processing_common-14.9.1rc1/changelog/358.misc.rst +0 -1
- dkist_processing_common-14.9.1rc1/changelog/363.feature.rst +0 -1
- dkist_processing_common-14.9.1rc1/changelog/363.misc.rst +0 -1
- dkist_processing_common-14.9.1rc1/dkist_processing_common.egg-info/scm_version.json +0 -8
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.gitignore +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.readthedocs.yml +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/bitbucket-pipelines.yml +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/changelog/.gitempty +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/_util/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/_util/constants.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/_util/graphql.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/_util/scratch.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/_util/tags.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/array.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/asdf.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/basemodel.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/bytes.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/fits.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/iobase.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/json.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/path.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/codecs/str.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/config.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/fonts/Lato-Regular.ttf +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/fonts/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/manual.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/constants.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/dkist_location.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/extras.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/fits_access.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/flower_pot.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/fried_parameter.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/graphql.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/input_dataset.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/message.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/message_queue_binding.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/metric_code.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/parameters.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/tags.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/task_name.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/telemetry.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/models/wavelength.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/average_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/cs_step.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/dsps_repeat.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/experiment_id_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/id_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/l0_fits_access.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/l1_fits_access.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/lookup_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/near_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/observing_program_id_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/proposal_id_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/retarder.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/single_value_single_key_flower.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/task.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/time.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/unique_bud.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/parsers/wavelength.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/assemble_movie.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/delete_input_frames.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/l1_output_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/globus.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/interservice_bus.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/metadata_store.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/object_store.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/mixin/quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/output_data_base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/parse_l0_input_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/quality_metrics.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/teardown.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/transfer_input_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/trial_catalog.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/trial_output_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/write_extra.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/write_l1.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tasks/write_l1_base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/__init__.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/conftest.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/mock_metadata_store.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_assemble_movie.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_assemble_quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_codecs.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_constants.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_construct_dataset_extras.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_cs_step.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_delete_input_frames.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_dkist_location.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_fits_access.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_flower_pot.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_fried_parameter.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_input_dataset.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_interservice_bus.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_interservice_bus_mixin.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_manual_processing.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_output_data_base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_parameters.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_parse_l0_input_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_publish_catalog_messages.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_quality.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_quality_mixin.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_scratch.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_stems.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_submit_dataset_metadata.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_tags.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_task_name.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_task_parsing.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_teardown.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_transfer_input_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_transfer_l1_output_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_trial_catalog.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_trial_output_data.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_workflow_task_base.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common/tests/test_write_l1.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/dependency_links.txt +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/dkist_processing_common.egg-info/top_level.txt +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/Makefile +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/changelog.rst +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/conf.py +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/index.rst +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/landing_page.rst +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/make.bat +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/docs/requirements.txt +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/licenses/LICENSE.rst +0 -0
- {dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/setup.cfg +0 -0
{dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.pre-commit-config.yaml
RENAMED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
# See https://pre-commit.com/hooks.html for more hooks
|
|
3
3
|
repos:
|
|
4
4
|
- repo: https://github.com/pre-commit/pre-commit-hooks
|
|
5
|
-
rev:
|
|
5
|
+
rev: v6.0.0
|
|
6
6
|
hooks:
|
|
7
7
|
- id: trailing-whitespace
|
|
8
8
|
- id: end-of-file-fixer
|
|
@@ -11,11 +11,11 @@ repos:
|
|
|
11
11
|
args: ['--maxkb=1024']
|
|
12
12
|
- id: debug-statements
|
|
13
13
|
- repo: https://github.com/psf/black
|
|
14
|
-
rev:
|
|
14
|
+
rev: 26.10.1
|
|
15
15
|
hooks:
|
|
16
16
|
- id: black
|
|
17
17
|
- repo: https://github.com/pycqa/isort
|
|
18
|
-
rev:
|
|
18
|
+
rev: 10.0.0b2
|
|
19
19
|
hooks:
|
|
20
20
|
- id: isort
|
|
21
21
|
name: isort (python)
|
|
@@ -30,7 +30,7 @@ repos:
|
|
|
30
30
|
- --convention=numpy
|
|
31
31
|
- --add-ignore=D105
|
|
32
32
|
- repo: https://bitbucket.org/dkistdc/pre-commit-hooks.git
|
|
33
|
-
rev: v1.
|
|
33
|
+
rev: v1.2.0
|
|
34
34
|
hooks:
|
|
35
35
|
- id: dkist-env-table
|
|
36
36
|
language_version: python3.13
|
{dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/.rovodev/.review-agent.md
RENAMED
|
@@ -444,6 +444,10 @@ beam_offsets = calculate_offsets(...)
|
|
|
444
444
|
- Tests assert only that code runs, without checking the meaningful output or side effect.
|
|
445
445
|
- Coverage decreases in important domain logic without explanation.
|
|
446
446
|
- Missing lines are justified only by “hard to test” when a smaller helper function would make the logic testable.
|
|
447
|
+
- For tests of mathematical or transform operations: a test asserts that new code matches old code (“before-vs-after”) rather than asserting correctness against a hand-derived expected value or domain property.
|
|
448
|
+
- For tests of mathematical or transform operations: a test verifies only internal consistency (e.g., round-tripping through the function’s own inverse) without an independently known truth to compare against.
|
|
449
|
+
- Multiple tests cover the same code path without exercising different inputs or edge cases; prefer collapsing into a single parametrized test.
|
|
450
|
+
- A test involving physical quantities (angles, shifts, wavelengths) uses floating-point inputs that make the expected output hard to verify by hand. Prefer integer shifts, 90° rotations, or other analytically tractable inputs.
|
|
447
451
|
|
|
448
452
|
**Acceptable explanation**:
|
|
449
453
|
|
|
@@ -535,3 +539,77 @@ When reporting an issue:
|
|
|
535
539
|
```text
|
|
536
540
|
This imports a concrete task from another task module. In dkist-processing-* task modules should import only from *_base modules or tasks.mixin so concrete workflow nodes do not become coupled to each other. Could this dependency move to a shared base/helper, or be expressed through the existing base class instead?
|
|
537
541
|
```
|
|
542
|
+
|
|
543
|
+
## Code Cleanliness
|
|
544
|
+
|
|
545
|
+
**Description**: New code should not introduce dead weight that accumulates technical debt.
|
|
546
|
+
|
|
547
|
+
**Flag when**:
|
|
548
|
+
|
|
549
|
+
- Commented-out code is added or left on the branch without a clear explanatory note.
|
|
550
|
+
- Unused imports are introduced.
|
|
551
|
+
- A variable is assigned but never read.
|
|
552
|
+
- A function return value is silently ignored where the return value carries meaningful state or error information.
|
|
553
|
+
- Magic numbers appear without an explanatory comment or named constant (e.g., `maxsize=3` with no comment explaining what 3 represents).
|
|
554
|
+
- An argument is accepted by a function but never used in its body.
|
|
555
|
+
|
|
556
|
+
---
|
|
557
|
+
|
|
558
|
+
## Code Consistency
|
|
559
|
+
|
|
560
|
+
**Description**: New code within a file should follow the same conventions and patterns as the surrounding existing code. When this document provides specific guidance (e.g., for logging or exception handling), that guidance takes precedence over matching existing patterns — do not ask an author to replicate a known bad pattern just for consistency.
|
|
561
|
+
|
|
562
|
+
**Flag when**:
|
|
563
|
+
|
|
564
|
+
- A new function is imported in a different style or different idiom for a common operation than the rest of the file, without a stated reason.
|
|
565
|
+
- Naming conventions differ between new and existing code in the same module (e.g., inconsistent method prefixes, docstring format, or error-handling style).
|
|
566
|
+
- A docstring format (NumPy style, one-liner, etc.) diverges from the file's existing format.
|
|
567
|
+
|
|
568
|
+
---
|
|
569
|
+
|
|
570
|
+
## API Design
|
|
571
|
+
|
|
572
|
+
**Description**: Public functions and methods should have clear, honest contracts. This is especially important in `dkist-processing-common` since its APIs are inherited and called across all instrument pipelines.
|
|
573
|
+
|
|
574
|
+
**Flag when**:
|
|
575
|
+
|
|
576
|
+
- A thin wrapper adds no validation, transformation, or abstraction over the function it calls — callers could use the underlying function directly.
|
|
577
|
+
- A default parameter value would produce silently incorrect output if the caller relies on it without thinking; prefer making the parameter required.
|
|
578
|
+
- A function returns a tuple where one element is "hidden" — not mentioned in the function name, docstring, or type annotation.
|
|
579
|
+
- A function builds a transform or intermediate structure without applying it, forcing every caller to replicate the application logic.
|
|
580
|
+
- An argument is accepted but ignored, or a return value is computed but never used.
|
|
581
|
+
|
|
582
|
+
---
|
|
583
|
+
|
|
584
|
+
## Physical Quantities and Sign Conventions
|
|
585
|
+
|
|
586
|
+
**Description**: Functions that deal with physical measurements must document units and sign conventions explicitly.
|
|
587
|
+
|
|
588
|
+
**Flag when**:
|
|
589
|
+
|
|
590
|
+
- A parameter representing a physical quantity (angle, shift, wavelength, exposure time, Fried parameter) has no documented unit in its docstring or type annotation.
|
|
591
|
+
- A sign negation occurs inside a function without an explanatory comment stating *why* the sign is flipped and what physical convention it implements.
|
|
592
|
+
- The same physical quantity uses opposite sign conventions in two parts of the codebase without cross-documentation linking the two.
|
|
593
|
+
- A unit conversion is performed without a comment identifying the source and target units.
|
|
594
|
+
|
|
595
|
+
**Good example**:
|
|
596
|
+
|
|
597
|
+
```python
|
|
598
|
+
# `-shift` is passed because `shift` is the measured offset *to correct for* —
|
|
599
|
+
# the forward correction therefore moves content by -shift.
|
|
600
|
+
yield from apply_geometric_correction(arrays, shift=-np.asarray(shift), ...)
|
|
601
|
+
```
|
|
602
|
+
|
|
603
|
+
---
|
|
604
|
+
|
|
605
|
+
## Changelog Fragments
|
|
606
|
+
|
|
607
|
+
**Description**: Changelog fragments describe user-visible changes, not implementation details.
|
|
608
|
+
|
|
609
|
+
**Flag when**:
|
|
610
|
+
|
|
611
|
+
- A fragment describes an internal refactor (e.g., "Refactored `_helper_fn` to use `ProcessPoolExecutor`") that has no visible effect on pipeline behavior, inputs, or outputs.
|
|
612
|
+
- A fragment attributes the change to the wrong function, wrong repo, or wrong abstraction level.
|
|
613
|
+
- A user-visible rename or new workflow variant is omitted or buried in a fragment about something else.
|
|
614
|
+
- Multiple user-visible changes are collapsed into one fragment when they deserve separate entries.
|
|
615
|
+
- Version numbers in dependency-bump fragments are placeholder strings (`X.Y.Z`, `TBD`) instead of the actual new version.
|
|
@@ -26,3 +26,18 @@ ignore:
|
|
|
26
26
|
- '*':
|
|
27
27
|
reason: 'Pillow upgrade blocked by version incompatibility with moviepy'
|
|
28
28
|
expires: '2027-10-20T00:00:00.000Z'
|
|
29
|
+
SNYK-PYTHON-APACHEAIRFLOWCORE-22391927:
|
|
30
|
+
- '*':
|
|
31
|
+
reason: 'Temporarily accept Airflow 3.3.1 findings while awaiting validated 3.4.1; DKIST skips Airflow .0 releases.'
|
|
32
|
+
expires: '2027-01-31T23:59:59.999Z'
|
|
33
|
+
created: '2026-11-10T18:33:08.326Z'
|
|
34
|
+
SNYK-PYTHON-APACHEAIRFLOWCORE-22392302:
|
|
35
|
+
- '*':
|
|
36
|
+
reason: 'Temporarily accept Airflow 3.3.1 findings while awaiting validated 3.4.1; DKIST skips Airflow .0 releases.'
|
|
37
|
+
expires: '2027-01-31T23:59:59.999Z'
|
|
38
|
+
created: '2026-11-10T18:33:08.326Z'
|
|
39
|
+
SNYK-PYTHON-APACHEAIRFLOWCORE-22400840:
|
|
40
|
+
- '*':
|
|
41
|
+
reason: 'Temporarily accept Airflow 3.3.1 findings while awaiting validated 3.4.1; DKIST skips Airflow .0 releases.'
|
|
42
|
+
expires: '2027-01-31T23:59:59.999Z'
|
|
43
|
+
created: '2026-11-10T18:33:08.326Z'
|
|
@@ -1,3 +1,28 @@
|
|
|
1
|
+
v14.9.2 (2026-11-13)
|
|
2
|
+
====================
|
|
3
|
+
|
|
4
|
+
Misc
|
|
5
|
+
----
|
|
6
|
+
|
|
7
|
+
- Upgrade minimum version of astropy to 8.0.2. (`#368 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/368>`__)
|
|
8
|
+
|
|
9
|
+
|
|
10
|
+
v14.9.1 (2026-11-05)
|
|
11
|
+
====================
|
|
12
|
+
|
|
13
|
+
Features
|
|
14
|
+
--------
|
|
15
|
+
|
|
16
|
+
- Add codec support for `list[BaseModel]`. (`#363 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/363>`__)
|
|
17
|
+
|
|
18
|
+
|
|
19
|
+
Misc
|
|
20
|
+
----
|
|
21
|
+
|
|
22
|
+
- Migrate `_format_warnings` from the quality mixin to the `QualityMetric` `BaseModel`. (`#358 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/358>`__)
|
|
23
|
+
- Assemble quality data as list of `QualityMetric`. (`#363 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/363>`__)
|
|
24
|
+
|
|
25
|
+
|
|
1
26
|
v14.9.0 (2026-10-27)
|
|
2
27
|
====================
|
|
3
28
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
Metadata-Version: 2.4
|
|
2
2
|
Name: dkist-processing-common
|
|
3
|
-
Version: 14.9.
|
|
3
|
+
Version: 14.9.2
|
|
4
4
|
Summary: Common task classes used by the DKIST science data processing pipelines
|
|
5
5
|
Author-email: NSO / AURA <dkistdc@nso.edu>
|
|
6
6
|
License: BSD-3-Clause
|
|
@@ -14,7 +14,7 @@ Classifier: Programming Language :: Python :: 3.13
|
|
|
14
14
|
Requires-Python: >=3.13
|
|
15
15
|
Description-Content-Type: text/x-rst
|
|
16
16
|
Requires-Dist: asdf<6.0,>=3.5.0
|
|
17
|
-
Requires-Dist: astropy>=
|
|
17
|
+
Requires-Dist: astropy>=8.0.2
|
|
18
18
|
Requires-Dist: dkist-fits-specifications<5.0,>=4.24.0
|
|
19
19
|
Requires-Dist: dkist-header-validator>=6.0.1
|
|
20
20
|
Requires-Dist: dkist-processing-core==7.5.1
|
|
@@ -234,7 +234,7 @@ To run the tests locally, clone the repository and install the package in editab
|
|
|
234
234
|
Changelog
|
|
235
235
|
#########
|
|
236
236
|
|
|
237
|
-
When you make
|
|
237
|
+
When you make a change to this repository it **MUST** be accompanied by a changelog file, **unless** the change is purely internal tooling or configuration (e.g., updates to CI config, review agent instructions, ``.snyk`` ignore files, or other files that have no effect on pipeline behavior, public API, or user-visible outputs). When in doubt, include a fragment.
|
|
238
238
|
The changelog for this repository uses the `towncrier <https://github.com/twisted/towncrier>`__ package.
|
|
239
239
|
Entries in the changelog for the next release are added as individual files (one per change) to the ``changelog/`` directory.
|
|
240
240
|
|
|
@@ -169,7 +169,7 @@ To run the tests locally, clone the repository and install the package in editab
|
|
|
169
169
|
Changelog
|
|
170
170
|
#########
|
|
171
171
|
|
|
172
|
-
When you make
|
|
172
|
+
When you make a change to this repository it **MUST** be accompanied by a changelog file, **unless** the change is purely internal tooling or configuration (e.g., updates to CI config, review agent instructions, ``.snyk`` ignore files, or other files that have no effect on pipeline behavior, public API, or user-visible outputs). When in doubt, include a fragment.
|
|
173
173
|
The changelog for this repository uses the `towncrier <https://github.com/twisted/towncrier>`__ package.
|
|
174
174
|
Entries in the changelog for the next release are added as individual files (one per change) to the ``changelog/`` directory.
|
|
175
175
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
Metadata-Version: 2.4
|
|
2
2
|
Name: dkist-processing-common
|
|
3
|
-
Version: 14.9.
|
|
3
|
+
Version: 14.9.2
|
|
4
4
|
Summary: Common task classes used by the DKIST science data processing pipelines
|
|
5
5
|
Author-email: NSO / AURA <dkistdc@nso.edu>
|
|
6
6
|
License: BSD-3-Clause
|
|
@@ -14,7 +14,7 @@ Classifier: Programming Language :: Python :: 3.13
|
|
|
14
14
|
Requires-Python: >=3.13
|
|
15
15
|
Description-Content-Type: text/x-rst
|
|
16
16
|
Requires-Dist: asdf<6.0,>=3.5.0
|
|
17
|
-
Requires-Dist: astropy>=
|
|
17
|
+
Requires-Dist: astropy>=8.0.2
|
|
18
18
|
Requires-Dist: dkist-fits-specifications<5.0,>=4.24.0
|
|
19
19
|
Requires-Dist: dkist-header-validator>=6.0.1
|
|
20
20
|
Requires-Dist: dkist-processing-core==7.5.1
|
|
@@ -234,7 +234,7 @@ To run the tests locally, clone the repository and install the package in editab
|
|
|
234
234
|
Changelog
|
|
235
235
|
#########
|
|
236
236
|
|
|
237
|
-
When you make
|
|
237
|
+
When you make a change to this repository it **MUST** be accompanied by a changelog file, **unless** the change is purely internal tooling or configuration (e.g., updates to CI config, review agent instructions, ``.snyk`` ignore files, or other files that have no effect on pipeline behavior, public API, or user-visible outputs). When in doubt, include a fragment.
|
|
238
238
|
The changelog for this repository uses the `towncrier <https://github.com/twisted/towncrier>`__ package.
|
|
239
239
|
Entries in the changelog for the next release are added as individual files (one per change) to the ``changelog/`` directory.
|
|
240
240
|
|
|
@@ -8,9 +8,6 @@ bitbucket-pipelines.yml
|
|
|
8
8
|
pyproject.toml
|
|
9
9
|
.rovodev/.review-agent.md
|
|
10
10
|
changelog/.gitempty
|
|
11
|
-
changelog/358.misc.rst
|
|
12
|
-
changelog/363.feature.rst
|
|
13
|
-
changelog/363.misc.rst
|
|
14
11
|
dkist_processing_common/__init__.py
|
|
15
12
|
dkist_processing_common/config.py
|
|
16
13
|
dkist_processing_common/manual.py
|
|
@@ -9,9 +9,6 @@
|
|
|
9
9
|
"README.rst",
|
|
10
10
|
"bitbucket-pipelines.yml",
|
|
11
11
|
"changelog/.gitempty",
|
|
12
|
-
"changelog/358.misc.rst",
|
|
13
|
-
"changelog/363.feature.rst",
|
|
14
|
-
"changelog/363.misc.rst",
|
|
15
12
|
"dkist_processing_common/__init__.py",
|
|
16
13
|
"dkist_processing_common/_util/__init__.py",
|
|
17
14
|
"dkist_processing_common/_util/constants.py",
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
Migrate `_format_warnings` from the quality mixin to the `QualityMetric` `BaseModel`.
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
Add codec support for `list[BaseModel]`.
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
Assemble quality data as list of `QualityMetric`.
|
|
File without changes
|
|
File without changes
|
{dkist_processing_common-14.9.1rc1 → dkist_processing_common-14.9.2}/bitbucket-pipelines.yml
RENAMED
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|