dkist-processing-common 13.0.3rc2__tar.gz → 13.0.4__tar.gz

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/.readthedocs.yml

@@ -1,6 +1,6 @@
 version: 2
 build:
-  os: ubuntu-20.04
+  os: ubuntu-24.04
   tools:
     python: "3.13"
   apt_packages:

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/CHANGELOG.rst

@@ -1,3 +1,33 @@
+v13.0.4 (2026-04-16)
+====================
+
+Misc
+----
+
+- Convert fits.open usage in tests to context managers. (`#289 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/289>`__)
+- Remove deprecated Astropy usage (e.g., CompImageHeader) and updated tests accordingly. (`#289 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/289>`__)
+- Configure pyproject.toml to turn warnings raised during testing into errors.
+  Ignore certain testing warnings that we know are okay. (`#289 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/289>`__)
+- Modernize code to address Python 3.13 deprecations (e.g., datetime.utcnow, Pillow image mode handling). (`#289 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/289>`__)
+- Update dkist-processing-core to v7.2.1, which includes better warning handling and an RTD build OS update. (`#298 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/298>`__)
+- Upgrade Read the Docs LTS build image to Ubuntu 24.04. (`#328 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/328>`__)
+
+
+v13.0.3 (2026-04-14)
+====================
+
+Features
+--------
+
+- Simplify the production of L1 quality metrics. (`#326 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/326>`__)
+
+
+Misc
+----
+
+- Make isb username and password configurable for local unit tests. (`#322 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/322>`__)
+
+
 v13.0.1 (2026-04-07)
 ====================
 

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 13.0.3rc2
+Version: 13.0.4
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -17,7 +17,7 @@ Requires-Dist: asdf<4.0.0,>=3.5.0
 Requires-Dist: astropy>=7.0.0
 Requires-Dist: dkist-fits-specifications<5.0,>=4.24.0
 Requires-Dist: dkist-header-validator<6.0,>=5.3.0
-Requires-Dist: dkist-processing-core==7.1.0
+Requires-Dist: dkist-processing-core==7.2.1
 Requires-Dist: dkist-processing-pac<4.0,>=3.1
 Requires-Dist: dkist-service-configuration<5.0,>=4.3.0
 Requires-Dist: dkist-spectral-lines<4.0,>=3.0.0

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tasks/assemble_movie.py

@@ -225,7 +225,7 @@ class AssembleMovie(WorkflowTaskBase, ABC):
             )
 
         background = Image.new("RGB", self.MOVIE_FRAME_SHAPE, (0, 0, 0))
-        frame_im = Image.fromarray(colored_image, mode="RGB")
+        frame_im = Image.fromarray(colored_image)
         frame_im = frame_im.resize(self.MOVIE_FRAME_SHAPE, resample=Image.NEAREST)
         background.paste(frame_im)
         draw = ImageDraw.Draw(background)

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tasks/quality_metrics.py

@@ -439,36 +439,22 @@ class QualityL1Metrics(WorkflowTaskBase, QualityMixin):
             fits_access_class=L1QualityFitsAccess,
         )
 
-        # accumulate specified L1QualityFitsAccess values into lists, sorted by datetime
-        rows = sorted(
-            (
-                (
-                    # DATE-BEG
-                    datetime.fromisoformat(frame.time_obs),
-                    # LIGHTLVL
-                    frame.light_level,
-                    # DSHEALTH
-                    frame.health_status,
-                    # ATMOS_R0
-                    frame.fried_parameter,
-                    # AO_LOCK
-                    frame.ao_status,
-                    # OOBSHIFT
-                    frame.num_out_of_bounds_ao_values,
-                )
-                for frame in frames
-            ),
-            # DATE-BEG
-            key=lambda row: row[0],
-        )
+        # sort by datetime
+        sorted_frames = sorted(frames, key=lambda f: datetime.fromisoformat(f.time_obs))
 
         return L1QualityData(
-            datetimes=tuple(row[0] for row in rows),
-            light_level_values=tuple(row[1] for row in rows),
-            health_status_values=tuple(row[2] for row in rows),
-            fried_parameter_values=tuple(row[3] for row in rows),
-            ao_lock_values=tuple(row[4] for row in rows),
-            ao_oob_values=tuple(row[5] for row in rows),
+            # DATE-BEG
+            datetimes=tuple(datetime.fromisoformat(f.time_obs) for f in sorted_frames),
+            # LIGHTLVL
+            light_level_values=tuple(f.light_level for f in sorted_frames),
+            # DSHEALTH
+            health_status_values=tuple(f.health_status for f in sorted_frames),
+            # ATMOS_R0
+            fried_parameter_values=tuple(f.fried_parameter for f in sorted_frames),
+            # AO_LOCK
+            ao_lock_values=tuple(f.ao_status for f in sorted_frames),
+            # OOBSHIFT
+            ao_oob_values=tuple(f.num_out_of_bounds_ao_values for f in sorted_frames),
         )
 
     def compute_and_write_l1_quality_metrics(self, l1_quality_data: L1QualityData) -> None:
@@ -575,19 +561,21 @@ class QualityL1Metrics(WorkflowTaskBase, QualityMixin):
         rows.extend(tuple(z) for z in zip(statuses, counts))
         table_data = TableData(rows=tuple(rows))
 
+        warnings = None
+        if any(s in statuses for s in ["bad", "ill", "unknown"]):
+            warnings = [
+                "Data sourced from components with a health status of 'ill', 'bad', or 'unknown'."
+            ]
+
         metric = QualityMetric(
             name="Data Source Health",
             description="This metric contains the worst health status of the data source during "
             "data acquisition. One reading is taken per L1 frame.",
             metric_code=MetricCode.health_status,
             table_data=[table_data],
+            warnings=warnings,
         )
 
-        if any(s in statuses for s in ["bad", "ill", "unknown"]):
-            metric.warnings = [
-                "Data sourced from components with a health status of 'ill', 'bad', or 'unknown'."
-            ]
-
         self.write(metric, tags=Tag.quality("GENERIC"), encoder=basemodel_encoder)
 
     def compute_and_write_light_level(self, l1_quality_data: L1QualityData) -> None:

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tasks/trial_catalog.py

@@ -93,7 +93,7 @@ class CreateTrialDatasetInventory(OutputDataBase):
             frame_inventory["_id"] = uuid4().hex
             frame_inventory["bucket"] = self.destination_bucket
             frame_inventory["frameStatus"] = "AVAILABLE"
-            frame_inventory["createDate"] = datetime.utcnow().isoformat("T")
+            frame_inventory["createDate"] = datetime.now().isoformat("T")
             frame_inventory["updateDate"] = None
             frame_inventory["lostDate"] = None
             frame_inventory["headerHDU"] = 1

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/conftest.py

@@ -617,7 +617,7 @@ def visp_modulation_matrix() -> np.ndarray:
 
 @pytest.fixture(scope="session")
 def fully_realistic_local_cs(
-    cs_with_correct_geometry, visp_modulation_matrix, pac_fit_mode, pac_init_set
+    cs_with_correct_geometry, visp_modulation_matrix, pac_fit_mode, pac_init_set, cs_data_shape
 ):
 
     cs_dict = cs_with_correct_geometry
@@ -643,7 +643,7 @@ def fully_realistic_local_cs(
     # Now set the "observed" value for each of the input objects
     for m in range(dresser.nummod):
         for n in range(dresser.numsteps):
-            cs_dict[n][m].data *= observed[m, n] / np.mean(cs_dict[n][m].data)
+            cs_dict[n][m].data = np.ones(cs_data_shape) * observed[m, n]
 
     return cs_dict
 

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_codecs.py

@@ -454,11 +454,10 @@ def test_fits_array_encoder_header_preserved(ndarray_object, header_func: Callab
     header = header_func(raw_header)
     encoded_data = fits_array_encoder(data=ndarray_object, header=header)
     bytes_reader = BytesIO(encoded_data)
-    hdul = fits.open(bytes_reader)
-
-    assert len(hdul) == 1
-    np.testing.assert_equal(hdul[0].data, ndarray_object)
-    assert hdul[0].header["KEY1"] == "VALUE1"
+    with fits.open(bytes_reader) as hdul:
+        assert len(hdul) == 1
+        np.testing.assert_equal(hdul[0].data, ndarray_object)
+        assert hdul[0].header["KEY1"] == "VALUE1"
 
 
 @pytest.mark.parametrize(
@@ -584,13 +583,11 @@ def test_fits_header_decoder(path_fixture_name, request):
     if init_num_fd is not None:
         assert init_num_fd == post_num_fd
 
-    hdul = fits.open(file_path, disable_image_compression=True)
-    if "compressed" in path_fixture_name:
-        expected_header = hdul[1].header
-    else:
-        expected_header = hdul[0].header
+    with fits.open(file_path, disable_image_compression=True) as hdul:
+        index = 1 if "compressed" in path_fixture_name else 0
+        expected_header = hdul[index].header
 
-    assert header == expected_header
+        assert header == expected_header
 
 
 @pytest.mark.parametrize(

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_fits_access.py

@@ -342,7 +342,6 @@ def test_header_dict(hdu_with_special_keys):
     [
         pytest.param(dict, id="Dict"),
         pytest.param(fits.header.Header, id="Header"),
-        pytest.param(fits.hdu.compressed.CompImageHeader, id="CompHeader"),
     ],
 )
 def test_from_header_naxis_preserved(header_type):

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_interservice_bus.py

@@ -4,8 +4,9 @@ from typing import Type
 from uuid import uuid4
 
 import pytest
+from pika import ConnectionParameters
+from pika.credentials import PlainCredentials
 from pydantic import BaseModel
-from pydantic import Field
 from talus import Binding
 from talus import ConsumeMessageBase
 from talus import DurableConsumer
@@ -15,6 +16,8 @@ from talus import MessageBodyBase
 from talus import PublishMessageBase
 from talus import Queue
 
+from dkist_processing_common.config import common_configurations
+
 
 @pytest.fixture
 def sample_message_body():
@@ -59,19 +62,35 @@ def consume_message(sample_message):
 
 
 @pytest.fixture
-def producer(sample_message, publish_message):
+def connection_parameters() -> ConnectionParameters:
+    isb_username = common_configurations.isb_username
+    isb_password = common_configurations.isb_password
+    connection_parameters = ConnectionParameters(
+        credentials=PlainCredentials(isb_username, isb_password)
+    )
+    return connection_parameters
+
+
+@pytest.fixture
+def producer(sample_message, publish_message, connection_parameters):
     exchange = sample_message.exchange
     binding = Binding(queue=sample_message.queue, message=publish_message)
-    with DurableProducer(queue_bindings=binding, publish_exchange=exchange) as p:
+    with DurableProducer(
+        queue_bindings=binding,
+        publish_exchange=exchange,
+        connection_parameters=connection_parameters,
+    ) as p:
         yield p
         p.channel.queue_delete(queue=sample_message.queue.name)
         p.channel.exchange_delete(exchange=sample_message.exchange.name)
 
 
 @pytest.fixture
-def consumer(sample_message):
+def consumer(sample_message, connection_parameters):
     queue = sample_message.queue
-    with DurableConsumer(consume_queue=queue, prefetch_count=100) as c:
+    with DurableConsumer(
+        consume_queue=queue, prefetch_count=100, connection_parameters=connection_parameters
+    ) as c:
         yield c
         c.channel.queue_delete(queue=sample_message.queue.name)
         c.channel.exchange_delete(exchange=sample_message.exchange.name)

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_interservice_bus_mixin.py

@@ -5,6 +5,8 @@ from typing import Dict
 from typing import Type
 
 import pytest
+from pika import ConnectionParameters
+from pika.credentials import PlainCredentials
 from pydantic import BaseModel
 from talus import ConsumeMessageBase
 from talus import DurableConsumer
@@ -77,9 +79,21 @@ def consume_message(task_message):
 
 
 @pytest.fixture
-def consumer(task_message):
+def connection_parameters() -> ConnectionParameters:
+    isb_username = common_configurations.isb_username
+    isb_password = common_configurations.isb_password
+    connection_parameters = ConnectionParameters(
+        credentials=PlainCredentials(isb_username, isb_password)
+    )
+    return connection_parameters
+
+
+@pytest.fixture
+def consumer(task_message, connection_parameters):
     queue = task_message.queue
-    with DurableConsumer(consume_queue=queue, prefetch_count=100) as c:
+    with DurableConsumer(
+        consume_queue=queue, prefetch_count=100, connection_parameters=connection_parameters
+    ) as c:
         yield c
         # Clean up all the queues, skipping queues that are not empty:
         for binding in common_message_queue_bindings:

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_quality.py

@@ -737,9 +737,9 @@ def test_ao_status(quality_l1_task_with_calibrated_frames: QualityL1Metrics):
     # Then
     metric_code = "AO_STATUS"
     tags = [Tag.quality("GENERIC")]
-    metrics = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len([metric for metric in metrics if metric.metric_code in metric_code]) == 1
     for metric in metrics:
         if metric.metric_code != metric_code:
@@ -772,9 +772,9 @@ def test_fried_parameter(
     # Then
     metric_code = "FRIED_PARAMETER"
     tags = [Tag.quality("GENERIC")]
-    metrics = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len([metric for metric in metrics if metric.metric_code in metric_code]) == 1
     for metric in metrics:
         if metric.metric_code != metric_code:
@@ -823,9 +823,9 @@ def test_health_status(quality_l1_task_with_calibrated_frames: QualityL1Metrics)
     # Then
     metric_code = "HEALTH_STATUS"
     tags = [Tag.quality("GENERIC")]
-    metrics = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len([metric for metric in metrics if metric.metric_code in metric_code]) == 1
     for metric in metrics:
         if metric.metric_code != metric_code:
@@ -867,9 +867,9 @@ def test_light_level(
     # Then
     metric_code = "LIGHT_LEVEL"
     tags = [Tag.quality("GENERIC")]
-    metrics = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len([metric for metric in metrics if metric.metric_code in metric_code]) == 1
     for metric in metrics:
         if metric.metric_code != metric_code:
@@ -919,9 +919,9 @@ def test_compute_and_write_ao_status(
     task.compute_and_write_ao_status(l1_quality_data)
     # Then
     tags = [Tag.quality("GENERIC")]
-    metrics: list[QualityMetric] = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len(metrics) == 1
     metric = metrics[0]
     # basics
@@ -956,9 +956,9 @@ def test_compute_and_write_fried_parameter(
     task.compute_and_write_fried_parameter(l1_quality_data)
     # Then
     tags = [Tag.quality("GENERIC")]
-    metrics: list[QualityMetric] = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len(metrics) == 1
     metric = metrics[0]
     # basics
@@ -1013,9 +1013,9 @@ def test_compute_and_write_health_status(
     task.compute_and_write_health_status(l1_quality_data)
     # Then
     tags = [Tag.quality("GENERIC")]
-    metrics: list[QualityMetric] = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len(metrics) == 1
     metric = metrics[0]
     # basics
@@ -1069,9 +1069,9 @@ def test_compute_and_write_light_level(
     task.compute_and_write_light_level(l1_quality_data)
     # Then
     tags = [Tag.quality("GENERIC")]
-    metrics: list[QualityMetric] = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len(metrics) == 1
     metric = metrics[0]
     # basics
@@ -1122,7 +1122,7 @@ def test_no_calibration_frames_no_l1_metrics(quality_l1_task_no_scratch_data: Qu
     task()
     # Then
     tags = [Tag.quality("GENERIC")]
-    metrics = [
-        metric for metric in task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
-    ]
+    metrics: list[QualityMetric] = list(
+        task.read(tags=tags, decoder=basemodel_decoder, model=QualityMetric)
+    )
     assert len(metrics) == 0

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_quality_mixin.py

@@ -1074,8 +1074,8 @@ def test_validate_vertical_multi_pane_plot_model():
     # Test invalid case
     with pytest.raises(
         ValidationError,
-        match="The number of items in `top_to_bottom_height_ratios` list \(3\) is not "
-        "the same as the number of plots \(2\)",
+        match=r"The number of items in `top_to_bottom_height_ratios` list \(3\) is not "
+        r"the same as the number of plots \(2\)",
     ):
         _ = VerticalMultiPanePlot2D(
             top_to_bottom_plot_list=[plot2d, plot2d], top_to_bottom_height_ratios=[1.0, 2.0, 3.0]

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common/tests/test_write_l1.py

@@ -445,17 +445,18 @@ def test_solarnet_keys(write_l1_task, mocker, fake_gql_client):
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        header = fits.open(file)[1].header
-        assert header["DATEREF"] == header["DATE-BEG"]
-        assert round(header["OBSGEO-X"]) == -5466045
-        assert round(header["OBSGEO-Y"]) == -2404389
-        assert round(header["OBSGEO-Z"]) == 2242134
-        assert header["SOLARRAD"] == 975.58
-        assert header["SPECSYS"] == "TOPOCENT"
-        assert header["VELOSYS"] == 0.0
-        assert header["WAVEBAND"] == "Fe XIII (1079.8 nm)"
-        assert header["WAVEMIN"] == 1075.0
-        assert header["WAVEMAX"] == 1085.0
+        with fits.open(file) as hdu:
+            header = hdu[1].header
+            assert header["DATEREF"] == header["DATE-BEG"]
+            assert round(header["OBSGEO-X"]) == -5466045
+            assert round(header["OBSGEO-Y"]) == -2404389
+            assert round(header["OBSGEO-Z"]) == 2242134
+            assert header["SOLARRAD"] == 975.58
+            assert header["SPECSYS"] == "TOPOCENT"
+            assert header["VELOSYS"] == 0.0
+            assert header["WAVEBAND"] == "Fe XIII (1079.8 nm)"
+            assert header["WAVEMIN"] == 1075.0
+            assert header["WAVEMAX"] == 1085.0
 
 
 def test_documentation_keys(write_l1_task, mocker, fake_gql_client):
@@ -477,18 +478,20 @@ def test_documentation_keys(write_l1_task, mocker, fake_gql_client):
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        header = fits.open(file)[1].header
-        assert header["INFO_URL"] == task.docs_base_url
-        assert header["HEADVERS"] == spec_version
-        assert (
-            header["HEAD_URL"] == f"{task.docs_base_url}/projects/data-products/en/v{spec_version}"
-        )
-        calvers = task.version_from_module_name()
-        assert header["CALVERS"] == calvers
-        assert (
-            header["CAL_URL"]
-            == f"{task.docs_base_url}/projects/{task.constants.instrument.lower()}/en/v{calvers}/{task.workflow_name}.html"
-        )
+        with fits.open(file) as hdu:
+            header = hdu[1].header
+            assert header["INFO_URL"] == task.docs_base_url
+            assert header["HEADVERS"] == spec_version
+            assert (
+                header["HEAD_URL"]
+                == f"{task.docs_base_url}/projects/data-products/en/v{spec_version}"
+            )
+            calvers = task.version_from_module_name()
+            assert header["CALVERS"] == calvers
+            assert (
+                header["CAL_URL"]
+                == f"{task.docs_base_url}/projects/{task.constants.instrument.lower()}/en/v{calvers}/{task.workflow_name}.html"
+            )
 
 
 def test_get_version_from_module(write_l1_task):
@@ -519,13 +522,13 @@ def test_rice_compression_with_specified_tile_size(write_l1_task, mocker, fake_g
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        hdul = fits.open(file)
-        bintable = hdul[1]._get_bintable_without_data()
-        comp_header = bintable.header
-        data_shape = list(hdul[1].data.shape)
-        data_shape.reverse()
-        for i, dim in enumerate(data_shape):
-            assert comp_header["ZTILE" + str(i + 1)] == min(dim, TILE_SIZE)
+        with fits.open(file) as hdul:
+            bintable = hdul[1]._get_bintable_without_data()
+            comp_header = bintable.header
+            data_shape = list(hdul[1].data.shape)
+            data_shape.reverse()
+            for i, dim in enumerate(data_shape):
+                assert comp_header["ZTILE" + str(i + 1)] == min(dim, TILE_SIZE)
 
 
 def test_rice_compression_with_default_tile_size(
@@ -547,14 +550,14 @@ def test_rice_compression_with_default_tile_size(
     assert task.tile_size_param == None
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        hdul = fits.open(file)
-        bintable = hdul[1]._get_bintable_without_data()
-        comp_header = bintable.header
-        data_shape = list(hdul[1].data.shape)
-        data_shape.reverse()
-        assert comp_header["ZTILE1"] == data_shape[0]
-        assert comp_header["ZTILE2"] == 128
-        assert comp_header["ZTILE3"] == 1
+        with fits.open(file) as hdul:
+            bintable = hdul[1]._get_bintable_without_data()
+            comp_header = bintable.header
+            data_shape = list(hdul[1].data.shape)
+            data_shape.reverse()
+            assert comp_header["ZTILE1"] == data_shape[0]
+            assert comp_header["ZTILE2"] == 128
+            assert comp_header["ZTILE3"] == 1
 
 
 def test_reprocessing_keys(write_l1_task, mocker, fake_gql_client):
@@ -571,20 +574,26 @@ def test_reprocessing_keys(write_l1_task, mocker, fake_gql_client):
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        header = fits.open(file)[1].header
-        assert header["IDSPARID"] == task.metadata_store_input_dataset_parameters.inputDatasetPartId
-        assert (
-            header["IDSOBSID"]
-            == task.metadata_store_input_dataset_observe_frames.inputDatasetPartId
-        )
-        assert (
-            header["IDSCALID"]
-            == task.metadata_store_input_dataset_calibration_frames.inputDatasetPartId
-        )
-        assert header["WKFLNAME"] == task.workflow_name
-        assert header["WKFLVERS"] == task.workflow_version
-        assert header["PROCTYPE"] == "L1"
-        assert header["PRODUCT"] == task.compute_product_id(header["IDSOBSID"], header["PROCTYPE"])
+        with fits.open(file) as hdu:
+            header = hdu[1].header
+            assert (
+                header["IDSPARID"]
+                == task.metadata_store_input_dataset_parameters.inputDatasetPartId
+            )
+            assert (
+                header["IDSOBSID"]
+                == task.metadata_store_input_dataset_observe_frames.inputDatasetPartId
+            )
+            assert (
+                header["IDSCALID"]
+                == task.metadata_store_input_dataset_calibration_frames.inputDatasetPartId
+            )
+            assert header["WKFLNAME"] == task.workflow_name
+            assert header["WKFLVERS"] == task.workflow_version
+            assert header["PROCTYPE"] == "L1"
+            assert header["PRODUCT"] == task.compute_product_id(
+                header["IDSOBSID"], header["PROCTYPE"]
+            )
 
 
 def test_missing_input_dataset_part(
@@ -603,13 +612,17 @@ def test_missing_input_dataset_part(
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        header = fits.open(file)[1].header
-        assert header["IDSPARID"] == task.metadata_store_input_dataset_parameters.inputDatasetPartId
-        assert (
-            header["IDSOBSID"]
-            == task.metadata_store_input_dataset_observe_frames.inputDatasetPartId
-        )
-        assert "IDSCALID" not in header
+        with fits.open(file) as hdu:
+            header = hdu[1].header
+            assert (
+                header["IDSPARID"]
+                == task.metadata_store_input_dataset_parameters.inputDatasetPartId
+            )
+            assert (
+                header["IDSOBSID"]
+                == task.metadata_store_input_dataset_observe_frames.inputDatasetPartId
+            )
+            assert "IDSCALID" not in header
 
 
 @pytest.mark.parametrize(
@@ -757,8 +770,9 @@ def test_empty_waveband(write_l1_task_with_empty_waveband, mocker, fake_gql_clie
     task()
     files = list(task.read(tags=[Tag.frame(), Tag.output()]))
     for file in files:
-        header = fits.open(file)[1].header
-        assert header["WAVEMIN"] == 10000
-        assert header["WAVEMAX"] == 10050
-        with pytest.raises(KeyError):
-            header["WAVEBAND"]
+        with fits.open(file) as hdu:
+            header = hdu[1].header
+            assert header["WAVEMIN"] == 10000
+            assert header["WAVEMAX"] == 10050
+            with pytest.raises(KeyError):
+                header["WAVEBAND"]

{dkist_processing_common-13.0.3rc2 → dkist_processing_common-13.0.4}/dkist_processing_common.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 13.0.3rc2
+Version: 13.0.4
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -17,7 +17,7 @@ Requires-Dist: asdf<4.0.0,>=3.5.0
 Requires-Dist: astropy>=7.0.0
 Requires-Dist: dkist-fits-specifications<5.0,>=4.24.0
 Requires-Dist: dkist-header-validator<6.0,>=5.3.0
-Requires-Dist: dkist-processing-core==7.1.0
+Requires-Dist: dkist-processing-core==7.2.1
 Requires-Dist: dkist-processing-pac<4.0,>=3.1
 Requires-Dist: dkist-service-configuration<5.0,>=4.3.0
 Requires-Dist: dkist-spectral-lines<4.0,>=3.0.0