dkist-processing-common 10.7.0__tar.gz → 10.7.1rc1__tar.gz

{dkist_processing_common-10.7.0 → dkist_processing_common-10.7.1rc1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 10.7.0
+Version: 10.7.1rc1
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause

dkist_processing_common-10.7.1rc1/changelog/248.bugfix.rst

@@ -0,0 +1 @@
+Fix a bug exposed by updates in the `dkist-inventory` package that did not manage HISTORY or COMMENT cards correctly.

{dkist_processing_common-10.7.0 → dkist_processing_common-10.7.1rc1}/dkist_processing_common/tests/test_fits_access.py

@@ -22,19 +22,21 @@ def hdu_with_complete_common_header(complete_common_header):
 def hdu_with_special_keys(hdu_with_complete_common_header, request):
     """
     An HDU with data and a header that includes variations on the special keys that make headers
-    different from dict's.
+    different from dicts.
+
+    The base complete_common_header already has history and comment cards so this fixture adds extras.
     """
     add_special = request.param
     hdu = hdu_with_complete_common_header
     if add_special == "history":
         hdu.header.add_history("test history")
-        return hdu
+        return hdu, request.param
     if add_special == "comment":
-        hdu.header.add_history("test comment")
-        return hdu
+        hdu.header.add_comment("test comment")
+        return hdu, request.param
     if add_special == "continue":
         hdu.header["LONG_VAL"] = " " * 100
-        return hdu
+        return hdu, request.param
 
 
 @pytest.fixture()
@@ -282,11 +284,16 @@ def test_header_dict(hdu_with_special_keys):
     """
     Given: A FitsAccess object with data and a header including special header keys
     When: Accessing the header_dict method
-    Then: The object's header is successfully exported as a dict of the same length as the header
+    Then: The object's header is successfully exported as a dict of the same length as the header when accounting for multiple HISTORY or COMMENT cards
     """
-    fits_obj = FitsAccessBase(hdu_with_special_keys)
+    hdu, added_header_key = hdu_with_special_keys
+    fits_obj = FitsAccessBase(hdu)
     assert isinstance(fits_obj.header_dict, dict)
-    assert len(fits_obj.header_dict) == len(fits_obj.header)
+    if added_header_key == "continue":
+        assert len(fits_obj.header_dict) == len(fits_obj.header)
+    if added_header_key in ["history", "comment"]:
+        # HISTORY and COMMENT keys get "squeezed"
+        assert len(fits_obj.header_dict) == len(fits_obj.header) - 1
 
 
 @pytest.mark.parametrize(

{dkist_processing_common-10.7.0 → dkist_processing_common-10.7.1rc1}/dkist_processing_common.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 10.7.0
+Version: 10.7.1rc1
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause

{dkist_processing_common-10.7.0 → dkist_processing_common-10.7.1rc1}/dkist_processing_common.egg-info/SOURCES.txt

@@ -7,6 +7,7 @@ README.rst
 bitbucket-pipelines.yml
 pyproject.toml
 changelog/.gitempty
+changelog/248.bugfix.rst
 dkist_processing_common/__init__.py
 dkist_processing_common/config.py
 dkist_processing_common/manual.py