dkist-processing-common 10.6.2__tar.gz → 10.6.3__tar.gz

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/CHANGELOG.rst

@@ -1,3 +1,12 @@
+v10.6.3 (2025-03-27)
+====================
+
+Bugfixes
+--------
+
+- Fix a bug where transfer input dataset fails if any of the input dataset part documents are missing. (`#241 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/241>`__)
+- Pydantic model validator now returns the validated instance. (`#240 <https://bitbucket.org/dkistdc/dkist-processing-common/pull-requests/240>`__)
+
 v10.6.2 (2025-03-19)
 ====================
 

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 10.6.2
+Version: 10.6.3
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/dkist_processing_common/models/wavelength.py

@@ -26,3 +26,4 @@ class WavelengthRange(BaseModel):
         """Validate that the max wavelength is greater than the min wavelength."""
         if self.min > self.max:
             raise ValueError("min is greater than max.  Values may be reversed.")
+        return self

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/dkist_processing_common/tasks/transfer_input_data.py

@@ -20,12 +20,17 @@ class TransferL0Data(WorkflowTaskBase, GlobusMixin, InputDatasetMixin):
 
     def download_input_dataset(self):
         """Get the input dataset document parts and save it to scratch with the appropriate tags."""
-        if doc := self.metadata_store_input_dataset_observe_frames.inputDatasetPartDocument:
-            self.write(doc, tags=Tag.input_dataset_observe_frames(), encoder=json_encoder)
-        if doc := self.metadata_store_input_dataset_calibration_frames.inputDatasetPartDocument:
-            self.write(doc, tags=Tag.input_dataset_calibration_frames(), encoder=json_encoder)
-        if doc := self.metadata_store_input_dataset_parameters.inputDatasetPartDocument:
-            self.write(doc, tags=Tag.input_dataset_parameters(), encoder=json_encoder)
+        if observe_frames := self.metadata_store_input_dataset_observe_frames:
+            observe_doc = observe_frames.inputDatasetPartDocument
+            self.write(observe_doc, tags=Tag.input_dataset_observe_frames(), encoder=json_encoder)
+        if calibration_frames := self.metadata_store_input_dataset_calibration_frames:
+            calibration_doc = calibration_frames.inputDatasetPartDocument
+            self.write(
+                calibration_doc, tags=Tag.input_dataset_calibration_frames(), encoder=json_encoder
+            )
+        if parameters := self.metadata_store_input_dataset_parameters:
+            parameters_doc = parameters.inputDatasetPartDocument
+            self.write(parameters_doc, tags=Tag.input_dataset_parameters(), encoder=json_encoder)
 
     def format_transfer_items(
         self, input_dataset_objects: list[InputDatasetObject]

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/dkist_processing_common/tests/test_transfer_input_data.py

@@ -17,10 +17,20 @@ class TransferL0DataTask(TransferL0Data):
         ...
 
 
-@pytest.fixture
-def transfer_l0_data_task(recipe_run_id, tmp_path, mocker):
+class FakeGQLClientMissingPart(FakeGQLClient):
+    """Same metadata mocker with calibration input dataset part missing."""
+
+    def execute_gql_query(self, **kwargs):
+        original_response = super().execute_gql_query(**kwargs)
+        # Remove calibration frames part
+        del original_response[0].recipeInstance.inputDataset.inputDatasetInputDatasetParts[2]
+        return original_response
+
+
+def _transfer_l0_data_task_with_client(recipe_run_id, tmp_path, mocker, client_cls):
     mocker.patch(
-        "dkist_processing_common.tasks.mixin.metadata_store.GraphQLClient", new=FakeGQLClient
+        "dkist_processing_common.tasks.mixin.metadata_store.GraphQLClient",
+        new=client_cls,
     )
     with TransferL0DataTask(
         recipe_run_id=recipe_run_id,
@@ -35,6 +45,18 @@ def transfer_l0_data_task(recipe_run_id, tmp_path, mocker):
         task._purge()
 
 
+@pytest.fixture
+def transfer_l0_data_task(recipe_run_id, tmp_path, mocker):
+    yield from _transfer_l0_data_task_with_client(recipe_run_id, tmp_path, mocker, FakeGQLClient)
+
+
+@pytest.fixture
+def transfer_l0_data_task_missing_part(recipe_run_id, tmp_path, mocker):
+    yield from _transfer_l0_data_task_with_client(
+        recipe_run_id, tmp_path, mocker, FakeGQLClientMissingPart
+    )
+
+
 def test_download_dataset(transfer_l0_data_task):
     """
     :Given: a TransferL0Data task with a valid input dataset
@@ -63,6 +85,29 @@ def test_download_dataset(transfer_l0_data_task):
     assert parameters_doc_from_file == expected_parameters_doc
 
 
+def test_download_dataset_missing_part(transfer_l0_data_task_missing_part):
+    """
+    :Given: a TransferL0Data task with a valid input dataset without calibration frames
+    :When: downloading the dataset documents from the metadata store
+    :Then: the correct number of documents are written to disk
+    """
+    # Given
+    task = transfer_l0_data_task_missing_part
+    # When
+    task.download_input_dataset()
+    # Then
+    observe_doc_from_file = next(
+        task.read(tags=Tag.input_dataset_observe_frames(), decoder=json_decoder)
+    )
+    parameters_doc_from_file = next(
+        task.read(tags=Tag.input_dataset_parameters(), decoder=json_decoder)
+    )
+    with pytest.raises(StopIteration):
+        calibration_doc_from_file = next(
+            task.read(tags=Tag.input_dataset_calibration_frames(), decoder=json_decoder)
+        )
+
+
 def test_format_frame_transfer_items(transfer_l0_data_task):
     """
     :Given: a TransferL0Data task with a downloaded input dataset

{dkist_processing_common-10.6.2 → dkist_processing_common-10.6.3}/dkist_processing_common.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: dkist-processing-common
-Version: 10.6.2
+Version: 10.6.3
 Summary: Common task classes used by the DKIST science data processing pipelines
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause