djcheckup 0.2.2__tar.gz → 0.2.4__tar.gz

{djcheckup-0.2.2 → djcheckup-0.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: djcheckup
-Version: 0.2.2
+Version: 0.2.4
 Summary: DJ Checkup is a security scanner for Django sites.
 Author: Stuart Maxwell
 Author-email: Stuart Maxwell <stuart@amanzi.nz>
@@ -35,7 +35,7 @@ License: BSD 3-Clause License
 Requires-Dist: httpx>=0.28.1
 Requires-Dist: rich>=14.1.0
 Requires-Dist: typer>=0.17.4
-Requires-Python: >=3.13
+Requires-Python: >=3.10
 Project-URL: Homepage, https://github.com/stuartmaxwell/djcheckup
 Project-URL: Repository, https://github.com/stuartmaxwell/djcheckup
 Description-Content-Type: text/markdown

{djcheckup-0.2.2 → djcheckup-0.2.4}/pyproject.toml

@@ -1,10 +1,10 @@
 [project]
 name = "djcheckup"
-version = "0.2.2"
+version = "0.2.4"
 description = "DJ Checkup is a security scanner for Django sites."
 readme = "README.md"
 authors = [{ name = "Stuart Maxwell", email = "stuart@amanzi.nz" }]
-requires-python = ">=3.13"
+requires-python = ">=3.10"
 dependencies = ["httpx>=0.28.1", "rich>=14.1.0", "typer>=0.17.4"]
 license = { file = "LICENSE" }
 
@@ -26,6 +26,9 @@ target-version = "py313"
 [tool.ruff.lint]
 select = ["ALL"]
 
+[tool.pyrefly]
+project-includes = ["src/djcheckup/**"]
+
 [tool.ruff.lint.extend-per-file-ignores]
 "tests/**" = ["S101", "ANN201", "ANN001", "ARG001"]
 
@@ -33,8 +36,23 @@ select = ["ALL"]
 convention = "google" # Accepts: "google", "numpy", or "pep257".
 
 [dependency-groups]
-dev = ["pytest>=8.4.2"]
+dev = [
+    "nox>=2025.5.1",
+    "pyrefly>=0.34.0",
+    "pytest>=8.4.2",
+    "pytest-cov>=7.0.0",
+]
 
 [tool.pytest.ini_options]
 pythonpath = "."
 python_files = "test_*.py"
+
+[tool.coverage.html]
+show_contexts = true
+
+[tool.coverage.run]
+branch = true
+include = ["src/djcheckup/*"]
+
+[tool.coverage.report]
+# exclude_lines = ["if TYPE_CHECKING:", "# pragma: no cover"]

{djcheckup-0.2.2 → djcheckup-0.2.4}/src/djcheckup/check_defs.py

@@ -56,7 +56,7 @@ csrf_httponly_check = CookieHttpOnlyCheck(
     depends_on="csrf_check",
     name="Is the CSRF cookie HttpOnly?",
     cookie_name="csrftoken",
-    success=False,
+    success=True,
     severity=SeverityWeight.MEDIUM,
     success_message="Your CSRF cookie is marked as HttpOnly, which helps prevent some XSS attacks.",
     failure_message="""
@@ -211,7 +211,7 @@ Reference:
 login_check = PathCheck(
     check_id="login_check",
     name="Is your login page exposed at a default or guessable URL?",
-    path="/accounts/login/",
+    path="/accounts/login",
     success=False,
     severity=SeverityWeight.MEDIUM,
     success_message="Login page is not exposed at the default URL. This reduces the risk of automated attacks.",

{djcheckup-0.2.2 → djcheckup-0.2.4}/src/djcheckup/checks.py

@@ -1,10 +1,11 @@
 """Check types."""
 
 from abc import ABC, abstractmethod
+from collections.abc import Sequence
 from dataclasses import dataclass
 from enum import Enum
 from http.cookiejar import CookieJar
-from typing import Literal, Self
+from typing import Literal
 
 import httpx
 
@@ -99,25 +100,6 @@ class _BaseCheck(ABC):
         )
 
 
-@dataclass
-class HeaderCheck(_BaseCheck):
-    """A header check."""
-
-    header_name: str
-    header_value: str = ""
-
-    def check(self, context: SiteCheckContext) -> bool:
-        """Check if a specific header is present and optionally if it matches a given value."""
-        # Normalize header names to lowercase for case-insensitive comparison
-        headers = {k.lower(): v for k, v in context.headers.items()}
-        actual_value = headers.get(self.header_name.lower())
-        if actual_value is None:
-            return False
-
-        # Compare header values case-insensitively if header_value is provided
-        return not (self.header_value and actual_value.lower() != self.header_value.lower())
-
-
 @dataclass
 class ContentCheck(_BaseCheck):
     """A content check.
@@ -230,6 +212,25 @@ class CookieSecureCheck(_BaseCheck):
         return False
 
 
+@dataclass
+class HeaderCheck(_BaseCheck):
+    """A header check."""
+
+    header_name: str
+    header_value: str = ""
+
+    def check(self, context: SiteCheckContext) -> bool:
+        """Check if a specific header is present and optionally if it matches a given value."""
+        # Normalize header names to lowercase for case-insensitive comparison
+        headers = {k.lower(): v for k, v in context.headers.items()}
+        actual_value = headers.get(self.header_name.lower())
+        if actual_value is None:
+            return False
+
+        # Compare header values case-insensitively if header_value is provided
+        return not (self.header_value and actual_value.lower() != self.header_value.lower())
+
+
 @dataclass
 class PathCheck(_BaseCheck):
     """A path check.
@@ -274,8 +275,8 @@ class SchemeCheck(_BaseCheck):
     def check(self, context: SiteCheckContext) -> bool:
         """Check if the scheme of the URL in the request matches the final scheme."""
         # If the start scheme matches the original URL scheme, then we don't need a new request.
-        if context.url.scheme == self.start_scheme and context.response_url.scheme == self.end_scheme:
-            return True
+        if context.url.scheme == self.start_scheme:
+            return context.response_url.scheme == self.end_scheme
 
         # Need to create a new URL with the specified start scheme
         new_url = context.url.copy_with(scheme=self.start_scheme)
@@ -349,7 +350,7 @@ class SiteChecker:
             self.client.close()
 
     # Context manager support for automatic cleanup
-    def __enter__(self) -> Self:
+    def __enter__(self) -> "SiteChecker":
         """Context manager entry."""
         return self
 
@@ -372,7 +373,7 @@ class SiteChecker:
             response = self.client.get(self.url)
             response.raise_for_status()
 
-        except httpx.RequestError:
+        except httpx.HTTPStatusError:
             return CheckResponse(
                 name=check_name,
                 result=CheckResult.FAILURE,
@@ -389,8 +390,15 @@ class SiteChecker:
             message=success_message,
         )
 
-    def run_checks(self, checks: list[_BaseCheck]) -> SiteCheckResult:
-        """Run all checks."""
+    def run_checks(self, checks: Sequence[_BaseCheck]) -> SiteCheckResult:
+        """Run all checks.
+
+        Args:
+            checks: Accepts any sequence (list, tuple, etc.) of check instances inheriting from _BaseCheck.
+
+        Returns:
+            A SiteCheckResult object containing the results of all checks.
+        """
         # First, run the first check
         first_check = self.run_first_check()
         site_check_results = SiteCheckResult(url=str(self.url), check_results=[first_check])