django-database-task 0.2.2__tar.gz → 0.2.4__tar.gz

{django_database_task-0.2.2/django_database_task.egg-info → django_database_task-0.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: django-database-task
-Version: 0.2.2
+Version: 0.2.4
 Summary: A database-backed task queue backend for Django 6.0's built-in task framework
 Author-email: Shinya Okano <tokibito@gmail.com>
 Maintainer-email: Shinya Okano <tokibito@gmail.com>
@@ -358,7 +358,7 @@ urlpatterns = [
 | `/tasks/run-one/` | POST | Process a single pending task |
 | `/tasks/status/` | GET | Get pending task count |
 | `/tasks/execute/<uuid>/` | POST | Execute a specific task by ID |
-| `/tasks/purge/` | POST | Delete completed tasks |
+| `/tasks/purge/` | GET, POST | Delete completed tasks |
 
 ### Request Parameters
 
@@ -434,10 +434,14 @@ Response (task not found):
 {"error": "Task not found"}  // HTTP 404
 ```
 
-#### POST `/tasks/purge/`
+#### GET/POST `/tasks/purge/`
 
 Delete completed tasks from the database. Useful for cron-based cleanup.
 
+**Note:** GET method is supported for GAE cron compatibility (GAE cron only supports GET requests).
+
+**POST parameters (JSON body):**
+
 | Parameter | Type | Default | Description |
 |-----------|------|---------|-------------|
 | `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
@@ -445,6 +449,15 @@ Delete completed tasks from the database. Useful for cron-based cleanup.
 | `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
 | `dry_run` | bool | false | If true, return count without deleting |
 
+**GET query parameters:**
+
+| Parameter | Type | Default | Description |
+|-----------|------|---------|-------------|
+| `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
+| `status` | string | "SUCCESSFUL,FAILED" | Target statuses, comma-separated |
+| `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
+| `dry_run` | string | "false" | If "true", return count without deleting |
+
 Response:
 ```json
 {"deleted": 150, "dry_run": false}
@@ -471,15 +484,21 @@ curl -X POST http://localhost:8000/tasks/run/ \
 # Get pending task count
 curl http://localhost:8000/tasks/status/
 
-# Delete tasks completed more than 7 days ago
+# Delete tasks completed more than 7 days ago (POST)
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 7}'
 
+# Delete tasks completed more than 7 days ago (GET - for GAE cron)
+curl "http://localhost:8000/tasks/purge/?days=7"
+
 # Dry run to check how many tasks would be deleted
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 30, "dry_run": true}'
+
+# Dry run via GET
+curl "http://localhost:8000/tasks/purge/?days=30&dry_run=true"
 ```
 
 ### Use Cases
@@ -717,6 +736,40 @@ TASKS = {
 
 When `OIDC_SERVICE_ACCOUNT_EMAIL` is configured, Cloud Tasks will send OIDC tokens with each request. The backend automatically verifies these tokens on the `/tasks/execute/` and `/tasks/purge/` endpoints.
 
+#### Required IAM Roles
+
+To use OIDC authentication, the following IAM roles are required:
+
+| Role | Description |
+|------|-------------|
+| `roles/cloudtasks.enqueuer` | Required to create tasks in Cloud Tasks queues |
+| `roles/iam.serviceAccountUser` | Required to specify the OIDC service account when creating tasks |
+
+**Setup:**
+
+1. Create a service account for OIDC token generation:
+   ```bash
+   gcloud iam service-accounts create cloud-tasks-invoker \
+       --display-name="Cloud Tasks Invoker"
+   ```
+
+2. Grant the Cloud Tasks Enqueuer role to the service account running your application (e.g., App Engine default service account):
+   ```bash
+   gcloud projects add-iam-policy-binding PROJECT_ID \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/cloudtasks.enqueuer"
+   ```
+
+3. Grant the Service Account User role to allow impersonation of the OIDC service account:
+   ```bash
+   gcloud iam service-accounts add-iam-policy-binding \
+       cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/iam.serviceAccountUser"
+   ```
+
+**Note:** The OIDC service account specified in `OIDC_SERVICE_ACCOUNT_EMAIL` does not need any additional roles. It is only used to generate the OIDC token that is included in the HTTP request to your task handler.
+
 ```python
 # settings.py - Automatic OIDC verification
 TASKS = {
@@ -724,7 +777,7 @@ TASKS = {
         "BACKEND": "django_database_task.cloudtasks.CloudTasksDatabaseBackend",
         "QUEUES": [],  # Allow all queue names
         "OPTIONS": {
-            "OIDC_SERVICE_ACCOUNT_EMAIL": "my-sa@project.iam.gserviceaccount.com",
+            "OIDC_SERVICE_ACCOUNT_EMAIL": "cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com",
             # OIDC_AUDIENCE is auto-detected from handler URL if not set
         },
     },

{django_database_task-0.2.2 → django_database_task-0.2.4}/README.md

@@ -322,7 +322,7 @@ urlpatterns = [
 | `/tasks/run-one/` | POST | Process a single pending task |
 | `/tasks/status/` | GET | Get pending task count |
 | `/tasks/execute/<uuid>/` | POST | Execute a specific task by ID |
-| `/tasks/purge/` | POST | Delete completed tasks |
+| `/tasks/purge/` | GET, POST | Delete completed tasks |
 
 ### Request Parameters
 
@@ -398,10 +398,14 @@ Response (task not found):
 {"error": "Task not found"}  // HTTP 404
 ```
 
-#### POST `/tasks/purge/`
+#### GET/POST `/tasks/purge/`
 
 Delete completed tasks from the database. Useful for cron-based cleanup.
 
+**Note:** GET method is supported for GAE cron compatibility (GAE cron only supports GET requests).
+
+**POST parameters (JSON body):**
+
 | Parameter | Type | Default | Description |
 |-----------|------|---------|-------------|
 | `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
@@ -409,6 +413,15 @@ Delete completed tasks from the database. Useful for cron-based cleanup.
 | `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
 | `dry_run` | bool | false | If true, return count without deleting |
 
+**GET query parameters:**
+
+| Parameter | Type | Default | Description |
+|-----------|------|---------|-------------|
+| `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
+| `status` | string | "SUCCESSFUL,FAILED" | Target statuses, comma-separated |
+| `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
+| `dry_run` | string | "false" | If "true", return count without deleting |
+
 Response:
 ```json
 {"deleted": 150, "dry_run": false}
@@ -435,15 +448,21 @@ curl -X POST http://localhost:8000/tasks/run/ \
 # Get pending task count
 curl http://localhost:8000/tasks/status/
 
-# Delete tasks completed more than 7 days ago
+# Delete tasks completed more than 7 days ago (POST)
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 7}'
 
+# Delete tasks completed more than 7 days ago (GET - for GAE cron)
+curl "http://localhost:8000/tasks/purge/?days=7"
+
 # Dry run to check how many tasks would be deleted
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 30, "dry_run": true}'
+
+# Dry run via GET
+curl "http://localhost:8000/tasks/purge/?days=30&dry_run=true"
 ```
 
 ### Use Cases
@@ -681,6 +700,40 @@ TASKS = {
 
 When `OIDC_SERVICE_ACCOUNT_EMAIL` is configured, Cloud Tasks will send OIDC tokens with each request. The backend automatically verifies these tokens on the `/tasks/execute/` and `/tasks/purge/` endpoints.
 
+#### Required IAM Roles
+
+To use OIDC authentication, the following IAM roles are required:
+
+| Role | Description |
+|------|-------------|
+| `roles/cloudtasks.enqueuer` | Required to create tasks in Cloud Tasks queues |
+| `roles/iam.serviceAccountUser` | Required to specify the OIDC service account when creating tasks |
+
+**Setup:**
+
+1. Create a service account for OIDC token generation:
+   ```bash
+   gcloud iam service-accounts create cloud-tasks-invoker \
+       --display-name="Cloud Tasks Invoker"
+   ```
+
+2. Grant the Cloud Tasks Enqueuer role to the service account running your application (e.g., App Engine default service account):
+   ```bash
+   gcloud projects add-iam-policy-binding PROJECT_ID \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/cloudtasks.enqueuer"
+   ```
+
+3. Grant the Service Account User role to allow impersonation of the OIDC service account:
+   ```bash
+   gcloud iam service-accounts add-iam-policy-binding \
+       cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/iam.serviceAccountUser"
+   ```
+
+**Note:** The OIDC service account specified in `OIDC_SERVICE_ACCOUNT_EMAIL` does not need any additional roles. It is only used to generate the OIDC token that is included in the HTTP request to your task handler.
+
 ```python
 # settings.py - Automatic OIDC verification
 TASKS = {
@@ -688,7 +741,7 @@ TASKS = {
         "BACKEND": "django_database_task.cloudtasks.CloudTasksDatabaseBackend",
         "QUEUES": [],  # Allow all queue names
         "OPTIONS": {
-            "OIDC_SERVICE_ACCOUNT_EMAIL": "my-sa@project.iam.gserviceaccount.com",
+            "OIDC_SERVICE_ACCOUNT_EMAIL": "cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com",
             # OIDC_AUDIENCE is auto-detected from handler URL if not set
         },
     },

{django_database_task-0.2.2 → django_database_task-0.2.4}/django_database_task/__init__.py

@@ -2,7 +2,7 @@
 django-database-task: A database-backed task queue backend for Django 6.0's task framework.
 """
 
-__version__ = "0.2.2"
+__version__ = "0.2.4"
 
 
 def __getattr__(name):

{django_database_task-0.2.2 → django_database_task-0.2.4}/django_database_task/backends.py

@@ -1,4 +1,5 @@
 import asyncio
+import logging
 import traceback
 from importlib import import_module
 from inspect import iscoroutinefunction
@@ -10,6 +11,8 @@ from django.tasks.signals import task_enqueued, task_finished, task_started
 from django.utils import timezone
 from django.utils.json import normalize_json
 
+logger = logging.getLogger("django_database_task")
+
 
 class DatabaseTaskBackend(BaseTaskBackend):
     """A task backend that persists tasks in the database."""
@@ -200,6 +203,20 @@ class DatabaseTaskBackend(BaseTaskBackend):
                 ]
             )
 
+            # Send signal for success
+            db_task.refresh_from_db()
+            final_result = self._db_task_to_result(db_task, task)
+            # Note: Django's task_finished handler logs "NoneType: None" after this
+            # due to exc_info=sys.exc_info() being called outside exception context.
+            # This is a known Django issue and will be fixed upstream.
+            logger.info(
+                "Task completed successfully: id=%s path=%s",
+                final_result.id,
+                db_task.task_path,
+            )
+            task_finished.send(sender=self.__class__, task_result=final_result)
+            return final_result
+
         except Exception as e:
             # Failure
             error = TaskError(
@@ -221,9 +238,14 @@ class DatabaseTaskBackend(BaseTaskBackend):
                 update_fields=["status", "errors_json", "finished_at", "updated_at"]
             )
 
-        # Get final result and send signal
-        db_task.refresh_from_db()
-        final_result = self._db_task_to_result(db_task, task)
-        task_finished.send(sender=self.__class__, task_result=final_result)
-
-        return final_result
+            # Send signal for failure (with exception context for Django's logging)
+            db_task.refresh_from_db()
+            final_result = self._db_task_to_result(db_task, task)
+            logger.error(
+                "Task failed: id=%s path=%s error=%s",
+                final_result.id,
+                db_task.task_path,
+                error.exception_class_path,
+            )
+            task_finished.send(sender=self.__class__, task_result=final_result)
+            return final_result

{django_database_task-0.2.2 → django_database_task-0.2.4}/django_database_task/cloudtasks/auth.py

@@ -5,12 +5,16 @@ Provides authentication handler and decorator for verifying OIDC tokens
 sent by Cloud Tasks.
 """
 
+import logging
+import traceback
 from functools import wraps
 
 from django.http import JsonResponse
 from google.auth.transport import requests as google_requests
 from google.oauth2 import id_token
 
+logger = logging.getLogger("django_database_task.cloudtasks.auth")
+
 
 def create_oidc_auth_handler(audience):
     """
@@ -64,8 +68,31 @@ def create_oidc_auth_handler(audience):
             # Attach claims to request for use in view
             request.cloud_tasks_claims = claims
 
+            # Log successful verification
+            service_account = claims.get("email", "unknown")
+            logger.info(
+                "OIDC token verified successfully: service_account=%s audience=%s",
+                service_account,
+                audience,
+            )
+
         except Exception as e:
-            return JsonResponse({"error": f"Invalid token: {e}"}, status=401)
+            # Log the full exception for debugging
+            # Use print as fallback since logging config may not capture this logger
+            error_type = type(e).__name__
+            error_msg = str(e) if str(e) else "No details available"
+            tb = traceback.format_exc()
+            full_error = (
+                f"OIDC token verification failed: {error_type}: {error_msg}\n{tb}"
+            )
+            logger.error(full_error)
+            # Also print to stderr for environments where logging is not configured
+            import sys
+
+            print(full_error, file=sys.stderr)
+            return JsonResponse(
+                {"error": f"Invalid token: {error_type}: {error_msg}"}, status=401
+            )
 
         return None
 

{django_database_task-0.2.2 → django_database_task-0.2.4}/django_database_task/views.py

@@ -366,11 +366,17 @@ class ExecuteTaskView(View):
 @method_decorator(csrf_exempt, name="dispatch")
 class PurgeCompletedTasksView(View):
     """
-    Delete completed tasks via HTTP POST.
+    Delete completed tasks via HTTP GET or POST.
 
     This endpoint is useful for cron-based cleanup of completed tasks
     when management commands cannot be executed directly.
 
+    GET query parameters:
+        days: Delete tasks completed more than N days ago (0=all, default: 0)
+        status: Target statuses, comma-separated (default: "SUCCESSFUL,FAILED")
+        batch_size: Number of tasks to delete at once (default: 1000, max: 10000)
+        dry_run: If "true", return count without deleting (default: "false")
+
     POST parameters (JSON body):
         days: Delete tasks completed more than N days ago (0=all, default: 0)
         status: Target statuses, comma-separated (default: "SUCCESSFUL,FAILED")
@@ -395,14 +401,57 @@ class PurgeCompletedTasksView(View):
         }
 
     Security:
-        - Only accepts POST requests
+        - Accepts GET and POST requests
         - CSRF exempt (intended for API/cron use)
         - Consider adding authentication in your URL configuration
-    """
 
-    http_method_names = ["post"]
+    GAE Cron:
+        GAE cron only supports GET requests. Use query parameters:
+        GET /tasks/purge/?days=7&status=SUCCESSFUL,FAILED
+    """
 
-    def post(self, request):
+    http_method_names = ["get", "post"]
+
+    def _get_params(self, request):
+        """Extract parameters from GET query string or POST JSON body."""
+        if request.method == "GET":
+            days_str = request.GET.get("days", "0")
+            try:
+                days = int(days_str)
+            except ValueError:
+                return None, {"error": "days must be an integer"}
+
+            batch_size_str = request.GET.get("batch_size", "1000")
+            try:
+                batch_size = int(batch_size_str)
+            except ValueError:
+                return None, {"error": "batch_size must be an integer"}
+
+            return {
+                "days": days,
+                "status": request.GET.get("status", "SUCCESSFUL,FAILED"),
+                "batch_size": batch_size,
+                "dry_run": request.GET.get("dry_run", "").lower() == "true",
+            }, None
+        else:
+            # POST - parse JSON body
+            try:
+                if request.body:
+                    data = json.loads(request.body)
+                else:
+                    data = {}
+            except json.JSONDecodeError:
+                return None, {"error": "Invalid JSON"}
+
+            return {
+                "days": data.get("days", 0),
+                "status": data.get("status", "SUCCESSFUL,FAILED"),
+                "batch_size": data.get("batch_size", 1000),
+                "dry_run": data.get("dry_run", False),
+            }, None
+
+    def _purge(self, request):
+        """Common purge logic for GET and POST."""
         backend_name = request.GET.get("backend_name", "default")
 
         # Get backend and check for auth handler
@@ -414,19 +463,15 @@ class PurgeCompletedTasksView(View):
                 if error_response:
                     return error_response
 
-        # Parse JSON body if present
-        try:
-            if request.body:
-                data = json.loads(request.body)
-            else:
-                data = {}
-        except json.JSONDecodeError:
-            return JsonResponse({"error": "Invalid JSON"}, status=400)
+        # Get parameters
+        params, error = self._get_params(request)
+        if error:
+            return JsonResponse(error, status=400)
 
-        days = data.get("days", 0)
-        status_str = data.get("status", "SUCCESSFUL,FAILED")
-        batch_size = data.get("batch_size", 1000)
-        dry_run = data.get("dry_run", False)
+        days = params["days"]
+        status_str = params["status"]
+        batch_size = params["batch_size"]
+        dry_run = params["dry_run"]
 
         # Validate parameters
         if not isinstance(days, int) or days < 0:
@@ -475,3 +520,9 @@ class PurgeCompletedTasksView(View):
             deleted_total += deleted_count
 
         return JsonResponse({"deleted": deleted_total, "dry_run": False})
+
+    def get(self, request):
+        return self._purge(request)
+
+    def post(self, request):
+        return self._purge(request)

{django_database_task-0.2.2 → django_database_task-0.2.4/django_database_task.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: django-database-task
-Version: 0.2.2
+Version: 0.2.4
 Summary: A database-backed task queue backend for Django 6.0's built-in task framework
 Author-email: Shinya Okano <tokibito@gmail.com>
 Maintainer-email: Shinya Okano <tokibito@gmail.com>
@@ -358,7 +358,7 @@ urlpatterns = [
 | `/tasks/run-one/` | POST | Process a single pending task |
 | `/tasks/status/` | GET | Get pending task count |
 | `/tasks/execute/<uuid>/` | POST | Execute a specific task by ID |
-| `/tasks/purge/` | POST | Delete completed tasks |
+| `/tasks/purge/` | GET, POST | Delete completed tasks |
 
 ### Request Parameters
 
@@ -434,10 +434,14 @@ Response (task not found):
 {"error": "Task not found"}  // HTTP 404
 ```
 
-#### POST `/tasks/purge/`
+#### GET/POST `/tasks/purge/`
 
 Delete completed tasks from the database. Useful for cron-based cleanup.
 
+**Note:** GET method is supported for GAE cron compatibility (GAE cron only supports GET requests).
+
+**POST parameters (JSON body):**
+
 | Parameter | Type | Default | Description |
 |-----------|------|---------|-------------|
 | `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
@@ -445,6 +449,15 @@ Delete completed tasks from the database. Useful for cron-based cleanup.
 | `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
 | `dry_run` | bool | false | If true, return count without deleting |
 
+**GET query parameters:**
+
+| Parameter | Type | Default | Description |
+|-----------|------|---------|-------------|
+| `days` | int | 0 | Delete tasks completed more than N days ago (0=all) |
+| `status` | string | "SUCCESSFUL,FAILED" | Target statuses, comma-separated |
+| `batch_size` | int | 1000 | Number of tasks to delete at once (max: 10000) |
+| `dry_run` | string | "false" | If "true", return count without deleting |
+
 Response:
 ```json
 {"deleted": 150, "dry_run": false}
@@ -471,15 +484,21 @@ curl -X POST http://localhost:8000/tasks/run/ \
 # Get pending task count
 curl http://localhost:8000/tasks/status/
 
-# Delete tasks completed more than 7 days ago
+# Delete tasks completed more than 7 days ago (POST)
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 7}'
 
+# Delete tasks completed more than 7 days ago (GET - for GAE cron)
+curl "http://localhost:8000/tasks/purge/?days=7"
+
 # Dry run to check how many tasks would be deleted
 curl -X POST http://localhost:8000/tasks/purge/ \
   -H "Content-Type: application/json" \
   -d '{"days": 30, "dry_run": true}'
+
+# Dry run via GET
+curl "http://localhost:8000/tasks/purge/?days=30&dry_run=true"
 ```
 
 ### Use Cases
@@ -717,6 +736,40 @@ TASKS = {
 
 When `OIDC_SERVICE_ACCOUNT_EMAIL` is configured, Cloud Tasks will send OIDC tokens with each request. The backend automatically verifies these tokens on the `/tasks/execute/` and `/tasks/purge/` endpoints.
 
+#### Required IAM Roles
+
+To use OIDC authentication, the following IAM roles are required:
+
+| Role | Description |
+|------|-------------|
+| `roles/cloudtasks.enqueuer` | Required to create tasks in Cloud Tasks queues |
+| `roles/iam.serviceAccountUser` | Required to specify the OIDC service account when creating tasks |
+
+**Setup:**
+
+1. Create a service account for OIDC token generation:
+   ```bash
+   gcloud iam service-accounts create cloud-tasks-invoker \
+       --display-name="Cloud Tasks Invoker"
+   ```
+
+2. Grant the Cloud Tasks Enqueuer role to the service account running your application (e.g., App Engine default service account):
+   ```bash
+   gcloud projects add-iam-policy-binding PROJECT_ID \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/cloudtasks.enqueuer"
+   ```
+
+3. Grant the Service Account User role to allow impersonation of the OIDC service account:
+   ```bash
+   gcloud iam service-accounts add-iam-policy-binding \
+       cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com \
+       --member="serviceAccount:PROJECT_ID@appspot.gserviceaccount.com" \
+       --role="roles/iam.serviceAccountUser"
+   ```
+
+**Note:** The OIDC service account specified in `OIDC_SERVICE_ACCOUNT_EMAIL` does not need any additional roles. It is only used to generate the OIDC token that is included in the HTTP request to your task handler.
+
 ```python
 # settings.py - Automatic OIDC verification
 TASKS = {
@@ -724,7 +777,7 @@ TASKS = {
         "BACKEND": "django_database_task.cloudtasks.CloudTasksDatabaseBackend",
         "QUEUES": [],  # Allow all queue names
         "OPTIONS": {
-            "OIDC_SERVICE_ACCOUNT_EMAIL": "my-sa@project.iam.gserviceaccount.com",
+            "OIDC_SERVICE_ACCOUNT_EMAIL": "cloud-tasks-invoker@PROJECT_ID.iam.gserviceaccount.com",
             # OIDC_AUDIENCE is auto-detected from handler URL if not set
         },
     },

{django_database_task-0.2.2 → django_database_task-0.2.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "django-database-task"
-version = "0.2.2"
+version = "0.2.4"
 description = "A database-backed task queue backend for Django 6.0's built-in task framework"
 readme = "README.md"
 license = "MIT"

{django_database_task-0.2.2 → django_database_task-0.2.4}/tests/test_views.py

@@ -738,10 +738,66 @@ class TestPurgeCompletedTasksView:
         data = response.json()
         assert data["deleted"] == 0
 
-    def test_purge_rejects_get(self, client):
-        """Test that GET method is not allowed."""
+    def test_purge_via_get(self, client):
+        """Test that GET method works for GAE cron compatibility."""
+        # Create a completed task
+        DatabaseTask.objects.create(
+            task_path="tests.test_executor.sample_task",
+            queue_name="default",
+            priority=0,
+            args_json=[1, 2],
+            kwargs_json={},
+            status=TaskResultStatus.SUCCESSFUL,
+            enqueued_at=timezone.now(),
+            finished_at=timezone.now(),
+            backend_name="default",
+        )
         response = client.get(reverse("django_database_task:purge_completed_tasks"))
-        assert response.status_code == 405
+        assert response.status_code == 200
+        data = response.json()
+        assert data["deleted"] == 1
+        assert data["dry_run"] is False
+
+    def test_purge_via_get_with_params(self, client):
+        """Test GET method with query parameters."""
+        # Create a completed task
+        DatabaseTask.objects.create(
+            task_path="tests.test_executor.sample_task",
+            queue_name="default",
+            priority=0,
+            args_json=[1, 2],
+            kwargs_json={},
+            status=TaskResultStatus.SUCCESSFUL,
+            enqueued_at=timezone.now(),
+            finished_at=timezone.now(),
+            backend_name="default",
+        )
+        response = client.get(
+            reverse("django_database_task:purge_completed_tasks"),
+            {"days": "0", "status": "SUCCESSFUL", "dry_run": "true"},
+        )
+        assert response.status_code == 200
+        data = response.json()
+        assert data["count"] == 1
+        assert data["dry_run"] is True
+
+    def test_purge_via_get_invalid_days(self, client):
+        """Test GET method with invalid days parameter."""
+        response = client.get(
+            reverse("django_database_task:purge_completed_tasks"),
+            {"days": "abc"},
+        )
+        assert response.status_code == 400
+        assert "days must be an integer" in response.json()["error"]
+
+    def test_purge_via_get_invalid_batch_size(self, client):
+        """Test GET method with invalid batch_size parameter."""
+        response = client.get(
+            reverse("django_database_task:purge_completed_tasks"),
+            {"batch_size": "abc"},
+        )
+        assert response.status_code == 400
+        assert "batch_size must be an integer" in response.json()["error"]
 
     def test_purge_rejects_invalid_json(self, client):
         """Test that invalid JSON returns 400."""