django-bulk-hooks 0.2.58__tar.gz → 0.2.60__tar.gz

{django_bulk_hooks-0.2.58 → django_bulk_hooks-0.2.60}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: django-bulk-hooks
-Version: 0.2.58
+Version: 0.2.60
 Summary: Hook-style hooks for Django bulk operations like bulk_create and bulk_update.
 License: MIT
 Keywords: django,bulk,hooks

{django_bulk_hooks-0.2.58 → django_bulk_hooks-0.2.60}/django_bulk_hooks/operations/bulk_executor.py

@@ -182,10 +182,35 @@ class BulkExecutor:
         if not objs:
             return 0
 
+        # Ensure auto_now fields are included and pre-saved for all models
+        # This handles both MTI and non-MTI models uniformly (SOC & DRY)
+        fields = list(fields)  # Make a copy so we can modify it
+        
+        # Get models to check - for MTI, check entire inheritance chain
+        if self.mti_handler.is_mti_model():
+            models_to_check = self.mti_handler.get_inheritance_chain()
+        else:
+            models_to_check = [self.model_cls]
+        
+        # Collect all auto_now fields and pre-save them
+        auto_now_fields = set()
+        for model in models_to_check:
+            for field in model._meta.local_fields:
+                if getattr(field, "auto_now", False) and not getattr(field, "auto_now_add", False):
+                    auto_now_fields.add(field.name)
+                    # Pre-save the field to set the value on instances
+                    for obj in objs:
+                        field.pre_save(obj, add=False)
+        
+        # Add auto_now fields to the update list if not already present
+        for auto_now_field in auto_now_fields:
+            if auto_now_field not in fields:
+                fields.append(auto_now_field)
+
         # Check if this is an MTI model and route accordingly
         if self.mti_handler.is_mti_model():
             logger.info(f"Detected MTI model {self.model_cls.__name__}, using MTI bulk update")
-            # Build execution plan
+            # Build execution plan (fields already have auto_now included)
             plan = self.mti_handler.build_update_plan(objs, fields, batch_size=batch_size)
             # Execute the plan
             return self._execute_mti_update_plan(plan)

{django_bulk_hooks-0.2.58 → django_bulk_hooks-0.2.60}/django_bulk_hooks/operations/coordinator.py

@@ -740,6 +740,8 @@ class BulkOperationCoordinator:
         if not result_objects:
             return
 
+        # First pass: collect objects with metadata and objects needing timestamp check
+        objects_needing_timestamp_check = []
         for obj in result_objects:
             # Check if metadata was set
             if hasattr(obj, "_bulk_hooks_was_created"):
@@ -749,29 +751,52 @@ class BulkOperationCoordinator:
                 else:
                     updated_objects.append(obj)
             else:
-                # Fallback: if no metadata, check timestamps
+                # Need to check timestamps - collect for bulk query
+                objects_needing_timestamp_check.append(obj)
+
+        # Bulk fetch timestamps for objects without metadata (avoids N+1 queries)
+        if objects_needing_timestamp_check:
+            # Group by model class to handle MTI scenarios
+            objects_by_model = {}
+            for obj in objects_needing_timestamp_check:
                 model_cls = obj.__class__
+                if model_cls not in objects_by_model:
+                    objects_by_model[model_cls] = []
+                objects_by_model[model_cls].append(obj)
+
+            # Fetch timestamps in bulk for each model class
+            for model_cls, objs in objects_by_model.items():
                 if hasattr(model_cls, "created_at") and hasattr(model_cls, "updated_at"):
-                    # Reload from DB to get accurate timestamps
-                    db_obj = model_cls.objects.filter(pk=obj.pk).values("created_at", "updated_at").first()
-                    if db_obj:
-                        created_at = db_obj["created_at"]
-                        updated_at = db_obj["updated_at"]
-                        if created_at and updated_at:
-                            time_diff = abs((updated_at - created_at).total_seconds())
-                            if time_diff <= 1.0:  # Within 1 second = just created
-                                created_objects.append(obj)
+                    # Bulk fetch timestamps for all objects of this model
+                    pks = [obj.pk for obj in objs if obj.pk is not None]
+                    if pks:
+                        timestamp_map = {
+                            record["pk"]: (record["created_at"], record["updated_at"])
+                            for record in model_cls.objects.filter(pk__in=pks).values("pk", "created_at", "updated_at")
+                        }
+
+                        # Classify each object based on timestamps
+                        for obj in objs:
+                            if obj.pk in timestamp_map:
+                                created_at, updated_at = timestamp_map[obj.pk]
+                                if created_at and updated_at:
+                                    time_diff = abs((updated_at - created_at).total_seconds())
+                                    if time_diff <= 1.0:  # Within 1 second = just created
+                                        created_objects.append(obj)
+                                    else:
+                                        updated_objects.append(obj)
+                                else:
+                                    # No timestamps, default to created
+                                    created_objects.append(obj)
                             else:
-                                updated_objects.append(obj)
-                        else:
-                            # No timestamps, default to created
-                            created_objects.append(obj)
+                                # Object not found, treat as created
+                                created_objects.append(obj)
                     else:
-                        # Object not found, treat as created
-                        created_objects.append(obj)
+                        # No PKs, default all to created
+                        created_objects.extend(objs)
                 else:
                     # No timestamp fields, default to created
-                    created_objects.append(obj)
+                    created_objects.extend(objs)
 
         logger.info(f"Upsert after hooks: {len(created_objects)} created, {len(updated_objects)} updated")
 

{django_bulk_hooks-0.2.58 → django_bulk_hooks-0.2.60}/django_bulk_hooks/operations/mti_handler.py

@@ -537,7 +537,7 @@ class MTIHandler:
 
         Args:
             objs: List of model instances to update
-            fields: List of field names to update
+            fields: List of field names to update (auto_now fields already included by executor)
             batch_size: Number of objects per batch
 
         Returns:
@@ -555,28 +555,15 @@ class MTIHandler:
 
         batch_size = batch_size or len(objs)
 
-        # Handle auto_now fields
-        for obj in objs:
-            for model in inheritance_chain:
-                for field in model._meta.local_fields:
-                    if getattr(field, "auto_now", False):
-                        field.pre_save(obj, add=False)
-
-        # Add auto_now fields to update list
-        auto_now_fields = set()
-        for model in inheritance_chain:
-            for field in model._meta.local_fields:
-                if getattr(field, "auto_now", False):
-                    auto_now_fields.add(field.name)
-
-        all_fields = list(fields) + list(auto_now_fields)
+        # Note: auto_now fields are already handled by executor.bulk_update()
+        # which calls pre_save() and includes them in the fields list
 
         # Group fields by model
         field_groups = []
         for model_idx, model in enumerate(inheritance_chain):
             model_fields = []
 
-            for field_name in all_fields:
+            for field_name in fields:
                 try:
                     field = self.model_cls._meta.get_field(field_name)
                     if field in model._meta.local_fields:

{django_bulk_hooks-0.2.58 → django_bulk_hooks-0.2.60}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-bulk-hooks"
-version = "0.2.58"
+version = "0.2.60"
 description = "Hook-style hooks for Django bulk operations like bulk_create and bulk_update."
 authors = ["Konrad Beck <konrad.beck@merchantcapital.co.za>"]
 readme = "README.md"