django-bulk-hooks 0.1.170__tar.gz → 0.1.172__tar.gz

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.


This version of django-bulk-hooks might be problematic. Click here for more details.

Files changed (17) hide show
  1. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/PKG-INFO +1 -1
  2. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/models.py +6 -4
  3. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/queryset.py +13 -31
  4. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/pyproject.toml +1 -1
  5. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/LICENSE +0 -0
  6. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/README.md +0 -0
  7. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/__init__.py +0 -0
  8. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/conditions.py +0 -0
  9. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/constants.py +0 -0
  10. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/context.py +0 -0
  11. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/decorators.py +0 -0
  12. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/engine.py +0 -0
  13. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/enums.py +0 -0
  14. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/handler.py +0 -0
  15. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/manager.py +0 -0
  16. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/priority.py +0 -0
  17. {django_bulk_hooks-0.1.170 → django_bulk_hooks-0.1.172}/django_bulk_hooks/registry.py +0 -0
@@ -1,6 +1,6 @@
1
1
  Metadata-Version: 2.1
2
2
  Name: django-bulk-hooks
3
- Version: 0.1.170
3
+ Version: 0.1.172
4
4
  Summary: Hook-style hooks for Django bulk operations like bulk_create and bulk_update.
5
5
  Home-page: https://github.com/AugendLimited/django-bulk-hooks
6
6
  License: MIT
@@ -44,7 +44,8 @@ class HookModelMixin(models.Model):
44
44
  else:
45
45
  # For update operations, run VALIDATE_UPDATE hooks for validation
46
46
  try:
47
- old_instance = self.__class__.objects.get(pk=self.pk)
47
+ # Use _base_manager to avoid triggering hooks recursively
48
+ old_instance = self.__class__._base_manager.get(pk=self.pk)
48
49
  ctx = HookContext(self.__class__)
49
50
  run(self.__class__, VALIDATE_UPDATE, [self], [old_instance], ctx=ctx)
50
51
  except self.__class__.DoesNotExist:
@@ -56,7 +57,7 @@ class HookModelMixin(models.Model):
56
57
  # If bypass_hooks is True, use base manager to avoid triggering hooks
57
58
  if bypass_hooks:
58
59
  return self._base_manager.save(self, *args, **kwargs)
59
-
60
+
60
61
  is_create = self.pk is None
61
62
 
62
63
  if is_create:
@@ -70,7 +71,8 @@ class HookModelMixin(models.Model):
70
71
  else:
71
72
  # For update operations, we need to get the old record
72
73
  try:
73
- old_instance = self.__class__.objects.get(pk=self.pk)
74
+ # Use _base_manager to avoid triggering hooks recursively
75
+ old_instance = self.__class__._base_manager.get(pk=self.pk)
74
76
  ctx = HookContext(self.__class__)
75
77
  run(self.__class__, BEFORE_UPDATE, [self], [old_instance], ctx=ctx)
76
78
 
@@ -92,7 +94,7 @@ class HookModelMixin(models.Model):
92
94
  # If bypass_hooks is True, use base manager to avoid triggering hooks
93
95
  if bypass_hooks:
94
96
  return self._base_manager.delete(self, *args, **kwargs)
95
-
97
+
96
98
  ctx = HookContext(self.__class__)
97
99
 
98
100
  # Run validation hooks first
@@ -139,21 +139,17 @@ class HookQuerySet(models.QuerySet):
139
139
  )
140
140
  else:
141
141
  # For single-table models, use Django's built-in bulk_create
142
- # but we need to call it on the base manager to avoid recursion
143
142
  # Filter out custom parameters that Django's bulk_create doesn't accept
144
-
145
- # Use Django's original QuerySet to avoid recursive calls
146
- from django.db.models import QuerySet
147
-
148
- original_qs = QuerySet(model_cls, using=self.db)
149
- result = original_qs.bulk_create(
150
- objs,
151
- batch_size=batch_size,
152
- ignore_conflicts=ignore_conflicts,
153
- update_conflicts=update_conflicts,
154
- update_fields=update_fields,
155
- unique_fields=unique_fields,
156
- )
143
+ django_kwargs = {
144
+ "batch_size": batch_size,
145
+ "ignore_conflicts": ignore_conflicts,
146
+ "update_conflicts": update_conflicts,
147
+ "update_fields": update_fields,
148
+ "unique_fields": unique_fields,
149
+ }
150
+ # Remove custom hook kwargs if present
151
+ django_kwargs = {k: v for k, v in django_kwargs.items() if v is not None}
152
+ result = super().bulk_create(objs, **django_kwargs)
157
153
 
158
154
  # Fire AFTER_CREATE hooks
159
155
  if not bypass_hooks:
@@ -250,23 +246,9 @@ class HookQuerySet(models.QuerySet):
250
246
 
251
247
  pks = [obj.pk for obj in objs if obj.pk is not None]
252
248
 
253
- # Use Django's base manager to perform the actual deletion
254
- # This avoids recursion and uses Django's built-in delete logic
255
- from django.db.models import QuerySet
256
-
257
- base_qs = QuerySet(model_cls, using=self.db)
258
-
259
- # Delete in batches if batch_size is specified
260
- if batch_size:
261
- for i in range(0, len(objs), batch_size):
262
- batch = objs[i : i + batch_size]
263
- batch_pks = [obj.pk for obj in batch if obj.pk is not None]
264
- if batch_pks:
265
- base_qs.filter(pk__in=batch_pks).delete()
266
- else:
267
- # Delete all at once
268
- if pks:
269
- base_qs.filter(pk__in=pks).delete()
249
+ # Call the base QuerySet implementation to avoid recursion
250
+ # The hooks have already been fired above, so we don't need them again
251
+ super().bulk_delete(objs, batch_size=batch_size)
270
252
 
271
253
  if not bypass_hooks:
272
254
  engine.run(model_cls, AFTER_DELETE, objs, ctx=ctx)
@@ -1,6 +1,6 @@
1
1
  [tool.poetry]
2
2
  name = "django-bulk-hooks"
3
- version = "0.1.170"
3
+ version = "0.1.172"
4
4
  description = "Hook-style hooks for Django bulk operations like bulk_create and bulk_update."
5
5
  authors = ["Konrad Beck <konrad.beck@merchantcapital.co.za>"]
6
6
  readme = "README.md"