django-apollo-forms 2.2.2__tar.gz → 2.2.4__tar.gz

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: django-apollo-forms
-Version: 2.2.2
+Version: 2.2.4
 Summary: Simple CMS for forms
 Home-page: https://morgan-and-morgan.github.io/apollo/
 Author: Morgan & Morgan Developers

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/apollo/api/v1/permissions.py

@@ -20,5 +20,5 @@ class FormSubmissionsPermission(permissions.DjangoModelPermissions):
             # view-level has_permission already takes care of read perms
             return True
 
-        # for updating objects, we only want to allow the creator of the form submission to update it
-        return hasattr(request, 'user') and request.user is not None and not request.user.is_anonymous and obj.created_by == request.user
+        # allow any authenticated user with sufficient permissions to update a submission
+        return hasattr(request, 'user') and request.user is not None and not request.user.is_anonymous

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/apollo/tests/test_api.py

@@ -679,7 +679,7 @@ class TestUpdateFormSubmission(FormsAPITestCase):
         self.assertEqual(resp.status_code, 403)
 
     @factory.django.mute_signals(signals.form_submission_cleaned)
-    def test_attempting_update_of_unowned_form_submission_returns_403(self):
+    def test_update_of_unowned_form_submission_returns_200(self):
         submission = FormSubmissionFactory(
             form=self.form,
             raw_data={'fields': [{'name': 'first_name', 'value': 'bobby'}, {'name': 'last_name', 'value': 'stein'}]},
@@ -693,7 +693,7 @@ class TestUpdateFormSubmission(FormsAPITestCase):
 
         resp = self.put('/submissions/%s' % submission.id, {'raw_data': [{'name': 'first_name', 'value': 'joe'}]})
 
-        self.assertEqual(resp.status_code, 403)
+        self.assertEqual(resp.status_code, 200)
 
     @factory.django.mute_signals(signals.form_submission_cleaned)
     def test_update_patches_object_partial(self):

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/apollo/views.py

@@ -31,7 +31,7 @@ class DownloadFormSubmissions(TemplateView):
         form_id = request.GET.get('form_id')
 
         form = Form.objects.get(id=form_id)
-        submissions = form.submissions.all()
+        submissions = form.submissions.filter(cleaned_data__isnull=False)
 
         # write the submissions to a CSV
         f = NamedTemporaryFile(suffix='.csv')
@@ -41,7 +41,7 @@ class DownloadFormSubmissions(TemplateView):
         with open(f.name, 'w') as csvfile:
             # we need to create the set of all field names across all submissions to avoid situations where the form
             # has changed which fields are included and it results in the header not including all fields sent
-            field_names = set([field for submission in submissions for field in submission.cleaned_data.keys() if submission.cleaned_data is not None])
+            field_names = set([field for submission in submissions for field in submission.cleaned_data.keys()])
             writer = csv.DictWriter(csvfile, field_names)
 
             writer.writeheader()

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/django_apollo_forms.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: django-apollo-forms
-Version: 2.2.2
+Version: 2.2.4
 Summary: Simple CMS for forms
 Home-page: https://morgan-and-morgan.github.io/apollo/
 Author: Morgan & Morgan Developers

{django_apollo_forms-2.2.2 → django_apollo_forms-2.2.4}/setup.py

@@ -13,7 +13,7 @@ def get_packages(package):
     return [dirpath for dirpath, dirnames, filenames in os.walk(package) if os.path.exists(os.path.join(dirpath, '__init__.py'))]
 
 
-version = '2.2.2'
+version = '2.2.4'
 
 # allow setup.py to be run from any path
 os.chdir(os.path.normpath(os.path.join(os.path.abspath(__file__), os.pardir)))